[GitHub] [incubator-druid] clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550024263 >though maybe it should be since there is a NOTICE file, https://github.com/apache/thrift/blob/master/NOTICE. Responding to myself, but

[GitHub] [incubator-druid] clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550019038 >This PR will make Travis failed because it's not updating licences.yaml. It actually might not, the old version doesn't appear to be in

[GitHub] [incubator-druid] clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550018795 >Why is this a development blocker? The old version of `scrooge-maven-plugin` uses a super old forked version of libthrift for some