jihoonson commented on issue #8038: Making optimal usage of multiple segment
cache locations
URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-536170957
@sashidhar oh yes I added. Thank you!
This is an
jihoonson commented on issue #8038: Making optimal usage of multiple segment
cache locations
URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-535955945
@dclim @himanshug @nishantmonu51 do you have more comments?
jihoonson commented on issue #8038: Making optimal usage of multiple segment
cache locations
URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-535796597
@sashidhar thanks for the quick update! I'll finish my review once
jihoonson commented on issue #8038: Making optimal usage of multiple segment
cache locations
URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-534800900
Please check the unused imports. LGTM once my last comments are addressed.
```
[ERROR]
jihoonson commented on issue #8038: Making optimal usage of multiple segment
cache locations
URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-516529125
Yeah, I will take a look probably next week.
This
jihoonson commented on issue #8038: Making optimal usage of multiple segment
cache locations
URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-510356901
I think this kind of issue needs a proposal before writing code so that the
author can avoid unnecessary work.
jihoonson commented on issue #8038: Making optimal usage of multiple segment
cache locations
URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-510180832
This sounds like a PR which needs a proposal to me.