[GitHub] [incubator-druid] jihoonson commented on issue #8823: Add InputSource and InputFormat interfaces

2019-11-15 Thread GitBox
jihoonson commented on issue #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#issuecomment-554450377 @ccaominh @clintropolis @jon-wei thanks for the review! This is an

[GitHub] [incubator-druid] jihoonson commented on issue #8823: Add InputSource and InputFormat interfaces

2019-11-13 Thread GitBox
jihoonson commented on issue #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#issuecomment-553688122 Updated PR to support the sampler better. Also addressed comments and merged master. Moved all tests in `CSVParserTest` into `CsvRea

[GitHub] [incubator-druid] jihoonson commented on issue #8823: Add InputSource and InputFormat interfaces

2019-11-11 Thread GitBox
jihoonson commented on issue #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#issuecomment-552572616 I'll fix `CsvReader.verify()` properly once https://github.com/apache/incubator-druid/pull/8744 gets merged. --