jihoonson opened a new pull request #8495: Check targetCompactionSizeBytes to 
search for candidate segments in auto compaction
URL: https://github.com/apache/incubator-druid/pull/8495
 
 
   ### Description
   
   This PR is to resolve the release blocker by temporarily addressing the bug 
reported in https://github.com/apache/incubator-druid/issues/8481. The auto 
compaction will check `targetCompactionSizeBytes` with this PR. The real 
solution should be something better such as 
https://github.com/apache/incubator-druid/issues/8489.
   
   It should be mentioned that the auto compaction can get stuck if 
`maxRowsPerSegment` or `maxTotalRows` is set instead of 
`targetCompactionSizeBytes`.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [x] added unit tests or modified existing tests to cover new code paths.
   - [x] been tested in a test Druid cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist above are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to