qutang1 commented on issue #8974: Fix double-checked locking in predicate 
suppliers in BoundDimFilter
URL: https://github.com/apache/incubator-druid/pull/8974#issuecomment-561465846
 
 
   In the line 58 of eclipse_formatting.xml, it should be changed to:
   `<setting 
id="org.eclipse.jdt.core.formatter.insert_new_line_before_catch_in_try_statement"
 value="insert"/>` instead of  "do not insert". By making this change, "catch" 
block will be alone on a line to in line with CI standard. Thus eclipse 
auto-formatting will be correct. I think the xml should be updated although I 
guess no one else than me is still using eclipse...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to