[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-09-28 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-536170742 Please add **Release Notes** label as this PR introduces a new Historical runtime property.

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-09-28 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-536170470 Thanks @jihoonson, @himanshug, @dclim, @nishantmonu51 for your review and suggestions. -

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-09-27 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-535943579 Thanks a lot @jihoonson for your thorough and patient review. ---

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-09-27 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-535878290 > @sashidhar thanks for the quick update! I'll finish my review once [#8038 (comment)](https://github

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-08-20 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-523213829 Yes Gian. I'm working on the review comments now. On Wed, Aug 21, 2019, 3:26 AM Gian Merlino wrote: > H

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-08-04 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-518068402 1. Added a new test for Least Bytes Used strategy. Updated existing tests. 2. Updated documentation for the selecti

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-07-29 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-516137723 Implemented both the strategies and made the strategy configurable. However there is one implementation glitch due to

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-07-24 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-514881236 Hi David, Sorry for the unclear wording. It should have been "This PR will introduce...". I was waiting for

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-07-22 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-513899084 @jihoonson , @himanshug , @dclim , @nishantmonu51 have you had a chance to review this ? ---

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-07-11 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-510742689 > many times users add new segment locations after the node has been in use for a while and already has some data and

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-07-11 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-510498088 Updated the description with the proposed algorithm and the alternatives discussed. Round-robin and least-bytes-used

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-07-10 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-510305954 @jihoonson , @himanshug , thanks for your inputs. Should I raise a separate proposal PR or modify this PR to make it

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-07-10 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-510046061 @dclim , @nishantmonu51 Here's what I'm thinking. As discussed, the segment cache location selector strategy sh

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-07-08 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-509253622 > to me choosing the segment cache location with the max free size instead of round robin makes more sense. otherwise