[GitHub] [incubator-druid] zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback)

2019-12-03 Thread GitBox
zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#issuecomment-561382604 Hi @leventov I rebased this PR to resolve code conflicts. Are you free to take a look?

[GitHub] [incubator-druid] zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-17 Thread GitBox
zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#issuecomment-554727725 thank you, @leventov get comments addressed This is an

[GitHub] [incubator-druid] zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#issuecomment-550104154 thank you, @leventov comments addressed did a force push, put this work on top of