[GitHub] a2l007 commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types

2018-10-23 Thread GitBox
a2l007 commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486#issuecomment-432406700 @jihoonson I see your point. Regarding the usecase, the custom metric in question is a compressed

[GitHub] a2l007 commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types

2018-10-23 Thread GitBox
a2l007 commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486#issuecomment-432373282 I think another way to handle this would be to have an explicit instanceof check for the Number

[GitHub] a2l007 commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types

2018-10-23 Thread GitBox
a2l007 commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486#issuecomment-432362305 @jihoonson The basic requirement is that for custom types, the compare method should not to throw