[GitHub] a2l007 commented on issue #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types

2018-11-30 Thread GitBox
a2l007 commented on issue #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types URL: https://github.com/apache/incubator-druid/pull/6505#issuecomment-443355775 @jihoonson @gianm Added tests. Please review. --

[GitHub] a2l007 commented on issue #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types

2018-10-31 Thread GitBox
a2l007 commented on issue #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types URL: https://github.com/apache/incubator-druid/pull/6505#issuecomment-434748621 @gianm That sounds like a better approach. I have updated the PR accordingly. Could you take a l

[GitHub] a2l007 commented on issue #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types

2018-10-23 Thread GitBox
a2l007 commented on issue #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types URL: https://github.com/apache/incubator-druid/pull/6505#issuecomment-432431447 @jihoonson I've made the changes based on our discussion. Could you please review?