jihoonson commented on issue #5812: AggregatorFactory.getComparator() must be null-safe URL: https://github.com/apache/incubator-druid/issues/5812#issuecomment-423705714 > it might be much better to handle nullability centralized, not to require for each implementer of AggregatorFactory to remember about nullability. E. g. wrap with Comparator.nullsFirst(aggFactory.getComparator()) at the usage sites of getComparator(). I like this idea. @nishantmonu51 any thoughts?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
