jon-wei opened a new pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask URL: https://github.com/apache/incubator-druid/pull/6065 If I define a CombiningFirehose with a IngestSegmentFirehose delegate in an IndexTask: ``` "firehose" : { "type": "combining", "delegates": [ { "type" : "ingestSegment", "dataSource" : "updates-tutorial", "interval" : "2018-01-01/2018-01-03" }, { "type" : "local", "baseDir" : "quickstart/", "filter" : "updates-data3.json" } ] }, ``` The following null check in IngestSegmentFirehoseFactory.connect() is triggered: ``` @Override public Firehose connect(InputRowParser inputRowParser, File temporaryDirectory) throws ParseException { log.info("Connecting firehose: dataSource[%s], interval[%s]", dataSource, interval); Preconditions.checkNotNull(taskToolbox, "taskToolbox is not set"); ``` This PR adjusts IndexTask so that it passes the taskToolbox to delegate IngestSegmentFirehoseFactory objects inside a CombiningFirehoseFactory.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
