This is an automated email from the ASF dual-hosted git repository.
cwylie pushed a commit to branch 0.15.0-incubating
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/0.15.0-incubating by this push:
new 04929e4 Fix LookupSerdeModule double-binding in
Coordinator-as-Overlord mode. (#7765) (#7774)
04929e4 is described below
commit 04929e480c01a455d86fe5f9dff2201c3f7cc007
Author: Gian Merlino <g...@imply.io>
AuthorDate: Mon May 27 14:10:06 2019 -0700
Fix LookupSerdeModule double-binding in Coordinator-as-Overlord mode.
(#7765) (#7774)
Fixes #7762.
---
services/src/main/java/org/apache/druid/cli/CliCoordinator.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/services/src/main/java/org/apache/druid/cli/CliCoordinator.java
b/services/src/main/java/org/apache/druid/cli/CliCoordinator.java
index c1ab5b9..98bb958 100644
--- a/services/src/main/java/org/apache/druid/cli/CliCoordinator.java
+++ b/services/src/main/java/org/apache/druid/cli/CliCoordinator.java
@@ -272,10 +272,12 @@ public class CliCoordinator extends ServerRunnable
}
);
- modules.add(new LookupSerdeModule());
-
if (beOverlord) {
modules.addAll(new CliOverlord().getModules(false));
+ } else {
+ // Only add LookupSerdeModule if !beOverlord, since CliOverlord includes
it, and having two copies causes
+ // the injector to get confused due to having multiple bindings for the
same classes.
+ modules.add(new LookupSerdeModule());
}
return modules;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
