Re: [PR] Grouping on complex columns aka unifying GroupBy strategies (druid)

cryptoe merged PR #16068: URL: https://github.com/apache/druid/pull/16068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Grouping on complex columns aka unifying GroupBy strategies (druid)

LakshSingla commented on PR #16068: URL: https://github.com/apache/druid/pull/16068#issuecomment-2068949371 I am cleaning up the dead todos, and adding a few tests soon! Should be good to go then. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Grouping on complex columns aka unifying GroupBy strategies (druid)

LakshSingla commented on code in PR #16068: URL: https://github.com/apache/druid/pull/16068#discussion_r1574136998 ## processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/column/DictionaryBuildingGroupByColumnSelectorStrategy.java: ## @@ -0,0 +1,203 @@ +/* + *

Re: [PR] Grouping on complex columns aka unifying GroupBy strategies (druid)

cryptoe commented on code in PR #16068: URL: https://github.com/apache/druid/pull/16068#discussion_r1572162264 ## processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/column/DictionaryBuildingGroupByColumnSelectorStrategy.java: ## @@ -0,0 +1,280 @@ +/* + *

Re: [PR] Grouping on complex columns aka unifying GroupBy strategies (druid)

LakshSingla commented on code in PR #16068: URL: https://github.com/apache/druid/pull/16068#discussion_r1572098882 ## processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/column/DictionaryBuildingGroupByColumnSelectorStrategy.java: ## @@ -0,0 +1,203 @@ +/* + *

Re: [PR] Grouping on complex columns aka unifying GroupBy strategies (druid)

LakshSingla commented on code in PR #16068: URL: https://github.com/apache/druid/pull/16068#discussion_r1571365472 ## processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/column/DictionaryBuildingGroupByColumnSelectorStrategy.java: ## @@ -0,0 +1,203 @@ +/* + *

Re: [PR] Grouping on complex columns aka unifying GroupBy strategies (druid)

github-advanced-security[bot] commented on code in PR #16068: URL: https://github.com/apache/druid/pull/16068#discussion_r1570539467 ## processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/column/KeyMappingGroupByColumnSelectorStrategy.java: ## @@ -0,0 +1,230

Re: [PR] Grouping on complex columns aka unifying GroupBy strategies (druid)

LakshSingla commented on code in PR #16068: URL: https://github.com/apache/druid/pull/16068#discussion_r1570502719 ## processing/src/main/java/org/apache/druid/query/filter/ArrayContainsElementFilter.java: ## @@ -108,7 +109,10 @@ public byte[] getCacheKey() final

Re: [PR] Grouping on complex columns aka unifying GroupBy strategies (druid)

cryptoe commented on code in PR #16068: URL: https://github.com/apache/druid/pull/16068#discussion_r1568682683 ## sql/src/test/java/org/apache/druid/sql/calcite/CalciteGroupByQueryTest.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Grouping on complex columns aka unifying GroupBy strategies (druid)

github-advanced-security[bot] commented on code in PR #16068: URL: https://github.com/apache/druid/pull/16068#discussion_r1557531355 ## processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/column/KeyMappingGroupByColumnSelectorStrategy.java: ## @@ -0,0 +1,232