github-actions[bot] closed pull request #15015: Validate datasource retention
rules: Reject rules that fully contain subsequent rules' interval
URL: https://github.com/apache/druid/pull/15015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
github-actions[bot] commented on PR #15015:
URL: https://github.com/apache/druid/pull/15015#issuecomment-2033314137
This pull request/issue has been closed due to lack of activity. If you
think that
is incorrect, or the pull request requires review, you can revive the PR at
any time.
github-actions[bot] commented on PR #15015:
URL: https://github.com/apache/druid/pull/15015#issuecomment-1977713615
This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this
abhishekrb19 commented on PR #15015:
URL: https://github.com/apache/druid/pull/15015#issuecomment-1736721994
@LakshSingla, re:
> where the user does want to add these absurd rules that have been
supported till now, WDYT of having a URL parameter ?forced which bypasses these
validation
abhishekrb19 commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1338052065
##
server/src/main/java/org/apache/druid/server/coordinator/rules/PeriodDropBeforeRule.java:
##
@@ -63,4 +64,18 @@ public boolean appliesTo(Interval theInterval,
abhishekrb19 commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1338049588
##
server/src/test/java/org/apache/druid/server/http/RulesResourceTest.java:
##
@@ -151,6 +166,286 @@ public void testGetDatasourceRuleHistoryWithWrongCount()
abhishekrb19 commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1332727568
##
server/src/main/java/org/apache/druid/server/coordinator/rules/Rules.java:
##
@@ -43,4 +48,40 @@ public static boolean eligibleForLoad(Period period,
Interval
abhishekrb19 commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1332727568
##
server/src/main/java/org/apache/druid/server/coordinator/rules/Rules.java:
##
@@ -43,4 +48,40 @@ public static boolean eligibleForLoad(Period period,
Interval
abhishekrb19 commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1332666287
##
server/src/main/java/org/apache/druid/server/coordinator/rules/Rules.java:
##
@@ -43,4 +48,40 @@ public static boolean eligibleForLoad(Period period,
Interval
LakshSingla commented on PR #15015:
URL: https://github.com/apache/druid/pull/15015#issuecomment-1728972172
To allow for the introduction of new rules and cases where the user does
want to add these absurd rules that have been supported till now, WDYT of
having a URL parameter `?forced`
LakshSingla commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1332567880
##
server/src/main/java/org/apache/druid/server/coordinator/rules/Rules.java:
##
@@ -43,4 +48,40 @@ public static boolean eligibleForLoad(Period period,
Interval
abhishekrb19 commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1332513789
##
server/src/main/java/org/apache/druid/server/coordinator/rules/Rules.java:
##
@@ -43,4 +48,40 @@ public static boolean eligibleForLoad(Period period,
Interval
kfaraz commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1330986915
##
server/src/main/java/org/apache/druid/server/coordinator/rules/PeriodDropBeforeRule.java:
##
@@ -63,4 +64,18 @@ public boolean appliesTo(Interval theInterval,
LakshSingla commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1332485399
##
server/src/main/java/org/apache/druid/server/coordinator/rules/Rules.java:
##
@@ -43,4 +48,40 @@ public static boolean eligibleForLoad(Period period,
Interval
LakshSingla commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1332485399
##
server/src/main/java/org/apache/druid/server/coordinator/rules/Rules.java:
##
@@ -43,4 +48,40 @@ public static boolean eligibleForLoad(Period period,
Interval
LakshSingla commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1332473001
##
server/src/main/java/org/apache/druid/server/coordinator/rules/Rules.java:
##
@@ -43,4 +48,40 @@ public static boolean eligibleForLoad(Period period,
Interval
LakshSingla commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1332473001
##
server/src/main/java/org/apache/druid/server/coordinator/rules/Rules.java:
##
@@ -43,4 +48,40 @@ public static boolean eligibleForLoad(Period period,
Interval
abhishekrb19 commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1332345292
##
server/src/main/java/org/apache/druid/server/coordinator/rules/Rules.java:
##
@@ -43,4 +48,40 @@ public static boolean eligibleForLoad(Period period,
Interval
abhishekrb19 commented on code in PR #15015:
URL: https://github.com/apache/druid/pull/15015#discussion_r1331090517
##
server/src/main/java/org/apache/druid/server/coordinator/rules/Rules.java:
##
@@ -43,4 +48,40 @@ public static boolean eligibleForLoad(Period period,
Interval
19 matches
Mail list logo
