Re: [PR] add google as external storage for msq export (druid)

abhishekagarwal87 merged PR #16051: URL: https://github.com/apache/druid/pull/16051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] add google as external storage for msq export (druid)

adarshsanjeev commented on PR #16051: URL: https://github.com/apache/druid/pull/16051#issuecomment-2039043960 Yes, the changes look good to me! Thanks for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] add google as external storage for msq export (druid)

abhishekagarwal87 commented on PR #16051: URL: https://github.com/apache/druid/pull/16051#issuecomment-2039026288 @adarshsanjeev - If its looks good to you, can we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] add google as external storage for msq export (druid)

abhishekagarwal87 commented on code in PR #16051: URL: https://github.com/apache/druid/pull/16051#discussion_r1552981537 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/output/GoogleExportConfig.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to

Re: [PR] add google as external storage for msq export (druid)

pjain1 commented on PR #16051: URL: https://github.com/apache/druid/pull/16051#issuecomment-2037614185 @adarshsanjeev yes tested on a cluster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] add google as external storage for msq export (druid)

pjain1 commented on code in PR #16051: URL: https://github.com/apache/druid/pull/16051#discussion_r1552004545 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/output/GoogleExportConfig.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache

Re: [PR] add google as external storage for msq export (druid)

abhishekagarwal87 commented on code in PR #16051: URL: https://github.com/apache/druid/pull/16051#discussion_r1550988691 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/output/GoogleExportConfig.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to

Re: [PR] add google as external storage for msq export (druid)

pjain1 commented on PR #16051: URL: https://github.com/apache/druid/pull/16051#issuecomment-2025650814 @adarshsanjeev anything else ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] add google as external storage for msq export (druid)

pjain1 commented on PR #16051: URL: https://github.com/apache/druid/pull/16051#issuecomment-2025647170 thanks @317brian added your commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] add google as external storage for msq export (druid)

317brian commented on code in PR #16051: URL: https://github.com/apache/druid/pull/16051#discussion_r1523793377 ## docs/multi-stage-query/reference.md: ## @@ -149,6 +149,39 @@ The following runtime parameters must be configured to export into an S3 destina |

Re: [PR] add google as external storage for msq export (druid)

317brian commented on PR #16051: URL: https://github.com/apache/druid/pull/16051#issuecomment-1995447062 Some minor copyedit nits. The only absolutely must fix one is the incorrect cloud provider being listed in an intro sentence -- This is an automated message from the Apache Git

Re: [PR] add google as external storage for msq export (druid)

317brian commented on code in PR #16051: URL: https://github.com/apache/druid/pull/16051#discussion_r1523793377 ## docs/multi-stage-query/reference.md: ## @@ -149,6 +149,39 @@ The following runtime parameters must be configured to export into an S3 destina |

Re: [PR] add google as external storage for msq export (druid)

pjain1 commented on code in PR #16051: URL: https://github.com/apache/druid/pull/16051#discussion_r1523124198 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/output/GoogleExportStorageProvider.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the

Re: [PR] add google as external storage for msq export (druid)

pjain1 commented on code in PR #16051: URL: https://github.com/apache/druid/pull/16051#discussion_r1523115949 ## docs/multi-stage-query/reference.md: ## @@ -149,6 +149,39 @@ The following runtime parameters must be configured to export into an S3 destina |

Re: [PR] add google as external storage for msq export (druid)

adarshsanjeev commented on code in PR #16051: URL: https://github.com/apache/druid/pull/16051#discussion_r1522634321 ## docs/multi-stage-query/reference.md: ## @@ -149,6 +149,39 @@ The following runtime parameters must be configured to export into an S3 destina |

Re: [PR] add google as external storage for msq export (druid)

adarshsanjeev commented on PR #16051: URL: https://github.com/apache/druid/pull/16051#issuecomment-1980347387 Thanks for the PR! I'll take a look at it shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL