[GitHub] asdf2014 commented on issue #6174: AssertionError at testCheckpointForInactiveTaskGroup in KafkaSupervisorTest

2018-08-19 Thread GitBox
asdf2014 commented on issue #6174: AssertionError at testCheckpointForInactiveTaskGroup in KafkaSupervisorTest URL: https://github.com/apache/incubator-druid/issues/6174#issuecomment-414106311 Okay, thanks for your confirmation. I will open a `PR` to solve this problem.

[GitHub] fjy commented on issue #5938: URL encode datasources, task ids, authenticator names.

2018-08-19 Thread GitBox
fjy commented on issue #5938: URL encode datasources, task ids, authenticator names. URL: https://github.com/apache/incubator-druid/pull/5938#issuecomment-414143789 @gianm this is having a hard time passing integration tests

[GitHub] KenjiTakahashi opened a new pull request #6195: Fix running Overlord inside Coordinator

2018-08-19 Thread GitBox
KenjiTakahashi opened a new pull request #6195: Fix running Overlord inside Coordinator URL: https://github.com/apache/incubator-druid/pull/6195 Fixes #6133. This is an automated message from the Apache Git Service. To

[GitHub] gianm edited a comment on issue #5709: Broker resiliency to misbehaving historical nodes

2018-08-19 Thread GitBox
gianm edited a comment on issue #5709: Broker resiliency to misbehaving historical nodes URL: https://github.com/apache/incubator-druid/issues/5709#issuecomment-414175186 Hi @peferron, That scope sounds useful for an initial patch. I think the biggest risk is that queries that are

[GitHub] gianm commented on issue #5709: Broker resiliency to misbehaving historical nodes

2018-08-19 Thread GitBox
gianm commented on issue #5709: Broker resiliency to misbehaving historical nodes URL: https://github.com/apache/incubator-druid/issues/5709#issuecomment-414175186 Hi @peferron, That scope sounds useful for an initial patch. I think the biggest risk is that queries that are doomed

[GitHub] gianm commented on issue #6189: Lucene indexing for free form text

2018-08-19 Thread GitBox
gianm commented on issue #6189: Lucene indexing for free form text URL: https://github.com/apache/incubator-druid/issues/6189#issuecomment-414172408 Hi @RestfulBlue, it sounds like an interesting idea. Are you imagining adding a Lucene index as a companion to a Druid segment (i.e. adding

[GitHub] gianm commented on issue #6088: Scan query: time-ordering

2018-08-19 Thread GitBox
gianm commented on issue #6088: Scan query: time-ordering URL: https://github.com/apache/incubator-druid/issues/6088#issuecomment-414174269 > FYI: I'd just like to see this kept as option in the query, so ones that do no need sorting avoid the performance hit. Agreed, we should

[GitHub] gianm commented on issue #5938: URL encode datasources, task ids, authenticator names.

2018-08-19 Thread GitBox
gianm commented on issue #5938: URL encode datasources, task ids, authenticator names. URL: https://github.com/apache/incubator-druid/pull/5938#issuecomment-414175659 I wasn't sure if it was timing out (we are pretty close to the timeout) or if there was something wrong with the patch

[GitHub] leventov commented on issue #5737: Include hybrid and caffeine in cache docs and show caffeine as default

2018-08-19 Thread GitBox
leventov commented on issue #5737: Include hybrid and caffeine in cache docs and show caffeine as default URL: https://github.com/apache/incubator-druid/pull/5737#issuecomment-414162618 Related: #6161 This is an automated

[GitHub] QiuMM opened a new pull request #6193: remove duplicate link to operations/recommendations.html

2018-08-19 Thread GitBox
QiuMM opened a new pull request #6193: remove duplicate link to operations/recommendations.html URL: https://github.com/apache/incubator-druid/pull/6193 There are two item links to the operations/recommendations.html, just remove one.

[GitHub] QiuMM opened a new pull request #6194: remove unnecessary tlsPortFinder to avoid potential port conflicts

2018-08-19 Thread GitBox
QiuMM opened a new pull request #6194: remove unnecessary tlsPortFinder to avoid potential port conflicts URL: https://github.com/apache/incubator-druid/pull/6194 Fix #6190. This is an automated message from the Apache Git

[GitHub] gianm commented on issue #5709: Broker resiliency to misbehaving historical nodes

2018-08-19 Thread GitBox
gianm commented on issue #5709: Broker resiliency to misbehaving historical nodes URL: https://github.com/apache/incubator-druid/issues/5709#issuecomment-414200342 > Don't these issues already exist today when druid.broker.retryPolicy.numTries > 1? The idea would be to respect this

[GitHub] peferron commented on issue #5709: Broker resiliency to misbehaving historical nodes

2018-08-19 Thread GitBox
peferron commented on issue #5709: Broker resiliency to misbehaving historical nodes URL: https://github.com/apache/incubator-druid/issues/5709#issuecomment-414190292 Thanks for the feedback @gianm. Don't these issues already exist today when `druid.broker.retryPolicy.numTries >