gianm commented on issue #6211: SQL planning error for nested queries
URL:
https://github.com/apache/incubator-druid/issues/6211#issuecomment-415996489
I backported this in #6228, and I will close this issue since it's fixed by
#5788.
gianm closed issue #6211: SQL planning error for nested queries
URL: https://github.com/apache/incubator-druid/issues/6211
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gianm opened a new pull request #6230: Fix four bugs with numeric dimension
output types. (#6220)
URL: https://github.com/apache/incubator-druid/pull/6230
* Fix four bugs with numeric dimension output types.
This patch includes the following bug fixes:
-
leventov commented on issue #6220: Fix four bugs with numeric dimension output
types.
URL: https://github.com/apache/incubator-druid/pull/6220#issuecomment-416003192
@fjy please don't merge PRs with unanswered comments (despite the approval),
otherwise why they are left?
gianm commented on issue #6220: Fix four bugs with numeric dimension output
types.
URL: https://github.com/apache/incubator-druid/pull/6220#issuecomment-416003871
Follow-up is in #6231.
This is an automated message from the
gianm opened a new pull request #6231: Minor followup to #6220.
URL: https://github.com/apache/incubator-druid/pull/6231
Adjustments to comments and usage of generics.
This is an automated message from the Apache Git Service.
gianm opened a new pull request #6228: [Backport] Support projection after
sorting in SQL
URL: https://github.com/apache/incubator-druid/pull/6228
Backport of #5788 to 0.12.3.
This is an automated message from the Apache Git
gianm commented on issue #5912: [SQL] Fix missing postAggregations for
Timeseries and TopN
URL: https://github.com/apache/incubator-druid/pull/5912#issuecomment-415996756
I believe this fixes a bug introduced by #5788, so it must be included in
0.12.3. I'll mark it.
gianm closed issue #6201: Deadlock on overlord with HttpRemoteTaskRunner
URL: https://github.com/apache/incubator-druid/issues/6201
This is an automated message from the Apache Git Service.
To respond to the message, please
gianm closed pull request #6212: fix TaskQueue-HRTR deadlock
URL: https://github.com/apache/incubator-druid/pull/6212
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
This is an automated email from the ASF dual-hosted git repository.
fjy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 23ba6f7 Fix four bugs with numeric
fjy closed pull request #6220: Fix four bugs with numeric dimension output
types.
URL: https://github.com/apache/incubator-druid/pull/6220
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this
fjy closed issue #6123: ClassCastException in groupBy when sorting on numeric
columns containing nulls
URL: https://github.com/apache/incubator-druid/issues/6123
This is an automated message from the Apache Git Service.
To
gianm closed pull request #6221: SQL: Finalize aggregations for inner queries
when necessary.
URL: https://github.com/apache/incubator-druid/pull/6221
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
gianm closed issue #5779: HLL in inner group by does not get finalized
URL: https://github.com/apache/incubator-druid/issues/5779
This is an automated message from the Apache Git Service.
To respond to the message, please
This is an automated email from the ASF dual-hosted git repository.
gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 28e6ae3 SQL: Finalize aggregations for
gianm commented on issue #6212: fix TaskQueue-HRTR deadlock
URL: https://github.com/apache/incubator-druid/pull/6212#issuecomment-415997052
LGTM, thanks @himanshug
This is an automated message from the Apache Git Service.
To
leventov commented on issue #6220: Fix four bugs with numeric dimension output
types.
URL: https://github.com/apache/incubator-druid/pull/6220#issuecomment-416004813
Thanks.
Yes it means non-blocking comments, however answering them before merging is
appreciated.
gianm commented on issue #6191: SQL: Support more result formats, add columns
header.
URL: https://github.com/apache/incubator-druid/pull/6191#issuecomment-416011442
I realized that a single blank line is a better trailer (it still lets you
detect truncation, and is easier to ignore).
gianm commented on issue #6076: Mutual TLS support
URL: https://github.com/apache/incubator-druid/pull/6076#issuecomment-416006702
@jon-wei is this still a WIP or is it ready for re-review?
This is an automated message from
gianm opened a new pull request #6232: Fix NPE on constant null numeric
expressions.
URL: https://github.com/apache/incubator-druid/pull/6232
The bug was caused by makeExprEvalSelector returning a null object, which
it isn't supposed to do. Fixed this by renaming
gianm commented on a change in pull request #6206: Fix NPE in
KafkaSupervisor.checkpointTaskGroup
URL: https://github.com/apache/incubator-druid/pull/6206#discussion_r212811973
##
File path:
gianm commented on a change in pull request #5280: add "subtotalsSpec"
attribute to groupBy query
URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r212812039
##
File path: docs/content/querying/groupbyquery.md
##
@@ -113,6 +114,94 @@ improve
gianm commented on a change in pull request #5280: add "subtotalsSpec"
attribute to groupBy query
URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r212812038
##
File path: docs/content/querying/groupbyquery.md
##
@@ -70,6 +70,7 @@ There are 11 main
gianm commented on a change in pull request #5280: add "subtotalsSpec"
attribute to groupBy query
URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r212812046
##
File path: docs/content/querying/groupbyquery.md
##
@@ -113,6 +114,94 @@ improve
gianm commented on a change in pull request #5280: add "subtotalsSpec"
attribute to groupBy query
URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r212812069
##
File path: docs/content/querying/groupbyquery.md
##
@@ -113,6 +114,94 @@ improve
gianm commented on issue #6223: make COMPLEX column filterable in Druid code
URL: https://github.com/apache/incubator-druid/pull/6223#issuecomment-416006551
@himanshug probably it makes sense for this new capability to always be true
for string, long, float, double; and for it to be false
gianm opened a new pull request #6233: FilteredBufferAggregator: Fix missing
relocate, isNull methods.
URL: https://github.com/apache/incubator-druid/pull/6233
FilteredBufferAggregator was missing these two methods, which meant that
nullability and relocation wouldn't work properly for
gianm commented on issue #6191: SQL: Support more result formats, add columns
header.
URL: https://github.com/apache/incubator-druid/pull/6191#issuecomment-416010989
I'm not a huge fan of the 'trailers' here, but from what I can see, our
version of Jetty (9.4.10.v20180503) will use
29 matches
Mail list logo
