[GitHub] drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-30 Thread GitBox
drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r214114896 ## File path:

[GitHub] jon-wei opened a new pull request #6273: Fix PostgreSQLConnectorConfig binding

2018-08-30 Thread GitBox
jon-wei opened a new pull request #6273: Fix PostgreSQLConnectorConfig binding URL: https://github.com/apache/incubator-druid/pull/6273 The new SSL config for the Postgres metadata connector added in #6181 was not being bound correctly and preventing service startup

[GitHub] gianm commented on issue #6270: BytesFullResponseHandler should only consume readableBytes of ChannelBuffer

2018-08-30 Thread GitBox
gianm commented on issue #6270: BytesFullResponseHandler should only consume readableBytes of ChannelBuffer URL: https://github.com/apache/incubator-druid/pull/6270#issuecomment-417443432 I've added this to 0.12.3, I think it's reasonable to include it there.

[GitHub] leventov commented on issue #5957: Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements

2018-08-30 Thread GitBox
leventov commented on issue #5957: Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements URL: https://github.com/apache/incubator-druid/pull/5957#issuecomment-417493607 @nishantmonu51 thanks for review. I've occasionally run Optimize

[GitHub] leventov opened a new issue #6274: Duplicate ExtractionDimFilterTest

2018-08-30 Thread GitBox
leventov opened a new issue #6274: Duplicate ExtractionDimFilterTest URL: https://github.com/apache/incubator-druid/issues/6274 Similar to #6064 This is an automated message from the Apache Git Service. To respond to the

[GitHub] leventov commented on a change in pull request #5957: Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements

2018-08-30 Thread GitBox
leventov commented on a change in pull request #5957: Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r214204308 ## File path:

[GitHub] leventov commented on a change in pull request #5957: Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements

2018-08-30 Thread GitBox
leventov commented on a change in pull request #5957: Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r214204279 ## File path:

[GitHub] leventov edited a comment on issue #5957: Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements

2018-08-30 Thread GitBox
leventov edited a comment on issue #5957: Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements URL: https://github.com/apache/incubator-druid/pull/5957#issuecomment-417493607 @nishantmonu51 thanks for review. I've accidently run Optimize

[GitHub] asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin

2018-08-30 Thread GitBox
asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r214085872 ## File path: docs/content/development/build.md ## @@ -13,16 +13,18 @@ Building Druid

[GitHub] gianm commented on issue #6266: Rename io.druid to org.apache.druid.

2018-08-30 Thread GitBox
gianm commented on issue #6266: Rename io.druid to org.apache.druid. URL: https://github.com/apache/incubator-druid/pull/6266#issuecomment-417374270 Added a fix for protobuf tests and re-pushed. The unit tests all pass on my machine, although I haven't tried the integration tests there.

[GitHub] fjy commented on issue #6235: Druid with Oak supporting also plain mode v04

2018-08-30 Thread GitBox
fjy commented on issue #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#issuecomment-417393438 @sanastas do you mind fixing merge conflicts? This is an automated

[GitHub] fjy commented on issue #6259: Docs consistency cleanup

2018-08-30 Thread GitBox
fjy commented on issue #6259: Docs consistency cleanup URL: https://github.com/apache/incubator-druid/pull/6259#issuecomment-417393309 @jon-wei can you fix merge conflicts? This is an automated message from the Apache Git

[GitHub] fjy closed pull request #6271: Docs: correct metric name in doc file

2018-08-30 Thread GitBox
fjy closed pull request #6271: Docs: correct metric name in doc file URL: https://github.com/apache/incubator-druid/pull/6271 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] gianm commented on issue #6266: Rename io.druid to org.apache.druid.

2018-08-30 Thread GitBox
gianm commented on issue #6266: Rename io.druid to org.apache.druid. URL: https://github.com/apache/incubator-druid/pull/6266#issuecomment-417411186 really good at writing import statements This is an automated message from

[incubator-druid] branch master updated: correct metric name in doc file (#6271)

2018-08-30 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 9b04846 correct metric name in doc file

[GitHub] gianm commented on issue #6266: Rename io.druid to org.apache.druid.

2018-08-30 Thread GitBox
gianm commented on issue #6266: Rename io.druid to org.apache.druid. URL: https://github.com/apache/incubator-druid/pull/6266#issuecomment-417390985 ok here we go! This is an automated message from the Apache Git Service. To

[GitHub] fjy commented on issue #6270: BytesFullResponseHandler should only consume readableBytes of ChannelBuffer

2018-08-30 Thread GitBox
fjy commented on issue #6270: BytesFullResponseHandler should only consume readableBytes of ChannelBuffer URL: https://github.com/apache/incubator-druid/pull/6270#issuecomment-417393216 @gaodayue do you mind merging with master to fix conflicts?

[GitHub] drcrallen commented on issue #6219: Add optional `name` to top level of FilteredAggregatorFactory

2018-08-30 Thread GitBox
drcrallen commented on issue #6219: Add optional `name` to top level of FilteredAggregatorFactory URL: https://github.com/apache/incubator-druid/pull/6219#issuecomment-417402060 @clintropolis whoops, yep, will fix This is an

[GitHub] gianm commented on issue #4137: Kafka indexing gets stuck if there is data from outside of load period

2018-08-30 Thread GitBox
gianm commented on issue #4137: Kafka indexing gets stuck if there is data from outside of load period URL: https://github.com/apache/incubator-druid/issues/4137#issuecomment-417368578 @xy-xin I think yes, although it is not super graceful (they will have to time out first). You could

[GitHub] drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-30 Thread GitBox
drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r214113695 ## File path:

[GitHub] leventov commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-30 Thread GitBox
leventov commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r214127877 ## File path:

[GitHub] drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-30 Thread GitBox
drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r214114233 ## File path:

[GitHub] leventov commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-30 Thread GitBox
leventov commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r214124793 ## File path:

[GitHub] QiuMM opened a new pull request #6272: Showdown all supervisors API.

2018-08-30 Thread GitBox
QiuMM opened a new pull request #6272: Showdown all supervisors API. URL: https://github.com/apache/incubator-druid/pull/6272 Every time I update my druid cluster, I need to shut down all KIS supervisors first. It is quite inconvenient to shut down one by one. So I add this API.

[GitHub] QiuMM opened a new pull request #6271: Docs: correct metric name in doc file

2018-08-30 Thread GitBox
QiuMM opened a new pull request #6271: Docs: correct metric name in doc file URL: https://github.com/apache/incubator-druid/pull/6271 Correct `jvm/gc/time` to `jvm/gc/cpu`. This is an automated message from the Apache Git

[GitHub] drcrallen commented on issue #6266: Rename io.druid to org.apache.druid.

2018-08-30 Thread GitBox
drcrallen commented on issue #6266: Rename io.druid to org.apache.druid. URL: https://github.com/apache/incubator-druid/pull/6266#issuecomment-417410032 @gianm get's a major line count boost with this one :) This is an

[GitHub] leventov commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-30 Thread GitBox
leventov commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r214130317 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-30 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r214216033 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-30 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r214210501 ## File path:

[GitHub] mohangaradi opened a new issue #6275: Kafka indexing from multiple topics into single datasource

2018-08-30 Thread GitBox
mohangaradi opened a new issue #6275: Kafka indexing from multiple topics into single datasource URL: https://github.com/apache/incubator-druid/issues/6275 Hi, Is it possible to ingest data from multiple topics into a single data source in kafka indexing ? or does it still have to

[GitHub] jon-wei opened a new pull request #6277: [Backport] BytesFullResponseHandler should only consume readableBytes of ChannelBuffer

2018-08-30 Thread GitBox
jon-wei opened a new pull request #6277: [Backport] BytesFullResponseHandler should only consume readableBytes of ChannelBuffer URL: https://github.com/apache/incubator-druid/pull/6277 Backport of #6270 to 0.12.3 This is an

[GitHub] gaodayue commented on issue #6270: BytesFullResponseHandler should only consume readableBytes of ChannelBuffer

2018-08-30 Thread GitBox
gaodayue commented on issue #6270: BytesFullResponseHandler should only consume readableBytes of ChannelBuffer URL: https://github.com/apache/incubator-druid/pull/6270#issuecomment-417511727 > It will help to do git config --local merge.renameLimit 5000 first, which will let git detect

[GitHub] jihoonson commented on issue #6273: Fix PostgreSQLConnectorConfig binding

2018-08-30 Thread GitBox
jihoonson commented on issue #6273: Fix PostgreSQLConnectorConfig binding URL: https://github.com/apache/incubator-druid/pull/6273#issuecomment-417515152 @fjy this bug was introduced in https://github.com/apache/incubator-druid/pull/6181 and it's not backported to 0.12.3. I'm changing the

[GitHub] xy-xin commented on issue #4137: Kafka indexing gets stuck if there is data from outside of load period

2018-08-30 Thread GitBox
xy-xin commented on issue #4137: Kafka indexing gets stuck if there is data from outside of load period URL: https://github.com/apache/incubator-druid/issues/4137#issuecomment-417523453 Thanks for your reply, @gianm . Have confirmed the result, and nothing bad impact. But still looking

[GitHub] clintropolis opened a new pull request #6276: fix coordinator console loading

2018-08-30 Thread GitBox
clintropolis opened a new pull request #6276: fix coordinator console loading URL: https://github.com/apache/incubator-druid/pull/6276 #6266 accidentally changed path coordinator console is loaded from to `org/apache/druid/console`, but druid-console pom.xml still [outputs to

[GitHub] leventov commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-30 Thread GitBox
leventov commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r214212101 ## File path:

[GitHub] jon-wei closed pull request #6270: BytesFullResponseHandler should only consume readableBytes of ChannelBuffer

2018-08-30 Thread GitBox
jon-wei closed pull request #6270: BytesFullResponseHandler should only consume readableBytes of ChannelBuffer URL: https://github.com/apache/incubator-druid/pull/6270 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] jon-wei closed issue #6269: Historical node fails to deserialize cachedSerializedUserMap

2018-08-30 Thread GitBox
jon-wei closed issue #6269: Historical node fails to deserialize cachedSerializedUserMap URL: https://github.com/apache/incubator-druid/issues/6269 This is an automated message from the Apache Git Service. To respond to the

[incubator-druid] branch master updated: BytesFullResponseHandler should only consume readableBytes of ChannelBuffer (#6270)

2018-08-30 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 951b36e BytesFullResponseHandler

[GitHub] gianm commented on issue #6266: Rename io.druid to org.apache.druid.

2018-08-30 Thread GitBox
gianm commented on issue #6266: Rename io.druid to org.apache.druid. URL: https://github.com/apache/incubator-druid/pull/6266#issuecomment-417203338 Interesting, there was a bump in CalciteQueryTest because some plans changed in cosmetic ways (dimensions in different order in cases where

[GitHub] fanwu72 opened a new issue #6268: Unexpected result is returned when query start time equals to end time

2018-08-30 Thread GitBox
fanwu72 opened a new issue #6268: Unexpected result is returned when query start time equals to end time URL: https://github.com/apache/incubator-druid/issues/6268 Hi there, I tested groupBy query and got unexpected result. When the starttime equals to endtime(e.g.

[GitHub] gaodayue opened a new pull request #6270: BytesFullResponseHandler should only consume readableBytes of ChannelBuffer

2018-08-30 Thread GitBox
gaodayue opened a new pull request #6270: BytesFullResponseHandler should only consume readableBytes of ChannelBuffer URL: https://github.com/apache/incubator-druid/pull/6270 Fixes #6269 This is an automated message

[GitHub] gaodayue opened a new issue #6269: Historical node fails to deserialize cachedSerializedUserMap

2018-08-30 Thread GitBox
gaodayue opened a new issue #6269: Historical node fails to deserialize cachedSerializedUserMap URL: https://github.com/apache/incubator-druid/issues/6269 After we added dozens of authenticator users in `basic-security` module, all nodes failed to poll authentication db from coordinator.

[GitHub] gaodayue commented on issue #6269: Historical node fails to deserialize cachedSerializedUserMap

2018-08-30 Thread GitBox
gaodayue commented on issue #6269: Historical node fails to deserialize cachedSerializedUserMap URL: https://github.com/apache/incubator-druid/issues/6269#issuecomment-417329792 I verified response from `/db/{authenticatorName}/cachedSerializedUserMap` is deserializable. The root cause

[GitHub] xy-xin commented on issue #4137: Kafka indexing gets stuck if there is data from outside of load period

2018-08-30 Thread GitBox
xy-xin commented on issue #4137: Kafka indexing gets stuck if there is data from outside of load period URL: https://github.com/apache/incubator-druid/issues/4137#issuecomment-417305989 We encounter this problem recently. Will kafka-indexing-service skip these data after some retries?