[GitHub] [incubator-druid] samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-04-05 Thread GitBox
samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r272482707 ## File path: docs/content/configuration/index.md ## @@ -1251,7

[GitHub] [incubator-druid] leventov commented on issue #7362: Principles for choosing logging severity

2019-04-05 Thread GitBox
leventov commented on issue #7362: Principles for choosing logging severity URL: https://github.com/apache/incubator-druid/issues/7362#issuecomment-480220550 @egor-ryashin this is the premise of adding debug and trace statements. However, in practice, I don't know of a single case when

[GitHub] [incubator-druid] leventov commented on a change in pull request #7328: EmitterModule: Throw an error on invalid emitter types.

2019-04-05 Thread GitBox
leventov commented on a change in pull request #7328: EmitterModule: Throw an error on invalid emitter types. URL: https://github.com/apache/incubator-druid/pull/7328#discussion_r272559397 ## File path: server/src/main/java/org/apache/druid/server/emitter/EmitterModule.java

[GitHub] [incubator-druid] xueyumusic commented on issue #5643: SQL: Push down filters from aggregators

2019-04-05 Thread GitBox
xueyumusic commented on issue #5643: SQL: Push down filters from aggregators URL: https://github.com/apache/incubator-druid/issues/5643#issuecomment-480193375 Hi, @gianm , Do you think whether it makes sense if having only one filter aggregation, such as: ``` SELECT COUNT(*)

[GitHub] [incubator-druid] gianm commented on issue #7362: Principles for choosing logging severity

2019-04-05 Thread GitBox
gianm commented on issue #7362: Principles for choosing logging severity URL: https://github.com/apache/incubator-druid/issues/7362#issuecomment-480321487 > TRACE is so noisy that use cases should be specialized. Usually I'd enable TRACE logging for a specific package, rather than

[GitHub] [incubator-druid] gianm commented on issue #7362: Principles for choosing logging severity

2019-04-05 Thread GitBox
gianm commented on issue #7362: Principles for choosing logging severity URL: https://github.com/apache/incubator-druid/issues/7362#issuecomment-480305168 Three thoughts on this that are maybe related, but also stand alone: 1) I have definitely used debug/trace logs to find bugs

[GitHub] [incubator-druid] leventov commented on issue #7362: Principles for choosing logging severity

2019-04-05 Thread GitBox
leventov commented on issue #7362: Principles for choosing logging severity URL: https://github.com/apache/incubator-druid/issues/7362#issuecomment-480312765 @egor-ryashin @gianm ok. Could you please suggest criteria for how to choose between INFO and DEBUG? @gianm I still

[GitHub] [incubator-druid] leventov commented on issue #7362: Principles for choosing logging severity

2019-04-05 Thread GitBox
leventov commented on issue #7362: Principles for choosing logging severity URL: https://github.com/apache/incubator-druid/issues/7362#issuecomment-480325575 > Ah, I really meant off-heap allocations (like decompression / dictionary merging buffers, etc) You can profile them with

[GitHub] [incubator-druid] leventov commented on issue #7362: Principles for choosing logging severity

2019-04-05 Thread GitBox
leventov commented on issue #7362: Principles for choosing logging severity URL: https://github.com/apache/incubator-druid/issues/7362#issuecomment-480315158 Another alternative is delegating all HTTP logging, for example, to a class `HttpLogging` and enable class-specific TRACE logging

[GitHub] [incubator-druid] gianm commented on issue #5643: SQL: Push down filters from aggregators

2019-04-05 Thread GitBox
gianm commented on issue #5643: SQL: Push down filters from aggregators URL: https://github.com/apache/incubator-druid/issues/5643#issuecomment-480283076 @xueyumusic, that does make sense too. This is an automated message

[GitHub] [incubator-druid] gianm edited a comment on issue #7362: Principles for choosing logging severity

2019-04-05 Thread GitBox
gianm edited a comment on issue #7362: Principles for choosing logging severity URL: https://github.com/apache/incubator-druid/issues/7362#issuecomment-480305168 Three thoughts on this that are maybe related, but also stand alone: 1) I have definitely used debug/trace logs to find

[GitHub] [incubator-druid] leerho commented on issue #7337: DataSketches HLL is not a replacement for Cardinality aggregator

2019-04-05 Thread GitBox
leerho commented on issue #7337: DataSketches HLL is not a replacement for Cardinality aggregator URL: https://github.com/apache/incubator-druid/issues/7337#issuecomment-480340797 I agree with @gianm . If the only operation you are doing is count and merge, you may as well use the

[GitHub] [incubator-druid] leerho commented on issue #7187: Improve topN algorithm

2019-04-05 Thread GitBox
leerho commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480349933 @peferron Thank you for your thoughtful comments. Clearly we have to leave it up to an informed user to decide. And all we can do is do our best to

[GitHub] [incubator-druid] gianm commented on issue #7320: use latest sketches-core-0.13.1

2019-04-05 Thread GitBox
gianm commented on issue #7320: use latest sketches-core-0.13.1 URL: https://github.com/apache/incubator-druid/pull/7320#issuecomment-480353582 0.15.0 is scheduled for a code freeze at the end of April, and would be released as soon as possible after that (typically takes a few days /

[GitHub] [incubator-druid] clintropolis closed issue #7377: Unified web console cuts off long strings

2019-04-05 Thread GitBox
clintropolis closed issue #7377: Unified web console cuts off long strings URL: https://github.com/apache/incubator-druid/issues/7377 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch master updated: SQL explain in web console (#7402)

2019-04-05 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new a66291a SQL explain in web console

[GitHub] [incubator-druid] clintropolis merged pull request #7402: SQL explain in web console

2019-04-05 Thread GitBox
clintropolis merged pull request #7402: SQL explain in web console URL: https://github.com/apache/incubator-druid/pull/7402 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-04-05 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r272737017 ## File path:

[GitHub] [incubator-druid] vogievetsky opened a new pull request #7419: Update console packages and enforce tslint quotes

2019-04-05 Thread GitBox
vogievetsky opened a new pull request #7419: Update console packages and enforce tslint quotes URL: https://github.com/apache/incubator-druid/pull/7419 Standardize on single quotes. Easier to do this change now than after the project is bigger.

[incubator-druid] branch master updated: Adding ability to pass configs in and fixing misc bugs (#7414)

2019-04-05 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 0fa122e Adding ability to pass

[GitHub] [incubator-druid] clintropolis merged pull request #7414: Adding ability to pass configs in and fixing misc bugs

2019-04-05 Thread GitBox
clintropolis merged pull request #7414: Adding ability to pass configs in and fixing misc bugs URL: https://github.com/apache/incubator-druid/pull/7414 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-druid] AlexanderSaydakov commented on issue #7320: use latest sketches-core-0.13.1

2019-04-05 Thread GitBox
AlexanderSaydakov commented on issue #7320: use latest sketches-core-0.13.1 URL: https://github.com/apache/incubator-druid/pull/7320#issuecomment-480346354 I understand. Is there an estimated time for 0.15.0 release? And for 0.14.1, if you decide to make it happen?

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-04-05 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r272737017 ## File path:

[incubator-druid] branch master updated: refactor lookups to be more chill to router (#7222)

2019-04-05 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 76b4a5c refactor lookups to be more

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions

2019-04-05 Thread GitBox
jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions URL: https://github.com/apache/incubator-druid/pull/7212#discussion_r272777522 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions

2019-04-05 Thread GitBox
jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions URL: https://github.com/apache/incubator-druid/pull/7212#discussion_r272777522 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions

2019-04-05 Thread GitBox
jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions URL: https://github.com/apache/incubator-druid/pull/7212#discussion_r272777551 ## File path:

[GitHub] [incubator-druid] justinborromeo commented on issue #7369: Change SQL endpoint response code from 405 to 404 on non-broker processes

2019-04-05 Thread GitBox
justinborromeo commented on issue #7369: Change SQL endpoint response code from 405 to 404 on non-broker processes URL: https://github.com/apache/incubator-druid/issues/7369#issuecomment-480434467 @egor-ryashin what do you mean by "another message"?

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions

2019-04-05 Thread GitBox
jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions URL: https://github.com/apache/incubator-druid/pull/7212#discussion_r272778705 ## File path:

[GitHub] [incubator-druid] egor-ryashin edited a comment on issue #7387: druid extensions-contrib deep storage cassandra loading error

2019-04-05 Thread GitBox
egor-ryashin edited a comment on issue #7387: druid extensions-contrib deep storage cassandra loading error URL: https://github.com/apache/incubator-druid/issues/7387#issuecomment-480448767 It didn't load the extension, as it says it doesn't know anything except `local` > known

[GitHub] [incubator-druid] shuqi7 opened a new pull request #7421: Add time taken by last query in SQL view

2019-04-05 Thread GitBox
shuqi7 opened a new pull request #7421: Add time taken by last query in SQL view URL: https://github.com/apache/incubator-druid/pull/7421 - Showing time taken by last query in SQL view

[GitHub] [incubator-druid] egor-ryashin commented on issue #7369: Change SQL endpoint response code from 405 to 404 on non-broker processes

2019-04-05 Thread GitBox
egor-ryashin commented on issue #7369: Change SQL endpoint response code from 405 to 404 on non-broker processes URL: https://github.com/apache/incubator-druid/issues/7369#issuecomment-480433129 I'm confused, as 405 stands for another message > The HyperText Transfer Protocol

[GitHub] [incubator-druid] jon-wei merged pull request #7222: refactor lookups to be more chill to router

2019-04-05 Thread GitBox
jon-wei merged pull request #7222: refactor lookups to be more chill to router URL: https://github.com/apache/incubator-druid/pull/7222 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch master updated: Update SQL doc for planning change (#7415)

2019-04-05 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new e23fd41 Update SQL doc for planning

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions

2019-04-05 Thread GitBox
jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions URL: https://github.com/apache/incubator-druid/pull/7212#discussion_r272767903 ## File path:

[GitHub] [incubator-druid] clintropolis opened a new pull request #7420: fix expressions docs operator table

2019-04-05 Thread GitBox
clintropolis opened a new pull request #7420: fix expressions docs operator table URL: https://github.com/apache/incubator-druid/pull/7420 Fixes markdown table to use code for `|` instead of escaping:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions

2019-04-05 Thread GitBox
jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions URL: https://github.com/apache/incubator-druid/pull/7212#discussion_r272356435 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions

2019-04-05 Thread GitBox
jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions URL: https://github.com/apache/incubator-druid/pull/7212#discussion_r272769658 ## File path:

[GitHub] [incubator-druid] clintropolis merged pull request #7415: Update SQL query execution doc

2019-04-05 Thread GitBox
clintropolis merged pull request #7415: Update SQL query execution doc URL: https://github.com/apache/incubator-druid/pull/7415 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-druid] egor-ryashin commented on issue #7387: druid extensions-contrib deep storage cassandra loading error

2019-04-05 Thread GitBox
egor-ryashin commented on issue #7387: druid extensions-contrib deep storage cassandra loading error URL: https://github.com/apache/incubator-druid/issues/7387#issuecomment-480448767 It didn't load the extension, as it says it doesn't know anything except `local` > known

[GitHub] [incubator-druid] justinborromeo opened a new issue #7422: Update API Reference doc with endpoints' request parameters and response model

2019-04-05 Thread GitBox
justinborromeo opened a new issue #7422: Update API Reference doc with endpoints' request parameters and response model URL: https://github.com/apache/incubator-druid/issues/7422 ### Motivation The existing API reference is very difficult to use since there's no documented

[GitHub] [incubator-druid] stale[bot] commented on issue #6493: Support for request logging in kafka emitter.

2019-04-05 Thread GitBox
stale[bot] commented on issue #6493: Support for request logging in kafka emitter. URL: https://github.com/apache/incubator-druid/pull/6493#issuecomment-480474164 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity

[GitHub] [incubator-druid] stale[bot] commented on issue #5739: make statsd emitter extensible

2019-04-05 Thread GitBox
stale[bot] commented on issue #5739: make statsd emitter extensible URL: https://github.com/apache/incubator-druid/pull/5739#issuecomment-480474161 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you

[GitHub] [incubator-druid] Freya0214 commented on issue #7387: druid extensions-contrib deep storage cassandra loading error

2019-04-05 Thread GitBox
Freya0214 commented on issue #7387: druid extensions-contrib deep storage cassandra loading error URL: https://github.com/apache/incubator-druid/issues/7387#issuecomment-480467236 > It didn't load the extension, as it says it doesn't know anything except local > > known