[GitHub] jihoonson commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling

jihoonson commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-409453337 @nishantmonu51 awesome! Thanks for clarifying. Everything looks good except the travis failure. Would you check it please?

[GitHub] nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-409441738 @jihoonson any more comments here ? This is an

[GitHub] hellobabygogo commented on issue #6085: SQL bug of avg function

hellobabygogo commented on issue #6085: SQL bug of avg function URL: https://github.com/apache/incubator-druid/issues/6085#issuecomment-409440817 @gianm hi, thanks for reply.I agree with your suggestion that used sum(queryTime) / sum("count") to instead of avg(queryTime) , but its

[GitHub] gianm commented on issue #6085: SQL bug of avg function

gianm commented on issue #6085: SQL bug of avg function URL: https://github.com/apache/incubator-druid/issues/6085#issuecomment-409433128 Hi @hellobabygogo, currently, Druid SQL is not rollup-aware. So for average on a rolled up datasource you should instead write: `select sum(queryTime)

[GitHub] josephglanville commented on issue #5584: Decoupling FirehoseFactory and InputRowParser

josephglanville commented on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-409430347 Yes, I am starting work on this now. I will open a PR when I have something we can iterate on.

[GitHub] jon-wei commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

jon-wei commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206712982 ## File path:

[GitHub] leventov commented on issue #6070: Use JUnit TemporaryFolder rule instead of system temp folder

leventov commented on issue #6070: Use JUnit TemporaryFolder rule instead of system temp folder URL: https://github.com/apache/incubator-druid/pull/6070#issuecomment-409392115 @yuppie-flu `failOnUnresolvableSignatures`. Please set it to true and include FileUtils in the forbidden-apis

[GitHub] leventov closed pull request #6083: [Backport] Fix 'auto' encoded longs + compression serializer

leventov closed pull request #6083: [Backport] Fix 'auto' encoded longs + compression serializer URL: https://github.com/apache/incubator-druid/pull/6083 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-druid] branch 0.12.2 updated: [Backport] Fix 'auto' encoded longs + compression serializer (#6083)

This is an automated email from the ASF dual-hosted git repository. leventov pushed a commit to branch 0.12.2 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.12.2 by this push: new be6481c [Backport] Fix 'auto'

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r206701447 ## File path: processing/src/main/java/io/druid/segment/data/codecs/ints/LemireIntFormDecoder.java ## @@

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r206691833 ## File path: processing/src/main/java/io/druid/segment/data/ShapeShiftingColumnSerializer.java ## @@ -0,0

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r206680592 ## File path: processing/src/main/java/io/druid/segment/data/ShapeShiftingColumnSerializer.java ## @@ -0,0

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r206685959 ## File path: processing/src/main/java/io/druid/segment/data/ShapeShiftingColumnSerializer.java ## @@ -0,0

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r206658759 ## File path: processing/src/main/java/io/druid/segment/data/codecs/FormMetrics.java ## @@ -0,0 +1,90 @@

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r206667473 ## File path: processing/src/main/java/io/druid/segment/data/codecs/ints/IntFormMetrics.java ## @@ -0,0

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r206690700 ## File path: processing/src/main/java/io/druid/segment/data/ShapeShiftingColumnSerializer.java ## @@ -0,0

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r206683651 ## File path: processing/src/main/java/io/druid/segment/data/ShapeShiftingColumnSerializer.java ## @@ -0,0

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r206700732 ## File path: processing/src/main/java/io/druid/segment/data/ShapeShiftingColumnarIntsSerializer.java ## @@

[GitHub] jon-wei closed pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask

jon-wei closed pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask URL: https://github.com/apache/incubator-druid/pull/6065 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[incubator-druid] branch master updated: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask (#6065)

This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 91943a2 Fix CombiningFirehoseFactory

[GitHub] jon-wei commented on issue #6084: Add broken test to demonstrate that CI can pass

jon-wei commented on issue #6084: Add broken test to demonstrate that CI can pass URL: https://github.com/apache/incubator-druid/pull/6084#issuecomment-409384511 @yuppie-flu yes, #6061 has been reverted This is an automated

[GitHub] jon-wei commented on issue #6084: Add broken test to demonstrate that CI can pass

jon-wei commented on issue #6084: Add broken test to demonstrate that CI can pass URL: https://github.com/apache/incubator-druid/pull/6084#issuecomment-409382812 The test failed (as it should), I think you might have hit a problem with https://github.com/apache/incubator-druid/pull/6061,

[GitHub] yuppie-flu opened a new pull request #6084: Add broken test to demonstrate that CI can pass

yuppie-flu opened a new pull request #6084: Add broken test to demonstrate that CI can pass URL: https://github.com/apache/incubator-druid/pull/6084 Looks like CI does not run any tests when a branch is rebased with changing commit message only for example. This can lead to PRs with

[GitHub] andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r206687572 ## File path:

[GitHub] andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r206687495 ## File path:

[GitHub] andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r206687464 ## File path:

[GitHub] jihoonson commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

jihoonson commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r206678821 ## File path:

[GitHub] jihoonson commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

jihoonson commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r206679171 ## File path:

[GitHub] jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206664109 ## File path:

[incubator-druid] branch master updated: Revert "skip travis on doc only changes" (#6077)

This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new bb2fd57 Revert "skip travis on doc

[GitHub] jon-wei closed pull request #6077: Revert "skip travis on doc only changes"

jon-wei closed pull request #6077: Revert "skip travis on doc only changes" URL: https://github.com/apache/incubator-druid/pull/6077 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] chengchengpei edited a comment on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

chengchengpei edited a comment on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#issuecomment-409238862 @jihoonson It is ready for review now. Could you please help remove WIP tag? Thanks. Btw,

[GitHub] jihoonson opened a new pull request #6083: [Backport] Fix 'auto' encoded longs + compression serializer

jihoonson opened a new pull request #6083: [Backport] Fix 'auto' encoded longs + compression serializer URL: https://github.com/apache/incubator-druid/pull/6083 Backport of https://github.com/apache/incubator-druid/pull/6045 to 0.12.2.

[GitHub] himanshug commented on issue #6066: Sorting rows when rollup is disabled

himanshug commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-409291702 I think, sorting would lead to encoded column values for same int all to be together , so we would end up with sorted int array as

[GitHub] asdf2014 commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

asdf2014 commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r206585314 ## File path:

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r20655 ## File path:

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r206549464 ## File path: processing/src/main/java/io/druid/query/aggregation/AggregatorUtil.java

[GitHub] nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-40923 @jihoonson In terms of functionality, After this PR, all things mentioned in the proposal except following should be

[GitHub] chengchengpei commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

chengchengpei commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#issuecomment-409238862 @jihoonson It is ready for review now. Thanks. Btw, why I cannot add/remove the tags?

[GitHub] andresgomezfrr commented on issue #5789: Add stringLast and stringFirst aggregators extension

andresgomezfrr commented on issue #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#issuecomment-409172115 Fix the test, I didn't see it, sorry! Remove the `filterNullValues` property. Instead, you can use the

[GitHub] andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r206471854 ## File path: