[GitHub] [incubator-druid] quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting

2019-03-19 Thread GitBox
quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting URL: https://github.com/apache/incubator-druid/issues/7297#issuecomment-474692002 > Make sure you use the DaraSketches HLL and not the Druid builtin HLL! Yes,i used the

[GitHub] [incubator-druid] leerho commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting

2019-03-19 Thread GitBox
leerho commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting URL: https://github.com/apache/incubator-druid/issues/7297#issuecomment-474691264 Make sure you use the DaraSketches HLL and not the Druid builtin HLL! On Tue, Mar 19, 2019

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7206: Add the pull-request template

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267188508 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7206: Add the pull-request template

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267188508 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7206: Add the pull-request template

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267182783 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7206: Add the pull-request template

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267182783 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7300: Druid console docs

2019-03-19 Thread GitBox
surekhasaharan commented on a change in pull request #7300: Druid console docs URL: https://github.com/apache/incubator-druid/pull/7300#discussion_r267111824 ## File path: docs/content/operations/druid-console.md ## @@ -0,0 +1,90 @@ +--- +layout: doc_page +title: "Druid

[GitHub] [incubator-druid] lxqfy opened a new issue #7302: Druid Broker Result Level Cache Not Working Properly When Different Query Intervals Cover the Same Set of Segments

2019-03-19 Thread GitBox
lxqfy opened a new issue #7302: Druid Broker Result Level Cache Not Working Properly When Different Query Intervals Cover the Same Set of Segments URL: https://github.com/apache/incubator-druid/issues/7302 Druid Broker Result Level Cache Not Working Properly When Different Query Intervals

[GitHub] [incubator-druid] jon-wei commented on issue #6972: Support LDAP authentication/authorization

2019-03-19 Thread GitBox
jon-wei commented on issue #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#issuecomment-474657054 @mohammadjkhan Sorry for the delay, I will start reviewing this week.

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267156636 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267163198 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryLimitRowIterator.java ## @@ -70,9

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267163198 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryLimitRowIterator.java ## @@ -70,9

[GitHub] [incubator-druid] fjy removed a comment on issue #7300: Druid console docs

2019-03-19 Thread GitBox
fjy removed a comment on issue #7300: Druid console docs URL: https://github.com/apache/incubator-druid/pull/7300#issuecomment-474643927 @clintropolis this is for 0.15 I believe, as it references features that doesn't exist in the 0.14 build

[GitHub] [incubator-druid] mohammadjkhan commented on issue #6972: Support LDAP authentication/authorization

2019-03-19 Thread GitBox
mohammadjkhan commented on issue #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#issuecomment-474654220 Hi @jon-wei I'm following up to see if you had the chance to look and review the changes in this PR yet? It's currently

[GitHub] [incubator-druid] fjy merged pull request #7298: [Backport] Fix race in historical when loading segments in parallel

2019-03-19 Thread GitBox
fjy merged pull request #7298: [Backport] Fix race in historical when loading segments in parallel URL: https://github.com/apache/incubator-druid/pull/7298 This is an automated message from the Apache Git Service. To

[incubator-druid] branch 0.14.0-incubating updated: Fix race in historical when loading segments in parallel (#7203) (#7298)

2019-03-19 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch 0.14.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.14.0-incubating by this push: new e926121 Fix race

[GitHub] [incubator-druid] fjy commented on issue #7300: Druid console docs

2019-03-19 Thread GitBox
fjy commented on issue #7300: Druid console docs URL: https://github.com/apache/incubator-druid/pull/7300#issuecomment-474643927 @clintropolis this is for 0.15 I believe, as it references features that doesn't exist in the 0.14 build

[GitHub] [incubator-druid] jon-wei edited a comment on issue #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei edited a comment on issue #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#issuecomment-474640476 I don't think this needs to be something done in this PR, but it's worth mentioning that moving the "time chunking" behavior to the broker,

[GitHub] [incubator-druid] jon-wei commented on issue #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on issue #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#issuecomment-474640476 I don't think this needs to be something done in this PR, but it's worth mentioning that moving the "time chunking" behavior to the broker, and

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r26714 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r26714 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34

[GitHub] [incubator-druid] vogievetsky commented on issue #7292: Add table column selection in druid console to allow hiding/showing of columns

2019-03-19 Thread GitBox
vogievetsky commented on issue #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#issuecomment-474634938 LGTM  @shuqi7 thank you for promptly addressing all my feedback

[GitHub] [incubator-druid] jihoonson edited a comment on issue #7291: Fix exclusivity for start offset in kinesis indexing service & check exclusivity properly in IndexerSQLMetadataStorageCoordinator

2019-03-19 Thread GitBox
jihoonson edited a comment on issue #7291: Fix exclusivity for start offset in kinesis indexing service & check exclusivity properly in IndexerSQLMetadataStorageCoordinator URL: https://github.com/apache/incubator-druid/pull/7291#issuecomment-474627712 This PR is ready for review. Updated

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267144903 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267139172 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

2019-03-19 Thread GitBox
vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r267145133 ## File path: web-console/src/utils/index.tsx ## @@ -20,3

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

2019-03-19 Thread GitBox
vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r267143824 ## File path: web-console/src/views/tasks-view.tsx ## @@

[GitHub] [incubator-druid] gianm commented on a change in pull request #7279: Add committer_readme.md

2019-03-19 Thread GitBox
gianm commented on a change in pull request #7279: Add committer_readme.md URL: https://github.com/apache/incubator-druid/pull/7279#discussion_r267138895 ## File path: committer_readme.md ## @@ -0,0 +1,56 @@ + +## PR action item checklist for committers + +1. Add

[GitHub] [incubator-druid] gianm commented on a change in pull request #7279: Add committer_readme.md

2019-03-19 Thread GitBox
gianm commented on a change in pull request #7279: Add committer_readme.md URL: https://github.com/apache/incubator-druid/pull/7279#discussion_r267142800 ## File path: committer_readme.md ## @@ -0,0 +1,56 @@ + +## PR action item checklist for committers + +1. Add

[GitHub] [incubator-druid] gianm commented on a change in pull request #7279: Add committer_readme.md

2019-03-19 Thread GitBox
gianm commented on a change in pull request #7279: Add committer_readme.md URL: https://github.com/apache/incubator-druid/pull/7279#discussion_r267140272 ## File path: committer_readme.md ## @@ -0,0 +1,56 @@ + +## PR action item checklist for committers + +1. Add

[GitHub] [incubator-druid] quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting

2019-03-19 Thread GitBox
quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting URL: https://github.com/apache/incubator-druid/issues/7297#issuecomment-474629206 Thank you so much! This is an

[GitHub] [incubator-druid] jihoonson commented on issue #7291: Fix exclusivity for start offset in kinesis indexing service

2019-03-19 Thread GitBox
jihoonson commented on issue #7291: Fix exclusivity for start offset in kinesis indexing service URL: https://github.com/apache/incubator-druid/pull/7291#issuecomment-474627712 This PR is ready for review. I added `SeekableStreamStartSequenceNumbers` and

[GitHub] [incubator-druid] gianm commented on issue #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories.

2019-03-19 Thread GitBox
gianm commented on issue #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories. URL: https://github.com/apache/incubator-druid/pull/7293#issuecomment-474625046 > I am going to revert the naming changes, since I didn't mean to create an incompatible change.

[GitHub] [incubator-druid] gianm commented on issue #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories.

2019-03-19 Thread GitBox
gianm commented on issue #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories. URL: https://github.com/apache/incubator-druid/pull/7293#issuecomment-474624342 I am going to revert the naming changes, since I didn't mean to create an incompatible change.

[GitHub] [incubator-druid] gianm commented on issue #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories.

2019-03-19 Thread GitBox
gianm commented on issue #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories. URL: https://github.com/apache/incubator-druid/pull/7293#issuecomment-474624269 Ah I forgot this was an extension point. I could revert the method naming changes, I didn't really mean

[GitHub] [incubator-druid] leventov commented on issue #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories.

2019-03-19 Thread GitBox
leventov commented on issue #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories. URL: https://github.com/apache/incubator-druid/pull/7293#issuecomment-474624119 Since it's an incompatible change, also adding `Design Review` tag.

[GitHub] [incubator-druid] leventov commented on a change in pull request #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories.

2019-03-19 Thread GitBox
leventov commented on a change in pull request #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories. URL: https://github.com/apache/incubator-druid/pull/7293#discussion_r267131588 ## File path:

[GitHub] [incubator-druid] michael-trelinski commented on a change in pull request #6740: Zookeeper loss

2019-03-19 Thread GitBox
michael-trelinski commented on a change in pull request #6740: Zookeeper loss URL: https://github.com/apache/incubator-druid/pull/6740#discussion_r267130059 ## File path: server/src/test/java/org/apache/druid/curator/BoundedExponentialBackoffRetryWithQuitTest.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

2019-03-19 Thread GitBox
leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267125648 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

2019-03-19 Thread GitBox
leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267121031 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

2019-03-19 Thread GitBox
leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267123308 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7206: Add the pull-request template

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267120891 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

2019-03-19 Thread GitBox
leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267121031 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

2019-03-19 Thread GitBox
leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267116731 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

2019-03-19 Thread GitBox
leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267115662 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] gianm merged pull request #7299: Fix conflicting information in configuration doc

2019-03-19 Thread GitBox
gianm merged pull request #7299: Fix conflicting information in configuration doc URL: https://github.com/apache/incubator-druid/pull/7299 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-druid] leventov opened a new pull request #7301: Make 'field can be final' inspection a warning in IntelliJ config

2019-03-19 Thread GitBox
leventov opened a new pull request #7301: Make 'field can be final' inspection a warning in IntelliJ config URL: https://github.com/apache/incubator-druid/pull/7301 A small step towards #7227. This is an automated message

[GitHub] [incubator-druid] leventov merged pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

2019-03-19 Thread GitBox
leventov merged pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185 This is an automated message from

[GitHub] [incubator-druid] leventov commented on issue #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

2019-03-19 Thread GitBox
leventov commented on issue #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#issuecomment-474589844 @egor-ryashin @clintropolis thanks for reviews.

[GitHub] [incubator-druid] yurmix commented on issue #6430: Contributing Moving-Average Query to open source.

2019-03-19 Thread GitBox
yurmix commented on issue #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#issuecomment-474581201 @jihoonson, thanks so much for your effort on this thorough review and sorry it took me that long to complete my response. I

[GitHub] [incubator-druid] yurmix edited a comment on issue #7290: Moving average query pr2

2019-03-19 Thread GitBox
yurmix edited a comment on issue #7290: Moving average query pr2 URL: https://github.com/apache/incubator-druid/pull/7290#issuecomment-474145356 > @yurmix thanks. I'm not sure reopening is better or not though. Sure thing, I'll go back to the original pr, if we have a merge issue to

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

2019-03-19 Thread GitBox
yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r267088298 ## File path:

[GitHub] [incubator-druid] AlexanderSaydakov commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting

2019-03-19 Thread GitBox
AlexanderSaydakov commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting URL: https://github.com/apache/incubator-druid/issues/7297#issuecomment-474555914 I would recommend using HLL if you don't need intersections and A-not-B operations,

[GitHub] [incubator-druid] justinborromeo opened a new pull request #7299: Fix conflicting information in configuration doc

2019-03-19 Thread GitBox
justinborromeo opened a new pull request #7299: Fix conflicting information in configuration doc URL: https://github.com/apache/incubator-druid/pull/7299 The doc says that both "noop" and "logging" emitters are the default in different places. Based on the code in EmitterModule, "noop"

[GitHub] [incubator-druid] stale[bot] commented on issue #3956: Thread safe reads for aggregators in IncrementalIndex

2019-03-19 Thread GitBox
stale[bot] commented on issue #3956: Thread safe reads for aggregators in IncrementalIndex URL: https://github.com/apache/incubator-druid/pull/3956#issuecomment-474550197 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

2019-03-19 Thread GitBox
egor-ryashin commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r267058115 ## File path:

[GitHub] [incubator-druid] quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting

2019-03-19 Thread GitBox
quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting URL: https://github.com/apache/incubator-druid/issues/7297#issuecomment-474510220 Thanks for quick reply ! > I don't see how this is possible. OK, maybe it is my

[GitHub] [incubator-druid] AlexanderSaydakov commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting

2019-03-19 Thread GitBox
AlexanderSaydakov commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting URL: https://github.com/apache/incubator-druid/issues/7297#issuecomment-474503384 I don't see how this is possible. Regarding HLL, I think it should use less

[GitHub] [incubator-druid] quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting

2019-03-19 Thread GitBox
quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting URL: https://github.com/apache/incubator-druid/issues/7297#issuecomment-474497181 Thanks for quick reply ! > Theta sketch ignores nulls and empty strings. Are you sure your

[GitHub] [incubator-druid] donbowman commented on a change in pull request #7296: Remove mysql database connector from container image

2019-03-19 Thread GitBox
donbowman commented on a change in pull request #7296: Remove mysql database connector from container image URL: https://github.com/apache/incubator-druid/pull/7296#discussion_r267004774 ## File path: distribution/docker/README.md ## @@ -24,3 +24,15 @@ From the root of

[GitHub] [incubator-druid] jihoonson opened a new pull request #7298: [Backport] Fix race in historical when loading segments in parallel

2019-03-19 Thread GitBox
jihoonson opened a new pull request #7298: [Backport] Fix race in historical when loading segments in parallel URL: https://github.com/apache/incubator-druid/pull/7298 Backport of #7203 to 0.14.0-incubating. This is an

[GitHub] [incubator-druid] jihoonson commented on issue #7203: Fix race in historical when loading segments in parallel

2019-03-19 Thread GitBox
jihoonson commented on issue #7203: Fix race in historical when loading segments in parallel URL: https://github.com/apache/incubator-druid/pull/7203#issuecomment-474467936 @a2l007 oh, I will backport. This is an automated

[GitHub] [incubator-druid] drcrallen commented on a change in pull request #7296: Remove mysql database connector from container image

2019-03-19 Thread GitBox
drcrallen commented on a change in pull request #7296: Remove mysql database connector from container image URL: https://github.com/apache/incubator-druid/pull/7296#discussion_r266991954 ## File path: distribution/docker/README.md ## @@ -24,3 +24,15 @@ From the root of

[GitHub] [incubator-druid] drcrallen commented on a change in pull request #7296: Remove mysql database connector from container image

2019-03-19 Thread GitBox
drcrallen commented on a change in pull request #7296: Remove mysql database connector from container image URL: https://github.com/apache/incubator-druid/pull/7296#discussion_r266991954 ## File path: distribution/docker/README.md ## @@ -24,3 +24,15 @@ From the root of

[GitHub] [incubator-druid] AlexanderSaydakov commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting

2019-03-19 Thread GitBox
AlexanderSaydakov commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting URL: https://github.com/apache/incubator-druid/issues/7297#issuecomment-474460432 Theta sketch ignores nulls and empty strings. Are you sure your input is really empty,

[GitHub] [incubator-druid] AlexanderSaydakov edited a comment on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting

2019-03-19 Thread GitBox
AlexanderSaydakov edited a comment on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting URL: https://github.com/apache/incubator-druid/issues/7297#issuecomment-474460432 Theta sketch ignores nulls and empty strings. Are you sure your input is really

[GitHub] [incubator-druid] a2l007 edited a comment on issue #7203: Fix race in historical when loading segments in parallel

2019-03-19 Thread GitBox
a2l007 edited a comment on issue #7203: Fix race in historical when loading segments in parallel URL: https://github.com/apache/incubator-druid/pull/7203#issuecomment-474406915 Hey @jihoonson , would this be backported to 0.14.0? Seeing the same issue in 0.14.0. If not, I can use ZK

[GitHub] [incubator-druid] a2l007 commented on issue #7203: Fix race in historical when loading segments in parallel

2019-03-19 Thread GitBox
a2l007 commented on issue #7203: Fix race in historical when loading segments in parallel URL: https://github.com/apache/incubator-druid/pull/7203#issuecomment-474406915 Hey @jihoonson , would this be backported to 0.14.0? I'm seeing the same issue in 0.14.0

[GitHub] [incubator-druid] quenlang opened a new issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting

2019-03-19 Thread GitBox
quenlang opened a new issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting URL: https://github.com/apache/incubator-druid/issues/7297 @AlexanderSaydakov @gianm I had found the thetaSketch aggrgator handle ```null``` or ```""``` into unexpected value

[GitHub] [incubator-druid] donbowman opened a new pull request #7296: Remove mysql database connector from container image

2019-03-19 Thread GitBox
donbowman opened a new pull request #7296: Remove mysql database connector from container image URL: https://github.com/apache/incubator-druid/pull/7296 See discussion on `dev` mailing list from 2019-03 around [docker

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

2019-03-19 Thread GitBox
yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266774086 ## File path: