[GitHub] [incubator-druid] mihai-cazacu-adswizz commented on issue #7403: how to use MaterializedView ,I didn't find the relevant submit task command.

2019-04-04 Thread GitBox
mihai-cazacu-adswizz commented on issue #7403: how to use MaterializedView ,I didn't find the relevant submit task command. URL: https://github.com/apache/incubator-druid/issues/7403#issuecomment-480153120 Hi, You have to run something like this: ``` curl -X 'POST' -H

[GitHub] [incubator-druid] gianm closed issue #6518: [Proposal] Shutdown druid processes upon complete loss of ZK connectivity

2019-04-04 Thread GitBox
gianm closed issue #6518: [Proposal] Shutdown druid processes upon complete loss of ZK connectivity URL: https://github.com/apache/incubator-druid/issues/6518 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] fjy merged pull request #7417: change Dockerfile maintainers email to dev mailing list

2019-04-04 Thread GitBox
fjy merged pull request #7417: change Dockerfile maintainers email to dev mailing list URL: https://github.com/apache/incubator-druid/pull/7417 This is an automated message from the Apache Git Service. To respond to the

[incubator-druid] branch master updated: change Dockerfile maintainers email to dev mailing list (#7417)

2019-04-04 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new e2aa6e4 change Dockerfile maintainers

[GitHub] [incubator-druid] vogievetsky commented on issue #7402: SQL explain in web console

2019-04-04 Thread GitBox
vogievetsky commented on issue #7402: SQL explain in web console URL: https://github.com/apache/incubator-druid/pull/7402#issuecomment-480120889 Looking good. Thank you for promptly addressing the feedback.  This is an

[GitHub] [incubator-druid] vogievetsky commented on issue #7406: Console SQL function doc generation

2019-04-04 Thread GitBox
vogievetsky commented on issue #7406: Console SQL function doc generation URL: https://github.com/apache/incubator-druid/pull/7406#issuecomment-480120773 Thank you for making the changes I suggested. This is  from me, much more maintainable

[GitHub] [incubator-druid] clintropolis opened a new pull request #7418: add travis check to make sure distribution packaging exits successfully

2019-04-04 Thread GitBox
clintropolis opened a new pull request #7418: add travis check to make sure distribution packaging exits successfully URL: https://github.com/apache/incubator-druid/pull/7418 Follow up to #7358, this adds a travis check that adds `mvn ... clean install -Pdist` run to ensure that creating

[GitHub] [incubator-druid] jon-wei edited a comment on issue #6972: Support LDAP authentication/authorization

2019-04-04 Thread GitBox
jon-wei edited a comment on issue #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#issuecomment-480112099 @mohammadjkhan Regarding my earlier comment

[GitHub] [incubator-druid] jon-wei edited a comment on issue #6972: Support LDAP authentication/authorization

2019-04-04 Thread GitBox
jon-wei edited a comment on issue #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#issuecomment-480112099 @mohammadjkhan Regarding my earlier comment

[GitHub] [incubator-druid] jon-wei commented on issue #6972: Support LDAP authentication/authorization

2019-04-04 Thread GitBox
jon-wei commented on issue #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#issuecomment-480112099 @mohammadjkhan Regarding my earlier comment (https://github.com/apache/incubator-druid/pull/6972#issuecomment-48052),

[GitHub] [incubator-druid] clintropolis opened a new pull request #7417: change Dockerfile maintainers email to dev mailing list

2019-04-04 Thread GitBox
clintropolis opened a new pull request #7417: change Dockerfile maintainers email to dev mailing list URL: https://github.com/apache/incubator-druid/pull/7417 This was missed in #6896. This is an automated message from the

[GitHub] [incubator-druid] surekhasaharan commented on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table

2019-04-04 Thread GitBox
surekhasaharan commented on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-480107278 I have updated the issue with proposal components which talks about the way I am thinking

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-04-04 Thread GitBox
jon-wei commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r272411215 ## File path: docs/content/development/extensions-core/druid-basic-security.md ## @@ -155,6

[GitHub] [incubator-druid] justinborromeo opened a new pull request #7416: Remove select execution code from SQL planner

2019-04-04 Thread GitBox
justinborromeo opened a new pull request #7416: Remove select execution code from SQL planner URL: https://github.com/apache/incubator-druid/pull/7416 #7373 changed SQL planning to eliminate the use of select queries for time-ordered SQL SELECTs. This PR removes the code in the SQL

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs

2019-04-04 Thread GitBox
vogievetsky commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs URL: https://github.com/apache/incubator-druid/pull/7414#discussion_r272405472 ## File path: web-console/src/entry.ts ## @@ -30,11 +30,14 @@ import

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7413: Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec

2019-04-04 Thread GitBox
jon-wei commented on a change in pull request #7413: Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec URL: https://github.com/apache/incubator-druid/pull/7413#discussion_r272404675 ## File path:

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs

2019-04-04 Thread GitBox
vogievetsky commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs URL: https://github.com/apache/incubator-druid/pull/7414#discussion_r272405016 ## File path: web-console/console-config.js ## @@ -0,0 +1,19 @@ +/* + * Licensed

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs

2019-04-04 Thread GitBox
vogievetsky commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs URL: https://github.com/apache/incubator-druid/pull/7414#discussion_r272404775 ## File path: web-console/console-config.js ## @@ -0,0 +1,19 @@ +/* + * Licensed

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs

2019-04-04 Thread GitBox
clintropolis commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs URL: https://github.com/apache/incubator-druid/pull/7414#discussion_r272396331 ## File path: web-console/console-config.js ## @@ -0,0 +1,19 @@ +/* + * Licensed

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs

2019-04-04 Thread GitBox
clintropolis commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs URL: https://github.com/apache/incubator-druid/pull/7414#discussion_r272397011 ## File path: web-console/console-config.js ## @@ -0,0 +1,19 @@ +/* + * Licensed

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs

2019-04-04 Thread GitBox
clintropolis commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs URL: https://github.com/apache/incubator-druid/pull/7414#discussion_r272397011 ## File path: web-console/console-config.js ## @@ -0,0 +1,19 @@ +/* + * Licensed

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs

2019-04-04 Thread GitBox
clintropolis commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs URL: https://github.com/apache/incubator-druid/pull/7414#discussion_r272398081 ## File path: web-console/src/entry.ts ## @@ -30,11 +30,14 @@ import

[GitHub] [incubator-druid] justinborromeo opened a new pull request #7415: Update SQL query execution doc

2019-04-04 Thread GitBox
justinborromeo opened a new pull request #7415: Update SQL query execution doc URL: https://github.com/apache/incubator-druid/pull/7415 #7373 changed SQL planning to eliminate the use of select queries for time-ordered SQL SELECTs. I should have updated the SQL docs to reflect this.

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7402: SQL explain in web console

2019-04-04 Thread GitBox
vogievetsky commented on a change in pull request #7402: SQL explain in web console URL: https://github.com/apache/incubator-druid/pull/7402#discussion_r272395735 ## File path: web-console/src/utils/druid-query.tsx ## @@ -43,3 +43,60 @@ export async function

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7402: SQL explain in web console

2019-04-04 Thread GitBox
vogievetsky commented on a change in pull request #7402: SQL explain in web console URL: https://github.com/apache/incubator-druid/pull/7402#discussion_r272395907 ## File path: web-console/src/dialogs/query-plan-dialog.tsx ## @@ -0,0 +1,134 @@ +/* + * Licensed to the

[GitHub] [incubator-druid] lemire commented on issue #7408: upgrade to RoaringBitmap 0.8.0 and serialise directly to ByteBuffer

2019-04-04 Thread GitBox
lemire commented on issue #7408: upgrade to RoaringBitmap 0.8.0 and serialise directly to ByteBuffer URL: https://github.com/apache/incubator-druid/pull/7408#issuecomment-480080368 @richardstartin What you describe looks like it might reduce the code complexity

[GitHub] [incubator-druid] yurmix commented on issue #6518: [Proposal] Shutdown druid processes upon complete loss of ZK connectivity

2019-04-04 Thread GitBox
yurmix commented on issue #6518: [Proposal] Shutdown druid processes upon complete loss of ZK connectivity URL: https://github.com/apache/incubator-druid/issues/6518#issuecomment-480079186 Fixed by #6740 (by @michael-trelinski), should be closed.

[GitHub] [incubator-druid] richardstartin commented on issue #7408: upgrade to RoaringBitmap 0.8.0 and serialise directly to ByteBuffer

2019-04-04 Thread GitBox
richardstartin commented on issue #7408: upgrade to RoaringBitmap 0.8.0 and serialise directly to ByteBuffer URL: https://github.com/apache/incubator-druid/pull/7408#issuecomment-480072686 The underlying array is always going to get allocated, unless it's smaller than 64 elements in which

[GitHub] [incubator-druid] justinborromeo commented on issue #7413: Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec

2019-04-04 Thread GitBox
justinborromeo commented on issue #7413: Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec URL: https://github.com/apache/incubator-druid/pull/7413#issuecomment-480064996 @jon-wei moved params to query context

[GitHub] [incubator-druid] lemire commented on issue #7408: upgrade to RoaringBitmap 0.8.0 and serialise directly to ByteBuffer

2019-04-04 Thread GitBox
lemire commented on issue #7408: upgrade to RoaringBitmap 0.8.0 and serialise directly to ByteBuffer URL: https://github.com/apache/incubator-druid/pull/7408#issuecomment-480061875 > Would it be worth keeping a stupid pool of buffers for the bitmaps to serialize into? My

[GitHub] [incubator-druid] vogievetsky opened a new pull request #7414: Adding ability to pass configs in and fixing misc bugs

2019-04-04 Thread GitBox
vogievetsky opened a new pull request #7414: Adding ability to pass configs in and fixing misc bugs URL: https://github.com/apache/incubator-druid/pull/7414 Adding a rudimentary mechanism for Druid to pass configs to the console (by overriding the `web-console/console-config.js` file) for

[GitHub] [incubator-druid] jon-wei commented on issue #7413: Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec

2019-04-04 Thread GitBox
jon-wei commented on issue #7413: Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec URL: https://github.com/apache/incubator-druid/pull/7413#issuecomment-480041412 I think it's more common in Druid to put these types of properties in the

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7406: Console SQL function doc generation

2019-04-04 Thread GitBox
vogievetsky commented on a change in pull request #7406: Console SQL function doc generation URL: https://github.com/apache/incubator-druid/pull/7406#discussion_r272013135 ## File path: web-console/script/create-sql-function-doc.js ## @@ -0,0 +1,104 @@ +#!/usr/bin/env

[GitHub] [incubator-druid] vogievetsky commented on issue #7402: SQL explain in web console

2019-04-04 Thread GitBox
vogievetsky commented on issue #7402: SQL explain in web console URL: https://github.com/apache/incubator-druid/pull/7402#issuecomment-480040522 @shuqi7 in the future please do not force push your branch after making the PR, it makes it harder to see what changes have been made when.

[GitHub] [incubator-druid] justinborromeo opened a new pull request #7413: Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec

2019-04-04 Thread GitBox
justinborromeo opened a new pull request #7413: Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec URL: https://github.com/apache/incubator-druid/pull/7413 Fixes #7397. Details are in the proposal.

[GitHub] [incubator-druid] gianm commented on issue #7337: DataSketches HLL is not a replacement for Cardinality aggregator

2019-04-04 Thread GitBox
gianm commented on issue #7337: DataSketches HLL is not a replacement for Cardinality aggregator URL: https://github.com/apache/incubator-druid/issues/7337#issuecomment-480022692 @jon-wei added some of this stuff to the docs in #7407. Btw, if you are doing a cardinality count

[GitHub] [incubator-druid] gianm commented on issue #7320: use latest sketches-core-0.13.1

2019-04-04 Thread GitBox
gianm commented on issue #7320: use latest sketches-core-0.13.1 URL: https://github.com/apache/incubator-druid/pull/7320#issuecomment-480019586 By the way I don't want to minimize the level of excitement I have for datasketches in general and the contributions of your team to Druid. The

[GitHub] [incubator-druid] gianm edited a comment on issue #7320: use latest sketches-core-0.13.1

2019-04-04 Thread GitBox
gianm edited a comment on issue #7320: use latest sketches-core-0.13.1 URL: https://github.com/apache/incubator-druid/pull/7320#issuecomment-479955647 My inclination would be no, since 0.14.0 is in the final stages of approval right now with the IPMC and I don't think it's worth further

[GitHub] [incubator-druid] gianm commented on issue #7375: [Proposal] Auto Refresh SSL Certs

2019-04-04 Thread GitBox
gianm commented on issue #7375: [Proposal] Auto Refresh SSL Certs URL: https://github.com/apache/incubator-druid/issues/7375#issuecomment-480013774 What is the purpose of `druid.server.https.cert.autoRefreshPeriod`, if the idea is that a CertificateWatcher would watch for changes and

[GitHub] [incubator-druid] gianm commented on a change in pull request #7328: EmitterModule: Throw an error on invalid emitter types.

2019-04-04 Thread GitBox
gianm commented on a change in pull request #7328: EmitterModule: Throw an error on invalid emitter types. URL: https://github.com/apache/incubator-druid/pull/7328#discussion_r272303150 ## File path: server/src/main/java/org/apache/druid/server/emitter/EmitterModule.java

[GitHub] [incubator-druid] drcrallen commented on issue #7408: upgrade to RoaringBitmap 0.8.0 and serialise directly to ByteBuffer

2019-04-04 Thread GitBox
drcrallen commented on issue #7408: upgrade to RoaringBitmap 0.8.0 and serialise directly to ByteBuffer URL: https://github.com/apache/incubator-druid/pull/7408#issuecomment-479996707 Would it be worth keeping a stupid pool of buffers for the bitmaps to serialize into? I guess we probably

[GitHub] [incubator-druid] fjy commented on a change in pull request #7328: EmitterModule: Throw an error on invalid emitter types.

2019-04-04 Thread GitBox
fjy commented on a change in pull request #7328: EmitterModule: Throw an error on invalid emitter types. URL: https://github.com/apache/incubator-druid/pull/7328#discussion_r272285361 ## File path: server/src/main/java/org/apache/druid/server/emitter/EmitterModule.java ##

[GitHub] [incubator-druid] fjy merged pull request #7412: Fix two issues with Coordinator -> Overlord communication.

2019-04-04 Thread GitBox
fjy merged pull request #7412: Fix two issues with Coordinator -> Overlord communication. URL: https://github.com/apache/incubator-druid/pull/7412 This is an automated message from the Apache Git Service. To respond to the

[incubator-druid] branch master updated: Fix two issues with Coordinator -> Overlord communication. (#7412)

2019-04-04 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 78745fe Fix two issues with Coordinator

[incubator-druid] branch master updated: upgrade to RoaringBitmap 0.8.0 and serialise directly to ByteBuffer (#7408)

2019-04-04 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new d29a320 upgrade to RoaringBitmap 0.8.0

[GitHub] [incubator-druid] gianm merged pull request #7408: upgrade to RoaringBitmap 0.8.0 and serialise directly to ByteBuffer

2019-04-04 Thread GitBox
gianm merged pull request #7408: upgrade to RoaringBitmap 0.8.0 and serialise directly to ByteBuffer URL: https://github.com/apache/incubator-druid/pull/7408 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] fjy commented on issue #7320: use latest sketches-core-0.13.1

2019-04-04 Thread GitBox
fjy commented on issue #7320: use latest sketches-core-0.13.1 URL: https://github.com/apache/incubator-druid/pull/7320#issuecomment-479957180 Agree with @gianm This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] gianm commented on issue #7320: use latest sketches-core-0.13.1

2019-04-04 Thread GitBox
gianm commented on issue #7320: use latest sketches-core-0.13.1 URL: https://github.com/apache/incubator-druid/pull/7320#issuecomment-479955647 My inclination would be no, since 0.14.0 is in the final stages of approval right now with the IPMC and I don't think it's worth further delay of

[GitHub] [incubator-druid] xueyumusic commented on a change in pull request #7388: Support LPAD and RPAD sql function

2019-04-04 Thread GitBox
xueyumusic commented on a change in pull request #7388: Support LPAD and RPAD sql function URL: https://github.com/apache/incubator-druid/pull/7388#discussion_r272229969 ## File path: core/src/main/java/org/apache/druid/java/util/common/StringUtils.java ## @@ -360,4

[GitHub] [incubator-druid] xueyumusic commented on a change in pull request #7388: Support LPAD and RPAD sql function

2019-04-04 Thread GitBox
xueyumusic commented on a change in pull request #7388: Support LPAD and RPAD sql function URL: https://github.com/apache/incubator-druid/pull/7388#discussion_r272229916 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -1206,4 +1206,61 @@

[GitHub] [incubator-druid] b-slim commented on issue #7404: "useDefaultValueForNull" needs documentation

2019-04-04 Thread GitBox
b-slim commented on issue #7404: "useDefaultValueForNull" needs documentation URL: https://github.com/apache/incubator-druid/issues/7404#issuecomment-479933274 @gianm which functionality you are asking about ? Considering null as null yes that is what it is set to by default.

[GitHub] [incubator-druid] gianm opened a new pull request #7412: Fix two issues with Coordinator -> Overlord communication.

2019-04-04 Thread GitBox
gianm opened a new pull request #7412: Fix two issues with Coordinator -> Overlord communication. URL: https://github.com/apache/incubator-druid/pull/7412 1) ClientCompactQuery needs to recognize the potential for 'intervals' to be set instead of 'segments'. The lack of this led to a

[GitHub] [incubator-druid] mihai-cazacu-adswizz opened a new issue #7411: [materialized view] Too many Hadoop jobs doing the same thing

2019-04-04 Thread GitBox
mihai-cazacu-adswizz opened a new issue #7411: [materialized view] Too many Hadoop jobs doing the same thing URL: https://github.com/apache/incubator-druid/issues/7411 ### Affected Version `0.13.0-incubating` ### Description I have created this MV specification:

[GitHub] [incubator-druid] QiuMM commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions

2019-04-04 Thread GitBox
QiuMM commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions URL: https://github.com/apache/incubator-druid/pull/7334#discussion_r272111408 ## File path: core/src/main/java/org/apache/druid/java/util/common/StringUtils.java ##