[GitHub] [incubator-druid] peferron commented on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
peferron commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-481112318 > The more generic we try to make this, the more challenging it will be to configure and the performance will be impacted. Understood. Extra

[GitHub] [incubator-druid] asdf2014 commented on issue #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions

2019-04-08 Thread GitBox
asdf2014 commented on issue #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions URL: https://github.com/apache/incubator-druid/pull/7334#issuecomment-481103056 @QiuMM Thanks for your comments :+1: They have all been fixed.

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions

2019-04-08 Thread GitBox
asdf2014 commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions URL: https://github.com/apache/incubator-druid/pull/7334#discussion_r273325395 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions

2019-04-08 Thread GitBox
asdf2014 commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions URL: https://github.com/apache/incubator-druid/pull/7334#discussion_r273325416 ## File path: core/src/test/java/org/apache/druid/java/util/common/StringUtilsTest.java

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions

2019-04-08 Thread GitBox
asdf2014 commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions URL: https://github.com/apache/incubator-druid/pull/7334#discussion_r273325355 ## File path: core/src/main/java/org/apache/druid/java/util/common/StringUtils.java

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions

2019-04-08 Thread GitBox
asdf2014 commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions URL: https://github.com/apache/incubator-druid/pull/7334#discussion_r273325369 ## File path: core/src/main/java/org/apache/druid/java/util/common/StringUtils.java

[GitHub] [incubator-druid] eagoo opened a new issue #7431: Is there a way ingest a datasource base on a query result

2019-04-08 Thread GitBox
eagoo opened a new issue #7431: Is there a way ingest a datasource base on a query result URL: https://github.com/apache/incubator-druid/issues/7431 just like sql: create table t_table_2 as select * from t_table_1 This is

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions

2019-04-08 Thread GitBox
jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions URL: https://github.com/apache/incubator-druid/pull/7212#discussion_r273318567 ## File path:

[GitHub] [incubator-druid] jon-wei opened a new pull request #7430: Fix comments in KinesisIndexTaskIOConfig

2019-04-08 Thread GitBox
jon-wei opened a new pull request #7430: Fix comments in KinesisIndexTaskIOConfig URL: https://github.com/apache/incubator-druid/pull/7430 This PR addresses minor comments made in #7351. The author of that PR is on vacation for a while.

[GitHub] [incubator-druid] wc188996 commented on issue #7426: druid-cassandra-storage doesn't include high-scale-lib dependency

2019-04-08 Thread GitBox
wc188996 commented on issue #7426: druid-cassandra-storage doesn't include high-scale-lib dependency URL: https://github.com/apache/incubator-druid/issues/7426#issuecomment-481089808 I found `com.github.stephenc.high-scale-lib` in `extensions-contrib/cassandra-storage/pom.xml:117`,

[GitHub] [incubator-druid] wc188996 commented on issue #7387: druid extensions-contrib deep storage cassandra loading error

2019-04-08 Thread GitBox
wc188996 commented on issue #7387: druid extensions-contrib deep storage cassandra loading error URL: https://github.com/apache/incubator-druid/issues/7387#issuecomment-481076249 This is a version matching issue. The "druid-cassandra-storage:0.12.x" does not match the version of the

[incubator-druid] branch master updated: Support kinesis compatibility (#7351)

2019-04-08 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new e87d6e3 Support kinesis compatibility

[GitHub] [incubator-druid] jon-wei merged pull request #7351: Support kinesis compatibility

2019-04-08 Thread GitBox
jon-wei merged pull request #7351: Support kinesis compatibility URL: https://github.com/apache/incubator-druid/pull/7351 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-druid] jon-wei commented on issue #7351: Support kinesis compatibility

2019-04-08 Thread GitBox
jon-wei commented on issue #7351: Support kinesis compatibility URL: https://github.com/apache/incubator-druid/pull/7351#issuecomment-481075451 Jihoon is currently on vacation, I'll merge this and do a follow-on PR that addresses my comments.

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7138: 'core' ORC extension

2019-04-08 Thread GitBox
clintropolis commented on a change in pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r273300645 ## File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcStructConverter.java

[GitHub] [incubator-druid] gianm commented on a change in pull request #7138: 'core' ORC extension

2019-04-08 Thread GitBox
gianm commented on a change in pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r273300223 ## File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcStructConverter.java ## @@

[GitHub] [incubator-druid] jon-wei commented on issue #7233: Add "is_overshadowed" column to sys.segments table

2019-04-08 Thread GitBox
jon-wei commented on issue #7233: Add "is_overshadowed" column to sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-481068250 The current proposal (add `is_overshadowed` representing published segments that are overshadowed by other published

[GitHub] [incubator-druid] hnakamor commented on issue #7108: Data ingestion fails on Quantiles DoublesSketch containing NULL When usingDefaultValueForNull = false

2019-04-08 Thread GitBox
hnakamor commented on issue #7108: Data ingestion fails on Quantiles DoublesSketch containing NULL When usingDefaultValueForNull = false URL: https://github.com/apache/incubator-druid/issues/7108#issuecomment-481063682 @gianm Thank you for fixing this bug! I'm happy to contribute a

[GitHub] [incubator-druid] clintropolis commented on issue #6928: Add Config Resource filter to lookup introspection endpoint

2019-04-08 Thread GitBox
clintropolis commented on issue #6928: Add Config Resource filter to lookup introspection endpoint URL: https://github.com/apache/incubator-druid/pull/6928#issuecomment-481063334 Oops, I didn't realize this PR existed and also fixed this issue in #7222 which has been merged, so this PR

[GitHub] [incubator-druid] gianm commented on issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core'

2019-04-08 Thread GitBox
gianm commented on issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core' URL: https://github.com/apache/incubator-druid/issues/7134#issuecomment-481062975 > To clarify, my current PR eliminates typeString, so 'optional' isn't really correct since it would always

[GitHub] [incubator-druid] clintropolis commented on issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core'

2019-04-08 Thread GitBox
clintropolis commented on issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core' URL: https://github.com/apache/incubator-druid/issues/7134#issuecomment-481061957 >I agree here - in my experience writing the typeString is tough for people, and making it optional

[incubator-druid] branch master updated: DoublesSketchComplexMetricSerde: Handle empty strings. (#7429)

2019-04-08 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 7cd5477 DoublesSketchComplexMetricSerde:

[GitHub] [incubator-druid] fjy closed issue #7108: Data ingestion fails on Quantiles DoublesSketch containing NULL When usingDefaultValueForNull = false

2019-04-08 Thread GitBox
fjy closed issue #7108: Data ingestion fails on Quantiles DoublesSketch containing NULL When usingDefaultValueForNull = false URL: https://github.com/apache/incubator-druid/issues/7108 This is an automated message from the

[GitHub] [incubator-druid] fjy merged pull request #7429: DoublesSketchComplexMetricSerde: Handle empty strings.

2019-04-08 Thread GitBox
fjy merged pull request #7429: DoublesSketchComplexMetricSerde: Handle empty strings. URL: https://github.com/apache/incubator-druid/pull/7429 This is an automated message from the Apache Git Service. To respond to the

[incubator-druid] branch master updated: Console SQL function doc generation (#7406)

2019-04-08 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 98ee863 Console SQL function doc

[GitHub] [incubator-druid] clintropolis merged pull request #7406: Console SQL function doc generation

2019-04-08 Thread GitBox
clintropolis merged pull request #7406: Console SQL function doc generation URL: https://github.com/apache/incubator-druid/pull/7406 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-druid] gianm commented on a change in pull request #7138: 'core' ORC extension

2019-04-08 Thread GitBox
gianm commented on a change in pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r273287410 ## File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcStructConverter.java ## @@

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7138: 'core' ORC extension

2019-04-08 Thread GitBox
clintropolis commented on a change in pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r273285621 ## File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcStructConverter.java

[GitHub] [incubator-druid] gianm opened a new pull request #7429: DoublesSketchComplexMetricSerde: Handle empty strings.

2019-04-08 Thread GitBox
gianm opened a new pull request #7429: DoublesSketchComplexMetricSerde: Handle empty strings. URL: https://github.com/apache/incubator-druid/pull/7429 Fixes #7108. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] gianm commented on issue #7108: Data ingestion fails on Quantiles DoublesSketch containing NULL When usingDefaultValueForNull = false

2019-04-08 Thread GitBox
gianm commented on issue #7108: Data ingestion fails on Quantiles DoublesSketch containing NULL When usingDefaultValueForNull = false URL: https://github.com/apache/incubator-druid/issues/7108#issuecomment-481050858 Should be fixed by #7429. Thanks for the report!

[GitHub] [incubator-druid] gianm commented on issue #7404: "useDefaultValueForNull" needs documentation

2019-04-08 Thread GitBox
gianm commented on issue #7404: "useDefaultValueForNull" needs documentation URL: https://github.com/apache/incubator-druid/issues/7404#issuecomment-481050440 Cool, @b-slim, that is good to hear, it sounds like it's fairly battle tested in that case.

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7351: Support kinesis compatibility

2019-04-08 Thread GitBox
jon-wei commented on a change in pull request #7351: Support kinesis compatibility URL: https://github.com/apache/incubator-druid/pull/7351#discussion_r273279225 ## File path:

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view

2019-04-08 Thread GitBox
vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view URL: https://github.com/apache/incubator-druid/pull/7421#discussion_r273277892 ## File path: web-console/src/components/sql-control.tsx ## @@ -218,6 +219,10 @@ export class

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view

2019-04-08 Thread GitBox
vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view URL: https://github.com/apache/incubator-druid/pull/7421#discussion_r273277537 ## File path: web-console/src/views/sql-view.tsx ## @@ -46,11 +47,12 @@ export interface

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view

2019-04-08 Thread GitBox
vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view URL: https://github.com/apache/incubator-druid/pull/7421#discussion_r273277382 ## File path: web-console/src/views/sql-view.tsx ## @@ -62,34 +64,44 @@ export class SqlView

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view

2019-04-08 Thread GitBox
vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view URL: https://github.com/apache/incubator-druid/pull/7421#discussion_r273277275 ## File path: web-console/src/views/sql-view.tsx ## @@ -62,34 +64,44 @@ export class SqlView

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7351: Support kinesis compatibility

2019-04-08 Thread GitBox
jon-wei commented on a change in pull request #7351: Support kinesis compatibility URL: https://github.com/apache/incubator-druid/pull/7351#discussion_r273276480 ## File path:

[GitHub] [incubator-druid] justinborromeo commented on issue #7399: druid-google-extension dependencies problem

2019-04-08 Thread GitBox
justinborromeo commented on issue #7399: druid-google-extension dependencies problem URL: https://github.com/apache/incubator-druid/issues/7399#issuecomment-481042377 What's the issue here? This is an automated message from

[GitHub] [incubator-druid] justinborromeo edited a comment on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks

2019-04-08 Thread GitBox
justinborromeo edited a comment on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks URL: https://github.com/apache/incubator-druid/issues/7238#issuecomment-481041614 @jihoonson I think `maxRowsPerSegment`, `maxTotalRows`, and `maxTotalSegments` are all

[GitHub] [incubator-druid] justinborromeo commented on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks

2019-04-08 Thread GitBox
justinborromeo commented on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks URL: https://github.com/apache/incubator-druid/issues/7238#issuecomment-481041614 I think `maxRowsPerSegment`, `maxTotalRows`, and `maxTotalSegments` are all necessary since they

[GitHub] [incubator-druid] vogievetsky commented on issue #7425: Add is_overshadowed column to sys.segments table

2019-04-08 Thread GitBox
vogievetsky commented on issue #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425#issuecomment-481040558 Does it make sense to add this to the web console within this PR?

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view

2019-04-08 Thread GitBox
vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view URL: https://github.com/apache/incubator-druid/pull/7421#discussion_r273270784 ## File path: web-console/src/views/sql-view.tsx ## @@ -62,25 +64,33 @@ export class SqlView

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view

2019-04-08 Thread GitBox
vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view URL: https://github.com/apache/incubator-druid/pull/7421#discussion_r273270220 ## File path: web-console/src/views/sql-view.tsx ## @@ -62,25 +64,33 @@ export class SqlView

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view

2019-04-08 Thread GitBox
vogievetsky commented on a change in pull request #7421: Add time taken by last query in SQL view URL: https://github.com/apache/incubator-druid/pull/7421#discussion_r273270504 ## File path: web-console/src/components/sql-control.tsx ## @@ -218,6 +219,9 @@ export class

[GitHub] [incubator-druid] justinborromeo opened a new pull request #7428: Add errors and state to stream supervisor status API endpoint

2019-04-08 Thread GitBox
justinborromeo opened a new pull request #7428: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7428 Closes #7217 Based on the proposal and discussion in #7217. The PR adds the following config values (which

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7138: 'core' ORC extension

2019-04-08 Thread GitBox
clintropolis commented on a change in pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r273265433 ## File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcHadoopInputRowParser.java

[GitHub] [incubator-druid] gianm commented on a change in pull request #7138: 'core' ORC extension

2019-04-08 Thread GitBox
gianm commented on a change in pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r273263852 ## File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcStructConverter.java ## @@

[GitHub] [incubator-druid] gianm commented on a change in pull request #7138: 'core' ORC extension

2019-04-08 Thread GitBox
gianm commented on a change in pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r273262704 ## File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcHadoopInputRowParser.java ##

[GitHub] [incubator-druid] gianm commented on a change in pull request #7138: 'core' ORC extension

2019-04-08 Thread GitBox
gianm commented on a change in pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r273262649 ## File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcHadoopInputRowParser.java ##

[GitHub] [incubator-druid] gianm commented on issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core'

2019-04-08 Thread GitBox
gianm commented on issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core' URL: https://github.com/apache/incubator-druid/issues/7134#issuecomment-481021853 For the reasons mentioned in my last comment I am  on the proposal. Will do another pass through the code

[GitHub] [incubator-druid] gianm commented on issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core'

2019-04-08 Thread GitBox
gianm commented on issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core' URL: https://github.com/apache/incubator-druid/issues/7134#issuecomment-481021756 @clintropolis, > The primary incompatibility is that the typeString of the current extension allows

[GitHub] [incubator-druid] justinborromeo commented on issue #7427: Add errors and state to stream supervisor status API endpoint

2019-04-08 Thread GitBox
justinborromeo commented on issue #7427: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7427#issuecomment-481020711 Merging master added some weird commits in the middle. Closing and will reopen with a cleaner commit

[GitHub] [incubator-druid] justinborromeo closed pull request #7427: Add errors and state to stream supervisor status API endpoint

2019-04-08 Thread GitBox
justinborromeo closed pull request #7427: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7427 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] justinborromeo opened a new pull request #7427: Add errors and state to stream supervisor status API endpoint

2019-04-08 Thread GitBox
justinborromeo opened a new pull request #7427: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7427 Closes #7217 Based on the proposal and discussion in #7217.

[GitHub] [incubator-druid] surekhasaharan edited a comment on issue #7233: Add "is_overshadowed" column to sys.segments table

2019-04-08 Thread GitBox
surekhasaharan edited a comment on issue #7233: Add "is_overshadowed" column to sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-481011070 thanks @gianm for articulating the definition of `is_overshadowed` . Added the definition of

[GitHub] [incubator-druid] surekhasaharan commented on issue #7233: Add "is_overshadowed" column to sys.segments table

2019-04-08 Thread GitBox
surekhasaharan commented on issue #7233: Add "is_overshadowed" column to sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-481011070 thanks @gianm for articulating the definition of `is_overshadowed` . Added the definition of `is_published` in the

[GitHub] [incubator-druid] egor-ryashin opened a new issue #7426: druid-cassandra-storage doesn't include high-scale-lib dependency

2019-04-08 Thread GitBox
egor-ryashin opened a new issue #7426: druid-cassandra-storage doesn't include high-scale-lib dependency URL: https://github.com/apache/incubator-druid/issues/7426 I've been investigating the issue (https://github.com/apache/incubator-druid/issues/7387) and got this error while the

[GitHub] [incubator-druid] gianm commented on issue #7233: Add "is_overshadowed" column to sys.segments table

2019-04-08 Thread GitBox
gianm commented on issue #7233: Add "is_overshadowed" column to sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-481001908 @surekhasaharan Can you please add the definition of `is_overshadowed` to the proposal? (To the "Proposed changes"

svn commit: r33519 - /release/incubator/druid/0.14.0-incubating/

2019-04-08 Thread jonwei
Author: jonwei Date: Mon Apr 8 20:45:30 2019 New Revision: 33519 Log: Publishing Apache Druid (incubating) 0.14.0 Added: release/incubator/druid/0.14.0-incubating/ release/incubator/druid/0.14.0-incubating/apache-druid-0.14.0-incubating-bin.tar.gz (with props)

[incubator-druid] annotated tag druid-0.14.0-incubating updated (f169ada -> f40a92c)

2019-04-08 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to annotated tag druid-0.14.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. *** WARNING: tag druid-0.14.0-incubating was modified! *** from f169ada (commit)

[GitHub] [incubator-druid] clintropolis commented on issue #5882: Coordinator load queue imbalance

2019-04-08 Thread GitBox
clintropolis commented on issue #5882: Coordinator load queue imbalance URL: https://github.com/apache/incubator-druid/issues/5882#issuecomment-480997190 I haven't done anything to fix the root issue directly, which is that the coordinator can make bad decisions and doesn't undo them when

[GitHub] [incubator-druid] surekhasaharan opened a new pull request #7425: Add is_overshadowed column to sys.segments table

2019-04-08 Thread GitBox
surekhasaharan opened a new pull request #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425 Addresses #7233 This PR adds a col `is_overshadowed` to `sys-segments` table Add a new class `SegmentWithOvershadowInfo` to

[GitHub] [incubator-druid] yurmix commented on issue #4032: [Proposal] Simple join support

2019-04-08 Thread GitBox
yurmix commented on issue #4032: [Proposal] Simple join support URL: https://github.com/apache/incubator-druid/issues/4032#issuecomment-480955567 @jihoonson This sounds like a very useful feature. I think this can be relevant to one of my lookup use-cases (multi-value lookups). In

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480939628 @peferron > top songs by unique viewers Yes. > additional aggregations could be computed at the same time Yes, with a

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480939628 @peferron > top songs by unique viewers Yes. > additional aggregations could be computed at the same time Yes, with a

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480939628 @peferron > top songs by unique viewers Yes. > additional aggregations could be computed at the same time Yes, with a

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480939628 @peferron > top songs by unique viewers Yes. > additional aggregations could be computed at the same time Yes, with a

[GitHub] [incubator-druid] leerho commented on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
leerho commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480939628 @peferron > top songs by unique viewers Yes. > additional aggregations could be computed at the same time Yes, with a caveat. For

[GitHub] [incubator-druid] capistrant commented on a change in pull request #7145: Enhance the Http Firehose to work with URIs requiring basic authentication

2019-04-08 Thread GitBox
capistrant commented on a change in pull request #7145: Enhance the Http Firehose to work with URIs requiring basic authentication URL: https://github.com/apache/incubator-druid/pull/7145#discussion_r273101292 ## File path: docs/content/ingestion/firehose.md ## @@ -74,6

[GitHub] [incubator-druid] capistrant commented on a change in pull request #7145: Enhance the Http Firehose to work with URIs requiring basic authentication

2019-04-08 Thread GitBox
capistrant commented on a change in pull request #7145: Enhance the Http Firehose to work with URIs requiring basic authentication URL: https://github.com/apache/incubator-druid/pull/7145#discussion_r273100319 ## File path:

[GitHub] [incubator-druid] peferron edited a comment on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
peferron edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480718601 From your description, it sounds like it could handle the "top songs by unique viewers" query we discussed earlier, by processing pairs of

[GitHub] [incubator-druid] peferron edited a comment on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
peferron edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480718601 From your description, it sounds like it could handle the "top songs by unique viewers" query we discussed earlier, by processing pairs of

[GitHub] [incubator-druid] QiuMM commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions

2019-04-08 Thread GitBox
QiuMM commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions URL: https://github.com/apache/incubator-druid/pull/7334#discussion_r273005036 ## File path: core/src/test/java/org/apache/druid/java/util/common/StringUtilsTest.java

[GitHub] [incubator-druid] QiuMM commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions

2019-04-08 Thread GitBox
QiuMM commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions URL: https://github.com/apache/incubator-druid/pull/7334#discussion_r273002248 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -326,7

[GitHub] [incubator-druid] QiuMM commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions

2019-04-08 Thread GitBox
QiuMM commented on a change in pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions URL: https://github.com/apache/incubator-druid/pull/7334#discussion_r272111408 ## File path: core/src/main/java/org/apache/druid/java/util/common/StringUtils.java ##

[GitHub] [incubator-druid] stale[bot] commented on issue #6768: extension for exactly distinct count for single long type dimension:accurate-cardinality

2019-04-08 Thread GitBox
stale[bot] commented on issue #6768: extension for exactly distinct count for single long type dimension:accurate-cardinality URL: https://github.com/apache/incubator-druid/pull/6768#issuecomment-480762276 This pull request has been marked as stale due to 60 days of inactivity. It will be

[GitHub] [incubator-druid] peferron edited a comment on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
peferron edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480718601 From your description, it sounds like it could handle the "top songs by unique viewers" query we discussed earlier, by processing pairs of

[GitHub] [incubator-druid] peferron commented on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
peferron commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480718601 From your description, it sounds like it could handle the "top songs by unique viewers" query we discussed earlier, by processing pairs of {SongID,

[GitHub] [incubator-druid] nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-04-08 Thread GitBox
nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r272909077 ## File path: docs/content/development/extensions-core/druid-basic-security.md ## @@ -155,6

[GitHub] [incubator-druid] nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-04-08 Thread GitBox
nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r272908742 ## File path: docs/content/development/extensions-core/druid-basic-security.md ## @@ -155,6

[GitHub] [incubator-druid] leventov commented on issue #5882: Coordinator load queue imbalance

2019-04-08 Thread GitBox
leventov commented on issue #5882: Coordinator load queue imbalance URL: https://github.com/apache/incubator-druid/issues/5882#issuecomment-480705740 @clintropolis should this issue be closed? This is an automated message

[GitHub] [incubator-druid] wc188996 edited a comment on issue #7387: druid extensions-contrib deep storage cassandra loading error

2019-04-08 Thread GitBox
wc188996 edited a comment on issue #7387: druid extensions-contrib deep storage cassandra loading error URL: https://github.com/apache/incubator-druid/issues/7387#issuecomment-480700559 > you can try to set this config in "common.runtime.properties file": > druid.extensions.pullList =

[GitHub] [incubator-druid] wc188996 edited a comment on issue #7387: druid extensions-contrib deep storage cassandra loading error

2019-04-08 Thread GitBox
wc188996 edited a comment on issue #7387: druid extensions-contrib deep storage cassandra loading error URL: https://github.com/apache/incubator-druid/issues/7387#issuecomment-480700559 > you can try to set this config in "common.runtime.properties file": > druid.extensions.pullList =

[GitHub] [incubator-druid] wc188996 commented on issue #7387: druid extensions-contrib deep storage cassandra loading error

2019-04-08 Thread GitBox
wc188996 commented on issue #7387: druid extensions-contrib deep storage cassandra loading error URL: https://github.com/apache/incubator-druid/issues/7387#issuecomment-480700559 > you can try to set this config in "common.runtime.properties file": > druid.extensions.pullList =