[GitHub] [incubator-druid] shuqi7 commented on issue #7435: Table pagination style change

2019-04-09 Thread GitBox
shuqi7 commented on issue #7435: Table pagination style change URL: https://github.com/apache/incubator-druid/pull/7435#issuecomment-481522884 > Please do not use that version I was using the APIs which are only available after 6.9.0, which allows custom rendering of the pagination

[GitHub] [incubator-druid] QiuMM merged pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions

2019-04-09 Thread GitBox
QiuMM merged pull request #7334: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions URL: https://github.com/apache/incubator-druid/pull/7334 This is an automated message from the Apache Git Service. To respond to the

[incubator-druid] branch master updated: Add "REVERSE" / "REPEAT" / "RIGHT" / "LEFT" functions (#7334)

2019-04-09 Thread qmm
This is an automated email from the ASF dual-hosted git repository. qmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 2f64414 Add "REVERSE" / "REPEAT" /

[GitHub] [incubator-druid] surekhasaharan commented on issue #7425: Add is_overshadowed column to sys.segments table

2019-04-09 Thread GitBox
surekhasaharan commented on issue #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425#issuecomment-481486344 > Does it make sense to add this to the web console within this PR? I think it'd be better to do as a separate

[GitHub] [incubator-druid] surekhasaharan commented on issue #7233: Add "is_overshadowed" column to sys.segments table

2019-04-09 Thread GitBox
surekhasaharan commented on issue #7233: Add "is_overshadowed" column to sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-481485819 @leventov I do not plan on renaming "used" to "published" with this issue, this is solely focused on adding the

[GitHub] [incubator-druid] shuqi7 opened a new pull request #7435: Table pagination style change

2019-04-09 Thread GitBox
shuqi7 opened a new pull request #7435: Table pagination style change URL: https://github.com/apache/incubator-druid/pull/7435 - Style console tables to follow Blueprint's skin ![image](https://user-images.githubusercontent.com/29443129/55841449-08e85d00-5ae4-11e9-9cc2-f0a330968a07.png)

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions

2019-04-09 Thread GitBox
jon-wei commented on a change in pull request #7212: Support Kafka supervisor adopting running tasks between versions URL: https://github.com/apache/incubator-druid/pull/7212#discussion_r273736390 ## File path:

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-04-09 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r273721733 ## File path:

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-04-09 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r273727431 ## File path:

[GitHub] [incubator-druid] justinborromeo opened a new pull request #7434: [WIP] Indexing Task Segment Limit

2019-04-09 Thread GitBox
justinborromeo opened a new pull request #7434: [WIP] Indexing Task Segment Limit URL: https://github.com/apache/incubator-druid/pull/7434 Closes #7238. Do not review, want to run Travis tests and manually test further.

[GitHub] [incubator-druid] jon-wei commented on issue #7126: 0.14.0-incubating release notes

2019-04-09 Thread GitBox
jon-wei commented on issue #7126: 0.14.0-incubating release notes URL: https://github.com/apache/incubator-druid/issues/7126#issuecomment-481452781 @sascha-coenen Thanks, it should be min() there. @trtg 0.14.0 is released now, the vote passed yesterday but we needed to wait ~24

[GitHub] [incubator-druid] justinborromeo commented on a change in pull request #7388: Support LPAD and RPAD sql function

2019-04-09 Thread GitBox
justinborromeo commented on a change in pull request #7388: Support LPAD and RPAD sql function URL: https://github.com/apache/incubator-druid/pull/7388#discussion_r273715180 ## File path: core/src/main/java/org/apache/druid/java/util/common/StringUtils.java ## @@ -360,4

[GitHub] [incubator-druid] justinborromeo commented on a change in pull request #7388: Support LPAD and RPAD sql function

2019-04-09 Thread GitBox
justinborromeo commented on a change in pull request #7388: Support LPAD and RPAD sql function URL: https://github.com/apache/incubator-druid/pull/7388#discussion_r273716078 ## File path: core/src/main/java/org/apache/druid/java/util/common/StringUtils.java ## @@ -360,4

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7388: Support LPAD and RPAD sql function

2019-04-09 Thread GitBox
clintropolis commented on a change in pull request #7388: Support LPAD and RPAD sql function URL: https://github.com/apache/incubator-druid/pull/7388#discussion_r273711557 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -1206,4 +1206,61 @@

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7388: Support LPAD and RPAD sql function

2019-04-09 Thread GitBox
clintropolis commented on a change in pull request #7388: Support LPAD and RPAD sql function URL: https://github.com/apache/incubator-druid/pull/7388#discussion_r273699805 ## File path: core/src/main/java/org/apache/druid/java/util/common/StringUtils.java ## @@ -360,4

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7388: Support LPAD and RPAD sql function

2019-04-09 Thread GitBox
clintropolis commented on a change in pull request #7388: Support LPAD and RPAD sql function URL: https://github.com/apache/incubator-druid/pull/7388#discussion_r273698758 ## File path: core/src/main/java/org/apache/druid/java/util/common/StringUtils.java ## @@ -360,4

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7388: Support LPAD and RPAD sql function

2019-04-09 Thread GitBox
clintropolis commented on a change in pull request #7388: Support LPAD and RPAD sql function URL: https://github.com/apache/incubator-druid/pull/7388#discussion_r273708154 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -1206,4 +1206,61 @@

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7388: Support LPAD and RPAD sql function

2019-04-09 Thread GitBox
clintropolis commented on a change in pull request #7388: Support LPAD and RPAD sql function URL: https://github.com/apache/incubator-druid/pull/7388#discussion_r273699190 ## File path: core/src/main/java/org/apache/druid/java/util/common/StringUtils.java ## @@ -360,4

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7388: Support LPAD and RPAD sql function

2019-04-09 Thread GitBox
clintropolis commented on a change in pull request #7388: Support LPAD and RPAD sql function URL: https://github.com/apache/incubator-druid/pull/7388#discussion_r273697853 ## File path: core/src/main/java/org/apache/druid/java/util/common/StringUtils.java ## @@ -360,4

[incubator-druid-website] branch asf-site updated: Add downloads for 0.14.0-incubating

2019-04-09 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-druid-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 8df8b9f Add downloads for

[GitHub] [incubator-druid] clintropolis commented on issue #7433: Explain a difference between interval and trueInterval in TimelineObjectHolder

2019-04-09 Thread GitBox
clintropolis commented on issue #7433: Explain a difference between interval and trueInterval in TimelineObjectHolder URL: https://github.com/apache/incubator-druid/issues/7433#issuecomment-481431004 The [javadocs of `LogicalSegment` have a

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-04-09 Thread GitBox
jon-wei commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r273690302 ## File path:

[GitHub] [incubator-druid] egor-ryashin commented on issue #7426: druid-cassandra-storage doesn't include high-scale-lib dependency

2019-04-09 Thread GitBox
egor-ryashin commented on issue #7426: druid-cassandra-storage doesn't include high-scale-lib dependency URL: https://github.com/apache/incubator-druid/issues/7426#issuecomment-481420961 @leventov as you've worked on #4313, probably, you understand better how to fix it. Right now I

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-04-09 Thread GitBox
jon-wei commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r273682761 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-04-09 Thread GitBox
jon-wei commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r273682761 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-04-09 Thread GitBox
jon-wei commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r273682761 ## File path:

[GitHub] [incubator-druid] leventov commented on issue #7233: Add "is_overshadowed" column to sys.segments table

2019-04-09 Thread GitBox
leventov commented on issue #7233: Add "is_overshadowed" column to sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-481373474 @surekhasaharan then the proposal looks good to me too. If you plan to rename "used segments" to "published

[GitHub] [incubator-druid] mohammadjkhan commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-04-09 Thread GitBox
mohammadjkhan commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r273636435 ## File path: docs/content/development/extensions-core/druid-basic-security.md ## @@ -155,6

[GitHub] [incubator-druid] mohammadjkhan commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-04-09 Thread GitBox
mohammadjkhan commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r273636435 ## File path: docs/content/development/extensions-core/druid-basic-security.md ## @@ -155,6

[GitHub] [incubator-druid] clintropolis commented on issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core'

2019-04-09 Thread GitBox
clintropolis commented on issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core' URL: https://github.com/apache/incubator-druid/issues/7134#issuecomment-481367682 Completed in #7138 This is an

[GitHub] [incubator-druid] clintropolis closed issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core'

2019-04-09 Thread GitBox
clintropolis closed issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core' URL: https://github.com/apache/incubator-druid/issues/7134 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] surekhasaharan commented on issue #7233: Add "is_overshadowed" column to sys.segments table

2019-04-09 Thread GitBox
surekhasaharan commented on issue #7233: Add "is_overshadowed" column to sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-481363935 @leventov `includeOvershadowedStatus` instead of `includeOvershadowInfo` seems fine to me for the query param in

[GitHub] [incubator-druid] leventov commented on issue #7279: Move dev-related files and instructions to dev/ directory; add committer's instructions

2019-04-09 Thread GitBox
leventov commented on issue #7279: Move dev-related files and instructions to dev/ directory; add committer's instructions URL: https://github.com/apache/incubator-druid/pull/7279#issuecomment-481355063 @gianm do you want to leave more comments?

[GitHub] [incubator-druid] leventov commented on issue #7233: Add "is_overshadowed" column to sys.segments table

2019-04-09 Thread GitBox
leventov commented on issue #7233: Add "is_overshadowed" column to sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-481353896 @surekhasaharan what do you think about "includeOvershadowedStatus", "SegmentWithOvershadowedStatus" instead of

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-04-09 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r273616011 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-04-09 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r273615203 ## File path:

[GitHub] [incubator-druid] leventov opened a new issue #7433: Explain a difference between interval and trueInterval in TimelineObjectHolder

2019-04-09 Thread GitBox
leventov opened a new issue #7433: Explain a difference between interval and trueInterval in TimelineObjectHolder URL: https://github.com/apache/incubator-druid/issues/7433 https://github.com/apache/incubator-druid/pull/7306#discussion_r272737017 here @egor-ryashin raised a valid concern.

[GitHub] [incubator-druid] Dylan1312 commented on issue #6814: [Discuss] Replacing hyperUnique as 'default' distinct count sketch

2019-04-09 Thread GitBox
Dylan1312 commented on issue #6814: [Discuss] Replacing hyperUnique as 'default' distinct count sketch URL: https://github.com/apache/incubator-druid/issues/6814#issuecomment-481326881 We've been evaluating the Datasketches implementation of HLL versus Druid's own implementation.

[GitHub] [incubator-druid] leventov commented on issue #7362: Principles for choosing logging severity

2019-04-09 Thread GitBox
leventov commented on issue #7362: Principles for choosing logging severity URL: https://github.com/apache/incubator-druid/issues/7362#issuecomment-481326108 My goal is to create criteria that can be more or less easily and unambiguously used during code reviews. Such as "Druid cluster

[incubator-druid] branch master updated: 'core' ORC extension (#7138)

2019-04-09 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 89bb43f 'core' ORC extension (#7138)

[GitHub] [incubator-druid] gianm merged pull request #7138: 'core' ORC extension

2019-04-09 Thread GitBox
gianm merged pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[incubator-druid] branch master updated: Fix comments in KinesisIndexTaskIOConfig (#7430)

2019-04-09 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 09abc4a Fix comments in

[GitHub] [incubator-druid] fjy merged pull request #7430: Fix comments in KinesisIndexTaskIOConfig

2019-04-09 Thread GitBox
fjy merged pull request #7430: Fix comments in KinesisIndexTaskIOConfig URL: https://github.com/apache/incubator-druid/pull/7430 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-druid] a2l007 closed pull request #6928: Add Config Resource filter to lookup introspection endpoint

2019-04-09 Thread GitBox
a2l007 closed pull request #6928: Add Config Resource filter to lookup introspection endpoint URL: https://github.com/apache/incubator-druid/pull/6928 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-druid] a2l007 commented on issue #6928: Add Config Resource filter to lookup introspection endpoint

2019-04-09 Thread GitBox
a2l007 commented on issue #6928: Add Config Resource filter to lookup introspection endpoint URL: https://github.com/apache/incubator-druid/pull/6928#issuecomment-481299784 No worries. I'm happy that the changes are in. Thanks!

[GitHub] [incubator-druid] nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-04-09 Thread GitBox
nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r273529452 ## File path:

[GitHub] [incubator-druid] hueiyuanSu opened a new issue #7432: druid in Ambari coordinator and overlord port not listen

2019-04-09 Thread GitBox
hueiyuanSu opened a new issue #7432: druid in Ambari coordinator and overlord port not listen URL: https://github.com/apache/incubator-druid/issues/7432 Hello! Everyone. I install druid with Ambari. Then,My metadata storage is mysql. When I installed druid , everything seems like ok!

[GitHub] [incubator-druid] Freya0214 closed issue #7387: druid extensions-contrib deep storage cassandra loading error

2019-04-09 Thread GitBox
Freya0214 closed issue #7387: druid extensions-contrib deep storage cassandra loading error URL: https://github.com/apache/incubator-druid/issues/7387 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-druid] Freya0214 commented on issue #7387: druid extensions-contrib deep storage cassandra loading error

2019-04-09 Thread GitBox
Freya0214 commented on issue #7387: druid extensions-contrib deep storage cassandra loading error URL: https://github.com/apache/incubator-druid/issues/7387#issuecomment-481200088 > This is a version matching issue. The "druid-cassandra-storage:0.12.x" does not match the version of the

[GitHub] [incubator-druid] wc188996 edited a comment on issue #7426: druid-cassandra-storage doesn't include high-scale-lib dependency

2019-04-09 Thread GitBox
wc188996 edited a comment on issue #7426: druid-cassandra-storage doesn't include high-scale-lib dependency URL: https://github.com/apache/incubator-druid/issues/7426#issuecomment-481089808 I found `com.github.stephenc.high-scale-lib` in

[GitHub] [incubator-druid] trtg edited a comment on issue #7126: 0.14.0-incubating release notes

2019-04-09 Thread GitBox
trtg edited a comment on issue #7126: 0.14.0-incubating release notes URL: https://github.com/apache/incubator-druid/issues/7126#issuecomment-481127928 What is the state of this release? I.e. when it will be downloadable? It's no longer marked as WIP and on the release page it's no longer

[GitHub] [incubator-druid] trtg commented on issue #7126: 0.14.0-incubating release notes

2019-04-09 Thread GitBox
trtg commented on issue #7126: 0.14.0-incubating release notes URL: https://github.com/apache/incubator-druid/issues/7126#issuecomment-481127928 What is the state of this release? I.e. when it will be downloadable? It's no longer marked as WIP and on the release page it's no longer tagged

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #6991: run pending tasks when assigned a task that is already pending

2019-04-09 Thread GitBox
asdf2014 commented on a change in pull request #6991: run pending tasks when assigned a task that is already pending URL: https://github.com/apache/incubator-druid/pull/6991#discussion_r273339908 ## File path: