[GitHub] [incubator-druid] jon-wei opened a new pull request #7673: Add option to use YARN RM as fallback for JobHistory failure

2019-05-15 Thread GitBox
jon-wei opened a new pull request #7673: Add option to use YARN RM as fallback for JobHistory failure URL: https://github.com/apache/incubator-druid/pull/7673 When a Hadoop job run by the HadoopIndexTask completes,`job.waitForCompletion()` expects the JobHistory server to be up and functi

[GitHub] [incubator-druid] vogievetsky commented on issue #7564: Add segment timeline chart in datasource view

2019-05-15 Thread GitBox
vogievetsky commented on issue #7564: Add segment timeline chart in datasource view URL: https://github.com/apache/incubator-druid/pull/7564#issuecomment-492922717 this looks good to me. I think as per @clintropolis there is room to improve the design but definitely good to go it. Can you

[GitHub] [incubator-druid] JackyYangPassion commented on issue #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster)

2019-05-15 Thread GitBox
JackyYangPassion commented on issue #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster) URL: https://github.com/apache/incubator-druid/pull/6988#issuecomment-492922329 @pzhdfy yes! I have manually this PR for 0.12.1 ; -

[GitHub] [incubator-druid] vogievetsky commented on issue #7657: Deleted created_time in "status"

2019-05-15 Thread GitBox
vogievetsky commented on issue #7657: Deleted created_time in "status" URL: https://github.com/apache/incubator-druid/pull/7657#issuecomment-492922064 This is not the correct approach to this issue it effectively undoes the tie-breaker reverting back to the state where the tasks are ordered

[GitHub] [incubator-druid] vogievetsky commented on issue #7669: add tests to dialogs, compnents and views. Add index files to compone…

2019-05-15 Thread GitBox
vogievetsky commented on issue #7669: add tests to dialogs, compnents and views. Add index files to compone… URL: https://github.com/apache/incubator-druid/pull/7669#issuecomment-492920053 Hello @mcbrewster, firstly let me welcome you to the Druid community! This humble 11k diff PR is a gr

[GitHub] [incubator-druid] vogievetsky opened a new pull request #7672: Data loader fixes

2019-05-15 Thread GitBox
vogievetsky opened a new pull request #7672: Data loader fixes URL: https://github.com/apache/incubator-druid/pull/7672 Making a bugfix PR for the data loader and sorting issue for the 0.15.0 release Due to changes that have already been merged into master and the changes that are comin

[GitHub] [incubator-druid] himanshug merged pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
himanshug merged pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633 This is an automated message from the Apache Git Service. To respond to the mes

[incubator-druid] branch master updated: make ComplexColumn an interface and ExtensionPoint (#7633)

2019-05-15 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 8687f42 make ComplexColumn an inter

[GitHub] [incubator-druid] gianm opened a new issue #7671: SQL: Exception with OR of impossible filters

2019-05-15 Thread GitBox
gianm opened a new issue #7671: SQL: Exception with OR of impossible filters URL: https://github.com/apache/incubator-druid/issues/7671 ### Description A query like this, which has and OR of two impossible time filters (a floor to day can never be any hour other than "00:00:00"):

[GitHub] [incubator-druid] fjy merged pull request #7670: Fix broken links in api-reference.md

2019-05-15 Thread GitBox
fjy merged pull request #7670: Fix broken links in api-reference.md URL: https://github.com/apache/incubator-druid/pull/7670 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[incubator-druid] branch master updated: Fix broken links in api-reference.md (#7670)

2019-05-15 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 3df364c Fix broken links in api-reference

[incubator-druid] branch clintropolis-patch-1 deleted (was f035672)

2019-05-15 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch clintropolis-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. was f035672 minor web console doc fixes The revisions that were on this branch are still contained

[GitHub] [incubator-druid] fjy merged pull request #7668: minor web console doc fixes

2019-05-15 Thread GitBox
fjy merged pull request #7668: minor web console doc fixes URL: https://github.com/apache/incubator-druid/pull/7668 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[incubator-druid] branch master updated: minor web console doc fixes (#7668)

2019-05-15 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new c2abbc2 minor web console doc fixes (#766

[GitHub] [incubator-druid] asdf2014 opened a new pull request #7670: Fix broken links in api-reference.md

2019-05-15 Thread GitBox
asdf2014 opened a new pull request #7670: Fix broken links in api-reference.md URL: https://github.com/apache/incubator-druid/pull/7670 Fix broken links in [http://druid.io/docs/latest/operations/api-reference.html](http://druid.io/docs/latest/operations/api-reference.html) ---

[GitHub] [incubator-druid] mcbrewster opened a new pull request #7669: add tests to dialogs, compnents and views. Add index files to compone…

2019-05-15 Thread GitBox
mcbrewster opened a new pull request #7669: add tests to dialogs, compnents and views. Add index files to compone… URL: https://github.com/apache/incubator-druid/pull/7669 …nts and dialogs. add nested file structure https://user-images.githubusercontent.com/37322608/57820019-d9122200

[incubator-druid] 01/01: minor web console doc fixes

2019-05-15 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch clintropolis-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git commit f0356723ccb9e74c20e2b7b13c8ff5c2529f8b1e Author: Clint Wylie AuthorDate: Wed May 15 18:12:12 2019

[incubator-druid] branch clintropolis-patch-1 created (now f035672)

2019-05-15 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch clintropolis-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. at f035672 minor web console doc fixes This branch includes the following new commits: ne

[GitHub] [incubator-druid] clintropolis opened a new pull request #7668: minor web console doc fixes

2019-05-15 Thread GitBox
clintropolis opened a new pull request #7668: minor web console doc fixes URL: https://github.com/apache/incubator-druid/pull/7668 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7642: Web console - add enable/disable actions for middle manager workers

2019-05-15 Thread GitBox
clintropolis commented on a change in pull request #7642: Web console - add enable/disable actions for middle manager workers URL: https://github.com/apache/incubator-druid/pull/7642#discussion_r284506186 ## File path: indexing-service/src/test/java/org/apache/druid/indexing/overlo

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7566: Data loader (sampler component) - Kafka/Kinesis samplers

2019-05-15 Thread GitBox
clintropolis commented on a change in pull request #7566: Data loader (sampler component) - Kafka/Kinesis samplers URL: https://github.com/apache/incubator-druid/pull/7566#discussion_r284491050 ## File path: extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/inde

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7566: Data loader (sampler component) - Kafka/Kinesis samplers

2019-05-15 Thread GitBox
clintropolis commented on a change in pull request #7566: Data loader (sampler component) - Kafka/Kinesis samplers URL: https://github.com/apache/incubator-druid/pull/7566#discussion_r284504241 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/Se

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7566: Data loader (sampler component) - Kafka/Kinesis samplers

2019-05-15 Thread GitBox
clintropolis commented on a change in pull request #7566: Data loader (sampler component) - Kafka/Kinesis samplers URL: https://github.com/apache/incubator-druid/pull/7566#discussion_r284496404 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/Se

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7566: Data loader (sampler component) - Kafka/Kinesis samplers

2019-05-15 Thread GitBox
clintropolis commented on a change in pull request #7566: Data loader (sampler component) - Kafka/Kinesis samplers URL: https://github.com/apache/incubator-druid/pull/7566#discussion_r284504688 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/Se

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7566: Data loader (sampler component) - Kafka/Kinesis samplers

2019-05-15 Thread GitBox
clintropolis commented on a change in pull request #7566: Data loader (sampler component) - Kafka/Kinesis samplers URL: https://github.com/apache/incubator-druid/pull/7566#discussion_r284491143 ## File path: extensions-core/kinesis-indexing-service/src/test/java/org/apache/druid/in

[incubator-druid] branch master updated: Fix compilation error in CoordinatorBasicAuthorizerResourceTest (#7667)

2019-05-15 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 7d63c29 Fix compilation error in C

[GitHub] [incubator-druid] jihoonson merged pull request #7667: Fix compilation error in CoordinatorBasicAuthorizerResourceTest

2019-05-15 Thread GitBox
jihoonson merged pull request #7667: Fix compilation error in CoordinatorBasicAuthorizerResourceTest URL: https://github.com/apache/incubator-druid/pull/7667 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-druid] himanshug commented on issue #7664: Re-indexing Segments that contain thetaSketches

2019-05-15 Thread GitBox
himanshug commented on issue #7664: Re-indexing Segments that contain thetaSketches URL: https://github.com/apache/incubator-druid/issues/7664#issuecomment-492868353 in reindexing task , try adding `"isInputThetaSketch":true` to metric spec for uid_sketch more info can be found in

[GitHub] [incubator-druid] himanshug commented on issue #7660: Quantiles sketch agg fails on inner query numeric post-agg columns

2019-05-15 Thread GitBox
himanshug commented on issue #7660: Quantiles sketch agg fails on inner query numeric post-agg columns URL: https://github.com/apache/incubator-druid/issues/7660#issuecomment-492867123 Theta Sketch[Buffer]Aggregator just does type check and dispatch, which would possibly be the quickest f

[GitHub] [incubator-druid] himanshug merged pull request #7654: Show all server types in sys.servers table

2019-05-15 Thread GitBox
himanshug merged pull request #7654: Show all server types in sys.servers table URL: https://github.com/apache/incubator-druid/pull/7654 This is an automated message from the Apache Git Service. To respond to the message, ple

[incubator-druid] branch master updated: Show all server types in sys.servers table (#7654)

2019-05-15 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new d3545f5 Show all server types in sy

[GitHub] [incubator-druid] himanshug commented on issue #7667: Fix compilation error in CoordinatorBasicAuthorizerResourceTest

2019-05-15 Thread GitBox
himanshug commented on issue #7667: Fix compilation error in CoordinatorBasicAuthorizerResourceTest URL: https://github.com/apache/incubator-druid/pull/7667#issuecomment-492859110 this was failing my PR build and I was scratching my head :) -

[GitHub] [incubator-druid] jon-wei opened a new pull request #7667: Fix compilation error in CoordinatorBasicAuthorizerResourceTest

2019-05-15 Thread GitBox
jon-wei opened a new pull request #7667: Fix compilation error in CoordinatorBasicAuthorizerResourceTest URL: https://github.com/apache/incubator-druid/pull/7667 Fixes a conflict between #7635 and #7661, this wasn't caught as both PRs compiled fine individually had completed their CI runs.

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs

2019-05-15 Thread GitBox
jon-wei commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs URL: https://github.com/apache/incubator-druid/pull/7629#discussion_r284476026 ## File path: docs/content/operations/basic-cluster-tuning.md ## @@ -0,

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs

2019-05-15 Thread GitBox
jon-wei commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs URL: https://github.com/apache/incubator-druid/pull/7629#discussion_r284475957 ## File path: docs/content/operations/basic-cluster-tuning.md ## @@ -0,

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs

2019-05-15 Thread GitBox
jon-wei commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs URL: https://github.com/apache/incubator-druid/pull/7629#discussion_r284475907 ## File path: docs/content/operations/basic-cluster-tuning.md ## @@ -0,

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7618: Virtual column updates for exploiting base column internal structure

2019-05-15 Thread GitBox
himanshug commented on a change in pull request #7618: Virtual column updates for exploiting base column internal structure URL: https://github.com/apache/incubator-druid/pull/7618#discussion_r284474011 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephel

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7618: Virtual column updates for exploiting base column internal structure

2019-05-15 Thread GitBox
himanshug commented on a change in pull request #7618: Virtual column updates for exploiting base column internal structure URL: https://github.com/apache/incubator-druid/pull/7618#discussion_r284474011 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephel

[GitHub] [incubator-druid] fjy closed pull request #7593: Bigo druid 0.14.0 incubating rc2

2019-05-15 Thread GitBox
fjy closed pull request #7593: Bigo druid 0.14.0 incubating rc2 URL: https://github.com/apache/incubator-druid/pull/7593 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-druid] fjy commented on issue #7593: Bigo druid 0.14.0 incubating rc2

2019-05-15 Thread GitBox
fjy commented on issue #7593: Bigo druid 0.14.0 incubating rc2 URL: https://github.com/apache/incubator-druid/pull/7593#issuecomment-492841277 Closing this for now as the author has not responded to questions or provided information about what this patch does. -

[incubator-druid] branch master updated: Added more mappings for new metrics. (#7665)

2019-05-15 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 0b739a5 Added more mappings for new metri

[GitHub] [incubator-druid] fjy merged pull request #7665: Added more statsd mappings for new metrics.

2019-05-15 Thread GitBox
fjy merged pull request #7665: Added more statsd mappings for new metrics. URL: https://github.com/apache/incubator-druid/pull/7665 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-druid] himanshug commented on issue #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
himanshug commented on issue #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#issuecomment-492839896 thanks guys, will fix the build and merge then. This is an

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs

2019-05-15 Thread GitBox
jihoonson commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs URL: https://github.com/apache/incubator-druid/pull/7629#discussion_r284459604 ## File path: docs/content/operations/basic-cluster-tuning.md ## @@ -

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs

2019-05-15 Thread GitBox
jihoonson commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs URL: https://github.com/apache/incubator-druid/pull/7629#discussion_r284460928 ## File path: docs/content/operations/basic-cluster-tuning.md ## @@ -

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs

2019-05-15 Thread GitBox
jihoonson commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs URL: https://github.com/apache/incubator-druid/pull/7629#discussion_r284423654 ## File path: docs/content/operations/basic-cluster-tuning.md ## @@ -

[GitHub] [incubator-druid] fjy commented on issue #7319: Fix unrealistic test variables in KafkaSupervisorTest and tidy up unused variable in checkpointing process

2019-05-15 Thread GitBox
fjy commented on issue #7319: Fix unrealistic test variables in KafkaSupervisorTest and tidy up unused variable in checkpointing process URL: https://github.com/apache/incubator-druid/pull/7319#issuecomment-492838620 @jihoonson mind fixing conflicts? ---

[GitHub] [incubator-druid] fjy merged pull request #7661: Fix compareAndSwap() in SQLMetadataConnector

2019-05-15 Thread GitBox
fjy merged pull request #7661: Fix compareAndSwap() in SQLMetadataConnector URL: https://github.com/apache/incubator-druid/pull/7661 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-druid] branch master updated: Fix compareAndSwap() in SQLMetadataConnector (#7661)

2019-05-15 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 6901123 Fix compareAndSwap() in SQLMetada

[GitHub] [incubator-druid] jon-wei commented on issue #7661: Fix compareAndSwap() in SQLMetadataConnector

2019-05-15 Thread GitBox
jon-wei commented on issue #7661: Fix compareAndSwap() in SQLMetadataConnector URL: https://github.com/apache/incubator-druid/pull/7661#issuecomment-492837641 > > Do we need similar changes in IndexerSQLMetadataStorageCoordinator's announceHistoricalSegments method? There's a similar kind o

[GitHub] [incubator-druid] fjy merged pull request #7658: Fix broken links in docs, add broken link checker.

2019-05-15 Thread GitBox
fjy merged pull request #7658: Fix broken links in docs, add broken link checker. URL: https://github.com/apache/incubator-druid/pull/7658 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch master updated: Fix broken links in docs, add broken link checker. (#7658)

2019-05-15 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 0352f45 Fix broken links in docs, add bro

[GitHub] [incubator-druid] fjy commented on issue #7629: Add basic tuning guide, getting started page, updated clustering docs

2019-05-15 Thread GitBox
fjy commented on issue #7629: Add basic tuning guide, getting started page, updated clustering docs URL: https://github.com/apache/incubator-druid/pull/7629#issuecomment-492835991 👍 This is an automated message from the Apac

[GitHub] [incubator-druid] fjy commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs

2019-05-15 Thread GitBox
fjy commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs URL: https://github.com/apache/incubator-druid/pull/7629#discussion_r284464539 ## File path: docs/content/tutorials/cluster.md ## @@ -22,56 +22,109 @@ tit

[GitHub] [incubator-druid] fjy commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs

2019-05-15 Thread GitBox
fjy commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs URL: https://github.com/apache/incubator-druid/pull/7629#discussion_r284464319 ## File path: docs/content/tutorials/cluster.md ## @@ -22,56 +22,109 @@ tit

[GitHub] [incubator-druid] fjy merged pull request #7577: Update tutorial to delete data

2019-05-15 Thread GitBox
fjy merged pull request #7577: Update tutorial to delete data URL: https://github.com/apache/incubator-druid/pull/7577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-druid] fjy commented on issue #7577: Update tutorial to delete data

2019-05-15 Thread GitBox
fjy commented on issue #7577: Update tutorial to delete data URL: https://github.com/apache/incubator-druid/pull/7577#issuecomment-492833912 👍 This is an automated message from the Apache Git Service. To respond to the messag

[incubator-druid] branch master updated: Update tutorial to delete data (#7577)

2019-05-15 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 9171069 Update tutorial to delete data (#

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7618: Virtual column updates for exploiting base column internal structure

2019-05-15 Thread GitBox
clintropolis commented on a change in pull request #7618: Virtual column updates for exploiting base column internal structure URL: https://github.com/apache/incubator-druid/pull/7618#discussion_r284432286 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinep

[GitHub] [incubator-druid] clintropolis commented on issue #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
clintropolis commented on issue #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#issuecomment-492824805 failing CI though ``` [ERROR] /home/travis/build/apache/incubator-druid/processing/src/main/java/org/apache/d

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs

2019-05-15 Thread GitBox
jon-wei commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs URL: https://github.com/apache/incubator-druid/pull/7629#discussion_r284442501 ## File path: docs/content/tutorials/cluster.md ## @@ -22,56 +22,107 @@

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs

2019-05-15 Thread GitBox
jon-wei commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs URL: https://github.com/apache/incubator-druid/pull/7629#discussion_r284442392 ## File path: examples/conf/druid/cluster/query/broker/jvm.config ## @@

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs

2019-05-15 Thread GitBox
jon-wei commented on a change in pull request #7629: Add basic tuning guide, getting started page, updated clustering docs URL: https://github.com/apache/incubator-druid/pull/7629#discussion_r284442144 ## File path: docs/content/tutorials/cluster.md ## @@ -22,56 +22,107 @@

[GitHub] [incubator-druid] stale[bot] commented on issue #7174: Change reservoir sampling of segments to spliterator approach

2019-05-15 Thread GitBox
stale[bot] commented on issue #7174: Change reservoir sampling of segments to spliterator approach URL: https://github.com/apache/incubator-druid/pull/7174#issuecomment-492813247 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no furt

[GitHub] [incubator-druid] surekhasaharan commented on issue #7648: Handle exceptions while fetching offsets

2019-05-15 Thread GitBox
surekhasaharan commented on issue #7648: Handle exceptions while fetching offsets URL: https://github.com/apache/incubator-druid/pull/7648#issuecomment-492812804 hey @shivtools it seems the tests are failing due to checkstyle violation, could you please check that ```[ERROR] /home/travis

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
himanshug commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#discussion_r284436145 ## File path: processing/src/main/java/org/apache/druid/segment/column/ComplexColumn.java ##

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
himanshug commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#discussion_r284435960 ## File path: processing/src/main/java/org/apache/druid/segment/column/ComplexColumn.java ##

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
himanshug commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#discussion_r284435517 ## File path: processing/src/main/java/org/apache/druid/segment/column/ComplexColumn.java ##

[GitHub] [incubator-druid] surekhasaharan commented on issue #7661: Fix compareAndSwap() in SQLMetadataConnector

2019-05-15 Thread GitBox
surekhasaharan commented on issue #7661: Fix compareAndSwap() in SQLMetadataConnector URL: https://github.com/apache/incubator-druid/pull/7661#issuecomment-492808848 > Do we need similar changes in IndexerSQLMetadataStorageCoordinator's announceHistoricalSegments method? There's a similar

[incubator-druid] branch master updated: Add simpler permissions option to BasicAuthorizer GET APIs (#7635)

2019-05-15 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new e874da7 Add simpler permissions option

[GitHub] [incubator-druid] jon-wei merged pull request #7635: Add simpler permissions option to BasicAuthorizer GET APIs

2019-05-15 Thread GitBox
jon-wei merged pull request #7635: Add simpler permissions option to BasicAuthorizer GET APIs URL: https://github.com/apache/incubator-druid/pull/7635 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7661: Fix compareAndSwap() in SQLMetadataConnector

2019-05-15 Thread GitBox
jon-wei commented on a change in pull request #7661: Fix compareAndSwap() in SQLMetadataConnector URL: https://github.com/apache/incubator-druid/pull/7661#discussion_r284426105 ## File path: extensions-core/postgresql-metadata-storage/src/main/java/org/apache/druid/metadata/storage

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7658: Fix broken links in docs, add broken link checker.

2019-05-15 Thread GitBox
clintropolis commented on a change in pull request #7658: Fix broken links in docs, add broken link checker. URL: https://github.com/apache/incubator-druid/pull/7658#discussion_r284418957 ## File path: docs/content/operations/druid-console.md ## @@ -41,7 +41,7 @@ Below is

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7658: Fix broken links in docs, add broken link checker.

2019-05-15 Thread GitBox
clintropolis commented on a change in pull request #7658: Fix broken links in docs, add broken link checker. URL: https://github.com/apache/incubator-druid/pull/7658#discussion_r284418481 ## File path: docs/_bin/deploy-docs.sh ## @@ -88,6 +88,9 @@ remote=$(git -C "$druid"

[GitHub] [incubator-druid] clintropolis commented on issue #7666: sketches-core-0.13.4

2019-05-15 Thread GitBox
clintropolis commented on issue #7666: sketches-core-0.13.4 URL: https://github.com/apache/incubator-druid/pull/7666#issuecomment-492794251 >By the way, did anyone verify that the previous update to 0.13.3 really fixed the Theta sketch regression (#7619)? I was no longer able to repr

[GitHub] [incubator-druid] AlexanderSaydakov opened a new pull request #7666: sketches-core-0.13.4

2019-05-15 Thread GitBox
AlexanderSaydakov opened a new pull request #7666: sketches-core-0.13.4 URL: https://github.com/apache/incubator-druid/pull/7666 From the sketches-core release notes: "0.13.4 May 14, 2019: Fix Theta Direct Union Bug, alternate path. It turns out there were two different code paths that

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
jihoonson commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#discussion_r284399941 ## File path: processing/src/main/java/org/apache/druid/segment/column/ComplexColumn.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
jihoonson commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#discussion_r284401161 ## File path: processing/src/main/java/org/apache/druid/segment/column/ComplexColumn.java ##

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
clintropolis commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#discussion_r284400668 ## File path: processing/src/main/java/org/apache/druid/segment/column/ComplexColumn.java ###

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
himanshug commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#discussion_r284398915 ## File path: processing/src/main/java/org/apache/druid/segment/column/ComplexColumn.java ##

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
himanshug commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#discussion_r284399030 ## File path: processing/src/main/java/org/apache/druid/segment/column/GenericIndexedBasedComplex

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
himanshug commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#discussion_r284398995 ## File path: processing/src/main/java/org/apache/druid/segment/column/ComplexColumn.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
jihoonson commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#discussion_r284390556 ## File path: processing/src/main/java/org/apache/druid/segment/column/ComplexColumn.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
jihoonson commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#discussion_r284389620 ## File path: processing/src/main/java/org/apache/druid/segment/column/ComplexColumn.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
jihoonson commented on a change in pull request #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#discussion_r284390726 ## File path: processing/src/main/java/org/apache/druid/segment/column/GenericIndexedBasedComplex

[GitHub] [incubator-druid] himanshug commented on issue #7618: Virtual column updates for exploiting base column internal structure

2019-05-15 Thread GitBox
himanshug commented on issue #7618: Virtual column updates for exploiting base column internal structure URL: https://github.com/apache/incubator-druid/pull/7618#issuecomment-492762129 @gianm @jon-wei @jihoonson @clintropolis can someone review this ? -

[GitHub] [incubator-druid] himanshug commented on issue #7633: make ComplexColumn an interface and ExtensionPoint

2019-05-15 Thread GitBox
himanshug commented on issue #7633: make ComplexColumn an interface and ExtensionPoint URL: https://github.com/apache/incubator-druid/pull/7633#issuecomment-492762064 @gianm @jon-wei @jihoonson @clintropolis can someone review this ? ---

[GitHub] [incubator-druid] gianm commented on a change in pull request #7658: Fix broken links in docs, add broken link checker.

2019-05-15 Thread GitBox
gianm commented on a change in pull request #7658: Fix broken links in docs, add broken link checker. URL: https://github.com/apache/incubator-druid/pull/7658#discussion_r284353540 ## File path: docs/_bin/deploy-docs.sh ## @@ -88,6 +88,9 @@ remote=$(git -C "$druid" config

[GitHub] [incubator-druid] gianm commented on issue #7660: Quantiles sketch agg fails on inner query numeric post-agg columns

2019-05-15 Thread GitBox
gianm commented on issue #7660: Quantiles sketch agg fails on inner query numeric post-agg columns URL: https://github.com/apache/incubator-druid/issues/7660#issuecomment-492668919 The HllSketch aggregator seems to have a similar issue.

[GitHub] [incubator-druid] dene14 opened a new pull request #7665: Added more statsd mappings for new metrics.

2019-05-15 Thread GitBox
dene14 opened a new pull request #7665: Added more statsd mappings for new metrics. URL: https://github.com/apache/incubator-druid/pull/7665 Statsd mappings look a bit outdated for recent changes in 0.14.0. Let's try to address that. Probably should be targeted to 0.14.2 milestone.

[GitHub] [incubator-druid] max-schmidt54321 opened a new issue #7664: Re-indexing Segments that contain thetaSketches

2019-05-15 Thread GitBox
max-schmidt54321 opened a new issue #7664: Re-indexing Segments that contain thetaSketches URL: https://github.com/apache/incubator-druid/issues/7664 Is it possible to re-index segments and use thetaSketches? Currently I have a datasource that is being ingested with the following super

[GitHub] [incubator-druid] HeIsRicky opened a new issue #7663: druid 0.14.1-incubating create table failed when starting the Coordinator

2019-05-15 Thread GitBox
HeIsRicky opened a new issue #7663: druid 0.14.1-incubating create table failed when starting the Coordinator URL: https://github.com/apache/incubator-druid/issues/7663 druid 0.14.1-incubating mysql 5.6 - Following sql has been executed ` -- create a druid database, make s

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7658: Fix broken links in docs, add broken link checker.

2019-05-15 Thread GitBox
clintropolis commented on a change in pull request #7658: Fix broken links in docs, add broken link checker. URL: https://github.com/apache/incubator-druid/pull/7658#discussion_r284130416 ## File path: docs/_bin/deploy-docs.sh ## @@ -88,6 +88,9 @@ remote=$(git -C "$druid"

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7661: Fix compareAndSwap() in SQLMetadataConnector

2019-05-15 Thread GitBox
clintropolis commented on a change in pull request #7661: Fix compareAndSwap() in SQLMetadataConnector URL: https://github.com/apache/incubator-druid/pull/7661#discussion_r284126673 ## File path: extensions-core/postgresql-metadata-storage/src/main/java/org/apache/druid/metadata/st