[GitHub] [druid] samarthjain commented on pull request #13545: perf: core/TextReader for faster json ingestion

2022-12-19 Thread GitBox
samarthjain commented on PR #13545: URL: https://github.com/apache/druid/pull/13545#issuecomment-1358569943 Looks good, @jasonk000 . Just one comment - how about tests for cases where there is only CR or LF in a line? -- This is an automated message from the Apache Git Service. To

[GitHub] [druid] jasonk000 commented on a diff in pull request #13545: perf: core/TextReader for faster json ingestion

2022-12-19 Thread GitBox
jasonk000 commented on code in PR #13545: URL: https://github.com/apache/druid/pull/13545#discussion_r1051088837 ## benchmarks/src/test/java/org/apache/druid/benchmark/JsonLineReaderBenchmark.java: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] paul-rogers commented on pull request #13580: Push operators

2022-12-19 Thread GitBox
paul-rogers commented on PR #13580: URL: https://github.com/apache/druid/pull/13580#issuecomment-1358151289 I believe you'll find that a push-based model doesn't scale well to larger DAGs, or those with branches. The push model has been tried several times in industry, and it tends to run

[GitHub] [druid] paul-rogers commented on a diff in pull request #13535: MSQ s3 deep storage tests

2022-12-19 Thread GitBox
paul-rogers commented on code in PR #13535: URL: https://github.com/apache/druid/pull/13535#discussion_r1052462276 ## integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/indexer/AbstractITBatchIndexTest.java: ## @@ -91,16 +97,149 @@ public String getFolderSuffix()

[GitHub] [druid-website] vogievetsky merged pull request #201: Autobuild

2022-12-19 Thread GitBox
vogievetsky merged PR #201: URL: https://github.com/apache/druid-website/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid-website-src] vogievetsky merged pull request #357: Update events.yml

2022-12-19 Thread GitBox
vogievetsky merged PR #357: URL: https://github.com/apache/druid-website-src/pull/357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] paul-rogers commented on a diff in pull request #13518: Migrate jdk8 unit tests from Travis to GHA

2022-12-19 Thread GitBox
paul-rogers commented on code in PR #13518: URL: https://github.com/apache/druid/pull/13518#discussion_r1052438026 ## .github/scripts/unit_tests_script.sh: ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [druid] paul-rogers commented on a diff in pull request #13597: New IT Framework - InputSource and InputFormat Tests

2022-12-19 Thread GitBox
paul-rogers commented on code in PR #13597: URL: https://github.com/apache/druid/pull/13597#discussion_r1052430468 ## integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/indexer/ITHttpInputSourceTest.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [druid] kfaraz commented on a diff in pull request #13596: [Draft][Do not merge] Add release notes

2022-12-19 Thread GitBox
kfaraz commented on code in PR #13596: URL: https://github.com/apache/druid/pull/13596#discussion_r1052194008 ## docs/release_notes_25.md: ## @@ -0,0 +1,663 @@ +Apache Druid 25.0.0 contains over 300 new features, bug fixes, performance enhancements, documentation improvements,

[GitHub] [druid] cryptoe commented on a diff in pull request #13535: MSQ s3 deep storage tests

2022-12-19 Thread GitBox
cryptoe commented on code in PR #13535: URL: https://github.com/apache/druid/pull/13535#discussion_r1052170067 ## integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/indexer/AbstractITBatchIndexTest.java: ## @@ -91,16 +97,149 @@ public String getFolderSuffix()

[GitHub] [druid] cryptoe commented on pull request #13597: New IT Framework - InputSource and InputFormat Tests

2022-12-19 Thread GitBox
cryptoe commented on PR #13597: URL: https://github.com/apache/druid/pull/13597#issuecomment-1357619713 @abhagraw Also please mention the exact tests which are being migrated as part of the DESC for the trail. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [druid] cryptoe commented on a diff in pull request #13597: New IT Framework - InputSource and InputFormat Tests

2022-12-19 Thread GitBox
cryptoe commented on code in PR #13597: URL: https://github.com/apache/druid/pull/13597#discussion_r1052165616 ## integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/indexer/ITHttpInputSourceTest.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software

[GitHub] [druid] cryptoe commented on a diff in pull request #13597: New IT Framework - InputSource and InputFormat Tests

2022-12-19 Thread GitBox
cryptoe commented on code in PR #13597: URL: https://github.com/apache/druid/pull/13597#discussion_r1052162279 ## integration-tests-ex/cases/cluster.sh: ## @@ -79,9 +79,12 @@ function category { # Add an entry here if you create a new category that shares # a

[GitHub] [druid] cryptoe commented on a diff in pull request #13597: New IT Framework - InputSource and InputFormat Tests

2022-12-19 Thread GitBox
cryptoe commented on code in PR #13597: URL: https://github.com/apache/druid/pull/13597#discussion_r1052162279 ## integration-tests-ex/cases/cluster.sh: ## @@ -79,9 +79,12 @@ function category { # Add an entry here if you create a new category that shares # a

[GitHub] [druid-website-src] petermarshallio opened a new pull request, #357: Update events.yml

2022-12-19 Thread GitBox
petermarshallio opened a new pull request, #357: URL: https://github.com/apache/druid-website-src/pull/357 New drop-in scheduled Removed old events -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [druid] LakshSingla commented on pull request #13596: [Draft][Do not merge] Add release notes

2022-12-19 Thread GitBox
LakshSingla commented on PR #13596: URL: https://github.com/apache/druid/pull/13596#issuecomment-1357447518 Looks good from my side as well. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] kfaraz merged pull request #13599: [Backport] Fix scope of dependencies in protobuf-extensions pom (#13593)

2022-12-19 Thread GitBox
kfaraz merged PR #13599: URL: https://github.com/apache/druid/pull/13599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] rohangarg commented on pull request #13596: [Draft][Do not merge] Add release notes

2022-12-19 Thread GitBox
rohangarg commented on PR #13596: URL: https://github.com/apache/druid/pull/13596#issuecomment-1357337039 Looks good from my side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] adarshsanjeev commented on pull request #13596: [Draft][Do not merge] Add release notes

2022-12-19 Thread GitBox
adarshsanjeev commented on PR #13596: URL: https://github.com/apache/druid/pull/13596#issuecomment-1357327372 Looks good from my side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [druid] kfaraz opened a new pull request, #13599: [Backport] Fix scope of dependencies in protobuf-extensions pom (#13593)

2022-12-19 Thread GitBox
kfaraz opened a new pull request, #13599: URL: https://github.com/apache/druid/pull/13599 Backports #13593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [druid] abhagraw commented on a diff in pull request #13535: MSQ s3 deep storage tests

2022-12-19 Thread GitBox
abhagraw commented on code in PR #13535: URL: https://github.com/apache/druid/pull/13535#discussion_r1051934449 ## integration-tests-ex/cases/cluster/S3DeepStorage/docker-compose.yaml: ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [druid] kfaraz merged pull request #13593: Fix scope of dependencies in protobuf-extensions

2022-12-19 Thread GitBox
kfaraz merged PR #13593: URL: https://github.com/apache/druid/pull/13593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] kfaraz merged pull request #13598: [Backport] Docs: Remove large data file (#13595)

2022-12-19 Thread GitBox
kfaraz merged PR #13598: URL: https://github.com/apache/druid/pull/13598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] cheddar merged pull request #13564: Unify the handling of HTTP between SQL and Native

2022-12-19 Thread GitBox
cheddar merged PR #13564: URL: https://github.com/apache/druid/pull/13564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13564: Unify the handling of HTTP between SQL and Native

2022-12-19 Thread GitBox
imply-cheddar commented on code in PR #13564: URL: https://github.com/apache/druid/pull/13564#discussion_r1051919297 ## core/src/main/java/org/apache/druid/query/QueryException.java: ## @@ -30,12 +29,129 @@ import java.util.function.Function; /** - * Base serializable error

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13564: Unify the handling of HTTP between SQL and Native

2022-12-19 Thread GitBox
imply-cheddar commented on code in PR #13564: URL: https://github.com/apache/druid/pull/13564#discussion_r1051916963 ## core/src/main/java/org/apache/druid/query/QueryException.java: ## @@ -30,12 +29,126 @@ import java.util.function.Function; /** - * Base serializable error

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13564: Unify the handling of HTTP between SQL and Native

2022-12-19 Thread GitBox
imply-cheddar commented on code in PR #13564: URL: https://github.com/apache/druid/pull/13564#discussion_r1051914517 ## server/src/test/java/org/apache/druid/server/mocks/MockHttpServletRequest.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13564: Unify the handling of HTTP between SQL and Native

2022-12-19 Thread GitBox
imply-cheddar commented on code in PR #13564: URL: https://github.com/apache/druid/pull/13564#discussion_r1051913011 ## sql/src/main/java/org/apache/druid/sql/http/SqlResource.java: ## @@ -320,4 +181,187 @@ public Response cancelQuery( return

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13564: Unify the handling of HTTP between SQL and Native

2022-12-19 Thread GitBox
imply-cheddar commented on code in PR #13564: URL: https://github.com/apache/druid/pull/13564#discussion_r1051910985 ## sql/src/main/java/org/apache/druid/sql/SqlPlanningException.java: ## @@ -32,11 +32,12 @@ */ public class SqlPlanningException extends BadQueryException {

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13564: Unify the handling of HTTP between SQL and Native

2022-12-19 Thread GitBox
imply-cheddar commented on code in PR #13564: URL: https://github.com/apache/druid/pull/13564#discussion_r1051909967 ## processing/src/main/java/org/apache/druid/query/context/ResponseContext.java: ## @@ -334,14 +335,15 @@ public Object mergeValues(Object oldValue, Object

[GitHub] [druid] cryptoe commented on a diff in pull request #13596: [Draft][Do not merge] Add release notes

2022-12-18 Thread GitBox
cryptoe commented on code in PR #13596: URL: https://github.com/apache/druid/pull/13596#discussion_r1051899638 ## docs/release_notes_25.md: ## @@ -0,0 +1,664 @@ +Apache Druid 25.0.0 contains over 300 new features, bug fixes, performance enhancements, documentation

[GitHub] [druid] kfaraz opened a new pull request, #13598: Docs: Remove large data file (#13595)

2022-12-18 Thread GitBox
kfaraz opened a new pull request, #13598: URL: https://github.com/apache/druid/pull/13598 Backports #13595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [druid] abhagraw opened a new pull request, #13597: New IT Framework - InputSource and InputFormat Tests

2022-12-18 Thread GitBox
abhagraw opened a new pull request, #13597: URL: https://github.com/apache/druid/pull/13597 Migrating InputSource and InputFormat Tests to the new IT framework. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [druid] kfaraz merged pull request #13595: Docs: remove large data file

2022-12-18 Thread GitBox
kfaraz merged PR #13595: URL: https://github.com/apache/druid/pull/13595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] cryptoe commented on a diff in pull request #13596: [Draft][Do not merge] Add release notes

2022-12-18 Thread GitBox
cryptoe commented on code in PR #13596: URL: https://github.com/apache/druid/pull/13596#discussion_r1051889300 ## docs/release_notes_25.md: ## @@ -0,0 +1,664 @@ +Apache Druid 25.0.0 contains over 300 new features, bug fixes, performance enhancements, documentation

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13564: Unify the handling of HTTP between SQL and Native

2022-12-18 Thread GitBox
imply-cheddar commented on code in PR #13564: URL: https://github.com/apache/druid/pull/13564#discussion_r1051880666 ## core/src/test/java/org/apache/druid/query/QueryExceptionTest.java: ## @@ -38,36 +33,72 @@ private static final String ERROR_MESSAGE_ORIGINAL = "";

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13564: Unify the handling of HTTP between SQL and Native

2022-12-18 Thread GitBox
imply-cheddar commented on code in PR #13564: URL: https://github.com/apache/druid/pull/13564#discussion_r1051878005 ## core/src/main/java/org/apache/druid/query/QueryException.java: ## @@ -30,12 +29,129 @@ import java.util.function.Function; /** - * Base serializable error

[GitHub] [druid] kfaraz closed issue #13359: JSON serialization of LocalInputSource changes meaning of files

2022-12-18 Thread GitBox
kfaraz closed issue #13359: JSON serialization of LocalInputSource changes meaning of files URL: https://github.com/apache/druid/issues/13359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] kfaraz merged pull request #13534: LocalInputSource: Serialize File paths without forcing resolution.

2022-12-18 Thread GitBox
kfaraz merged PR #13534: URL: https://github.com/apache/druid/pull/13534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] kfaraz commented on issue #13507: Unauthorized call to /druid/indexer/v1/supervisor returns 200

2022-12-18 Thread GitBox
kfaraz commented on issue #13507: URL: https://github.com/apache/druid/issues/13507#issuecomment-1357107247 @wiegandf , that's correct, this is just a GET endpoint. So you are authorized to hit the API itself, but the result of the API is the list of supervisors to which you have WRITE

[GitHub] [druid] vogievetsky opened a new pull request, #13595: Docs: remove large data file

2022-12-18 Thread GitBox
vogievetsky opened a new pull request, #13595: URL: https://github.com/apache/druid/pull/13595 https://github.com/apache/druid/pull/13261 committed a large data file to the repo blowing up the distribution size. This file is already available elsewhere - same place as where the console

[GitHub] [druid] kfaraz merged pull request #13591: [Backport] docs: DataSketches

2022-12-18 Thread GitBox
kfaraz merged PR #13591: URL: https://github.com/apache/druid/pull/13591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] LakshSingla commented on a diff in pull request #13353: Worker retry for MSQ task

2022-12-18 Thread GitBox
LakshSingla commented on code in PR #13353: URL: https://github.com/apache/druid/pull/13353#discussion_r1051751976 ## core/src/main/java/org/apache/druid/java/util/common/function/TriConsumer.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] kfaraz opened a new pull request, #13593: Fix dependencies in extensions/kafka and extensions/protobuf

2022-12-18 Thread GitBox
kfaraz opened a new pull request, #13593: URL: https://github.com/apache/druid/pull/13593 The dependencies in extensions should either have scope `provided` or `test` unless they are used only by the given extension. Duplicate dependencies or dependencies declared under the wrong

[GitHub] [druid] kfaraz opened a new issue, #13592: [Draft] 25.0.0 Release Notes

2022-12-18 Thread GitBox
kfaraz opened a new issue, #13592: URL: https://github.com/apache/druid/issues/13592 Apache Druid 25.0.0 contains over 300 new features, bug fixes, performance enhancements, documentation improvements, and additional test coverage from 67 contributors. [See the complete set of changes for

[GitHub] [druid] vtlim opened a new pull request, #13591: [Backport] docs: DataSketches

2022-12-17 Thread GitBox
vtlim opened a new pull request, #13591: URL: https://github.com/apache/druid/pull/13591 Backports #13524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [druid] vtlim merged pull request #13524: Document shouldFinalize for sketches that have the parameter

2022-12-17 Thread GitBox
vtlim merged PR #13524: URL: https://github.com/apache/druid/pull/13524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] kfaraz merged pull request #13590: Suppress CVEs for Hadoop3 profile

2022-12-17 Thread GitBox
kfaraz merged PR #13590: URL: https://github.com/apache/druid/pull/13590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] kfaraz opened a new pull request, #13590: Suppress CVEs for Hadoop3 profile

2022-12-17 Thread GitBox
kfaraz opened a new pull request, #13590: URL: https://github.com/apache/druid/pull/13590 Suppress the following CVEs which are pulled in by the hdfs-storage module: - CVE-2022-1278 - CVE-2022-2048 - CVE-2022-3509 - CVE-2022-40152 -- This is an automated message from the

[GitHub] [druid] kfaraz commented on pull request #13531: Support prometheus emitter

2022-12-16 Thread GitBox
kfaraz commented on PR #13531: URL: https://github.com/apache/druid/pull/13531#issuecomment-1356014256 Hi, @jaegwonseo , thanks for your patience! We have been a little occupied with the upcoming release of Druid 25. I will try to get this reviewed soon. -- This is an automated message

[GitHub] [druid] jaegwonseo commented on pull request #13531: Support prometheus emitter

2022-12-16 Thread GitBox
jaegwonseo commented on PR #13531: URL: https://github.com/apache/druid/pull/13531#issuecomment-1356008387 @kfaraz Is there something wrong or needs to be corrected? plz check this -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [druid] kfaraz merged pull request #13589: [Backport] docs: Jupyter tutorial

2022-12-16 Thread GitBox
kfaraz merged PR #13589: URL: https://github.com/apache/druid/pull/13589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] paul-rogers commented on a diff in pull request #13564: Unify the handling of HTTP between SQL and Native

2022-12-16 Thread GitBox
paul-rogers commented on code in PR #13564: URL: https://github.com/apache/druid/pull/13564#discussion_r1051287738 ## sql/src/main/java/org/apache/druid/sql/SqlPlanningException.java: ## @@ -32,11 +32,12 @@ */ public class SqlPlanningException extends BadQueryException { +

[GitHub] [druid] vtlim opened a new pull request, #13589: [Backport] docs: Jupyter tutorial

2022-12-16 Thread GitBox
vtlim opened a new pull request, #13589: URL: https://github.com/apache/druid/pull/13589 Backports https://github.com/apache/druid/pull/13342/, https://github.com/apache/druid/pull/13345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [druid] vogievetsky merged pull request #13577: Web console: default max workers to cluster capacity and simplify live reports

2022-12-16 Thread GitBox
vogievetsky merged PR #13577: URL: https://github.com/apache/druid/pull/13577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] vtlim commented on a diff in pull request #13429: 25.0 release notes: batch 3

2022-12-16 Thread GitBox
vtlim commented on code in PR #13429: URL: https://github.com/apache/druid/pull/13429#discussion_r1051228330 ## docs/next-release-notes.md: ## @@ -239,6 +362,10 @@ https://github.com/apache/druid/pull/12177 ## Operations +### Deploying Druid + +There is now a Python

[GitHub] [druid] vogievetsky merged pull request #13587: [backport] Web console: fix preview dropping out of MSQ mode

2022-12-16 Thread GitBox
vogievetsky merged PR #13587: URL: https://github.com/apache/druid/pull/13587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] vogievetsky merged pull request #13586: Web console: fix preview dropping out of MSQ mode

2022-12-16 Thread GitBox
vogievetsky merged PR #13586: URL: https://github.com/apache/druid/pull/13586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] ektravel commented on a diff in pull request #13468: docs: add a link for the Druid SQL tutorial

2022-12-16 Thread GitBox
ektravel commented on code in PR #13468: URL: https://github.com/apache/druid/pull/13468#discussion_r1051226155 ## docs/tutorials/tutorial-jupyter-index.md: ## @@ -68,4 +69,7 @@ The notebooks are located in the [apache/druid repo](https://github.com/apache/d The links that

[GitHub] [druid] kfaraz commented on a diff in pull request #13429: 25.0 release notes: batch 3

2022-12-16 Thread GitBox
kfaraz commented on code in PR #13429: URL: https://github.com/apache/druid/pull/13429#discussion_r1050804076 ## docs/next-release-notes.md: ## @@ -119,21 +190,84 @@ https://github.com/apache/druid/pull/13133 ### Added new configuration keys to query context security model

[GitHub] [druid] techdocsmith commented on a diff in pull request #13524: Document shouldFinalize for sketches that have the parameter

2022-12-16 Thread GitBox
techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051173494 ## docs/development/extensions-core/datasketches-theta.md: ## @@ -45,17 +50,18 @@ druid.extensions.loadList=["druid-datasketches"] } ```

[GitHub] [druid] techdocsmith commented on a diff in pull request #13524: Document shouldFinalize for sketches that have the parameter

2022-12-16 Thread GitBox
techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051172477 ## docs/development/extensions-core/datasketches-theta.md: ## @@ -45,17 +50,18 @@ druid.extensions.loadList=["druid-datasketches"] } ```

[GitHub] [druid] techdocsmith commented on a diff in pull request #13524: Document shouldFinalize for sketches that have the parameter

2022-12-16 Thread GitBox
techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051172477 ## docs/development/extensions-core/datasketches-theta.md: ## @@ -45,17 +50,18 @@ druid.extensions.loadList=["druid-datasketches"] } ```

[GitHub] [druid] techdocsmith commented on a diff in pull request #13524: Document shouldFinalize for sketches that have the parameter

2022-12-16 Thread GitBox
techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051170369 ## docs/development/extensions-core/datasketches-theta.md: ## @@ -45,17 +50,18 @@ druid.extensions.loadList=["druid-datasketches"] } ```

[GitHub] [druid] ektravel opened a new pull request, #13588: docs: notebook only for Druid SQL Partitioning tutorial

2022-12-16 Thread GitBox
ektravel opened a new pull request, #13588: URL: https://github.com/apache/druid/pull/13588 Adds the Jupyter notebook file `partitioned-by-tutorial.ipynb` This PR has: [ x ] been self-reviewed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [druid] techdocsmith commented on a diff in pull request #13524: Document shouldFinalize for sketches that have the parameter

2022-12-16 Thread GitBox
techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051170516 ## docs/development/extensions-core/datasketches-quantiles.md: ## @@ -50,17 +52,18 @@ The result of the aggregation is a DoublesSketch that is the union of all

[GitHub] [druid] techdocsmith commented on a diff in pull request #13524: Document shouldFinalize for sketches that have the parameter

2022-12-16 Thread GitBox
techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051169719 ## docs/development/extensions-core/datasketches-kll.md: ## @@ -50,17 +52,17 @@ The result of the aggregation is a KllFloatsSketch or KllDoublesSketch that is t

[GitHub] [druid] techdocsmith commented on a diff in pull request #13524: Document shouldFinalize for sketches that have the parameter

2022-12-16 Thread GitBox
techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051169719 ## docs/development/extensions-core/datasketches-kll.md: ## @@ -50,17 +52,17 @@ The result of the aggregation is a KllFloatsSketch or KllDoublesSketch that is t

[GitHub] [druid] techdocsmith commented on a diff in pull request #13524: Document shouldFinalize for sketches that have the parameter

2022-12-16 Thread GitBox
techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051167497 ## docs/development/extensions-core/datasketches-hll.md: ## @@ -23,29 +23,32 @@ title: "DataSketches HLL Sketch module" --> -This module provides Apache

[GitHub] [druid] techdocsmith commented on a diff in pull request #13524: Document shouldFinalize for sketches that have the parameter

2022-12-16 Thread GitBox
techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051165775 ## docs/development/extensions-core/datasketches-hll.md: ## @@ -23,29 +23,32 @@ title: "DataSketches HLL Sketch module" --> -This module provides Apache

[GitHub] [druid] techdocsmith commented on a diff in pull request #13524: Document shouldFinalize for sketches that have the parameter

2022-12-16 Thread GitBox
techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051172477 ## docs/development/extensions-core/datasketches-theta.md: ## @@ -45,17 +50,18 @@ druid.extensions.loadList=["druid-datasketches"] } ```

[GitHub] [druid] vtlim merged pull request #13342: docs: add index page and related stuff for jupyter tutorials

2022-12-16 Thread GitBox
vtlim merged PR #13342: URL: https://github.com/apache/druid/pull/13342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] techdocsmith commented on a diff in pull request #13524: Document shouldFinalize for sketches that have the parameter

2022-12-16 Thread GitBox
techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051165775 ## docs/development/extensions-core/datasketches-hll.md: ## @@ -23,29 +23,32 @@ title: "DataSketches HLL Sketch module" --> -This module provides Apache

[GitHub] [druid] samarthjain commented on a diff in pull request #13545: perf: core/TextReader for faster json ingestion

2022-12-16 Thread GitBox
samarthjain commented on code in PR #13545: URL: https://github.com/apache/druid/pull/13545#discussion_r1051142169 ## core/src/main/java/org/apache/druid/data/input/impl/FastLineIterator.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [druid] jasonk000 commented on a diff in pull request #13545: perf: core/TextReader for faster json ingestion

2022-12-16 Thread GitBox
jasonk000 commented on code in PR #13545: URL: https://github.com/apache/druid/pull/13545#discussion_r1051088837 ## benchmarks/src/test/java/org/apache/druid/benchmark/JsonLineReaderBenchmark.java: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] jasonk000 commented on a diff in pull request #13545: perf: core/TextReader for faster json ingestion

2022-12-16 Thread GitBox
jasonk000 commented on code in PR #13545: URL: https://github.com/apache/druid/pull/13545#discussion_r1051082187 ## core/src/main/java/org/apache/druid/data/input/impl/FastLineIterator.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [druid] jasonk000 commented on a diff in pull request #13545: perf: core/TextReader for faster json ingestion

2022-12-16 Thread GitBox
jasonk000 commented on code in PR #13545: URL: https://github.com/apache/druid/pull/13545#discussion_r1051075072 ## core/src/main/java/org/apache/druid/data/input/impl/FastLineIterator.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [druid] samarthjain commented on a diff in pull request #13545: perf: core/TextReader for faster json ingestion

2022-12-16 Thread GitBox
samarthjain commented on code in PR #13545: URL: https://github.com/apache/druid/pull/13545#discussion_r1051057134 ## core/src/main/java/org/apache/druid/data/input/impl/FastLineIterator.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [druid] ektravel commented on a diff in pull request #13465: docs: notebook only for SQL tutorial

2022-12-16 Thread GitBox
ektravel commented on code in PR #13465: URL: https://github.com/apache/druid/pull/13465#discussion_r1051003730 ## examples/quickstart/jupyter-notebooks/sql-tutorial.ipynb: ## @@ -0,0 +1,764 @@ +{ + "cells": [ + { + "cell_type": "markdown", + "id": "ad4e60b6", +

[GitHub] [druid] vogievetsky opened a new pull request, #13587: [backport] Web console: fix preview dropping out of MSQ mode

2022-12-16 Thread GitBox
vogievetsky opened a new pull request, #13587: URL: https://github.com/apache/druid/pull/13587 Backport of https://github.com/apache/druid/pull/13586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] cryptoe merged pull request #13585: Suppress CVE-2022-45685 and CVE-2022-45693 from jettison-1.3

2022-12-16 Thread GitBox
cryptoe merged PR #13585: URL: https://github.com/apache/druid/pull/13585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] vogievetsky opened a new pull request, #13586: Web console: fix preview dropping out of MSQ mode

2022-12-16 Thread GitBox
vogievetsky opened a new pull request, #13586: URL: https://github.com/apache/druid/pull/13586 Make it so that preview has to run in MSQ to prevent this error when in `auto` engine selector mode:

[GitHub] [druid] writer-jill commented on a diff in pull request #13574: Add clarification about JSONPath syntax to doc

2022-12-16 Thread GitBox
writer-jill commented on code in PR #13574: URL: https://github.com/apache/druid/pull/13574#discussion_r1050860778 ## docs/querying/sql-json-functions.md: ## @@ -47,7 +47,7 @@ You can use the following JSON functions to extract, transform, and create `COMP ### JSONPath

[GitHub] [druid] kfaraz commented on a diff in pull request #13429: 25.0 release notes: batch 3

2022-12-16 Thread GitBox
kfaraz commented on code in PR #13429: URL: https://github.com/apache/druid/pull/13429#discussion_r1050823562 ## docs/next-release-notes.md: ## @@ -239,6 +362,10 @@ https://github.com/apache/druid/pull/12177 ## Operations +### Deploying Druid + +There is now a Python

[GitHub] [druid] kfaraz commented on a diff in pull request #13429: 25.0 release notes: batch 3

2022-12-16 Thread GitBox
kfaraz commented on code in PR #13429: URL: https://github.com/apache/druid/pull/13429#discussion_r1050823562 ## docs/next-release-notes.md: ## @@ -239,6 +362,10 @@ https://github.com/apache/druid/pull/12177 ## Operations +### Deploying Druid + +There is now a Python

[GitHub] [druid] kfaraz commented on a diff in pull request #13429: 25.0 release notes: batch 3

2022-12-16 Thread GitBox
kfaraz commented on code in PR #13429: URL: https://github.com/apache/druid/pull/13429#discussion_r1050809228 ## docs/next-release-notes.md: ## @@ -239,6 +362,10 @@ https://github.com/apache/druid/pull/12177 ## Operations +### Deploying Druid Review Comment: This item

[GitHub] [druid] kfaraz commented on a diff in pull request #13429: 25.0 release notes: batch 3

2022-12-16 Thread GitBox
kfaraz commented on code in PR #13429: URL: https://github.com/apache/druid/pull/13429#discussion_r1050804353 ## docs/next-release-notes.md: ## @@ -119,21 +190,84 @@ https://github.com/apache/druid/pull/13133 ### Added new configuration keys to query context security model

[GitHub] [druid] kfaraz commented on a diff in pull request #13429: 25.0 release notes: batch 3

2022-12-16 Thread GitBox
kfaraz commented on code in PR #13429: URL: https://github.com/apache/druid/pull/13429#discussion_r1050804076 ## docs/next-release-notes.md: ## @@ -119,21 +190,84 @@ https://github.com/apache/druid/pull/13133 ### Added new configuration keys to query context security model

[GitHub] [druid] kfaraz commented on a diff in pull request #13429: 25.0 release notes: batch 3

2022-12-16 Thread GitBox
kfaraz commented on code in PR #13429: URL: https://github.com/apache/druid/pull/13429#discussion_r1050803038 ## docs/next-release-notes.md: ## @@ -119,21 +190,84 @@ https://github.com/apache/druid/pull/13133 ### Added new configuration keys to query context security model

[GitHub] [druid] kfaraz commented on a diff in pull request #13429: 25.0 release notes: batch 3

2022-12-16 Thread GitBox
kfaraz commented on code in PR #13429: URL: https://github.com/apache/druid/pull/13429#discussion_r1050802128 ## docs/next-release-notes.md: ## @@ -21,19 +21,88 @@ title: "WIP release notes for 25.0" ~ under the License. --> -## Query engine +## Highlights -###

[GitHub] [druid] kfaraz commented on issue #13547: Increased druid.worker.capacity in bin/start-druid script

2022-12-16 Thread GitBox
kfaraz commented on issue #13547: URL: https://github.com/apache/druid/issues/13547#issuecomment-1354868852 Thanks for the sugggestions, @gianm and for the fix, @findingrish ! I am closing this ticket as all 3 items have now been implemented. -- This is an automated message from the

[GitHub] [druid] kfaraz closed issue #13547: Increased druid.worker.capacity in bin/start-druid script

2022-12-16 Thread GitBox
kfaraz closed issue #13547: Increased druid.worker.capacity in bin/start-druid script URL: https://github.com/apache/druid/issues/13547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [druid] abhagraw commented on pull request #13535: MSQ s3 deep storage tests

2022-12-16 Thread GitBox
abhagraw commented on PR #13535: URL: https://github.com/apache/druid/pull/13535#issuecomment-1354748832 @paul-rogers Have merged `AbstractITSQLBasedIngestionTest` with `AbstractITBatchIndexTest` and moved all the s3 related code to `AbstractS3InputSourceParallelIndexTest`. This

[GitHub] [druid] kfaraz opened a new pull request, #13585: Suppress CVE-2022-45685 and CVE-2022-45693 from jettison-1.3

2022-12-16 Thread GitBox
kfaraz opened a new pull request, #13585: URL: https://github.com/apache/druid/pull/13585 Suppresses CVE-2022-45685 and CVE-2022-45693 from jettison-1.3 The jettison dependency is pulled by the cassandra-storage contrib extension. -- This is an automated message from the Apache Git

[GitHub] [druid] findingrish commented on issue #13547: Increased druid.worker.capacity in bin/start-druid script

2022-12-16 Thread GitBox
findingrish commented on issue #13547: URL: https://github.com/apache/druid/issues/13547#issuecomment-1354568760 This pr https://github.com/apache/druid/pull/13581 further refines the logic to compute task memory and count. -- This is an automated message from the Apache Git Service. To

[GitHub] [druid] kfaraz merged pull request #13582: [Backport] allow string dimension indexer to handle byte[] as base64 strings (#13573)

2022-12-16 Thread GitBox
kfaraz merged PR #13582: URL: https://github.com/apache/druid/pull/13582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] kfaraz merged pull request #13584: [Backport] Druid quickstart: Monotonic task count

2022-12-16 Thread GitBox
kfaraz merged PR #13584: URL: https://github.com/apache/druid/pull/13584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] findingrish opened a new pull request, #13584: [Backport] Druid quickstart: Monotonic task count

2022-12-16 Thread GitBox
findingrish opened a new pull request, #13584: URL: https://github.com/apache/druid/pull/13584 Backports #13583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [druid] findingrish closed pull request #13583: [Backport] Druid quickstart: Monotonic task count

2022-12-16 Thread GitBox
findingrish closed pull request #13583: [Backport] Druid quickstart: Monotonic task count URL: https://github.com/apache/druid/pull/13583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] findingrish opened a new pull request, #13583: [Backport] Druid quickstart: Monotonic task count

2022-12-16 Thread GitBox
findingrish opened a new pull request, #13583: URL: https://github.com/apache/druid/pull/13583 Backports #13581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

<    2   3   4   5   6   7   8   9   10   11   >