[GitHub] [incubator-druid] jihoonson commented on issue #6715: [Proposal] time granularity based materialized view

2019-10-18 Thread GitBox
jihoonson commented on issue #6715: [Proposal] time granularity based materialized view URL: https://github.com/apache/incubator-druid/issues/6715#issuecomment-543533742 This sounds cool. @pzhdfy are you still planning to do this?

[GitHub] [incubator-druid] stale[bot] commented on issue #6715: [Proposal] time granularity based materialized view

2019-10-18 Thread GitBox
stale[bot] commented on issue #6715: [Proposal] time granularity based materialized view URL: https://github.com/apache/incubator-druid/issues/6715#issuecomment-543533762 This issue is no longer marked as stale. This

[GitHub] [incubator-druid] stale[bot] commented on issue #6715: [Proposal] time granularity based materialized view

2019-10-17 Thread GitBox
stale[bot] commented on issue #6715: [Proposal] time granularity based materialized view URL: https://github.com/apache/incubator-druid/issues/6715#issuecomment-543522609 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #8547: Add `sys.supervisors` table to system tables

2019-10-17 Thread GitBox
surekhasaharan commented on a change in pull request #8547: Add `sys.supervisors` table to system tables URL: https://github.com/apache/incubator-druid/pull/8547#discussion_r336321281 ## File path: docs/operations/api-reference.md ## @@ -519,9 +519,25 @@ Returns a list of

[GitHub] [incubator-druid] FaxianZhao opened a new pull request #8694: bug fix for unit test

2019-10-17 Thread GitBox
FaxianZhao opened a new pull request #8694: bug fix for unit test URL: https://github.com/apache/incubator-druid/pull/8694 Unit test fix for DruidCoordinatorBalancerTest ### Description Some of current unit test will go thought decommissioning logic, but it should test general

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8547: Add `sys.supervisors` table to system tables

2019-10-17 Thread GitBox
jon-wei commented on a change in pull request #8547: Add `sys.supervisors` table to system tables URL: https://github.com/apache/incubator-druid/pull/8547#discussion_r336292901 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8547: Add `sys.supervisors` table to system tables

2019-10-17 Thread GitBox
jon-wei commented on a change in pull request #8547: Add `sys.supervisors` table to system tables URL: https://github.com/apache/incubator-druid/pull/8547#discussion_r336292349 ## File path: docs/operations/api-reference.md ## @@ -519,9 +519,25 @@ Returns a list of

[GitHub] [incubator-druid] woshifudayun commented on issue #8666: resolve resolveip command not found issue in integration test

2019-10-17 Thread GitBox
woshifudayun commented on issue #8666: resolve resolveip command not found issue in integration test URL: https://github.com/apache/incubator-druid/pull/8666#issuecomment-543445057 > Now all integration tests fail in CI, e. g. see

[GitHub] [incubator-druid] jon-wei commented on issue #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-17 Thread GitBox
jon-wei commented on issue #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#issuecomment-543436384 @jihoonson Addressed latest comments, also added a "round" parameter to the HLL sketch estimate postagg, and fixed

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-17 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r336286772 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-17 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r336286795 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-17 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r336286755 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8570: Auto compaction based on parallel indexing

2019-10-17 Thread GitBox
jihoonson commented on a change in pull request #8570: Auto compaction based on parallel indexing URL: https://github.com/apache/incubator-druid/pull/8570#discussion_r336283019 ## File path: core/src/main/java/org/apache/druid/data/input/SegmentsSplitHintSpec.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-17 Thread GitBox
jihoonson commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r336276162 ## File path: docs/querying/sql.md ## @@ -363,6 +366,44 @@ All 'array'

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-17 Thread GitBox
jihoonson commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r336276121 ## File path: docs/querying/sql.md ## @@ -363,6 +366,44 @@ All 'array'

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-17 Thread GitBox
jihoonson commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r336270404 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-17 Thread GitBox
jihoonson commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r336274502 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-17 Thread GitBox
jihoonson commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r336274374 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8570: Auto compaction based on parallel indexing

2019-10-17 Thread GitBox
clintropolis commented on a change in pull request #8570: Auto compaction based on parallel indexing URL: https://github.com/apache/incubator-druid/pull/8570#discussion_r336274338 ## File path: core/src/main/java/org/apache/druid/data/input/SegmentsSplitHintSpec.java ##

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #8547: Add `sys.supervisors` table to system tables

2019-10-17 Thread GitBox
surekhasaharan commented on a change in pull request #8547: Add `sys.supervisors` table to system tables URL: https://github.com/apache/incubator-druid/pull/8547#discussion_r336272925 ## File path: docs/operations/api-reference.md ## @@ -519,9 +519,25 @@ Returns a list of

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8547: Add `sys.supervisors` table to system tables

2019-10-17 Thread GitBox
jon-wei commented on a change in pull request #8547: Add `sys.supervisors` table to system tables URL: https://github.com/apache/incubator-druid/pull/8547#discussion_r336264520 ## File path: docs/operations/api-reference.md ## @@ -519,9 +519,25 @@ Returns a list of

[GitHub] [incubator-druid] clintropolis merged pull request #8624: Use targetRowsPerSegment for single-dim partitions

2019-10-17 Thread GitBox
clintropolis merged pull request #8624: Use targetRowsPerSegment for single-dim partitions URL: https://github.com/apache/incubator-druid/pull/8624 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8656: Message rejection absolute date

2019-10-17 Thread GitBox
jihoonson commented on a change in pull request #8656: Message rejection absolute date URL: https://github.com/apache/incubator-druid/pull/8656#discussion_r336251577 ## File path: docs/development/extensions-core/kafka-ingestion.md ## @@ -206,6 +206,7 @@ For Roaring

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8656: Message rejection absolute date

2019-10-17 Thread GitBox
himanshug commented on a change in pull request #8656: Message rejection absolute date URL: https://github.com/apache/incubator-druid/pull/8656#discussion_r336249455 ## File path: docs/development/extensions-core/kafka-ingestion.md ## @@ -206,6 +206,7 @@ For Roaring

[GitHub] [incubator-druid] himanshug commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-17 Thread GitBox
himanshug commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-543354123 > Motivation ... allowing the creation of a check that would make sure all runtime

[GitHub] [incubator-druid] jihoonson commented on issue #8061: Native parallel batch indexing with shuffle

2019-10-17 Thread GitBox
jihoonson commented on issue #8061: Native parallel batch indexing with shuffle URL: https://github.com/apache/incubator-druid/issues/8061#issuecomment-543348202 Hi @quenlang, I assume you're using hadoop indexing task since the parallel indexing task doesn't support single-dimension

[GitHub] [incubator-druid] himanshug merged pull request #7066: Support assign tasks to run on different categories of MiddleManagers

2019-10-17 Thread GitBox
himanshug merged pull request #7066: Support assign tasks to run on different categories of MiddleManagers URL: https://github.com/apache/incubator-druid/pull/7066 This is an automated message from the Apache Git Service.

[GitHub] [incubator-druid] jnaous commented on issue #8689: Update tutorial-kerberos-hadoop.md

2019-10-17 Thread GitBox
jnaous commented on issue #8689: Update tutorial-kerberos-hadoop.md URL: https://github.com/apache/incubator-druid/pull/8689#issuecomment-543319042 Haha wasn't me. Serves me right for trying to fix the docs :) I'll fix those. On Thu, Oct 17, 2019 at 11:56 AM Fangjin Yang

[GitHub] [incubator-druid] jon-wei commented on issue #8692: Issue 8678 Non-coordinator services are repeatedly logging JsonMappin…

2019-10-17 Thread GitBox
jon-wei commented on issue #8692: Issue 8678 Non-coordinator services are repeatedly logging JsonMappin… URL: https://github.com/apache/incubator-druid/pull/8692#issuecomment-543318481 Can you update the PR title and description to describe the fix, and remove "Issue 8678" from the title?

[GitHub] [incubator-druid] QiuMM commented on issue #7066: Support assign tasks to run on different categories of MiddleManagers

2019-10-17 Thread GitBox
QiuMM commented on issue #7066: Support assign tasks to run on different categories of MiddleManagers URL: https://github.com/apache/incubator-druid/pull/7066#issuecomment-543314696 The CI have passed, thank you very much @clintropolis .

[GitHub] [incubator-druid] fjy commented on issue #8689: Update tutorial-kerberos-hadoop.md

2019-10-17 Thread GitBox
fjy commented on issue #8689: Update tutorial-kerberos-hadoop.md URL: https://github.com/apache/incubator-druid/pull/8689#issuecomment-543314028 @jnaous I think this has a few spelling mistakes that the tests found This is an

[GitHub] [incubator-druid] fjy commented on issue #8691: Fix jackson property name for dropwizardemitterconfig

2019-10-17 Thread GitBox
fjy commented on issue #8691: Fix jackson property name for dropwizardemitterconfig URL: https://github.com/apache/incubator-druid/pull/8691#issuecomment-543314254 @nishantmonu51 I think this is failing UT This is an

[GitHub] [incubator-druid] fjy merged pull request #8693: Update segments.md

2019-10-17 Thread GitBox
fjy merged pull request #8693: Update segments.md URL: https://github.com/apache/incubator-druid/pull/8693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-druid] jnaous opened a new pull request #8693: Update segments.md

2019-10-17 Thread GitBox
jnaous opened a new pull request #8693: Update segments.md URL: https://github.com/apache/incubator-druid/pull/8693 Make bullet numbers clearer with parantheses, fix last reference to 2 being interpreted as a bullet point.

[GitHub] [incubator-druid] mohammadjkhan opened a new pull request #8692: Issue 8678 Non-coordinator services are repeatedly logging JsonMappin…

2019-10-17 Thread GitBox
mohammadjkhan opened a new pull request #8692: Issue 8678 Non-coordinator services are repeatedly logging JsonMappin… URL: https://github.com/apache/incubator-druid/pull/8692 …gException when using druid-basic-security extension with an authenticator that has no users setup

[GitHub] [incubator-druid] nishantmonu51 opened a new pull request #8691: Fix jackson property name for dropwizardemitterconfig

2019-10-17 Thread GitBox
nishantmonu51 opened a new pull request #8691: Fix jackson property name for dropwizardemitterconfig URL: https://github.com/apache/incubator-druid/pull/8691 Fix jackson property name and add test This was causing below exception - ``` JsonConfigurator requires Jackson-annotated

[GitHub] [incubator-druid] quenlang commented on issue #8061: Native parallel batch indexing with shuffle

2019-10-17 Thread GitBox
quenlang commented on issue #8061: Native parallel batch indexing with shuffle URL: https://github.com/apache/incubator-druid/issues/8061#issuecomment-543125241 > Hi @quenlang, you should be able to do it. An example tuningConfig could be > > ```json > "tuningConfig" : { >

[GitHub] [incubator-druid] mr0al closed issue #8674: Druid coordinator dynamic compaction failure

2019-10-17 Thread GitBox
mr0al closed issue #8674: Druid coordinator dynamic compaction failure URL: https://github.com/apache/incubator-druid/issues/8674 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-druid] mr0al commented on issue #8674: Druid coordinator dynamic compaction failure

2019-10-17 Thread GitBox
mr0al commented on issue #8674: Druid coordinator dynamic compaction failure URL: https://github.com/apache/incubator-druid/issues/8674#issuecomment-543117037 Sorry for delay - it was local. Changing to remote seems to fix it.. I see https://github.com/apache/incubator-druid/issues/8683

[GitHub] [incubator-druid] stale[bot] commented on issue #6723: Druid-redis does not provide a historical buffer interface?

2019-10-17 Thread GitBox
stale[bot] commented on issue #6723: Druid-redis does not provide a historical buffer interface? URL: https://github.com/apache/incubator-druid/issues/6723#issuecomment-543111670 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires

[GitHub] [incubator-druid] stale[bot] closed issue #6723: Druid-redis does not provide a historical buffer interface?

2019-10-17 Thread GitBox
stale[bot] closed issue #6723: Druid-redis does not provide a historical buffer interface? URL: https://github.com/apache/incubator-druid/issues/6723 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-druid] denever commented on a change in pull request #8656: Message rejection absolute date

2019-10-17 Thread GitBox
denever commented on a change in pull request #8656: Message rejection absolute date URL: https://github.com/apache/incubator-druid/pull/8656#discussion_r335894524 ## File path: docs/development/extensions-core/kafka-ingestion.md ## @@ -206,6 +206,7 @@ For Roaring

[GitHub] [incubator-druid] liutang123 commented on issue #8690: KIS task fail when set segmentGranularity with timezone

2019-10-17 Thread GitBox
liutang123 commented on issue #8690: KIS task fail when set segmentGranularity with timezone URL: https://github.com/apache/incubator-druid/issues/8690#issuecomment-543050100 cc @gaodayue This is an automated message from

[GitHub] [incubator-druid] liutang123 opened a new issue #8690: KIS task fail when set segmentGranularity with timezone

2019-10-17 Thread GitBox
liutang123 opened a new issue #8690: KIS task fail when set segmentGranularity with timezone URL: https://github.com/apache/incubator-druid/issues/8690 ### Affected Version 0.15.1-incubating ### Description When submit a KIS Supervisor with segmentGranularity configured

[GitHub] [incubator-druid] jnaous opened a new pull request #8689: Update tutorial-kerberos-hadoop.md

2019-10-16 Thread GitBox
jnaous opened a new pull request #8689: Update tutorial-kerberos-hadoop.md URL: https://github.com/apache/incubator-druid/pull/8689 Fix up what looks like a bad merge. This is an automated message from the Apache Git

[GitHub] [incubator-druid] jnaous commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
jnaous commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542970766 Something like that could be implemented by making the request async: when a check

[GitHub] [incubator-druid] fjy closed issue #8673: InlineFirehose does not work with index_parallel ingestion

2019-10-16 Thread GitBox
fjy closed issue #8673: InlineFirehose does not work with index_parallel ingestion URL: https://github.com/apache/incubator-druid/issues/8673 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] fjy merged pull request #8682: implement FiniteFirehoseFactory in InlineFirehose

2019-10-16 Thread GitBox
fjy merged pull request #8682: implement FiniteFirehoseFactory in InlineFirehose URL: https://github.com/apache/incubator-druid/pull/8682 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8688: Remove commit() method Firehose

2019-10-16 Thread GitBox
lgtm-com[bot] commented on issue #8688: Remove commit() method Firehose URL: https://github.com/apache/incubator-druid/pull/8688#issuecomment-542968321 This pull request **fixes 2 alerts** when merging 6038515d62b8271de839f8c5f9c59d8a002382c2 into 89ce6384f57cb13c776cfcc9fc7b97126b834fac

[GitHub] [incubator-druid] vogievetsky commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
vogievetsky commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542968137 Yeah just to be clear I never pictured it to be a proxy to an arbitrary

[GitHub] [incubator-druid] gianm merged pull request #8687: Update tutorial-rollup.md

2019-10-16 Thread GitBox
gianm merged pull request #8687: Update tutorial-rollup.md URL: https://github.com/apache/incubator-druid/pull/8687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-druid] gianm commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
gianm commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542964407 > Also there is already an open proxy in the sampler (http firehose). I think it's

[GitHub] [incubator-druid] vogievetsky commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
vogievetsky commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542959319 The proxy could only forward to Druid nodes themselves so it is not open to

[GitHub] [incubator-druid] jihoonson opened a new pull request #8688: Remove commit() method Firehose

2019-10-16 Thread GitBox
jihoonson opened a new pull request #8688: Remove commit() method Firehose URL: https://github.com/apache/incubator-druid/pull/8688 ### Description `commit()` method was used only by the ancient kafka firehose which was removed in https://github.com/apache/incubator-druid/pull/8020.

[GitHub] [incubator-druid] JulianJaffePinterest commented on issue #8685: Allow bootstrap.servers to be provided via a PasswordProvider for Kafka Ingestion

2019-10-16 Thread GitBox
JulianJaffePinterest commented on issue #8685: Allow bootstrap.servers to be provided via a PasswordProvider for Kafka Ingestion URL: https://github.com/apache/incubator-druid/issues/8685#issuecomment-542942083 I agree that allowing most properties to be specified via a Provider makes

[GitHub] [incubator-druid] jnaous opened a new pull request #8687: Update tutorial-rollup.md

2019-10-16 Thread GitBox
jnaous opened a new pull request #8687: Update tutorial-rollup.md URL: https://github.com/apache/incubator-druid/pull/8687 At this point there hasn't yet been an explanation in the tutorial of what "segments" are This is

[GitHub] [incubator-druid] aditya-r-m commented on issue #8682: implement FiniteFirehoseFactory in InlineFirehose

2019-10-16 Thread GitBox
aditya-r-m commented on issue #8682: implement FiniteFirehoseFactory in InlineFirehose URL: https://github.com/apache/incubator-druid/pull/8682#issuecomment-542927214 @jihoonson implemented the suggested updates. This is an

[GitHub] [incubator-druid] xvrl commented on a change in pull request #6702: Add SelfDiscoveryResource; rename org.apache.druid.discovery.NodeType to NodeRole

2019-10-16 Thread GitBox
xvrl commented on a change in pull request #6702: Add SelfDiscoveryResource; rename org.apache.druid.discovery.NodeType to NodeRole URL: https://github.com/apache/incubator-druid/pull/6702#discussion_r335746585 ## File path: integration-tests/docker/docker-entrypoint.sh ##

[GitHub] [incubator-druid] gianm edited a comment on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
gianm edited a comment on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542903549 > It might be better for the servers to all self-check themselves, and report the

[GitHub] [incubator-druid] gianm commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
gianm commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542903549 > It might be better for the servers to all self-check themselves, and report the

[GitHub] [incubator-druid] gianm commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
gianm commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542903041 This sounds like an open proxy and therefore I am scared of it. In the context of

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718988 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718831 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718915 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718720 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718425 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718521 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718581 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718056 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718002 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335717239 ## File path: docs/querying/sql.md ## @@ -363,6 +366,44 @@ All 'array' references

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335716800 ## File path: docs/querying/sql.md ## @@ -363,6 +366,44 @@ All 'array' references

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335716427 ## File path: docs/querying/sql.md ## @@ -363,6 +366,44 @@ All 'array' references

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335716107 ## File path: docs/querying/sql.md ## @@ -363,6 +366,44 @@ All 'array' references

[GitHub] [incubator-druid] jihoonson commented on issue #8663: Kafka indexing service duplicate entry exception in druid_pendingSegments

2019-10-16 Thread GitBox
jihoonson commented on issue #8663: Kafka indexing service duplicate entry exception in druid_pendingSegments URL: https://github.com/apache/incubator-druid/issues/8663#issuecomment-542881773 Hmm, the entries in `druid_pendingSegments` table are never updated but should be reused if

[GitHub] [incubator-druid] clintropolis commented on issue #7066: Support assign tasks to run on different categories of MiddleManagers

2019-10-16 Thread GitBox
clintropolis commented on issue #7066: Support assign tasks to run on different categories of MiddleManagers URL: https://github.com/apache/incubator-druid/pull/7066#issuecomment-542879965 >@clintropolis It seems didn't work. Oops, I guess you added it to the wrong part of the file

[GitHub] [incubator-druid] vogievetsky opened a new issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
vogievetsky opened a new issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686 ### Description It would be amazing if the router's management proxy could proxy to any node in the

[GitHub] [incubator-druid] gianm commented on issue #8685: Allow bootstrap.servers to be provided via a PasswordProvider for Kafka Ingestion

2019-10-16 Thread GitBox
gianm commented on issue #8685: Allow bootstrap.servers to be provided via a PasswordProvider for Kafka Ingestion URL: https://github.com/apache/incubator-druid/issues/8685#issuecomment-542863946 Maybe it'd make sense to allow this for _any_ property?

[GitHub] [incubator-druid] JulianJaffePinterest opened a new issue #8685: Allow bootstrap.servers to be provided via a PasswordProvider for Kafka Ingestion

2019-10-16 Thread GitBox
JulianJaffePinterest opened a new issue #8685: Allow bootstrap.servers to be provided via a PasswordProvider for Kafka Ingestion URL: https://github.com/apache/incubator-druid/issues/8685 ### Description Currently, the `consumerProperties` map in a KafkaSupervisorIOConfig can use

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8656: Message rejection absolute date

2019-10-16 Thread GitBox
jihoonson commented on a change in pull request #8656: Message rejection absolute date URL: https://github.com/apache/incubator-druid/pull/8656#discussion_r335616355 ## File path: docs/development/extensions-core/kafka-ingestion.md ## @@ -206,6 +206,7 @@ For Roaring

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335598648 ## File path: processing/src/main/java/org/apache/druid/query/topn/PooledTopNAlgorithm.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335591855 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335581582 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/query/ScanBenchmark.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335596027 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/hyperloglog/HyperUniquesSerde.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335583876 ## File path: core/src/main/java/org/apache/druid/utils/JvmUtils.java ## @@ -50,11 +50,12 @@ public

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335585792 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335590256 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r33559 ## File path: processing/src/test/java/org/apache/druid/query/extraction/MapLookupExtractionFnSerDeTest.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335585321 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335587140 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335595612 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335591115 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335582594 ## File path: core/src/main/java/org/apache/druid/common/config/NullHandling.java ## @@ -50,6 +50,7

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335601766 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335599463 ## File path: processing/src/main/java/org/apache/druid/segment/data/CompressionFactory.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335595130 ## File path: indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskLifecycleTest.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335600321 ## File path: processing/src/test/java/org/apache/druid/query/filter/IntervalDimFilterTest.java ##

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335583652 ## File path: core/src/main/java/org/apache/druid/java/util/emitter/EmittingLogger.java ## @@ -40,6

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335600158 ## File path: processing/src/test/java/org/apache/druid/query/filter/InDimFilterSerDesrTest.java ##

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335590033 ## File path:

  1   2   3   4   5   6   7   8   9   10   >