clintropolis commented on pull request #10070: URL: https://github.com/apache/druid/pull/10070#issuecomment-652065443
> I feel we should mention this in the release notes since it modifies the default behavior for druid.server.maxSize. For clusters having historicals with this property set to zero, the coordinator will longer assign segments to them. I've added clarification to the docs via #10105 Thanks for bringing this up, am working on draft of release notes right now and will be sure to add this. I don't think it is technically a change though, as far as I can tell it was always intended that the balancer uses the size historicals advertise in order to make segment placement decisions, just some flaws were causing the coordinator to assign them anyway I guess? I can't imagine the balancer was otherwise working if size was set to 0, since size is used pretty heavily to determine what can be moved and to where. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
