clintropolis opened a new pull request #8535: fix caching bug with multi-column group-by URL: https://github.com/apache/incubator-druid/pull/8535 This PR fixes an issue with the `GroupByQueryToolchest` cache strategy method that pulls values from the cache and translates them back into `ResultRow`, where an omission of incrementing a counter caused only the _last_ dimension column value to be put in the _first_ dimension position. Prior to this fix the added test would fail with ``` java.lang.AssertionError: Expected :ResultRow{row=[123, val1, fooval1, 1, Pair{lhs=123, rhs=val1}]} Actual :ResultRow{row=[123, fooval1, null, 1, Pair{lhs=123, rhs=val1}]} ``` <hr> This PR has: - [x] been self-reviewed. - [x] added unit tests or modified existing tests to cover new code paths.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
