[GitHub] [incubator-druid] denever commented on issue #8656: Message rejection absolute date

2019-10-16 Thread GitBox
denever commented on issue #8656: Message rejection absolute date
URL: https://github.com/apache/incubator-druid/pull/8656#issuecomment-542760791
 
 
   Travis is blocked, has passed, but here is still pending


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



[GitHub] [incubator-druid] denever commented on issue #8656: Message rejection absolute date

2019-10-16 Thread GitBox
denever commented on issue #8656: Message rejection absolute date
URL: https://github.com/apache/incubator-druid/pull/8656#issuecomment-542636264
 
 
   > thanks, can you also update the necessary documentation and mention the 
precedence of `lateMessageRejectionStartDateTime` vs 
`lateMessageRejectionPeriod` or maybe there should be some check ensuring user 
doesn't specify both as that is most likely an user error.
   
   I've update documentation and mentioned the precedence


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



[GitHub] [incubator-druid] denever commented on issue #8656: Message rejection absolute date

2019-10-14 Thread GitBox
denever commented on issue #8656: Message rejection absolute date
URL: https://github.com/apache/incubator-druid/pull/8656#issuecomment-541591629
 
 
   > can you please describe your use case for this feature ?
   > 
   > also fill appropriate items in PR checklist that cover things like whether 
this change is tested on a cluster etc ?
   
   Done!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org