esevastyanov opened a new pull request #7459: Fix Kafka consumer non-thread-safe close URL: https://github.com/apache/incubator-druid/pull/7459 #7153 Isolated a supplier's close by removing its invocation from a non-notice-processing thread. There were two `recordSupplier`'s stop call: first (removed) was in `SeekableStreamSupervisor::stop` method, second is in `ShutdownNotice::handle` method. The first one was redundant since `SeekableStreamSupervisor::stop` method is used to add `ShutdownNotice` to a notice queue if the `recordSupplier` was started. It also was incorrect because it wasn't under `recordSupplierLock`. The issue might be reproduced (nondeterministically) by creating and terminating Kafka supervisors via overlord's http calls: ``` for i in {1..50}; do \ curl -X POST -H 'Content-Type: application/json' -d @quickstart/tutorial/wikipedia-kafka-supervisor.json http://<OVERLORD_IP>:<OVERLORD_PORT>/druid/indexer/v1/supervisor && \ sleep $((1 + $RANDOM % 10)) && \ curl http://<OVERLORD_IP>:<OVERLORD_PORT>/druid/indexer/v1/supervisor?full && \ curl -X POST http://<OVERLORD_IP>:<OVERLORD_PORT>/druid/indexer/v1/supervisor/terminateAll; \ done ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
