leventov opened a new issue #8501: Use fastutil's LongSet in `Sink.dedupSet`
URL: https://github.com/apache/incubator-druid/issues/8501
 
 
   FYI @kaijianding 
   
   Also, consider using a proven (SMHasher-wise) hashing algorithm such as 
xxHash (implemented e. g. in 
https://github.com/OpenHFT/Zero-Allocation-Hashing) rather than BKDRHash, which 
seems like a marginal improvement (if improvement at all) over the String's 
default hash code (the only difference is using 131 instead of 31 as a 
multiplication constant). While String's default hash function is widely 
considered a bad hashing algorithm.
   
   Related: #6861

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to