[GitHub] KenjiTakahashi commented on issue #6125: Fix appenderator_realtime creating shards bigger by 1 than maxRowsPerSegment

2018-08-09 Thread GitBox
KenjiTakahashi commented on issue #6125: Fix appenderator_realtime creating shards bigger by 1 than maxRowsPerSegment URL: https://github.com/apache/incubator-druid/pull/6125#issuecomment-411905193 Hm, we've got OOM in one of the groupby tests it seems. Looks unrelated?

[GitHub] KenjiTakahashi commented on issue #6125: Fix appenderator_realtime creating shards bigger by 1 than maxRowsPerSegment

2018-08-09 Thread GitBox
KenjiTakahashi commented on issue #6125: Fix appenderator_realtime creating shards bigger by 1 than maxRowsPerSegment URL: https://github.com/apache/incubator-druid/pull/6125#issuecomment-411730852 @clintropolis I see that you've moved this check to a separate method, so this fix (as-is)