[GitHub] josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-09-21 Thread GitBox
josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-423473524 What I came up with was this: Firstly a new interface to handle reading a file and emitting rows that can

[GitHub] josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-08-02 Thread GitBox
josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-410030450 One thing that has become apparent is the `StringInputRowParser` is a bit of a bad citizen. It extends

[GitHub] josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-07-28 Thread GitBox
josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-408612801 @jihoonson we actually make use of parse batch support also. That said `InputRowParser` should still

[GitHub] josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-07-28 Thread GitBox
josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-408612801 @jihoonson we actually make use of parse batch support also. That said `InputRowParser` should still

[GitHub] josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-07-28 Thread GitBox
josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-408612801 @jihoonson we actually make use of parse batch support also. That said InputRowParser should still