This is an automated email from the ASF dual-hosted git repository. huxing pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
The following commit(s) were added to refs/heads/master by this push: new 628ad77 Optimize getExtensionClass method. (#2788) 628ad77 is described below commit 628ad777b963fb450873a5fd38eebf99002bbc68 Author: 时无两丶 <442367...@qq.com> AuthorDate: Thu Dec 6 22:47:27 2018 +0800 Optimize getExtensionClass method. (#2788) Just return the class instead of throwing exception. --- .../org/apache/dubbo/common/extension/ExtensionLoader.java | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java b/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java index 31f72e6..49a7bdb 100644 --- a/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java +++ b/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java @@ -346,12 +346,8 @@ public class ExtensionLoader<T> { if (name == null || name.length() == 0) { throw new IllegalArgumentException("Extension name == null"); } - try { - this.getExtensionClass(name); - return true; - } catch (Throwable t) { - return false; - } + Class<?> c = this.getExtensionClass(name); + return c != null; } public Set<String> getSupportedExtensions() { @@ -565,11 +561,7 @@ public class ExtensionLoader<T> { if (name == null) { throw new IllegalArgumentException("Extension name == null"); } - Class<?> clazz = getExtensionClasses().get(name); - if (clazz == null) { - throw new IllegalStateException("No such extension \"" + name + "\" for " + type.getName() + "!"); - } - return clazz; + return getExtensionClasses().get(name); } private Map<String, Class<?>> getExtensionClasses() {