This is an automated email from the ASF dual-hosted git repository.

wangxin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/master by this push:
     new 78aea48  [Dubbo-4183] Fix unstable tests in ConditionRouterTest  
(#4226)
78aea48 is described below

commit 78aea48cd710fc797b69c4eb2176f72554be3fd7
Author: Huang YunKun <hty...@gmail.com>
AuthorDate: Thu Jun 6 22:52:44 2019 +0800

    [Dubbo-4183] Fix unstable tests in ConditionRouterTest  (#4226)
---
 .../router/condition/ConditionRouterTest.java      | 109 ++++++++++-----------
 .../store/etcd/EtcdMetadataReportTest.java         |   2 +
 2 files changed, 56 insertions(+), 55 deletions(-)

diff --git 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/router/condition/ConditionRouterTest.java
 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/router/condition/ConditionRouterTest.java
index a88a759..ba400f0 100644
--- 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/router/condition/ConditionRouterTest.java
+++ 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/router/condition/ConditionRouterTest.java
@@ -18,7 +18,6 @@ package org.apache.dubbo.rpc.cluster.router.condition;
 
 
 import org.apache.dubbo.common.URL;
-import org.apache.dubbo.common.utils.NetUtils;
 import org.apache.dubbo.rpc.Invocation;
 import org.apache.dubbo.rpc.Invoker;
 import org.apache.dubbo.rpc.RpcInvocation;
@@ -37,7 +36,7 @@ import static 
org.apache.dubbo.rpc.cluster.Constants.FORCE_KEY;
 import static org.apache.dubbo.rpc.cluster.Constants.RULE_KEY;
 
 public class ConditionRouterTest {
-
+    private static final String LOCAL_HOST = "127.0.0.1";
     private URL SCRIPT_URL = 
URL.valueOf("condition://0.0.0.0/com.foo.BarService");
 
     @BeforeAll
@@ -90,9 +89,9 @@ public class ConditionRouterTest {
         List<Invoker<String>> invokers = new ArrayList<Invoker<String>>();
         Invoker<String> invoker1 = new MockInvoker<String>(URL.valueOf(
                 
"dubbo://10.20.3.3:20880/com.foo.BarService?default.serialization=fastjson"));
-        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost()
+        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST
                 + ":20880/com.foo.BarService"));
-        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost()
+        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST
                 + ":20880/com.foo.BarService"));
         invokers.add(invoker1);
         invokers.add(invoker2);
@@ -102,32 +101,32 @@ public class ConditionRouterTest {
         System.err.println(invoker3.getUrl().getAddress());
 
         Router router1 = new ConditionRouterFactory().getRouter(getRouteUrl(
-                "host = " + NetUtils.getLocalHost() + " => " + " host = 
10.20.3.3").addParameter(FORCE_KEY,
+                "host = " + LOCAL_HOST + " => " + " host = 
10.20.3.3").addParameter(FORCE_KEY,
                 String.valueOf(true)));
         Router router2 = new ConditionRouterFactory().getRouter(getRouteUrl(
-                "host = " + NetUtils.getLocalHost() + " => " + " host = 
10.20.3.* & host != 10.20.3.3").addParameter(
+                "host = " + LOCAL_HOST + " => " + " host = 10.20.3.* & host != 
10.20.3.3").addParameter(
                 FORCE_KEY, String.valueOf(true)));
         Router router3 = new ConditionRouterFactory().getRouter(getRouteUrl(
-                "host = " + NetUtils.getLocalHost() + " => " + " host = 
10.20.3.3  & host != 10.20.3.3").addParameter(
+                "host = " + LOCAL_HOST + " => " + " host = 10.20.3.3  & host 
!= 10.20.3.3").addParameter(
                 FORCE_KEY, String.valueOf(true)));
         Router router4 = new ConditionRouterFactory().getRouter(getRouteUrl(
-                "host = " + NetUtils.getLocalHost() + " => " + " host = 
10.20.3.2,10.20.3.3,10.20.3.4").addParameter(
+                "host = " + LOCAL_HOST + " => " + " host = 
10.20.3.2,10.20.3.3,10.20.3.4").addParameter(
                 FORCE_KEY, String.valueOf(true)));
         Router router5 = new ConditionRouterFactory().getRouter(getRouteUrl(
-                "host = " + NetUtils.getLocalHost() + " => " + " host != 
10.20.3.3").addParameter(FORCE_KEY,
+                "host = " + LOCAL_HOST + " => " + " host != 
10.20.3.3").addParameter(FORCE_KEY,
                 String.valueOf(true)));
         Router router6 = new ConditionRouterFactory().getRouter(getRouteUrl(
-                "host = " + NetUtils.getLocalHost() + " => " + " serialization 
= fastjson").addParameter(
+                "host = " + LOCAL_HOST + " => " + " serialization = 
fastjson").addParameter(
                 FORCE_KEY, String.valueOf(true)));
 
 
 
-        List<Invoker<String>> filteredInvokers1 = router1.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
-        List<Invoker<String>> filteredInvokers2 = router2.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
-        List<Invoker<String>> filteredInvokers3 = router3.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
-        List<Invoker<String>> filteredInvokers4 = router4.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
-        List<Invoker<String>> filteredInvokers5 = router5.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
-        List<Invoker<String>> filteredInvokers6 = router6.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
+        List<Invoker<String>> filteredInvokers1 = router1.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
+        List<Invoker<String>> filteredInvokers2 = router2.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
+        List<Invoker<String>> filteredInvokers3 = router3.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
+        List<Invoker<String>> filteredInvokers4 = router4.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
+        List<Invoker<String>> filteredInvokers5 = router5.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
+        List<Invoker<String>> filteredInvokers6 = router6.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
         Assertions.assertEquals(1, filteredInvokers1.size());
         Assertions.assertEquals(0, filteredInvokers2.size());
         Assertions.assertEquals(0, filteredInvokers3.size());
@@ -163,74 +162,74 @@ public class ConditionRouterTest {
         // Test filter condition
         List<Invoker<String>> invokers = new ArrayList<Invoker<String>>();
         Invoker<String> invoker1 = new 
MockInvoker<String>(URL.valueOf("dubbo://10.20.3.3:20880/com.foo.BarService"));
-        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost()
+        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST
                 + ":20880/com.foo.BarService"));
-        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost()
+        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST
                 + ":20880/com.foo.BarService"));
         invokers.add(invoker1);
         invokers.add(invoker2);
         invokers.add(invoker3);
 
         Router router4 = new ConditionRouterFactory().getRouter(getRouteUrl(
-                "host = " + NetUtils.getLocalHost() + " & methods = getFoo => 
" + " host = 10.20.3.3").addParameter(
+                "host = " + LOCAL_HOST + " & methods = getFoo => " + " host = 
10.20.3.3").addParameter(
                 FORCE_KEY, String.valueOf(true)));
         List<Invoker<String>> filteredInvokers1 = router4.route(invokers,
-                URL.valueOf("consumer://" + NetUtils.getLocalHost() + 
"/com.foo.BarService"), invocation);
+                URL.valueOf("consumer://" + LOCAL_HOST + 
"/com.foo.BarService"), invocation);
         Assertions.assertEquals(1, filteredInvokers1.size());
 
         Router router5 = new ConditionRouterFactory().getRouter(getRouteUrl(
-                "host = " + NetUtils.getLocalHost() + " & methods = 
unvalidmethod => " + " host = 10.20.3.3")
+                "host = " + LOCAL_HOST + " & methods = unvalidmethod => " + " 
host = 10.20.3.3")
                 .addParameter(FORCE_KEY, String.valueOf(true)));
         List<Invoker<String>> filteredInvokers2 = router5.route(invokers,
-                URL.valueOf("consumer://" + NetUtils.getLocalHost() + 
"/com.foo.BarService"), invocation);
+                URL.valueOf("consumer://" + LOCAL_HOST + 
"/com.foo.BarService"), invocation);
         Assertions.assertEquals(3, filteredInvokers2.size());
         // Request a non-exists method
     }
 
     @Test
     public void testRoute_ReturnFalse() {
-        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + 
NetUtils.getLocalHost() + " => false"));
+        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + LOCAL_HOST + " => 
false"));
         List<Invoker<String>> invokers = new ArrayList<Invoker<String>>();
         invokers.add(new MockInvoker<String>());
         invokers.add(new MockInvoker<String>());
         invokers.add(new MockInvoker<String>());
-        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
+        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
         Assertions.assertEquals(0, filteredInvokers.size());
     }
 
     @Test
     public void testRoute_ReturnEmpty() {
-        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + 
NetUtils.getLocalHost() + " => "));
+        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + LOCAL_HOST + " => 
"));
         List<Invoker<String>> invokers = new ArrayList<Invoker<String>>();
         invokers.add(new MockInvoker<String>());
         invokers.add(new MockInvoker<String>());
         invokers.add(new MockInvoker<String>());
-        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
+        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
         Assertions.assertEquals(0, filteredInvokers.size());
     }
 
     @Test
     public void testRoute_ReturnAll() {
-        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + 
NetUtils.getLocalHost() + " => " + " host = " + NetUtils.getLocalHost()));
+        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + LOCAL_HOST + " => " 
+ " host = " + LOCAL_HOST));
         List<Invoker<String>> invokers = new ArrayList<Invoker<String>>();
-        invokers.add(new MockInvoker<String>(URL.valueOf("dubbo://" + 
NetUtils.getLocalHost() + ":20880/com.foo.BarService")));
-        invokers.add(new MockInvoker<String>(URL.valueOf("dubbo://" + 
NetUtils.getLocalHost() + ":20880/com.foo.BarService")));
-        invokers.add(new MockInvoker<String>(URL.valueOf("dubbo://" + 
NetUtils.getLocalHost() + ":20880/com.foo.BarService")));
-        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
+        invokers.add(new MockInvoker<String>(URL.valueOf("dubbo://" + 
LOCAL_HOST + ":20880/com.foo.BarService")));
+        invokers.add(new MockInvoker<String>(URL.valueOf("dubbo://" + 
LOCAL_HOST + ":20880/com.foo.BarService")));
+        invokers.add(new MockInvoker<String>(URL.valueOf("dubbo://" + 
LOCAL_HOST + ":20880/com.foo.BarService")));
+        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
         Assertions.assertEquals(invokers, filteredInvokers);
     }
 
     @Test
     public void testRoute_HostFilter() {
-        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + 
NetUtils.getLocalHost() + " => " + " host = " + NetUtils.getLocalHost()));
+        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + LOCAL_HOST + " => " 
+ " host = " + LOCAL_HOST));
         List<Invoker<String>> invokers = new ArrayList<Invoker<String>>();
         Invoker<String> invoker1 = new 
MockInvoker<String>(URL.valueOf("dubbo://10.20.3.3:20880/com.foo.BarService"));
-        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost() + 
":20880/com.foo.BarService"));
-        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost() + 
":20880/com.foo.BarService"));
+        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST + 
":20880/com.foo.BarService"));
+        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST + 
":20880/com.foo.BarService"));
         invokers.add(invoker1);
         invokers.add(invoker2);
         invokers.add(invoker3);
-        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
+        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
         Assertions.assertEquals(2, filteredInvokers.size());
         Assertions.assertEquals(invoker2, filteredInvokers.get(0));
         Assertions.assertEquals(invoker3, filteredInvokers.get(1));
@@ -238,15 +237,15 @@ public class ConditionRouterTest {
 
     @Test
     public void testRoute_Empty_HostFilter() {
-        Router router = new ConditionRouterFactory().getRouter(getRouteUrl(" 
=> " + " host = " + NetUtils.getLocalHost()));
+        Router router = new ConditionRouterFactory().getRouter(getRouteUrl(" 
=> " + " host = " + LOCAL_HOST));
         List<Invoker<String>> invokers = new ArrayList<Invoker<String>>();
         Invoker<String> invoker1 = new 
MockInvoker<String>(URL.valueOf("dubbo://10.20.3.3:20880/com.foo.BarService"));
-        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost() + 
":20880/com.foo.BarService"));
-        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost() + 
":20880/com.foo.BarService"));
+        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST + 
":20880/com.foo.BarService"));
+        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST + 
":20880/com.foo.BarService"));
         invokers.add(invoker1);
         invokers.add(invoker2);
         invokers.add(invoker3);
-        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
+        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
         Assertions.assertEquals(2, filteredInvokers.size());
         Assertions.assertEquals(invoker2, filteredInvokers.get(0));
         Assertions.assertEquals(invoker3, filteredInvokers.get(1));
@@ -254,15 +253,15 @@ public class ConditionRouterTest {
 
     @Test
     public void testRoute_False_HostFilter() {
-        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("true => " + " host = " + 
NetUtils.getLocalHost()));
+        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("true => " + " host = " + 
LOCAL_HOST));
         List<Invoker<String>> invokers = new ArrayList<Invoker<String>>();
         Invoker<String> invoker1 = new 
MockInvoker<String>(URL.valueOf("dubbo://10.20.3.3:20880/com.foo.BarService"));
-        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost() + 
":20880/com.foo.BarService"));
-        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost() + 
":20880/com.foo.BarService"));
+        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST + 
":20880/com.foo.BarService"));
+        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST + 
":20880/com.foo.BarService"));
         invokers.add(invoker1);
         invokers.add(invoker2);
         invokers.add(invoker3);
-        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
+        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
         Assertions.assertEquals(2, filteredInvokers.size());
         Assertions.assertEquals(invoker2, filteredInvokers.get(0));
         Assertions.assertEquals(invoker3, filteredInvokers.get(1));
@@ -270,15 +269,15 @@ public class ConditionRouterTest {
 
     @Test
     public void testRoute_Placeholder() {
-        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + 
NetUtils.getLocalHost() + " => " + " host = $host"));
+        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + LOCAL_HOST + " => " 
+ " host = $host"));
         List<Invoker<String>> invokers = new ArrayList<Invoker<String>>();
         Invoker<String> invoker1 = new 
MockInvoker<String>(URL.valueOf("dubbo://10.20.3.3:20880/com.foo.BarService"));
-        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost() + 
":20880/com.foo.BarService"));
-        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost() + 
":20880/com.foo.BarService"));
+        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST + 
":20880/com.foo.BarService"));
+        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST + 
":20880/com.foo.BarService"));
         invokers.add(invoker1);
         invokers.add(invoker2);
         invokers.add(invoker3);
-        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
+        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
         Assertions.assertEquals(2, filteredInvokers.size());
         Assertions.assertEquals(invoker2, filteredInvokers.get(0));
         Assertions.assertEquals(invoker3, filteredInvokers.get(1));
@@ -286,29 +285,29 @@ public class ConditionRouterTest {
 
     @Test
     public void testRoute_NoForce() {
-        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + 
NetUtils.getLocalHost() + " => " + " host = 1.2.3.4"));
+        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + LOCAL_HOST + " => " 
+ " host = 1.2.3.4"));
         List<Invoker<String>> invokers = new ArrayList<Invoker<String>>();
         Invoker<String> invoker1 = new 
MockInvoker<String>(URL.valueOf("dubbo://10.20.3.3:20880/com.foo.BarService"));
-        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost() + 
":20880/com.foo.BarService"));
-        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost() + 
":20880/com.foo.BarService"));
+        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST + 
":20880/com.foo.BarService"));
+        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST + 
":20880/com.foo.BarService"));
         invokers.add(invoker1);
         invokers.add(invoker2);
         invokers.add(invoker3);
-        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
+        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
         Assertions.assertEquals(invokers, filteredInvokers);
     }
 
     @Test
     public void testRoute_Force() {
-        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + 
NetUtils.getLocalHost() + " => " + " host = 1.2.3.4").addParameter(FORCE_KEY, 
String.valueOf(true)));
+        Router router = new 
ConditionRouterFactory().getRouter(getRouteUrl("host = " + LOCAL_HOST + " => " 
+ " host = 1.2.3.4").addParameter(FORCE_KEY, String.valueOf(true)));
         List<Invoker<String>> invokers = new ArrayList<Invoker<String>>();
         Invoker<String> invoker1 = new 
MockInvoker<String>(URL.valueOf("dubbo://10.20.3.3:20880/com.foo.BarService"));
-        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost() + 
":20880/com.foo.BarService"));
-        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + NetUtils.getLocalHost() + 
":20880/com.foo.BarService"));
+        Invoker<String> invoker2 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST + 
":20880/com.foo.BarService"));
+        Invoker<String> invoker3 = new 
MockInvoker<String>(URL.valueOf("dubbo://" + LOCAL_HOST + 
":20880/com.foo.BarService"));
         invokers.add(invoker1);
         invokers.add(invoker2);
         invokers.add(invoker3);
-        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + NetUtils.getLocalHost() + "/com.foo.BarService"), 
new RpcInvocation());
+        List<Invoker<String>> filteredInvokers = router.route(invokers, 
URL.valueOf("consumer://" + LOCAL_HOST + "/com.foo.BarService"), new 
RpcInvocation());
         Assertions.assertEquals(0, filteredInvokers.size());
     }
 
diff --git 
a/dubbo-metadata-report/dubbo-metadata-report-etcd/src/test/java/org/apache/dubbo/metadata/store/etcd/EtcdMetadataReportTest.java
 
b/dubbo-metadata-report/dubbo-metadata-report-etcd/src/test/java/org/apache/dubbo/metadata/store/etcd/EtcdMetadataReportTest.java
index 770b058..2f45171 100644
--- 
a/dubbo-metadata-report/dubbo-metadata-report-etcd/src/test/java/org/apache/dubbo/metadata/store/etcd/EtcdMetadataReportTest.java
+++ 
b/dubbo-metadata-report/dubbo-metadata-report-etcd/src/test/java/org/apache/dubbo/metadata/store/etcd/EtcdMetadataReportTest.java
@@ -32,6 +32,7 @@ import io.etcd.jetcd.launcher.EtcdClusterFactory;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import java.net.URI;
@@ -73,6 +74,7 @@ public class EtcdMetadataReportTest {
     }
 
     @Test
+    @Disabled("Disabled because https://github.com/apache/dubbo/issues/4185";)
     public void testStoreProvider() throws Exception {
         String version = "1.0.0";
         String group = null;

Reply via email to