This is an automated email from the ASF dual-hosted git repository. wangzx pushed a commit to branch fix/tooltip-dispose-NPE in repository https://gitbox.apache.org/repos/asf/echarts.git
The following commit(s) were added to refs/heads/fix/tooltip-dispose-NPE by this push: new 0d29cd898 fix(tooltip): still use `parentNode.removeChild` to reserve support for IE. 0d29cd898 is described below commit 0d29cd898f550d7d6451af4f4f56881082188941 Author: plainheart <y...@all-my-life.cn> AuthorDate: Wed Nov 1 23:27:03 2023 +0800 fix(tooltip): still use `parentNode.removeChild` to reserve support for IE. --- src/component/tooltip/TooltipHTMLContent.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/component/tooltip/TooltipHTMLContent.ts b/src/component/tooltip/TooltipHTMLContent.ts index 817ec1d60..7e08b53f9 100644 --- a/src/component/tooltip/TooltipHTMLContent.ts +++ b/src/component/tooltip/TooltipHTMLContent.ts @@ -522,7 +522,9 @@ class TooltipHTMLContent { dispose() { clearTimeout(this._hideTimeout); clearTimeout(this._longHideTimeout); - this.el.remove(); + + const parentNode = this.el.parentNode; + parentNode && parentNode.removeChild(this.el); this.el = this._container = null; } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org