[GitHub] [echarts] JinJianQi commented on pull request #17288: feat: add the insideDataZoom 'gestureOnTouchPad' option that can Optimize the Experience on the MAC touchpad.

2023-08-21 Thread via GitHub
JinJianQi commented on PR #17288: URL: https://github.com/apache/echarts/pull/17288#issuecomment-1687471246 Sorry for the very late reply, and you guys are awesome. @Chaoses-Ib I haven't found a suitable method to accurately differentiate actions from the trackpad and the mouse. From

[GitHub] [echarts] JinJianQi commented on pull request #17288: feat: add the insideDataZoom 'gestureOnTouchPad' option that can Optimize the Experience on the MAC touchpad.

2022-09-22 Thread GitBox
JinJianQi commented on PR #17288: URL: https://github.com/apache/echarts/pull/17288#issuecomment-1255205237 @100pah Thanks for your reply :) From my side, I think both A and B are good, C just changes the original behavior, which means we may need another way to represent the

[GitHub] [echarts] JinJianQi commented on pull request #17288: feat: add the insideDataZoom 'gestureOnTouchPad' option that can Optimize the Experience on the MAC touchpad.

2022-09-20 Thread GitBox
JinJianQi commented on PR #17288: URL: https://github.com/apache/echarts/pull/17288#issuecomment-1252540776 As far as I know, the [moveOnMouseWheel](https://echarts.apache.org/en/option.html#%2Fsearch%2FmoveOnMouseWheel) now just can't distinguish between X and Y directions. To put it

[GitHub] [echarts] JinJianQi commented on pull request #17288: feat: add the insideDataZoom 'gestureOnTouchPad' option that can Optimize the Experience on the MAC touchpad.

2022-09-08 Thread GitBox
JinJianQi commented on PR #17288: URL: https://github.com/apache/echarts/pull/17288#issuecomment-1240776169 @100pah, Is there any thing bad? If so, I would like to fix it. Thanks. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [echarts] JinJianQi commented on pull request #17288: feat: add the insideDataZoom 'gestureOnTouchPad' option that can Optimize the Experience on the MAC touchpad.

2022-08-19 Thread GitBox
JinJianQi commented on PR #17288: URL: https://github.com/apache/echarts/pull/17288#issuecomment-1220513838 Any thing update here ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [echarts] JinJianQi commented on pull request #17288: feat: add the insideDataZoom 'gestureOnTouchPad' option that can Optimize the Experience on the MAC touchpad.

2022-07-28 Thread GitBox
JinJianQi commented on PR #17288: URL: https://github.com/apache/echarts/pull/17288#issuecomment-1197872400 Personally, I think B is better, case touchpad is so different with mouse, and I think we should offer users to decide how to deal with wheel event. -- This is an automated message

[GitHub] [echarts] JinJianQi commented on pull request #17288: feat: add the insideDataZoom 'gestureOnTouchPad' option that can Optimize the Experience on the MAC touchpad.

2022-07-21 Thread GitBox
JinJianQi commented on PR #17288: URL: https://github.com/apache/echarts/pull/17288#issuecomment-1192153158 Hi, Anything update here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [echarts] JinJianQi commented on pull request #17288: feat: add the insideDataZoom 'gestureOnTouchPad' option that can Optimize the Experience on the MAC touchpad.

2022-07-01 Thread GitBox
JinJianQi commented on PR #17288: URL: https://github.com/apache/echarts/pull/17288#issuecomment-1171975707 > Please remove the changes of `dist` and `i18n`. Okay, I removed them and fixed some lint error. Could you help me to review it again, and maybe find something inappropriate?