[GitHub] [echarts] cvSoldier commented on pull request #18379: fix(lines): Lines series symbolSize cannot be updated. close #18350

2023-03-28 Thread via GitHub
cvSoldier commented on PR #18379: URL: https://github.com/apache/echarts/pull/18379#issuecomment-1487986305 Hi @Ovilia. Since all checks have passed, may I ask if it's ready for merging now? (kind of exciting for becoming a contributor) -- This is an automated message from the Apache

[GitHub] [echarts] cvSoldier commented on pull request #18379: fix(lines): Lines series symbolSize cannot be updated. close #18350

2023-03-23 Thread via GitHub
cvSoldier commented on PR #18379: URL: https://github.com/apache/echarts/pull/18379#issuecomment-1482200819 found that ci failed again,:worried: but I didn't understand the reason. Do I need to commit any changes? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [echarts] cvSoldier commented on pull request #18379: fix(lines): Lines series symbolSize cannot be updated. close #18350

2023-03-21 Thread via GitHub
cvSoldier commented on PR #18379: URL: https://github.com/apache/echarts/pull/18379#issuecomment-1477748976 Test case was added, but I'm a bit confused, in [Run test cases](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request#run-test-cases) it is written that just need Run