[GitHub] [incubator-echarts] Ovilia edited a comment on pull request #12859: feat: time axis label formatter

2020-07-13 Thread GitBox
Ovilia edited a comment on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655945171 @quillblue Thanks for your comments. Here are my thoughts on this. ## Primary & Secondary Ticks I think secondary ticks may not be a minor tick.

[GitHub] [incubator-echarts] Ovilia edited a comment on pull request #12859: feat: time axis label formatter

2020-07-13 Thread GitBox
Ovilia edited a comment on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655945171 @quillblue Thanks for your comments. Here are my thoughts on this. ## Primary & Secondary Ticks I think secondary ticks may not be a minor tick.

[GitHub] [incubator-echarts] Ovilia edited a comment on pull request #12859: feat: time axis label formatter

2020-07-13 Thread GitBox
Ovilia edited a comment on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655945171 @quillblue Thanks for your comments. Here are my thoughts on this. ## Primary & Secondary Ticks I think secondary ticks may not be a minor tick.

[GitHub] [incubator-echarts] Ovilia edited a comment on pull request #12859: feat: time axis label formatter

2020-07-09 Thread GitBox
Ovilia edited a comment on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655945171 @quillblue Thanks for your comments. Here are my thoughts on this. ## Primary & Secondary Ticks I think secondary ticks may not be a minor tick.

[GitHub] [incubator-echarts] Ovilia edited a comment on pull request #12859: feat: time axis label formatter

2020-07-09 Thread GitBox
Ovilia edited a comment on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655951837 @100pah I think that makes sense. `一、二` should take `ee` if we have future feature requests. Or do you think we should provide `ee` for `Mo, Tu` and ` 一,二`

[GitHub] [incubator-echarts] Ovilia edited a comment on pull request #12859: feat: time axis label formatter

2020-07-09 Thread GitBox
Ovilia edited a comment on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655951837 @100pah I think that makes sense. `一、二` should take `ee` if we have future feature requests. I would suggest break change it to 1~12 because it's more