pissang commented on pull request #12468:
URL: 
https://github.com/apache/incubator-echarts/pull/12468#issuecomment-668499728


   I think it's better to encode the color in the visual so legend can access 
it.
   
   Current change is too tricky and may cause unexpected issues in the further. 
For example, this #000 color may be given by the `visualMap` component. In this 
case `itemStyleModel.get('color')` is also null.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

Reply via email to