This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch aggregate-transform
in repository https://gitbox.apache.org/repos/asf/echarts.git


The following commit(s) were added to refs/heads/aggregate-transform by this 
push:
     new 7f14e94dc fix(dataset): fix using transform in dataset may cause dead 
loop.
7f14e94dc is described below

commit 7f14e94dc08eaf898d50129d78376c8a199f5a8b
Author: pissang <bm2736...@gmail.com>
AuthorDate: Thu Apr 14 12:38:34 2022 +0800

    fix(dataset): fix using transform in dataset may cause dead loop.
---
 src/data/helper/sourceHelper.ts | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/data/helper/sourceHelper.ts b/src/data/helper/sourceHelper.ts
index 5408f6adc..449ff1b5e 100644
--- a/src/data/helper/sourceHelper.ts
+++ b/src/data/helper/sourceHelper.ts
@@ -26,7 +26,8 @@ import {
     isString,
     isObject,
     isTypedArray,
-    HashMap
+    HashMap,
+    filter
 } from 'zrender/src/core/util';
 import { Source } from '../Source';
 
@@ -322,7 +323,7 @@ export function queryDatasetUpstreamDatasetModels(
         return [];
     }
 
-    return queryReferringComponents(
+    return filter(queryReferringComponents(
         datasetModel.ecModel,
         'dataset',
         {
@@ -330,7 +331,7 @@ export function queryDatasetUpstreamDatasetModels(
             id: datasetModel.get('fromDatasetId', true)
         },
         SINGLE_REFERRING
-    ).models as DatasetModel[];
+    ).models as DatasetModel[], model => model !== datasetModel);
 }
 
 /**


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

Reply via email to