[GitHub] [incubator-echarts] OpenWaygate opened a new issue #11218: 官网示例出现 Uncaught ReferenceError: $ is not defined at tree-vertical.html:23
OpenWaygate opened a new issue #11218: 官网示例出现 Uncaught ReferenceError: $ is not defined at tree-vertical.html:23 URL: https://github.com/apache/incubator-echarts/issues/11218 ### Version 4.2.1 ### Steps to reproduce 并不清楚所用的echarts版本, 但代码是官方的 从官网下载示例 https://echarts.apache.org/examples/en/editor.html?c=tree-vertical, 换用自己的ak, 出现错误  ``` Uncaught ReferenceError: $ is not defined at tree-vertical.html:23 ``` ### What is expected? 期望出现官网的效果 ### What is actually happening? 一直loading This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11218: 官网示例出现 Uncaught ReferenceError: $ is not defined at tree-vertical.html:23
echarts-robot[bot] commented on issue #11218: 官网示例出现 Uncaught ReferenceError: $ is not defined at tree-vertical.html:23 URL: https://github.com/apache/incubator-echarts/issues/11218#issuecomment-530254890 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org . If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11219: 【需求】图例(legend)需要能控制不触发brushSelected事件
echarts-robot[bot] commented on issue #11219: 【需求】图例(legend)需要能控制不触发brushSelected事件 URL: https://github.com/apache/incubator-echarts/issues/11219#issuecomment-530263225 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org . If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] comvir opened a new issue #11219: 【需求】图例(legend)需要能控制不触发brushSelected事件
comvir opened a new issue #11219: 【需求】图例(legend)需要能控制不触发brushSelected事件 URL: https://github.com/apache/incubator-echarts/issues/11219 ### What problem does this feature solve? 图表绑定了brushSelected事件，这个事件会通过图例点击触发。 现在要求brushSelected事件只有框选才会触发， 而图例点击时仅触发自身的互动效果，而不触发brushSelected事件。 ### What does the proposed API look like? legend增加silent属性，默认false。 当silent为true时，不触发brushSelected事件 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch test-autorun updated: test: add version selection in visual regression testing tool
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch test-autorun
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/test-autorun by this push:
new bf3a0ae test: add version selection in visual regression testing tool
bf3a0ae is described below
commit bf3a0ae16ad9e2c5f87243c2171a1ff2b8b04332
Author: pissang
AuthorDate: Wed Sep 11 16:30:18 2019 +0800
test: add version selection in visual regression testing tool
---
test/runTest/blacklist.js | 7 -
test/runTest/cli.js| 38 --
test/runTest/client/client.css | 5
test/runTest/client/client.js | 62 ++
test/runTest/client/index.html | 58 +--
test/runTest/server.js | 34 +--
test/runTest/util.js | 31 ++---
7 files changed, 170 insertions(+), 65 deletions(-)
diff --git a/test/runTest/blacklist.js b/test/runTest/blacklist.js
index b1a5204..e3d220f 100644
--- a/test/runTest/blacklist.js
+++ b/test/runTest/blacklist.js
@@ -29,5 +29,10 @@ module.exports = [
'finished-gl.html',
'scatter-gps.html',
-'webkit-dep.html'
+'webkit-dep.html',
+
+// This case will have timeout
+'visualMap-performance1.html',
+'lines-bus.html',
+'lines-stream-not-large.html'
];
diff --git a/test/runTest/cli.js b/test/runTest/cli.js
index 70be90f..62bf18d 100644
--- a/test/runTest/cli.js
+++ b/test/runTest/cli.js
@@ -32,11 +32,15 @@ const Timeline = require('./Timeline');
program
.option('-t, --tests ', 'Tests names list')
.option('--no-headless', 'Not headless')
-.option('-s, --speed ', 'Playback speed');
+.option('-s, --speed ', 'Playback speed')
+.option('--expected ', 'Expected version')
+.option('--actual ', 'Actual version');
program.parse(process.argv);
program.speed = +program.speed || 1;
+program.actual = program.actual || 'local';
+program.expected = program.expected || '4.2.1';
if (!program.tests) {
throw new Error('Tests are required');
@@ -144,6 +148,9 @@ async function runTestPage(browser, testOpt, version,
runtimeCode) {
page.on('pageerror', error => {
errors.push(error.toString());
});
+page.on('dialog', async dialog => {
+await dialog.dismiss();
+});
try {
await page.setViewport({width: 800, height: 600});
@@ -151,19 +158,20 @@ async function runTestPage(browser, testOpt, version,
runtimeCode) {
waitUntil: 'networkidle2',
timeout: 1
});
+
+await waitTime(200); // Wait for animation or something else. Pending
+// Final shot.
+await page.mouse.move(0, 0);
+let desc = 'Full Shot';
+const {screenshotName, screenshotPath} = await takeScreenshot(page,
true, fileUrl, desc, version);
+screenshots.push({screenshotName, desc, screenshotPath});
+
+await runActions(page, testOpt, version, screenshots);
}
catch(e) {
console.error(e);
}
-await waitTime(200); // Wait for animation or something else. Pending
-// Final shot.
-let desc = 'Full Shot';
-const {screenshotName, screenshotPath} = await takeScreenshot(page, true,
fileUrl, desc, version);
-screenshots.push({screenshotName, desc, screenshotPath});
-
-await runActions(page, testOpt, version, screenshots);
-
await page.close();
return {
@@ -181,10 +189,10 @@ async function writePNG(diffPNG, diffPath) {
});
};
-async function runTest(browser, testOpt, runtimeCode) {
+async function runTest(browser, testOpt, runtimeCode, expectedVersion,
actualVersion) {
testOpt.status === 'running';
-const expectedResult = await runTestPage(browser, testOpt, '4.2.1',
runtimeCode);
-const actualResult = await runTestPage(browser, testOpt, '', runtimeCode);
+const expectedResult = await runTestPage(browser, testOpt,
expectedVersion, runtimeCode);
+const actualResult = await runTestPage(browser, testOpt, actualVersion,
runtimeCode);
// sortScreenshots(expectedResult.screenshots);
// sortScreenshots(actualResult.screenshots);
@@ -218,6 +226,8 @@ async function runTest(browser, testOpt, runtimeCode) {
testOpt.expectedLogs = expectedResult.logs;
testOpt.actualErrors = actualResult.errors;
testOpt.expectedErrors = expectedResult.errors;
+testOpt.actualVersion = actualVersion;
+testOpt.expectedVersion = expectedVersion;
testOpt.lastRun = Date.now();
}
@@ -235,11 +245,11 @@ async function runTests(pendingTests) {
for (let testOpt of pendingTests) {
console.log('Running Test', testOpt.name);
try {
-await runTest(browser, testOpt, runtimeCode);
+await runTest(browser, testOpt, runtimeCode, program.expected,
program.actual);
[incubator-echarts] 01/02: test: case insensitive search
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch test-autorun
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 61e5a01b189f74cc1a4295c3bc8a6f199fbc3469
Author: pissang
AuthorDate: Wed Sep 11 16:35:40 2019 +0800
test: case insensitive search
---
test/runTest/client/client.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/runTest/client/client.js b/test/runTest/client/client.js
index f910178..2cd0563 100644
--- a/test/runTest/client/client.js
+++ b/test/runTest/client/client.js
@@ -103,8 +103,9 @@ const app = new Vue({
return this.fullTests.slice().sort(sortFunc);
}
+let searchString = this.searchString.toLowerCase();
return this.fullTests.filter(test => {
-return test.name.match(this.searchString);
+return test.name.toLowerCase().match(searchString);
}).sort(sortFunc);
},
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 02/02: test: add more run options.
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch test-autorun
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit d561931f605aa0f8e762211175ff3683cc88cb43
Author: pissang
AuthorDate: Wed Sep 11 16:49:09 2019 +0800
test: add more run options.
---
test/runTest/client/client.js | 44 --
test/runTest/client/index.html | 7 ---
2 files changed, 34 insertions(+), 17 deletions(-)
diff --git a/test/runTest/client/client.js b/test/runTest/client/client.js
index 2cd0563..7f644ed 100644
--- a/test/runTest/client/client.js
+++ b/test/runTest/client/client.js
@@ -109,6 +109,22 @@ const app = new Vue({
}).sort(sortFunc);
},
+selectedTests() {
+return this.fullTests.filter(test => {
+return test.selected;
+});
+},
+unfinishedTests() {
+return this.fullTests.filter(test => {
+return test.status !== 'finished';
+});
+},
+failedTests() {
+return this.fullTests.filter(test => {
+return test.status === 'finished' && test.summary !==
'success';
+});
+},
+
currentTest() {
let currentTest = this.fullTests.find(item => item.name ===
this.currentTestName);
if (!currentTest) {
@@ -171,20 +187,20 @@ const app = new Vue({
runTests([testName]);
},
run(runTarget) {
-const tests = this.fullTests.filter(test => {
-if (runTarget === 'selected') {
-return test.selected;
-}
-else if (runTarget === 'unfinished') {
-return test.status !== 'finished';
-}
-else { // Run all
-return true;
-}
-}).map(test => {
-return test.name;
-});
-runTests(tests);
+let tests;
+if (runTarget === 'selected') {
+tests = this.selectedTests;
+}
+else if (runTarget === 'unfinished') {
+tests = this.unfinishedTests;
+}
+else if (runTarget === 'failed') {
+tests = this.failedTests;
+}
+else {
+tests = this.fullTests;
+}
+runTests(tests.map(test => test.name));
},
stopTests() {
this.running = false;
diff --git a/test/runTest/client/index.html b/test/runTest/client/index.html
index 64c2eba..8706c33 100644
--- a/test/runTest/client/index.html
+++ b/test/runTest/client/index.html
@@ -46,10 +46,11 @@ under the License.
@click="run('selected')"
@command="run"
>
- Run selected
+ Run selected
({{selectedTests.length}})
-Run
unfinished
-Run
all
+Run
unfinished ({{unfinishedTests.length}})
+Run failed
({{failedTests.length}})
+Run all
({{fullTests.length}})
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch test-autorun updated (bf3a0ae -> d561931)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch test-autorun in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from bf3a0ae test: add version selection in visual regression testing tool new 61e5a01 test: case insensitive search new d561931 test: add more run options. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: test/runTest/client/client.js | 47 -- test/runTest/client/index.html | 7 --- 2 files changed, 36 insertions(+), 18 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch test-autorun updated: test: remove unused code
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch test-autorun
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/test-autorun by this push:
new 77d3aa7 test: remove unused code
77d3aa7 is described below
commit 77d3aa72dc2940a6ed24d1bc74b13110d9a25a26
Author: pissang
AuthorDate: Wed Sep 11 16:49:43 2019 +0800
test: remove unused code
---
test/runTest/client/index.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/runTest/client/index.html b/test/runTest/client/index.html
index 8706c33..4b1f8d0 100644
--- a/test/runTest/client/index.html
+++ b/test/runTest/client/index.html
@@ -185,7 +185,7 @@ under the License.
Diff -
{{result.diffRatio.toFixed(4)}}
-
+
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch test-autorun updated: test: add alert if scroll changed during action recording
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch test-autorun
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/test-autorun by this push:
new 3b43fbb test: add alert if scroll changed during action recording
3b43fbb is described below
commit 3b43fbbe5c40e46a15736e6835f5f1a213fdce87
Author: pissang
AuthorDate: Wed Sep 11 17:02:55 2019 +0800
test: add alert if scroll changed during action recording
---
test/runTest/actions/__meta__.json | 3 ++-
test/runTest/actions/axes.json | 1 +
test/runTest/recorder/recorder.js | 15 +--
3 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/test/runTest/actions/__meta__.json
b/test/runTest/actions/__meta__.json
index 8af1757..d9b9e28 100644
--- a/test/runTest/actions/__meta__.json
+++ b/test/runTest/actions/__meta__.json
@@ -127,5 +127,6 @@
"treemap-obama": 1,
"treemap-option": 1,
"treemap-option2": 1,
- "visualMap-categories": 1
+ "visualMap-categories": 1,
+ "axes": 0
}
\ No newline at end of file
diff --git a/test/runTest/actions/axes.json b/test/runTest/actions/axes.json
new file mode 100644
index 000..0637a08
--- /dev/null
+++ b/test/runTest/actions/axes.json
@@ -0,0 +1 @@
+[]
\ No newline at end of file
diff --git a/test/runTest/recorder/recorder.js
b/test/runTest/recorder/recorder.js
index fc74b38..44c6323 100644
--- a/test/runTest/recorder/recorder.js
+++ b/test/runTest/recorder/recorder.js
@@ -196,6 +196,7 @@ function notify(title, message) {
function keyboardRecordingHandler(e) {
if (e.key.toLowerCase() === 'r' && e.shiftKey) {
+let $iframe = getIframe();
if (!app.recordingAction) {
// Create a new action if currentAction has ops.
if (!app.currentAction || app.currentAction.ops.length > 0) {
@@ -204,7 +205,6 @@ function keyboardRecordingHandler(e) {
app.recordingAction = app.currentAction;
if (app.recordingAction) {
-let $iframe = getIframe();
app.recordingAction.scrollY = $iframe.contentWindow.scrollY;
app.recordingAction.scrollX = $iframe.contentWindow.scrollX;
app.recordingAction.timestamp = Date.now();
@@ -213,8 +213,19 @@ function keyboardRecordingHandler(e) {
}
}
else {
+if (app.recordingAction &&
+(app.recordingAction.scrollY !== $iframe.contentWindow.scrollY
+ || app.recordingAction.scrollX !==
$iframe.contentWindow.scrollX)) {
+app.recordingAction.ops = [];
+app.$alert('You can\'t scroll the page during the action
recording. Please create another action after scrolled to the next demo.',
'Recording Fail', {
+confirmButtonText: 'Get!'
+});
+
+}
+else {
+saveData();
+}
app.recordingAction = null;
-saveData();
}
// Get scroll
}
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang opened a new pull request #11220: Visual regression testing tool: enhance UI, add more run options.
pissang opened a new pull request #11220: Visual regression testing tool: enhance UI, add more run options. URL: https://github.com/apache/incubator-echarts/pull/11220 This pull request is about some enhancement on the visual regression testing tool. The enhancement is mainly focused on the running option UI. 1. Add a dropdown of run button. Can run unfinished/failed/all tests with one click now!.  2. Add ECharts version selection.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch test-autorun updated (3b43fbb -> abf9cb5)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch test-autorun in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from 3b43fbb test: add alert if scroll changed during action recording add abf9cb5 test: fix echarts version replacement in runtime No new revisions were added by this update. Summary of changes: test/runTest/cli.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 04/06: test: remove unused code
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 4a9f6ec21347417f354ccbc5a71b356e9883c8d5
Author: pissang
AuthorDate: Wed Sep 11 16:49:43 2019 +0800
test: remove unused code
---
test/runTest/client/index.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/runTest/client/index.html b/test/runTest/client/index.html
index 8706c33..4b1f8d0 100644
--- a/test/runTest/client/index.html
+++ b/test/runTest/client/index.html
@@ -185,7 +185,7 @@ under the License.
Diff -
{{result.diffRatio.toFixed(4)}}
-
+
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 02/06: test: case insensitive search
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 738038b91578f7257b6050c0ce8207d061bdd9bc
Author: pissang
AuthorDate: Wed Sep 11 16:35:40 2019 +0800
test: case insensitive search
---
test/runTest/client/client.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/runTest/client/client.js b/test/runTest/client/client.js
index f910178..2cd0563 100644
--- a/test/runTest/client/client.js
+++ b/test/runTest/client/client.js
@@ -103,8 +103,9 @@ const app = new Vue({
return this.fullTests.slice().sort(sortFunc);
}
+let searchString = this.searchString.toLowerCase();
return this.fullTests.filter(test => {
-return test.name.match(this.searchString);
+return test.name.toLowerCase().match(searchString);
}).sort(sortFunc);
},
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 01/06: test: add version selection in visual regression testing tool
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 27dc4cba1f2e62b0ad2083537e66310cfb268e87
Author: pissang
AuthorDate: Wed Sep 11 16:30:18 2019 +0800
test: add version selection in visual regression testing tool
---
test/runTest/blacklist.js | 7 -
test/runTest/cli.js| 38 --
test/runTest/client/client.css | 5
test/runTest/client/client.js | 62 ++
test/runTest/client/index.html | 58 +--
test/runTest/server.js | 34 +--
test/runTest/util.js | 31 ++---
7 files changed, 170 insertions(+), 65 deletions(-)
diff --git a/test/runTest/blacklist.js b/test/runTest/blacklist.js
index b1a5204..e3d220f 100644
--- a/test/runTest/blacklist.js
+++ b/test/runTest/blacklist.js
@@ -29,5 +29,10 @@ module.exports = [
'finished-gl.html',
'scatter-gps.html',
-'webkit-dep.html'
+'webkit-dep.html',
+
+// This case will have timeout
+'visualMap-performance1.html',
+'lines-bus.html',
+'lines-stream-not-large.html'
];
diff --git a/test/runTest/cli.js b/test/runTest/cli.js
index 70be90f..62bf18d 100644
--- a/test/runTest/cli.js
+++ b/test/runTest/cli.js
@@ -32,11 +32,15 @@ const Timeline = require('./Timeline');
program
.option('-t, --tests ', 'Tests names list')
.option('--no-headless', 'Not headless')
-.option('-s, --speed ', 'Playback speed');
+.option('-s, --speed ', 'Playback speed')
+.option('--expected ', 'Expected version')
+.option('--actual ', 'Actual version');
program.parse(process.argv);
program.speed = +program.speed || 1;
+program.actual = program.actual || 'local';
+program.expected = program.expected || '4.2.1';
if (!program.tests) {
throw new Error('Tests are required');
@@ -144,6 +148,9 @@ async function runTestPage(browser, testOpt, version,
runtimeCode) {
page.on('pageerror', error => {
errors.push(error.toString());
});
+page.on('dialog', async dialog => {
+await dialog.dismiss();
+});
try {
await page.setViewport({width: 800, height: 600});
@@ -151,19 +158,20 @@ async function runTestPage(browser, testOpt, version,
runtimeCode) {
waitUntil: 'networkidle2',
timeout: 1
});
+
+await waitTime(200); // Wait for animation or something else. Pending
+// Final shot.
+await page.mouse.move(0, 0);
+let desc = 'Full Shot';
+const {screenshotName, screenshotPath} = await takeScreenshot(page,
true, fileUrl, desc, version);
+screenshots.push({screenshotName, desc, screenshotPath});
+
+await runActions(page, testOpt, version, screenshots);
}
catch(e) {
console.error(e);
}
-await waitTime(200); // Wait for animation or something else. Pending
-// Final shot.
-let desc = 'Full Shot';
-const {screenshotName, screenshotPath} = await takeScreenshot(page, true,
fileUrl, desc, version);
-screenshots.push({screenshotName, desc, screenshotPath});
-
-await runActions(page, testOpt, version, screenshots);
-
await page.close();
return {
@@ -181,10 +189,10 @@ async function writePNG(diffPNG, diffPath) {
});
};
-async function runTest(browser, testOpt, runtimeCode) {
+async function runTest(browser, testOpt, runtimeCode, expectedVersion,
actualVersion) {
testOpt.status === 'running';
-const expectedResult = await runTestPage(browser, testOpt, '4.2.1',
runtimeCode);
-const actualResult = await runTestPage(browser, testOpt, '', runtimeCode);
+const expectedResult = await runTestPage(browser, testOpt,
expectedVersion, runtimeCode);
+const actualResult = await runTestPage(browser, testOpt, actualVersion,
runtimeCode);
// sortScreenshots(expectedResult.screenshots);
// sortScreenshots(actualResult.screenshots);
@@ -218,6 +226,8 @@ async function runTest(browser, testOpt, runtimeCode) {
testOpt.expectedLogs = expectedResult.logs;
testOpt.actualErrors = actualResult.errors;
testOpt.expectedErrors = expectedResult.errors;
+testOpt.actualVersion = actualVersion;
+testOpt.expectedVersion = expectedVersion;
testOpt.lastRun = Date.now();
}
@@ -235,11 +245,11 @@ async function runTests(pendingTests) {
for (let testOpt of pendingTests) {
console.log('Running Test', testOpt.name);
try {
-await runTest(browser, testOpt, runtimeCode);
+await runTest(browser, testOpt, runtimeCode, program.expected,
program.actual);
}
catch (e) {
// Restore status
-testOpt.status = 'pending';
+testOpt.status = 'unsettled';
console
[incubator-echarts] 03/06: test: add more run options.
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 064d679caa44d5635637737abc7b3b49e7b1e8d3
Author: pissang
AuthorDate: Wed Sep 11 16:49:09 2019 +0800
test: add more run options.
---
test/runTest/client/client.js | 44 --
test/runTest/client/index.html | 7 ---
2 files changed, 34 insertions(+), 17 deletions(-)
diff --git a/test/runTest/client/client.js b/test/runTest/client/client.js
index 2cd0563..7f644ed 100644
--- a/test/runTest/client/client.js
+++ b/test/runTest/client/client.js
@@ -109,6 +109,22 @@ const app = new Vue({
}).sort(sortFunc);
},
+selectedTests() {
+return this.fullTests.filter(test => {
+return test.selected;
+});
+},
+unfinishedTests() {
+return this.fullTests.filter(test => {
+return test.status !== 'finished';
+});
+},
+failedTests() {
+return this.fullTests.filter(test => {
+return test.status === 'finished' && test.summary !==
'success';
+});
+},
+
currentTest() {
let currentTest = this.fullTests.find(item => item.name ===
this.currentTestName);
if (!currentTest) {
@@ -171,20 +187,20 @@ const app = new Vue({
runTests([testName]);
},
run(runTarget) {
-const tests = this.fullTests.filter(test => {
-if (runTarget === 'selected') {
-return test.selected;
-}
-else if (runTarget === 'unfinished') {
-return test.status !== 'finished';
-}
-else { // Run all
-return true;
-}
-}).map(test => {
-return test.name;
-});
-runTests(tests);
+let tests;
+if (runTarget === 'selected') {
+tests = this.selectedTests;
+}
+else if (runTarget === 'unfinished') {
+tests = this.unfinishedTests;
+}
+else if (runTarget === 'failed') {
+tests = this.failedTests;
+}
+else {
+tests = this.fullTests;
+}
+runTests(tests.map(test => test.name));
},
stopTests() {
this.running = false;
diff --git a/test/runTest/client/index.html b/test/runTest/client/index.html
index 64c2eba..8706c33 100644
--- a/test/runTest/client/index.html
+++ b/test/runTest/client/index.html
@@ -46,10 +46,11 @@ under the License.
@click="run('selected')"
@command="run"
>
- Run selected
+ Run selected
({{selectedTests.length}})
-Run
unfinished
-Run
all
+Run
unfinished ({{unfinishedTests.length}})
+Run failed
({{failedTests.length}})
+Run all
({{fullTests.length}})
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 06/06: test: fix echarts version replacement in runtime
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 1c9f5b3f0d5265573249d0e5a5cf480819a97fee
Author: pissang
AuthorDate: Wed Sep 11 17:19:26 2019 +0800
test: fix echarts version replacement in runtime
---
test/runTest/cli.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/runTest/cli.js b/test/runTest/cli.js
index 62bf18d..ffd133d 100644
--- a/test/runTest/cli.js
+++ b/test/runTest/cli.js
@@ -63,6 +63,7 @@ function getClientRelativePath(absPath) {
function replaceEChartsVersion(interceptedRequest, version) {
// TODO Extensions and maps
if (interceptedRequest.url().endsWith('dist/echarts.js')) {
+console.log(getVersionDir(version));
interceptedRequest.continue({
url: `${origin}/test/runTest/${getVersionDir(version)}/echarts.js`
});
@@ -138,7 +139,7 @@ async function runTestPage(browser, testOpt, version,
runtimeCode) {
const page = await browser.newPage();
page.setRequestInterception(true);
-page.on('request', replaceEChartsVersion);
+page.on('request', request => replaceEChartsVersion(request, version));
await page.evaluateOnNewDocument(runtimeCode);
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 05/06: test: add alert if scroll changed during action recording
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit e57d21dcfbaf3b33146b49acb04a4f44a8ff83b0
Author: pissang
AuthorDate: Wed Sep 11 17:02:55 2019 +0800
test: add alert if scroll changed during action recording
---
test/runTest/actions/__meta__.json | 3 ++-
test/runTest/actions/axes.json | 1 +
test/runTest/recorder/recorder.js | 15 +--
3 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/test/runTest/actions/__meta__.json
b/test/runTest/actions/__meta__.json
index 8af1757..d9b9e28 100644
--- a/test/runTest/actions/__meta__.json
+++ b/test/runTest/actions/__meta__.json
@@ -127,5 +127,6 @@
"treemap-obama": 1,
"treemap-option": 1,
"treemap-option2": 1,
- "visualMap-categories": 1
+ "visualMap-categories": 1,
+ "axes": 0
}
\ No newline at end of file
diff --git a/test/runTest/actions/axes.json b/test/runTest/actions/axes.json
new file mode 100644
index 000..0637a08
--- /dev/null
+++ b/test/runTest/actions/axes.json
@@ -0,0 +1 @@
+[]
\ No newline at end of file
diff --git a/test/runTest/recorder/recorder.js
b/test/runTest/recorder/recorder.js
index fc74b38..44c6323 100644
--- a/test/runTest/recorder/recorder.js
+++ b/test/runTest/recorder/recorder.js
@@ -196,6 +196,7 @@ function notify(title, message) {
function keyboardRecordingHandler(e) {
if (e.key.toLowerCase() === 'r' && e.shiftKey) {
+let $iframe = getIframe();
if (!app.recordingAction) {
// Create a new action if currentAction has ops.
if (!app.currentAction || app.currentAction.ops.length > 0) {
@@ -204,7 +205,6 @@ function keyboardRecordingHandler(e) {
app.recordingAction = app.currentAction;
if (app.recordingAction) {
-let $iframe = getIframe();
app.recordingAction.scrollY = $iframe.contentWindow.scrollY;
app.recordingAction.scrollX = $iframe.contentWindow.scrollX;
app.recordingAction.timestamp = Date.now();
@@ -213,8 +213,19 @@ function keyboardRecordingHandler(e) {
}
}
else {
+if (app.recordingAction &&
+(app.recordingAction.scrollY !== $iframe.contentWindow.scrollY
+ || app.recordingAction.scrollX !==
$iframe.contentWindow.scrollX)) {
+app.recordingAction.ops = [];
+app.$alert('You can\'t scroll the page during the action
recording. Please create another action after scrolled to the next demo.',
'Recording Fail', {
+confirmButtonText: 'Get!'
+});
+
+}
+else {
+saveData();
+}
app.recordingAction = null;
-saveData();
}
// Get scroll
}
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch master updated (e81fe3c -> 1c9f5b3)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from e81fe3c Merge pull request #11214 from apache/test-autorun new 27dc4cb test: add version selection in visual regression testing tool new 738038b test: case insensitive search new 064d679 test: add more run options. new 4a9f6ec test: remove unused code new e57d21d test: add alert if scroll changed during action recording new 1c9f5b3 test: fix echarts version replacement in runtime The 6 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: test/runTest/actions/__meta__.json | 3 +- test/runTest/actions/axes.json | 1 + test/runTest/blacklist.js | 7 ++- test/runTest/cli.js| 41 ++--- test/runTest/client/client.css | 5 +++ test/runTest/client/client.js | 91 -- test/runTest/client/index.html | 61 - test/runTest/recorder/recorder.js | 15 ++- test/runTest/server.js | 34 ++ test/runTest/util.js | 31 +++-- 10 files changed, 213 insertions(+), 76 deletions(-) create mode 100644 test/runTest/actions/axes.json - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #11220: Visual regression testing tool: enhance UI, add more run options.
pissang merged pull request #11220: Visual regression testing tool: enhance UI, add more run options. URL: https://github.com/apache/incubator-echarts/pull/11220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] ahmadalibaloch commented on issue #11135: [SURVEY] What companies are using Apache ECharts (incubating)?
ahmadalibaloch commented on issue #11135: [SURVEY] What companies are using Apache ECharts (incubating)? URL: https://github.com/apache/incubator-echarts/issues/11135#issuecomment-530324726 Intech Process Automation, Pakistan We have an industrial automation product with business intelligence and IIot. We started off from the superset incubator and now almost all charts available in that plus many more are built in echarts. We have live charts (line, bar, gauge), charts with huge historic data, events coming in from different machines displayed using echart markers, labeling and custom tooltips using echart formatters, and connected charts in which activity on one chart is duplicated in another chart in different format like line chart connected with pie chart here we use the echart events to get the selected window or selected points to render the second chart. I have also added some useful issues in the backlog here like performance improvement for large data-sets using background canvas rendering and showing custom line for empty or null values. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] ahmadalibaloch edited a comment on issue #11135: [SURVEY] What companies are using Apache ECharts (incubating)?
ahmadalibaloch edited a comment on issue #11135: [SURVEY] What companies are using Apache ECharts (incubating)? URL: https://github.com/apache/incubator-echarts/issues/11135#issuecomment-530324726 Intech Process Automation, Pakistan We have an industrial automation product with business intelligence and IIot. We started off from the superset incubator and now almost all charts available in that plus many more are built in echarts. We have live charts (line, bar, gauge), charts with huge historic data, events coming in from different machines displayed using echart markers, labeling and custom tooltips using echart formatters, and connected charts in which activity on one chart is duplicated in another chart in different format like line chart connected with pie chart here we use the echart events to get the selected window or selected points to render the second chart. Before selecting echarts, I evaluated many charting libraries, like highcharts, d3 charting libraries and some canvas libraries. Echarts win for its declarative style of configuration (docs <3 ), a large list of customization options for individual charts, and the variety of charts available with examples. I have also added some useful issues in the backlog here like performance improvement for large data-sets using background canvas rendering and showing custom line for empty or null values. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] ahmadalibaloch edited a comment on issue #11135: [SURVEY] What companies are using Apache ECharts (incubating)?
ahmadalibaloch edited a comment on issue #11135: [SURVEY] What companies are using Apache ECharts (incubating)? URL: https://github.com/apache/incubator-echarts/issues/11135#issuecomment-530324726 Intech Process Automation, Pakistan We have an industrial automation product with business intelligence and IIot. We started off from the superset incubator and now almost all charts available in that plus many more are built in echarts. We have **live charts** (line, bar, gauge), charts with huge **historic data**, events coming in from different machines displayed using **echart markers**, labeling and **custom tooltips** using echart formatters, and **connected charts** in which activity on one chart is duplicated in another chart in different format like line chart connected with pie chart here we use the **echart events** to get the selected window or selected points to render the second chart. Before selecting echarts, I evaluated many charting libraries, like highcharts, d3 charting libraries and some canvas libraries. **Echarts wins for its declarative style of configuration** (docs <3 ), a large list of **customization** options for individual charts, and the **variety of charts** available with examples. I have also added some useful issues in the backlog here like performance improvement for large data-sets using background canvas rendering and showing custom line for empty or null values. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] ahmadalibaloch edited a comment on issue #11135: [SURVEY] What companies are using Apache ECharts (incubating)?
ahmadalibaloch edited a comment on issue #11135: [SURVEY] What companies are using Apache ECharts (incubating)? URL: https://github.com/apache/incubator-echarts/issues/11135#issuecomment-530324726 Intech Process Automation, Pakistan We have an industrial automation product with BI tools. Almost all charts are built in echarts except grids and maps. We have **live charts** (line, bar, gauge), charts with huge **historic data**, events coming in from different machines displayed using **echart markers**, labeling and **custom tooltips** using echart formatters, and **connected charts** in which activity on one chart is duplicated in another chart in different format like line chart connected with pie chart here we use the **echart events** to get the selected window or selected points to render the second chart. Before selecting echarts, I evaluated many charting libraries, like highcharts, d3 charting libraries and some canvas libraries. **Echarts wins for its declarative style of configuration** (docs <3 ), a large list of **customization** options for individual charts, and the **variety of charts** available with examples. I have also added some useful issues in the backlog here like performance improvement for large data-sets using background canvas rendering and showing custom line for empty or null values. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] ITAYC0HEN commented on issue #11024: Graph becomes crazy when zooming in or out
ITAYC0HEN commented on issue #11024: Graph becomes crazy when zooming in or out URL: https://github.com/apache/incubator-echarts/issues/11024#issuecomment-530344308 @Ovilia & @pissang - thank you for your quick response and sorry for my delay. Here is an attached zip file with a mock website. You can use your mouse wheel to zoom in and out and inspect the weird behavior. As a reminder, my goal is to show the labels upon zooming in but hide them when the website is zoomed out to a certain point. [site - mock.zip](https://github.com/apache/incubator-echarts/files/3600582/site.-.mock.zip) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 02/02: test: fix expected/actual screenshot path bug.
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch test-autorun
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 24eff674f0b770cd6bfe6168360c41cbb60bad98
Author: pissang
AuthorDate: Wed Sep 11 20:35:33 2019 +0800
test: fix expected/actual screenshot path bug.
---
test/runTest/cli.js | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/test/runTest/cli.js b/test/runTest/cli.js
index 1bda323..45142d6 100644
--- a/test/runTest/cli.js
+++ b/test/runTest/cli.js
@@ -73,7 +73,7 @@ function replaceEChartsVersion(interceptedRequest, version) {
}
}
-async function takeScreenshot(page, fullPage, fileUrl, desc, version, minor) {
+async function takeScreenshot(page, fullPage, fileUrl, desc, isExpected,
minor) {
let screenshotName = testNameFromFile(fileUrl);
if (desc) {
screenshotName += '-' + slugify(desc, { replacement: '-', lower: true
});
@@ -81,7 +81,7 @@ async function takeScreenshot(page, fullPage, fileUrl, desc,
version, minor) {
if (minor) {
screenshotName += '-' + minor;
}
-let screenshotPrefix = version ? 'expected' : 'actual';
+let screenshotPrefix = isExpected ? 'expected' : 'actual';
fse.ensureDirSync(path.join(__dirname, getScreenshotDir()));
let screenshotPath = path.join(__dirname,
`${getScreenshotDir()}/${screenshotName}-${screenshotPrefix}.png`);
await page.screenshot({
@@ -92,7 +92,7 @@ async function takeScreenshot(page, fullPage, fileUrl, desc,
version, minor) {
return {screenshotName, screenshotPath};
}
-async function runActions(page, testOpt, version, screenshots) {
+async function runActions(page, testOpt, isExpected, screenshots) {
let timeline = new Timeline(page);
let actions;
try {
@@ -114,10 +114,10 @@ async function runActions(page, testOpt, version,
screenshots) {
let count = 0;
async function _innerTakeScreenshot() {
const desc = action.desc || action.name;
-const {screenshotName, screenshotPath} = await
takeScreenshot(page, false, testOpt.fileUrl, desc, version, count++);
+const {screenshotName, screenshotPath} = await
takeScreenshot(page, false, testOpt.fileUrl, desc, isExpected, count++);
screenshots.push({screenshotName, desc, screenshotPath});
}
-await timeline.runAction(action, _innerTakeScreenshot, playbackSpeed);
+await timeline.runAction(action, _innerTakeScreenshot, playbackSpeed);
if (count === 0) {
await waitTime(200);
@@ -131,7 +131,7 @@ async function runActions(page, testOpt, version,
screenshots) {
timeline.stop();
}
-async function runTestPage(browser, testOpt, version, runtimeCode) {
+async function runTestPage(browser, testOpt, version, runtimeCode, isExpected)
{
const fileUrl = testOpt.fileUrl;
const screenshots = [];
const logs = [];
@@ -164,10 +164,10 @@ async function runTestPage(browser, testOpt, version,
runtimeCode) {
// Final shot.
await page.mouse.move(0, 0);
let desc = 'Full Shot';
-const {screenshotName, screenshotPath} = await takeScreenshot(page,
true, fileUrl, desc, version);
+const {screenshotName, screenshotPath} = await takeScreenshot(page,
true, fileUrl, desc, isExpected);
screenshots.push({screenshotName, desc, screenshotPath});
-await runActions(page, testOpt, version, screenshots);
+await runActions(page, testOpt, isExpected, screenshots);
}
catch(e) {
console.error(e);
@@ -192,8 +192,8 @@ async function writePNG(diffPNG, diffPath) {
async function runTest(browser, testOpt, runtimeCode, expectedVersion,
actualVersion) {
testOpt.status === 'running';
-const expectedResult = await runTestPage(browser, testOpt,
expectedVersion, runtimeCode);
-const actualResult = await runTestPage(browser, testOpt, actualVersion,
runtimeCode);
+const expectedResult = await runTestPage(browser, testOpt,
expectedVersion, runtimeCode, true);
+const actualResult = await runTestPage(browser, testOpt, actualVersion,
runtimeCode, false);
// sortScreenshots(expectedResult.screenshots);
// sortScreenshots(actualResult.screenshots);
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch test-autorun updated (abf9cb5 -> 24eff67)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch test-autorun in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from abf9cb5 test: fix echarts version replacement in runtime new ea2c006 test: fix some running status issue in visual regression testing tool new 24eff67 test: fix expected/actual screenshot path bug. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: package-lock.json | 359 + package.json | 17 +- test/runTest/cli.js| 24 +-- test/runTest/client/client.js | 10 +- test/runTest/client/index.html | 4 +- test/runTest/server.js | 56 +-- test/runTest/store.js | 8 +- 7 files changed, 267 insertions(+), 211 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 01/02: test: fix some running status issue in visual regression testing tool
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch test-autorun
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit ea2c006f4c3c5e11e85f2d3e540063cca7dcb5a4
Author: pissang
AuthorDate: Wed Sep 11 20:16:04 2019 +0800
test: fix some running status issue in visual regression testing tool
---
package-lock.json | 359 +
package.json | 17 +-
test/runTest/cli.js| 4 +-
test/runTest/client/client.js | 10 +-
test/runTest/client/index.html | 4 +-
test/runTest/server.js | 56 +--
test/runTest/store.js | 8 +-
7 files changed, 257 insertions(+), 201 deletions(-)
diff --git a/package-lock.json b/package-lock.json
index 8b995ed..58127e3 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -10,7 +10,7 @@
"integrity":
"sha512-27d4lZoomVyo51VegxI20xZPuSHusqbQag/ztrBC7wegWoQ1nLREPVSKSW8byhTlzTKyNE4ifaTA6lCp7JjpFw==",
"dev": true,
"requires": {
-"@babel/highlight": "7.5.0"
+"@babel/highlight": "^7.0.0"
}
},
"@babel/core": {
@@ -19,20 +19,20 @@
"integrity":
"sha512-jRsuseXBo9pN197KnDwhhaaBzyZr2oIcLHHTt2oDdQrej5Qp57dCCJafWx5ivU8/alEYDpssYqv1MUqcxwQlrA==",
"dev": true,
"requires": {
-"@babel/code-frame": "7.5.5",
-"@babel/generator": "7.6.0",
-"@babel/helpers": "7.6.0",
-"@babel/parser": "7.5.5",
-"@babel/template": "7.6.0",
-"@babel/traverse": "7.6.0",
-"@babel/types": "7.6.1",
-"convert-source-map": "1.6.0",
-"debug": "4.1.1",
-"json5": "2.1.0",
-"lodash": "4.17.15",
-"resolve": "1.12.0",
-"semver": "5.7.1",
-"source-map": "0.5.7"
+"@babel/code-frame": "^7.0.0",
+"@babel/generator": "^7.3.4",
+"@babel/helpers": "^7.2.0",
+"@babel/parser": "^7.3.4",
+"@babel/template": "^7.2.2",
+"@babel/traverse": "^7.3.4",
+"@babel/types": "^7.3.4",
+"convert-source-map": "^1.1.0",
+"debug": "^4.1.0",
+"json5": "^2.1.0",
+"lodash": "^4.17.11",
+"resolve": "^1.3.2",
+"semver": "^5.4.1",
+"source-map": "^0.5.0"
},
"dependencies": {
"@babel/template": {
@@ -41,9 +41,9 @@
"integrity":
"sha512-5AEH2EXD8euCk446b7edmgFdub/qfH1SN6Nii3+fyXP807QRx9Q73A2N5hNwRRslC2H9sNzaFhsPubkS4L8oNQ==",
"dev": true,
"requires": {
-"@babel/code-frame": "7.5.5",
-"@babel/parser": "7.6.0",
-"@babel/types": "7.6.1"
+"@babel/code-frame": "^7.0.0",
+"@babel/parser": "^7.6.0",
+"@babel/types": "^7.6.0"
},
"dependencies": {
"@babel/parser": {
@@ -60,9 +60,9 @@
"integrity":
"sha512-X7gdiuaCmA0uRjCmRtYJNAVCc/q+5xSgsfKJHqMN4iNLILX39677fJE1O40arPMh0TTtS9ItH67yre6c7k6t0g==",
"dev": true,
"requires": {
-"esutils": "2.0.3",
-"lodash": "4.17.15",
-"to-fast-properties": "2.0.0"
+"esutils": "^2.0.2",
+"lodash": "^4.17.13",
+"to-fast-properties": "^2.0.0"
}
},
"semver": {
@@ -79,11 +79,11 @@
"integrity":
"sha512-Ms8Mo7YBdMMn1BYuNtKuP/z0TgEIhbcyB8HVR6PPNYp4P61lMsABiS4A3VG1qznjXVCf3r+fVHhm4efTYVsySA==",
"dev": true,
"requires": {
-"@babel/types": "7.6.1",
-"jsesc": "2.5.2",
-"lodash": "4.17.15",
-"source-map": "0.5.7",
-"trim-right": "1.0.1"
+"@babel/types": "^7.6.0",
+"jsesc": "^2.5.1",
+"lodash": "^4.17.13",
+"source-map": "^0.5.0",
+"trim-right": "^1.0.1"
},
"dependencies": {
"@babel/types": {
@@ -92,9 +92,9 @@
"integrity":
"sha512-X7gdiuaCmA0uRjCmRtYJNAVCc/q+5xSgsfKJHqMN4iNLILX39677fJE1O40arPMh0TTtS9ItH67yre6c7k6t0g==",
"dev": true,
"requires": {
-"esutils": "2.0.3",
-"lodash": "4.17.15",
-"to-fast-properties": "2.0.0"
+"esutils": "^2.0.2",
+"lodash": "^4.17.13",
+"to-fast-properties": "^2.0.0"
}
}
}
@@ -105,9 +105,9 @@
"integrity":
"sha512-A95XEoCpb3TO+KZzJ4S/5uW5fNe26DjBGqf1o9ucyLyCmi1dXq/B3c8iaWTfBk3VvetUxl16e8tIrd5teOCfGw==",
"dev": true,
"requires": {
-"@babel/helper-get-function-arity": "7.0.0",
-"@babel/template": "7.6.0",
-"@babel/types": "7.6.1"
+"@babel/helper-get-function-arity": "^7.0.0",
+"@babel/template": "^7.1.0",
+"@babel/types": "^7.0.0"
},
"dependencies": {
"@babel/parser": {
@@ -122,9 +122,9 @@
"integrity":
"sha512-5AEH2EXD8euCk446b7edmgFdub/qfH1SN6Nii3+fyXP807QRx9Q73A2N5hNwRRslC2H9sNzaFhsPubkS4L8oNQ==",
[incubator-echarts] branch test-autorun updated: test: add svg renderer testing. store run config in local
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch test-autorun
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/test-autorun by this push:
new 0f6df50 test: add svg renderer testing. store run config in local
0f6df50 is described below
commit 0f6df508e69cc728bf890d32cfb2f1cf55853bbe
Author: pissang
AuthorDate: Wed Sep 11 21:12:49 2019 +0800
test: add svg renderer testing. store run config in local
---
test/runTest/blacklist.js | 9 -
test/runTest/cli.js| 18 +++---
test/runTest/client/client.js | 12
test/runTest/client/index.html | 9 -
test/runTest/server.js | 27 +++
test/runTest/store.js | 41 +
6 files changed, 91 insertions(+), 25 deletions(-)
diff --git a/test/runTest/blacklist.js b/test/runTest/blacklist.js
index e3d220f..a405b0b 100644
--- a/test/runTest/blacklist.js
+++ b/test/runTest/blacklist.js
@@ -17,7 +17,7 @@
* under the License.
*/
-module.exports = [
+module.exports.blacklist = [
'-cases.html',
'geo-random-stream.html',
'chord.html',
@@ -36,3 +36,10 @@ module.exports = [
'lines-bus.html',
'lines-stream-not-large.html'
];
+
+
+module.exports.SVGBlacklist = [
+'bar-stream-large.html',
+'bar-stream-large1.html',
+'candlestick-large2.html'
+];
\ No newline at end of file
diff --git a/test/runTest/cli.js b/test/runTest/cli.js
index 45142d6..d027e0c 100644
--- a/test/runTest/cli.js
+++ b/test/runTest/cli.js
@@ -34,13 +34,15 @@ program
.option('--no-headless', 'Not headless')
.option('-s, --speed ', 'Playback speed')
.option('--expected ', 'Expected version')
-.option('--actual ', 'Actual version');
+.option('--actual ', 'Actual version')
+.option('--renderer ', 'svg/canvas renderer');
program.parse(process.argv);
program.speed = +program.speed || 1;
program.actual = program.actual || 'local';
program.expected = program.expected || '4.2.1';
+program.renderer = (program.renderer || 'canvas').toLowerCase();
if (!program.tests) {
throw new Error('Tests are required');
@@ -155,7 +157,7 @@ async function runTestPage(browser, testOpt, version,
runtimeCode, isExpected) {
try {
await page.setViewport({width: 800, height: 600});
-await page.goto(`${origin}/test/${fileUrl}`, {
+await
page.goto(`${origin}/test/${fileUrl}?__RENDERER__=${program.renderer}`, {
waitUntil: 'networkidle2',
timeout: 1
});
@@ -191,6 +193,11 @@ async function writePNG(diffPNG, diffPath) {
};
async function runTest(browser, testOpt, runtimeCode, expectedVersion,
actualVersion) {
+if (program.renderer === 'svg' && testOpt.ignoreSVG) {
+console.log(testOpt.name + ' don\'t support svg testing.');
+return;
+}
+
testOpt.status === 'running';
const expectedResult = await runTestPage(browser, testOpt,
expectedVersion, runtimeCode, true);
const actualResult = await runTestPage(browser, testOpt, actualVersion,
runtimeCode, false);
@@ -229,6 +236,7 @@ async function runTest(browser, testOpt, runtimeCode,
expectedVersion, actualVer
testOpt.expectedErrors = expectedResult.errors;
testOpt.actualVersion = actualVersion;
testOpt.expectedVersion = expectedVersion;
+testOpt.useSVG = program.renderer === 'svg';
testOpt.lastRun = Date.now();
}
@@ -244,7 +252,7 @@ async function runTests(pendingTests) {
try {
for (let testOpt of pendingTests) {
-console.log('Running Test', testOpt.name);
+console.log(`Running test: ${testOpt.name}, renderer:
${program.renderer}`);
try {
await runTest(browser, testOpt, runtimeCode, program.expected,
program.actual);
}
@@ -269,6 +277,10 @@ runTests(program.tests.split(',').map(testName => {
fileUrl: fileNameFromTest(testName),
name: testName,
results: [],
+actualLogs: [],
+expectedLogs: [],
+actualErrors: [],
+expectedErrors: [],
status: 'pending'
};
}));
\ No newline at end of file
diff --git a/test/runTest/client/client.js b/test/runTest/client/client.js
index 463b788..9ad2d39 100644
--- a/test/runTest/client/client.js
+++ b/test/runTest/client/client.js
@@ -18,6 +18,7 @@
*/
const socket = io('/client');
+const LOCAL_SAVE_KEY = 'visual-regression-testing-config';
function processTestsData(tests, oldTestsData) {
tests.forEach((test, idx) => {
@@ -74,6 +75,7 @@ const app = new Vue({
replaySpeed: 5,
actualVersion: 'local',
expectedVersion: null,
+renderer: 'canvas',
threads: 1
}
},
@@ -209,6 +211,15 @@ const app = new Vue({
}
});
+// Save and restore
+try {
+
[GitHub] [incubator-echarts] pissang opened a new pull request #11221: Visual regression testing tool: support SVG renderer test and bug fixes.
pissang opened a new pull request #11221: Visual regression testing tool: support SVG renderer test and bug fixes. URL: https://github.com/apache/incubator-echarts/pull/11221 This pull request is about some enhancement and bug fixes on the visual regression testing tool. ### Enhancement + Add SVG renderer testing.  + Store run configuration in local ### Bug fixes. + Fix running status syncing issue on different page, or after page refreshed. + Fix actual screenshot and expected screenshot path are same bug. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch test-autorun updated (0f6df50 -> 0827f16)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch test-autorun in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from 0f6df50 test: add svg renderer testing. store run config in local add 081f24a Fix #8489 geo.label.formatter is not working add 0b08bab Merge pull request #11201 from apache/test-autorun add e81fe3c Merge pull request #11214 from apache/test-autorun add 27dc4cb test: add version selection in visual regression testing tool add 738038b test: case insensitive search add 064d679 test: add more run options. add 4a9f6ec test: remove unused code add e57d21d test: add alert if scroll changed during action recording add 1c9f5b3 test: fix echarts version replacement in runtime add 0827f16 Merge branch 'master' into test-autorun No new revisions were added by this update. Summary of changes: src/coord/geo/GeoModel.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #11221: Visual regression testing tool: support SVG renderer test and bug fixes.
pissang merged pull request #11221: Visual regression testing tool: support SVG renderer test and bug fixes. URL: https://github.com/apache/incubator-echarts/pull/11221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 01/01: Merge pull request #11221 from apache/test-autorun
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git commit 498132d3e3e2fb80267734d00886c4385cbef363 Merge: 1c9f5b3 0827f16 Author: Yi Shen AuthorDate: Wed Sep 11 21:32:49 2019 +0800 Merge pull request #11221 from apache/test-autorun Visual regression testing tool: support SVG renderer test and bug fixes. package-lock.json | 359 + package.json | 17 +- test/runTest/blacklist.js | 9 +- test/runTest/cli.js| 42 +++-- test/runTest/client/client.js | 22 ++- test/runTest/client/index.html | 13 +- test/runTest/server.js | 83 +++--- test/runTest/store.js | 49 -- 8 files changed, 358 insertions(+), 236 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch master updated (1c9f5b3 -> 498132d)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from 1c9f5b3 test: fix echarts version replacement in runtime add bf3a0ae test: add version selection in visual regression testing tool add 61e5a01 test: case insensitive search add d561931 test: add more run options. add 77d3aa7 test: remove unused code add 3b43fbb test: add alert if scroll changed during action recording add abf9cb5 test: fix echarts version replacement in runtime add ea2c006 test: fix some running status issue in visual regression testing tool add 24eff67 test: fix expected/actual screenshot path bug. add 0f6df50 test: add svg renderer testing. store run config in local add 0827f16 Merge branch 'master' into test-autorun new 498132d Merge pull request #11221 from apache/test-autorun The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: package-lock.json | 359 + package.json | 17 +- test/runTest/blacklist.js | 9 +- test/runTest/cli.js| 42 +++-- test/runTest/client/client.js | 22 ++- test/runTest/client/index.html | 13 +- test/runTest/server.js | 83 +++--- test/runTest/store.js | 49 -- 8 files changed, 358 insertions(+), 236 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch test-autorun updated: test: add test preview for screenshot.
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch test-autorun
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/test-autorun by this push:
new 04eefd5 test: add test preview for screenshot.
04eefd5 is described below
commit 04eefd52a7e5e80061d182b8320f72824b071a9e
Author: pissang
AuthorDate: Wed Sep 11 22:48:42 2019 +0800
test: add test preview for screenshot.
---
test/lib/config.js | 24 ---
test/runTest/blacklist.js | 3 +++
test/runTest/cli.js| 2 +-
test/runTest/client/client.css | 13 +
test/runTest/client/client.js | 23 ++
test/runTest/client/index.html | 44 +-
6 files changed, 75 insertions(+), 34 deletions(-)
diff --git a/test/lib/config.js b/test/lib/config.js
index 5409c4a..9b04aa0 100644
--- a/test/lib/config.js
+++ b/test/lib/config.js
@@ -25,22 +25,32 @@
// `true` by default for debugging.
sourceMap == null && (sourceMap = true);
+var params = {};
+location.search.slice(1).split('&').forEach(item => {
+var kv = item.split('=');
+params[kv[0]] = kv[1];
+});
// Set default renderer in dev mode from hash.
-var matchResult =
location.href.match(/[?&]__RENDERER__=(canvas|svg)(&|$)/);
-if (matchResult) {
-window.__ECHARTS__DEFAULT__RENDERER__ = matchResult[1];
+if (params.__RENDERER__) {
+window.__ECHARTS__DEFAULT__RENDERER__ = params.__RENDERER__;
}
// Set echarts source code.
-var matchResult =
location.href.match(/[?&]__ECDIST__=(webpack-req-ec|webpack-req-eclibec|webpackold-req-ec|webpackold-req-eclibec)(&|$)/);
-var ecDistPath = 'dist/echarts';
-if (matchResult) {
+var ecDistPath;
+if (params.__ECDIST__) {
ecDistPath = ({
'webpack-req-ec':
'../echarts-boilerplate/echarts-webpack/dist/webpack-req-ec',
'webpack-req-eclibec':
'../echarts-boilerplate/echarts-webpack/dist/webpack-req-eclibec',
'webpackold-req-ec':
'../echarts-boilerplate/echarts-webpackold/dist/webpackold-req-ec',
'webpackold-req-eclibec':
'../echarts-boilerplate/echarts-webpackold/dist/webpackold-req-eclibec',
-})[matchResult[1]];
+})[params.__ECDIST__];
+if (!ecDistPath && params.__ECDIST__.match(/[0-9.]/)) {
+// Version number
+ecDistPath = 'test/runTest/tmp/__version__/' + params.__ECDIST__ +
'/echarts';
+}
+}
+if (!ecDistPath) {
+ecDistPath = 'dist/echarts';
}
if (typeof require !== 'undefined') {
diff --git a/test/runTest/blacklist.js b/test/runTest/blacklist.js
index a405b0b..86da51a 100644
--- a/test/runTest/blacklist.js
+++ b/test/runTest/blacklist.js
@@ -31,6 +31,9 @@ module.exports.blacklist = [
'scatter-gps.html',
'webkit-dep.html',
+// Image size not match
+'symbol2.html',
+
// This case will have timeout
'visualMap-performance1.html',
'lines-bus.html',
diff --git a/test/runTest/cli.js b/test/runTest/cli.js
index d027e0c..a0940d4 100644
--- a/test/runTest/cli.js
+++ b/test/runTest/cli.js
@@ -162,7 +162,7 @@ async function runTestPage(browser, testOpt, version,
runtimeCode, isExpected) {
timeout: 1
});
-await waitTime(200); // Wait for animation or something else. Pending
+await waitTime(500); // Wait for animation or something else. Pending
// Final shot.
await page.mouse.move(0, 0);
let desc = 'Full Shot';
diff --git a/test/runTest/client/client.css b/test/runTest/client/client.css
index 1dc5484..8a2c598 100644
--- a/test/runTest/client/client.css
+++ b/test/runTest/client/client.css
@@ -170,6 +170,14 @@
margin-top: 60px;
}
+.test-screenshots .preview {
+cursor: pointer;
+color: #409eff;
+}
+.test-screenshots .preview:hover {
+text-decoration: underline;
+}
+
.test-screenshots img {
/* height: 200px; */
width: 100%;
@@ -196,6 +204,11 @@
color: #f56c6c
}
+iframe {
+border: none;
+overflow: overlay;
+}
+
::-webkit-scrollbar {
height: 8px;
diff --git a/test/runTest/client/client.js b/test/runTest/client/client.js
index 9ad2d39..d574574 100644
--- a/test/runTest/client/client.js
+++ b/test/runTest/client/client.js
@@ -70,6 +70,10 @@ const app = new Vue({
versions: [],
+showIframeDialog: false,
+previewIframeSrc: '',
+previewTitle: '',
+
runConfig: {
noHeadless: false,
replaySpeed: 5,
@@ -207,6 +211,25 @@ const app = new Vue({
stopTests() {
this.running = false;
socket.emit('stop');
+},
+
+preview(test, version) {
+let searches = [];
+
+let ecVersion = test[version + 'Version'];
+if (ecVersion
[GitHub] [incubator-echarts-doc] Ovilia merged pull request #62: visualMap piecewise.categories dataValue typo correction
Ovilia merged pull request #62: visualMap piecewise.categories dataValue typo correction URL: https://github.com/apache/incubator-echarts-doc/pull/62 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts-doc] branch master updated: visualMap piecewise.categories dataValue typo correction
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-echarts-doc.git The following commit(s) were added to refs/heads/master by this push: new 214c8f1 visualMap piecewise.categories dataValue typo correction 214c8f1 is described below commit 214c8f197325cd6990c921617b7a023a31e83a5c Author: Steven Cobb AuthorDate: Tue Aug 27 10:01:25 2019 -0400 visualMap piecewise.categories dataValue typo correction --- en/option/component/visual-map-piecewise.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/en/option/component/visual-map-piecewise.md b/en/option/component/visual-map-piecewise.md index d548470..09c2782 100644 --- a/en/option/component/visual-map-piecewise.md +++ b/en/option/component/visual-map-piecewise.md @@ -72,7 +72,7 @@ You would realize the sequence in `pieces` by a simple trial. See more detailed ## categories(Array) -When dataValues in series.data (specified by [visualMap-piecewise.dimension](~visualMap-piecewise.dimension)) are discrete (or also known as category data or enumerable data), and we intend to perform **Table Mapping** from dataVale to visual channels, `categories` is used to describe the entire enumeration of data. For instance: +When dataValues in series.data (specified by [visualMap-piecewise.dimension](~visualMap-piecewise.dimension)) are discrete (or also known as category data or enumerable data), and we intend to perform **Table Mapping** from dataValue to visual channels, `categories` is used to describe the entire enumeration of data. For instance: ```javascript categories: [ - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on issue #62: visualMap piecewise.categories dataValue typo correction
Ovilia commented on issue #62: visualMap piecewise.categories dataValue typo correction URL: https://github.com/apache/incubator-echarts-doc/pull/62#issuecomment-530477410 @sjcobb Thanks for the help! :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia merged pull request #61: fix broken tutorial link in dataset options
Ovilia merged pull request #61: fix broken tutorial link in dataset options URL: https://github.com/apache/incubator-echarts-doc/pull/61 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts-doc] branch master updated: fix broken tutorial link in dataset options
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-echarts-doc.git The following commit(s) were added to refs/heads/master by this push: new 73d54a9 fix broken tutorial link in dataset options 73d54a9 is described below commit 73d54a98297c6123ea8dfab5354b39dbbd1ab5dd Author: Steven Cobb AuthorDate: Tue Aug 27 09:47:42 2019 -0400 fix broken tutorial link in dataset options --- en/option/component/dataset.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/en/option/component/dataset.md b/en/option/component/dataset.md index cac1253..d28efea 100644 --- a/en/option/component/dataset.md +++ b/en/option/component/dataset.md @@ -5,7 +5,7 @@ `dataset` component is published since ECharts 4. `dataset` brings convenience in data management separated with styles and enables data reuse by different series. More importantly, is enables data encoding from data to visual, which brings convenience in some scenarios. -More details about `dataset` can be checked in the [tutorial](https://ecomfe.github.io/echarts-doc/public/en/tutorial.html#dataset). +More details about `dataset` can be checked in the [tutorial](https://echarts.apache.org/en/tutorial.html#Dataset). --- - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on issue #61: fix broken tutorial link in dataset options
Ovilia commented on issue #61: fix broken tutorial link in dataset options URL: https://github.com/apache/incubator-echarts-doc/pull/61#issuecomment-530477856 Thanks @sjcobb We really appreciate your help with the doc! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch master updated (498132d -> 644922e)
This is an automated email from the ASF dual-hosted git repository. deqingli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from 498132d Merge pull request #11221 from apache/test-autorun new bb2d7d3 doc(tree): add annotation about tree root disappear after roam new 6217cd0 Merge remote-tracking branch 'upstream/master' new 16dd99d fix: dataStack work incorrectly with toolbox dataZoom #10972 #8520 #7534 #10359 #8069 #7872 #7732 #7672 new 414096f test: add dataStack with dataZoom test new c54e60a Merge remote-tracking branch 'upstream/master' new d4d2586 Merge remote-tracking branch 'upstream/master' new 9f2abd0 doc(tree): update code annotation new 7574e1e text: add automatic test material for stackBar-dataZoom demo new 69f8254 fix: merge upstream with conflicts fixed new 644922e Merge pull request #11213 from deqingli/master The 5371 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/chart/tree/TreeView.js |2 + src/component/legend.js |2 +- src/echarts.js |5 +- src/processor/dataStack.js |2 +- test/runTest/actions/__meta__.json |3 +- test/runTest/actions/stackBar-dataZoom.json |1 + test/stackBar-dataZoom.html | 1431 +++ 7 files changed, 1442 insertions(+), 4 deletions(-) create mode 100644 test/runTest/actions/stackBar-dataZoom.json create mode 100644 test/stackBar-dataZoom.html - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] deqingli merged pull request #11213: Fix dataStack work incorrectly with dataZoom
deqingli merged pull request #11213: Fix dataStack work incorrectly with dataZoom URL: https://github.com/apache/incubator-echarts/pull/11213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] 13387635653 opened a new issue #11222: 仪表盘区域设置标题问题
13387635653 opened a new issue #11222: 仪表盘区域设置标题问题 URL: https://github.com/apache/incubator-echarts/issues/11222 仪表盘可以设置区域颜色等，但是没法给每个区域设置自己的标题。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-robot[bot] closed issue #11222: 仪表盘区域设置标题问题
echarts-robot[bot] closed issue #11222: 仪表盘区域设置标题问题 URL: https://github.com/apache/incubator-echarts/issues/11222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11222: 仪表盘区域设置标题问题
echarts-robot[bot] commented on issue #11222: 仪表盘区域设置标题问题 URL: https://github.com/apache/incubator-echarts/issues/11222#issuecomment-530647149 This issue is not created using [issue template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close it. 🙊 Sorry for this, but it helps save our maintainers' time so that more developers get helped. Feel free to create another issue using the issue template. If you think you have already made your point clear without the template, or your problem cannot be covered by it, you may re-open this issue again. 这个 issue 未使用 [issue 模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。 为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。 如果您愿意，可以请使用 issue 模板重新创建 issue。 如果你认为虽然没有使用模板，但你已经提供了复现问题的充分描述，或者你的问题无法使用模板表达，也可以重新 open 这个 issue。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] 13387635653 opened a new issue #11223: 仪表盘无法给每个颜色区域添加标题
13387635653 opened a new issue #11223: 仪表盘无法给每个颜色区域添加标题
URL: https://github.com/apache/incubator-echarts/issues/11223
### What problem does this feature solve?
比如要用到仪表盘展示阶梯信息，第一阶梯，第二阶梯等；区域颜色可以通过数组控制，但是对应的区域没法知道具体代表什么意思，需要为其添加一个标题。
### What does the proposed API look like?
axisLine: {
lineStyle: {
color:[[0.2, '#91c7ae','区域标题1'], [0.8, '#63869e','区域标题2'],
[1, '#c23531','区域标题3']]
}
}
可以直接在原来设置颜色区域的后面添加一个标题，然后字体颜色自动根据区域显示，并且字的展示方向就沿着仪表盘对应区域内侧居中显示
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11223: 仪表盘无法给每个颜色区域添加标题
echarts-robot[bot] commented on issue #11223: 仪表盘无法给每个颜色区域添加标题 URL: https://github.com/apache/incubator-echarts/issues/11223#issuecomment-530650208 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org . If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Justming opened a new issue #11224: 请问通过Java直接渲染图表并生成图片是否有可用方案？
Justming opened a new issue #11224: 请问通过Java直接渲染图表并生成图片是否有可用方案？ URL: https://github.com/apache/incubator-echarts/issues/11224 This issue is not created by [echarts-issue-helper](https://ecomfe.github.io/echarts-issue-helper) and will be soon closed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-robot[bot] closed issue #11224: 请问通过Java直接渲染图表并生成图片是否有可用方案？
echarts-robot[bot] closed issue #11224: 请问通过Java直接渲染图表并生成图片是否有可用方案？ URL: https://github.com/apache/incubator-echarts/issues/11224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11224: 请问通过Java直接渲染图表并生成图片是否有可用方案？
echarts-robot[bot] commented on issue #11224: 请问通过Java直接渲染图表并生成图片是否有可用方案？ URL: https://github.com/apache/incubator-echarts/issues/11224#issuecomment-530650761 This issue is not created using [issue template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close it. 🙊 Sorry for this, but it helps save our maintainers' time so that more developers get helped. Feel free to create another issue using the issue template. If you think you have already made your point clear without the template, or your problem cannot be covered by it, you may re-open this issue again. 这个 issue 未使用 [issue 模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。 为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。 如果您愿意，可以请使用 issue 模板重新创建 issue。 如果你认为虽然没有使用模板，但你已经提供了复现问题的充分描述，或者你的问题无法使用模板表达，也可以重新 open 这个 issue。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] 13387635653 commented on issue #11223: 仪表盘无法给每个颜色区域添加标题
13387635653 commented on issue #11223: 仪表盘无法给每个颜色区域添加标题 URL: https://github.com/apache/incubator-echarts/issues/11223#issuecomment-530651280 期望的效果图片如下：  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-robot[bot] closed issue #11225: 4.2.1 版本: echarts.js:67821 Uncaught TypeError: Cannot read property 'style' of undefined
echarts-robot[bot] closed issue #11225: 4.2.1 版本: echarts.js:67821 Uncaught TypeError: Cannot read property 'style' of undefined URL: https://github.com/apache/incubator-echarts/issues/11225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11225: 4.2.1 版本: echarts.js:67821 Uncaught TypeError: Cannot read property 'style' of undefined
echarts-robot[bot] commented on issue #11225: 4.2.1 版本: echarts.js:67821 Uncaught TypeError: Cannot read property 'style' of undefined URL: https://github.com/apache/incubator-echarts/issues/11225#issuecomment-530660163 This issue is not created using [issue template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close it. 🙊 Sorry for this, but it helps save our maintainers' time so that more developers get helped. Feel free to create another issue using the issue template. If you think you have already made your point clear without the template, or your problem cannot be covered by it, you may re-open this issue again. 这个 issue 未使用 [issue 模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。 为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。 如果您愿意，可以请使用 issue 模板重新创建 issue。 如果你认为虽然没有使用模板，但你已经提供了复现问题的充分描述，或者你的问题无法使用模板表达，也可以重新 open 这个 issue。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] soindy opened a new issue #11225: 4.2.1 版本: echarts.js:67821 Uncaught TypeError: Cannot read property 'style' of undefined
soindy opened a new issue #11225: 4.2.1 版本: echarts.js:67821 Uncaught TypeError: Cannot read property 'style' of undefined URL: https://github.com/apache/incubator-echarts/issues/11225 echarts.js:67821 Uncaught TypeError: Cannot read property 'style' of undefined at ExtendedClass.updatePointerEl (echarts.js:67821) at ExtendedClass.render (echarts.js:67721) at updateAxisPointer (echarts.js:40769) at ExtendedClass.updateAxisPointer (echarts.js:40739) at callView (echarts.js:27780) at Array.forEach () at each$1 (echarts.js:528) at updateDirectly (echarts.js:27753) at ECharts. (echarts.js:27971) at Array.forEach () updatePointerEl @ echarts.js:67821 render @ echarts.js:67721 updateAxisPointer @ echarts.js:40769 updateAxisPointer @ echarts.js:40739 callView @ echarts.js:27780 each$1 @ echarts.js:528 updateDirectly @ echarts.js:27753 (anonymous) @ echarts.js:27971 each$1 @ echarts.js:528 doDispatchAction @ echarts.js:27956 echartsProto.dispatchAction @ echarts.js:27909 (anonymous) @ echarts.js:645 dispatchAction @ echarts.js:67496 (anonymous) @ echarts.js:67559 doEnter @ echarts.js:67476 (anonymous) @ echarts.js:657 (anonymous) @ echarts.js:67446 each$1 @ echarts.js:538 (anonymous) @ echarts.js:67445 trigger @ echarts.js:1475 dispatchToElement @ echarts.js:2160 mousemove @ echarts.js:2062 trigger @ echarts.js:1475 mousemove @ echarts.js:10587 (anonymous) @ echarts.js:10773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] icetimidus opened a new issue #11226: 柱状图中series指定的dataset定位错误
icetimidus opened a new issue #11226: 柱状图中series指定的dataset定位错误 URL: https://github.com/apache/incubator-echarts/issues/11226 ### Version 4.2.1 ### Reproduction link [https://gallery.echartsjs.com/editor.html?c=xZQjtEQlY7&v=1](https://gallery.echartsjs.com/editor.html?c=xZQjtEQlY7&v=1) ### Steps to reproduce 详见链接 ### What is expected? 指定的dataset数据定位正确 ### What is actually happening? 其中“ECM”与“公司业务系统”均显示成了“ECM”的数据 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11226: 柱状图中series指定的dataset定位错误
echarts-robot[bot] commented on issue #11226: 柱状图中series指定的dataset定位错误 URL: https://github.com/apache/incubator-echarts/issues/11226#issuecomment-530668504 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org . If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] drumslave-git commented on issue #8151: dataset 可以为每个数据指定样式
drumslave-git commented on issue #8151: dataset 可以为每个数据指定样式
URL:
https://github.com/apache/incubator-echarts/issues/8151#issuecomment-530690619
Hi.
If anyone needs it, I found a workaround.
My dataset looks like this:
```
{source: [
{value: 15, name: 'test', color: '#FF00FF'},
...
]}
```
Before chart init you need to add such code
```
import echarts from 'echarts';
const VISUAL_PRIORITY = echarts.PRIORITY.VISUAL.COMPONENT;
echarts.registerVisual(VISUAL_PRIORITY, {
createOnAllSeries: true,
reset: function (seriesModel) {
const data = seriesModel.getData();
data.each(function (idx) {
const itemModel = data.getItemModel(idx);
let color = itemModel.get('itemStyle.color');
if(!color){ // if there is no color set in normal way
color = itemModel.get('color');
if(color && typeof color === 'string'){ // if there is no
such field in dataset, it can return array (default color palette)
data.setItemVisual(idx, 'color', color);
}
}
});
}
});
```
After this you can init charts as always. Using such approach you can do any
calculations based on your dataset item data to determine color.
Don't know if it is good, but works for me and I got no other choice.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
