[incubator-echarts] branch next updated: fix(map): fix label not display on map
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/next by this push:
new f9307c7 fix(map): fix label not display on map
f9307c7 is described below
commit f9307c75901d099dbca95fe73a929d75a650bcd0
Author: pissang
AuthorDate: Fri Jul 10 13:53:39 2020 +0800
fix(map): fix label not display on map
---
src/chart/map/MapView.ts| 68 +++--
src/component/helper/MapDraw.ts | 2 --
src/util/graphic.ts | 8 ++---
3 files changed, 19 insertions(+), 59 deletions(-)
diff --git a/src/chart/map/MapView.ts b/src/chart/map/MapView.ts
index 9a7292c..2ced9f5 100644
--- a/src/chart/map/MapView.ts
+++ b/src/chart/map/MapView.ts
@@ -18,36 +18,22 @@
*/
-import * as zrUtil from 'zrender/src/core/util';
import * as graphic from '../../util/graphic';
import MapDraw from '../../component/helper/MapDraw';
import ChartView from '../../view/Chart';
import MapSeries, { MapDataItemOption } from './MapSeries';
import GlobalModel from '../../model/Global';
import ExtensionAPI from '../../ExtensionAPI';
-import { Payload } from '../../util/types';
+import { Payload, DisplayState, ECElement } from '../../util/types';
import Model from '../../model/Model';
-
-const HIGH_DOWN_PROP = '__seriesMapHighDown' as const;
-const RECORD_VERSION_PROP = '__seriesMapCallKey' as const;
-const ORIGINAL_Z2 = '__mapOriginalZ2' as const;
-
-interface CircleExtend extends graphic.Circle {
-[ORIGINAL_Z2]: number;
-}
interface HighDownRecord {
recordVersion: number;
-circle: CircleExtend;
labelModel: Model;
hoverLabelModel: Model;
emphasisText: string;
normalText: string;
};
-interface RegionGroupExtend extends graphic.Group {
-[HIGH_DOWN_PROP]: HighDownRecord;
-[RECORD_VERSION_PROP]: number;
-}
class MapView extends ChartView {
@@ -175,7 +161,7 @@ class MapView extends ChartView {
const labelModel = itemModel.getModel('label');
const hoverLabelModel = itemModel.getModel(['emphasis',
'label']);
-const regionGroup = fullData.getItemGraphicEl(fullIndex) as
RegionGroupExtend;
+const regionGroup = fullData.getItemGraphicEl(fullIndex);
// `getFormattedLabel` needs to use `getData` inside. Here
// `mapModel.getData()` is shallow cloned from
`mainSeries.getData()`.
@@ -184,43 +170,23 @@ class MapView extends ChartView {
// set on original data item will never get. But it has been
working
// like that from the begining, and this scenario is rarely
encountered.
// So it won't be fixed until have to.
-const normalText = zrUtil.retrieve2(
-mapModel.getFormattedLabel(fullIndex, 'normal'),
-name
-);
-const emphasisText = zrUtil.retrieve2(
-mapModel.getFormattedLabel(fullIndex, 'emphasis'),
-normalText
-);
-
-let highDownRecord = regionGroup[HIGH_DOWN_PROP];
-const recordVersion = Math.random();
-
-// Prevent from register listeners duplicatedly when roaming.
-if (!highDownRecord) {
-highDownRecord = regionGroup[HIGH_DOWN_PROP] = {} as
HighDownRecord;
-// let onEmphasis = zrUtil.curry(onRegionHighDown, true);
-// let onNormal = zrUtil.curry(onRegionHighDown, false);
-// regionGroup.on('mouseover', onEmphasis)
-// .on('mouseout', onNormal)
-// .on('emphasis', onEmphasis)
-// .on('normal', onNormal);
-}
-// Prevent removed regions effect current grapics.
-regionGroup[RECORD_VERSION_PROP] = recordVersion;
-zrUtil.extend(highDownRecord, {
-recordVersion,
-circle,
-labelModel,
-hoverLabelModel,
-emphasisText,
-normalText
-} as HighDownRecord);
+graphic.setLabelStyle(circle, labelModel, hoverLabelModel, {
+labelFetcher: {
+getFormattedLabel(idx: number, state: DisplayState) {
+return mapModel.getFormattedLabel(fullIndex,
state);
+}
+}
+});
+if (!labelModel.get('position')) {
+circle.setTextConfig({
+position: 'bottom'
+});
+}
-// FIXME
-// Consider set option when emphasis.
-//
[GitHub] [incubator-echarts] liyangyangi commented on issue #12920: 希望直角坐标系新增单位字段显示在轴的顶部
liyangyangi commented on issue #12920: URL: https://github.com/apache/incubator-echarts/issues/12920#issuecomment-656460413 就是新增一条空的Y轴只定义单位吗，好像可以，我怎么没想到呢哈哈我晚会试试，谢谢你 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12950: line showtip的一个疑问
echarts-bot[bot] commented on issue #12950: URL: https://github.com/apache/incubator-echarts/issues/12950#issuecomment-656459408 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical questions. If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] theDoinb opened a new issue #12950: line showtip的一个疑问
theDoinb opened a new issue #12950: URL: https://github.com/apache/incubator-echarts/issues/12950 ### Version 4.8.0 ### Reproduction link [https://gallery.echartsjs.com/editor.html?c=xAzDC4SR72=1](https://gallery.echartsjs.com/editor.html?c=xAzDC4SR72=1) ### Steps to reproduce 图表在一个范围内似乎showtip 失效还是被遮挡的感觉。 例如我打开个链接那图，将浏览器缩小至916*250，910*183...，就缩小到差不多随意伸缩下应该都能看到轮播消失了， 往大或往小showtip似乎都是正常的 ### What is expected? 多y轴showtip是正常的 ### What is actually happening? 多y轴showtip在某些大小下是异常的 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] yufeng04 commented on issue #12920: 希望直角坐标系新增单位字段显示在轴的顶部
yufeng04 commented on issue #12920:
URL:
https://github.com/apache/incubator-echarts/issues/12920#issuecomment-656457401
```
yAxis:[
{
type: 'value',
name: 'title',
nameLocation: 'middle',
position:'left'
},
{
type: 'value',
name: 'unit',
nameLocation: 'end',
position:'left'
}
]
```
这样可以满足需求吗？
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] JsDeng closed issue #12910: ECHARTS is not friendly to RGBA support
JsDeng closed issue #12910: URL: https://github.com/apache/incubator-echarts/issues/12910 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] JsDeng commented on issue #12910: ECHARTS is not friendly to RGBA support
JsDeng commented on issue #12910: URL: https://github.com/apache/incubator-echarts/issues/12910#issuecomment-656452855 > ### Version > 4.8.0 > > ### Reproduction link > https://gallery.echartsjs.com/editor.html?c=xGAcmLY-q9=2 > > ### Steps to reproduce > The mouse slides in several bars to reproduce > > ### What is expected? > The mouse hovers over the liability column and the bar chart is displayed normally > > ### What is actually happening? > Hover over the liability column, the bar chart does not show > > The problem will occur with RGBA color values > Hi, I'm afraid that there is an incorrect usage of the color of `rgba` and `rgb`. > If `rgba` is used, it should be like `rgba(158, 208, 255, 1)`, that is, four parameters should be provided. > If `rgb` is used, it should be like `rgb(158, 208, 255)`, that is, three parameters should be provided. > > Please have a try again according to this. Thank you for being busy to demystify me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch next updated (4c3b1b2 -> e64f712)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch next in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from 4c3b1b2 Merge pull request #12911 from apache/label-enhancement add e64f712 fix(map): fix label not update on roam bug in map No new revisions were added by this update. Summary of changes: src/chart/map/MapView.ts| 14 +++--- src/component/helper/MapDraw.ts | 19 --- 2 files changed, 19 insertions(+), 14 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch state updated (f0dd14f -> 8ea9498)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch state in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from f0dd14f feat(animation): apply fade out animation on more series add 4c3b1b2 Merge pull request #12911 from apache/label-enhancement add e64f712 fix(map): fix label not update on roam bug in map add 8ea9498 Merge branch 'next' into state No new revisions were added by this update. Summary of changes: src/chart/map/MapView.ts| 14 +++--- src/component/helper/MapDraw.ts | 19 --- 2 files changed, 19 insertions(+), 14 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] ferrydjing commented on issue #12869: echarts tree图单个节点设置linestyle无效
ferrydjing commented on issue #12869:
URL:
https://github.com/apache/incubator-echarts/issues/12869#issuecomment-656451623
> data.children[i].lineStyle = {
> color: '#2b3878',
> width: 2
> }
> 这样也可以单个设置
这样应该不行吧，这种和我的用法没有区别的样子
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang closed issue #12948: echarts tree图如何增加每个分支的流向动画
pissang closed issue #12948: URL: https://github.com/apache/incubator-echarts/issues/12948 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia edited a comment on pull request #12859: feat: time axis label formatter
Ovilia edited a comment on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655945171 @quillblue Thanks for your comments. Here are my thoughts on this. ## Primary & Secondary Ticks I think secondary ticks may not be a minor tick. Consider the following case: ``` |_|_|_|__ ... 2020 Feb Mar Apr ``` By our definition, `2020` is a primary tick since it's in the year level, while others are secondary ticks because they are in the month level. But in most cases, the tick color of `2020` may not be different than others while text color may be different. Also, primary and secondary are two default rich text styles we provide. There may also be a tertiary level like week info in the above case. So major and minor ticks may not deal with situations like this. ## i18n First, we have to provide some frequently used formats like `'HH:mm:ss'`. It's unwise to ask users to install another library if they want simple time formats like this. On the other side, if we provide too many formats, it will increase package size while most people won't use it. So we should be prudent when deciding which formats to support. Here are my proposed formatters supported: | Group| Template | Examples (EN) | (ZH) | [Moment.js](https://momentjs.com/docs/#/displaying/) | [date-fns](https://date-fns.org/v2.14.0/docs/format) | |--|--|---||---|--| | Year | | 2020, 1990|| | SAME | | | yy | 20, 90|| YY| SAME | | Quarter | Q| 1, 2 || SAME | SAME | | Month| | January, February | 一月、二月 | SAME | SAME | | | MMM | Jan, Feb | 一、二 | SAME | SAME | | | MM | 01, 02|| SAME | SAME | | | M| 1, 2 || SAME | SAME | | Week of Year | ww | 01, 02|| SAME | SAME | | | w| 1, 2 || SAME | SAME | | Day of Month | dd | 01, 02|| DD| SAME | | | d| 1, 2 || D | SAME | | Day of Week | | Monday, Tuesday | 周一、周二星期一、星期二 | | SAME | | | e | M, T | 一、二 | ddd | SAME | | | e| 1, 2 || d | SAME | | Hour | HH | 00, 23|| SAME | SAME | | | H| 0, 23 || SAME | SAME | | Minute | mm | 00, 01|| SAME | SAME | | | m| 0, 1 || SAME | SAME | | Second | ss | 00, 01|| SAME | SAME | | | s| 0, 1 || SAME | SAME | | Millisecond | SSS | 000, 001 || SAME | SAME | | | S| 0, 1 || SAME | SAME | This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] confirmTing commented on issue #12944: 希望可以支持堆叠图正序，或者倒序的配置
confirmTing commented on issue #12944: URL: https://github.com/apache/incubator-echarts/issues/12944#issuecomment-656443673 @plainheart 非常感谢！ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] confirmTing closed issue #12944: 希望可以支持堆叠图正序，或者倒序的配置
confirmTing closed issue #12944: URL: https://github.com/apache/incubator-echarts/issues/12944 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12949: echarts tree图如何增加每个分支的流向动画
echarts-bot[bot] commented on issue #12949: URL: https://github.com/apache/incubator-echarts/issues/12949#issuecomment-656431684 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical questions. If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] CodeBogey opened a new issue #12949: echarts tree图如何增加每个分支的流向动画
CodeBogey opened a new issue #12949: URL: https://github.com/apache/incubator-echarts/issues/12949 ### Version 4.8.0 ### Steps to reproduce echarts tree图如何增加每个分支的流向动画 ### What is expected? echarts tree图如何增加每个分支的流向动画 ### What is actually happening? echarts tree图如何增加每个分支的流向动画 --- echarts tree图如何增加每个分支的流向动画 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12948: echarts tree图如何增加每个分支的流向动画
echarts-bot[bot] commented on issue #12948: URL: https://github.com/apache/incubator-echarts/issues/12948#issuecomment-656431059 This issue is not created using [issue template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close it. Sorry for this, but it helps save our maintainers' time so that more developers get helped. Feel free to create another issue using the issue template. If you think you have already made your point clear without the template, or your problem cannot be covered by it, you may re-open this issue again. 这个 issue 未使用 [issue 模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。 为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。 如果您愿意，可以请使用 issue 模板重新创建 issue。 如果你认为虽然没有使用模板，但你已经提供了复现问题的充分描述，或者你的问题无法使用模板表达，也可以重新 open 这个 issue。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] CodeBogey opened a new issue #12948: echarts tree图如何增加每个分支的流向动画
CodeBogey opened a new issue #12948: URL: https://github.com/apache/incubator-echarts/issues/12948 This issue is not created by [echarts-issue-helper](https://ecomfe.github.io/echarts-issue-helper) and will be soon closed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] CodeBogey commented on issue #12869: echarts tree图单个节点设置linestyle无效
CodeBogey commented on issue #12869:
URL:
https://github.com/apache/incubator-echarts/issues/12869#issuecomment-656429671
data.children[i].lineStyle = {
color: '#2b3878',
width: 2
}
这样也可以单个设置
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 opened a new pull request #12947: Tooltip
susiwen8 opened a new pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947 ## Brief Information This pull request is in the type of: - [ ] bug fixing - [ ] new feature - [x] others ### What does this PR do? New tooltip style for 5.0 ### Fixed issues Close https://github.com/apache/incubator-echarts/issues/12929 ## Details ### Before: What was the problem? ### After: How is it fixed in this PR? ## Usage ### Are there any API changes? - [ ] The API has been changed. ### Related test cases or examples to use the new APIs NA. ## Others ### Merging options - [x] Please squash the commits into a single one when merge. ### Other information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12947: Tooltip
echarts-bot[bot] commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-656195254 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on issue #12944: 希望可以支持堆叠图正序，或者倒序的配置
plainheart commented on issue #12944: URL: https://github.com/apache/incubator-echarts/issues/12944#issuecomment-656104765 和 #12929 的部分需求有些相关，不过这个目前通过调整 legend 顺序和使用 tooltip formatter 暂时也可以实现，示例：https://gallery.echartsjs.com/editor.html?c=x2f1uPXMSK=1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] plainheart closed issue #12945: Convert JSON file to GEXF file format
plainheart closed issue #12945: URL: https://github.com/apache/incubator-echarts/issues/12945 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] felicia-lim2503 opened a new issue #12946: Converting JSON file to GEXF file format
felicia-lim2503 opened a new issue #12946: URL: https://github.com/apache/incubator-echarts/issues/12946 ### What problem does this feature solve? I'm currently using Javascript to implement the circular layout graph (https://echarts.apache.org/examples/en/editor.html?c=graph-circular-layout). The input data used in the sample codes uses JSON file and it is converted to GEXF file. However, there is no available JSON file to GEXF file converter available over the internet. Really hope there is a solution for this as I can't find any other solutions. Thank you! ### What does the proposed API look like? A JSON file to GEXF file converter - converts JSON file to GEXF file to insert data into echarts circular layout graph. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12946: Converting JSON file to GEXF file format
echarts-bot[bot] commented on issue #12946: URL: https://github.com/apache/incubator-echarts/issues/12946#issuecomment-656049335 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical questions. If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12945: Convert JSON file to GEXF file format
echarts-bot[bot] commented on issue #12945: URL: https://github.com/apache/incubator-echarts/issues/12945#issuecomment-656044831 This issue is not created using [issue template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close it. Sorry for this, but it helps save our maintainers' time so that more developers get helped. Feel free to create another issue using the issue template. If you think you have already made your point clear without the template, or your problem cannot be covered by it, you may re-open this issue again. 这个 issue 未使用 [issue 模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。 为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。 如果您愿意，可以请使用 issue 模板重新创建 issue。 如果你认为虽然没有使用模板，但你已经提供了复现问题的充分描述，或者你的问题无法使用模板表达，也可以重新 open 这个 issue。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] felicia-lim2503 opened a new issue #12945: Convert JSON file to GEXF file format
felicia-lim2503 opened a new issue #12945: URL: https://github.com/apache/incubator-echarts/issues/12945 How do I convert the input data for the graph from JSON file to GEXF file format? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] confirmTing commented on issue #12944: 希望可以支持堆叠图正序，或者倒序的配置
confirmTing commented on issue #12944: URL: https://github.com/apache/incubator-echarts/issues/12944#issuecomment-656021636 期望效果： 张三是紫色，李四是青色，王五是绿色.. 依次类推 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12944: 希望可以支持堆叠图正序，或者倒序的配置
echarts-bot[bot] commented on issue #12944: URL: https://github.com/apache/incubator-echarts/issues/12944#issuecomment-656020781 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical questions. If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] confirmTing opened a new issue #12944: 希望可以支持堆叠图正序，或者倒序的配置
confirmTing opened a new issue #12944: URL: https://github.com/apache/incubator-echarts/issues/12944 ### What problem does this feature solve? 希望可以获得从上至下的一致性效果，而不是默认的从下至上 ### What does the proposed API look like? 无 希望的顺序  实际的顺序  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia edited a comment on pull request #12859: feat: time axis label formatter
Ovilia edited a comment on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655951837 @100pah I think that makes sense. `一、二` should take `ee` if we have future feature requests. Or do you think we should provide `ee` for `Mo, Tu` and ` 一，二` for now? I would suggest break change it to 1~12 because it's more universal and it cannot provide extra help to `HH`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia edited a comment on pull request #12859: feat: time axis label formatter
Ovilia edited a comment on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655951837 @100pah I think that makes sense. `一、二` should take `ee` if we have future feature requests. I would suggest break change it to 1~12 because it's more universal and it cannot provide extra help to `HH`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] quillblue commented on pull request #12859: feat: time axis label formatter
quillblue commented on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655952030 @Ovilia for the case you mention I treat 2020 as a major tick on the level of year (though from straight understanding it is on the same monthly level of Feb, Mar), and minor tick on the level of month. For i18n, I agree with that common and widely used date formatter is provided by ECharts self maybe in util since format will be used not only in axis but also maybe in series and etc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on pull request #12859: feat: time axis label formatter
Ovilia commented on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655951837 @100pah I think that makes sense. `一、二` should take `ee` if we have future feature requests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] 100pah edited a comment on pull request #12859: feat: time axis label formatter
100pah edited a comment on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655947629 @Ovilia ### (1) In the column of `(ZH)` Could `Monday, Tuesday` <=> `星期一，星期二` `Mon, Tue` <=> `周一，周二` `Mo, Tu` <=> `一，二` ### (2) How about the current `h`,`hh` in `echarts.format.formatTime`. (A) Make it the same as `H`, `HH`, which will be different from `date-fns` and make it hard to modify the meaning in future. (B) Break change it to represent `1~12`, which might need to create a new util format method and deprecated `echarts.format.formatTime`. (I am not sure) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] 100pah edited a comment on pull request #12859: feat: time axis label formatter
100pah edited a comment on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655947629 @Ovilia In the column of `(ZH)` Could `Monday, Tuesday` <=> `星期一，星期二` `Mon, Tue` <=> `周一，周二` `Mo, Tu` <=> `一，二` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] 100pah commented on pull request #12859: feat: time axis label formatter
100pah commented on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655947629 @Ovilia In the column of `(ZH)` Could `Monday, Tuesday` <=> `星期一，星期二` `Mon, Tue` <=> `周一，周二` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on pull request #12859: feat: time axis label formatter
Ovilia commented on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655945171 @quillblue Thanks for your comments. Here are my thoughts on this. ## Primary & Secondary Ticks I think secondary ticks may not be a minor tick. Consider the following case: ``` |_|_|_|__ ... 2020 Feb Mar Apr ``` By our definition, `2020` is a primary tick since it's in the year level, while others are secondary ticks because they are in the month level. But in most cases, the tick color of `2020` may not be different than others while text color may be different. Also, primary and secondary are two default rich text styles we provide. There may also be a tertiary level like week info in the above case. So major and minor ticks may not deal with situations like this. ## i18n First, we have to provide some frequently used formats like `'HH:mm:ss'`. It's unwise to ask users to install another library if they want simple time formats like this. On the other side, if we provide too many formats, it will increase package size while most people won't use it. So we should be prudent when deciding which formats to support. Here are my proposed formatters supported: | Group| Template | Examples (EN) | (ZH) | [Moment.js](https://momentjs.com/docs/#/displaying/) | [date-fns](https://date-fns.org/v2.14.0/docs/format) | |--|--|---||---|--| | Year | | 2020, 1990|| | SAME | | | yy | 20, 90|| YY| SAME | | Quarter | Q| 1, 2 || SAME | SAME | | Month| | January, February | 一月、二月 | SAME | SAME | | | MMM | Jan, Feb | 一、二 | SAME | SAME | | | MM | 01, 02|| SAME | SAME | | | M| 1, 2 || SAME | SAME | | Week of Year | ww | 01, 02|| SAME | SAME | | | w| 1, 2 || SAME | SAME | | Day of Month | dd | 01, 02|| DD| SAME | | | d| 1, 2 || D | SAME | | Day of Week | | Monday, Tuesday | 周一、周二 | | SAME | | | eee | Mon, Tue | 一、二 | ddd | SAME | | | e| 1, 2 || d | SAME | | Hour | HH | 00, 23|| SAME | SAME | | | H| 0, 23 || SAME | SAME | | Minute | mm | 00, 01|| SAME | SAME | | | m| 0, 1 || SAME | SAME | | Second | ss | 00, 01|| SAME | SAME | | | s| 0, 1 || SAME | SAME | | Millisecond | SSS | 000, 001 || SAME | SAME | | | S| 0, 1 || SAME | SAME | This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] quillblue commented on pull request #12859: feat: time axis label formatter
quillblue commented on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655922999 @Ovilia Some additional thoughts based on this topic: ### Extend to Major/Minor axis ticks instead of use Primary/Secondary style This will help general customization on all geo coord axis ticks/labels not only simply specified to time axis. For time axis, user can use two formatter if they need. (more like the ways build charts in Microsoft Office) ### For i18n I would prefer to use any of external formatter (Moment for example) in callback, as various external time formatter have already provided enough functionality on culture/date preference/lanuange etc. This would also help seperate on format part and render part, which I think in axis component render is what need to be focused on. For default formatter based on value, in my opinion may need to fully use of util to handle the transformation from date to text. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
