[GitHub] [incubator-echarts] susiwen8 commented on pull request #12947: Tooltip

2020-07-21 Thread GitBox
susiwen8 commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-662246281 Arrow position might need lots of improvement, and `arrow` At very beginning, I was trying find `nearest point` to `cursor`, so goes `_getNearestPoint`

[incubator-echarts] branch optimize-style updated: fix: add back hover layer.

2020-07-21 Thread shenyi
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a commit to branch optimize-style in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git The following commit(s) were added to refs/heads/optimize-style by this push: new 3ddf62a fix: add

[GitHub] [incubator-echarts] pissang closed issue #12935: [Design] The distance between individual columns is set to 1/2 of the width of the column itself.

2020-07-21 Thread GitBox
pissang closed issue #12935: URL: https://github.com/apache/incubator-echarts/issues/12935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13001: x-axis renders series multiple times

2020-07-21 Thread GitBox
echarts-bot[bot] commented on issue #13001: URL: https://github.com/apache/incubator-echarts/issues/13001#issuecomment-662196599 @praveenchandkasarla Please provide a demo for the issue either with https://codepen.io/Ovilia/pen/dyYWXWM or https://gallery.echartsjs.com/editor.html.

[GitHub] [incubator-echarts] zhengxs216 opened a new issue #13005: echart 3D散点图-bug

2020-07-21 Thread GitBox
zhengxs216 opened a new issue #13005: URL: https://github.com/apache/incubator-echarts/issues/13005 ### Version 4.8.0 ### Steps to reproduce 如果3D散点图只有一个点的话,tooltip无法显示弹框 ### What is expected? 只有一条数据的时候,可以显示tooltip弹框 ### What is actually happening?

[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13005: echart 3D散点图-bug

2020-07-21 Thread GitBox
echarts-bot[bot] commented on issue #13005: URL: https://github.com/apache/incubator-echarts/issues/13005#issuecomment-662204728 Hi! We've received your issue and please be patient to get responded.  The average response time is expected to be within one day for weekdays. In the

[GitHub] [incubator-echarts] owenvip closed issue #13003: legend not work when set dataset and series.encode

2020-07-21 Thread GitBox
owenvip closed issue #13003: URL: https://github.com/apache/incubator-echarts/issues/13003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-echarts] owenvip commented on issue #13003: legend not work when set dataset and series.encode

2020-07-21 Thread GitBox
owenvip commented on issue #13003: URL: https://github.com/apache/incubator-echarts/issues/13003#issuecomment-662199675 #9151 figured out This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #12947: Tooltip

2020-07-21 Thread GitBox
susiwen8 commented on a change in pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#discussion_r458481565 ## File path: src/component/tooltip/TooltipView.ts ## @@ -752,12 +805,50 @@ class TooltipView extends ComponentView { html =

[GitHub] [incubator-echarts] quillblue commented on issue #12935: [Design] The distance between individual columns is set to 1/2 of the width of the column itself.

2020-07-21 Thread GitBox
quillblue commented on issue #12935: URL: https://github.com/apache/incubator-echarts/issues/12935#issuecomment-662189164 @pissang never mind. I can learn from your code and work on others:) This is an automated message

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #12947: Tooltip

2020-07-21 Thread GitBox
susiwen8 commented on a change in pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#discussion_r458478984 ## File path: src/util/format.ts ## @@ -66,6 +66,13 @@ export function encodeHTML(source: string): string { }); } +export

[GitHub] [incubator-echarts] bryandam commented on issue #13004: Multiple Charts Will Grow but Not Shrink In A Grid

2020-07-21 Thread GitBox
bryandam commented on issue #13004: URL: https://github.com/apache/incubator-echarts/issues/13004#issuecomment-662182377 Thanks for the reply @plainheart. What's weird is that they work for a single chart, they work when charts grows, just not when there's multiple and it shrinks.

[GitHub] [incubator-echarts] plainheart commented on issue #13000: 为tooltip 循环添加新的元素无效问题

2020-07-21 Thread GitBox
plainheart commented on issue #13000: URL: https://github.com/apache/incubator-echarts/issues/13000#issuecomment-662177666 是的 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-echarts] plainheart commented on issue #13004: Multiple Charts Will Grow but Not Shrink In A Grid

2020-07-21 Thread GitBox
plainheart commented on issue #13004: URL: https://github.com/apache/incubator-echarts/issues/13004#issuecomment-662175559 It seems to do with the `grid` layout. When the height of the chart grows and calls resize function, ECharts cannot calculate a new correct height. But I think there

[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13004: Multiple Charts Will Grow but Not Shrink In A Grid

2020-07-21 Thread GitBox
echarts-bot[bot] commented on issue #13004: URL: https://github.com/apache/incubator-echarts/issues/13004#issuecomment-662075322 Hi! We've received your issue and please be patient to get responded.  The average response time is expected to be within one day for weekdays. In the

[GitHub] [incubator-echarts] bryandam opened a new issue #13004: Multiple Charts Will Grow but Not Shrink In A Grid

2020-07-21 Thread GitBox
bryandam opened a new issue #13004: URL: https://github.com/apache/incubator-echarts/issues/13004 ### Version 4.8.0 ### Reproduction link [https://jsfiddle.net/8hngc24b/49/](https://jsfiddle.net/8hngc24b/49/) ### Steps to reproduce -Create a grid layout consuming 100%

[incubator-echarts] branch optimize-style updated: fix(state): not blur others when highlighting with axisPointer

2020-07-21 Thread shenyi
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a commit to branch optimize-style in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git The following commit(s) were added to refs/heads/optimize-style by this push: new a7f2c16 fix(state):

[incubator-echarts] branch optimize-style updated: feat(bar): improve gaps between bar. #12935

2020-07-21 Thread shenyi
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a commit to branch optimize-style in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git The following commit(s) were added to refs/heads/optimize-style by this push: new a7c0d8c feat(bar):

[incubator-echarts] branch optimize-style updated: fix(axisPointer): not use align: 'center' because it's already been calculated

2020-07-21 Thread shenyi
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a commit to branch optimize-style in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git The following commit(s) were added to refs/heads/optimize-style by this push: new 6fca352

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #12947: Tooltip

2020-07-21 Thread GitBox
susiwen8 commented on a change in pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#discussion_r458147432 ## File path: src/component/tooltip/TooltipHTMLContent.ts ## @@ -79,6 +129,7 @@ function assembleCssText(tooltipModel: Model) {

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #12947: Tooltip

2020-07-21 Thread GitBox
susiwen8 commented on a change in pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#discussion_r458137911 ## File path: src/component/marker/markerHelper.ts ## @@ -81,9 +81,9 @@ function markerTypeCalculatorWithExtent( ?

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #12947: Tooltip

2020-07-21 Thread GitBox
susiwen8 commented on a change in pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#discussion_r458136357 ## File path: src/component/marker/MarkerModel.ts ## @@ -206,19 +203,16 @@ abstract class MarkerModel extends Com const value =

[GitHub] [incubator-echarts] 100pah commented on a change in pull request #12947: Tooltip

2020-07-21 Thread GitBox
100pah commented on a change in pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#discussion_r458078752 ## File path: src/util/format.ts ## @@ -66,6 +66,13 @@ export function encodeHTML(source: string): string { }); } +export

[GitHub] [incubator-echarts] cyang52 commented on issue #13000: 为tooltip 循环添加新的元素无效问题

2020-07-21 Thread GitBox
cyang52 commented on issue #13000: URL: https://github.com/apache/incubator-echarts/issues/13000#issuecomment-661842078 我看到文档里面写 dataindex :数据在传入的 data 数组中的 index,这个data 不是series 传入的series.data 是吧? This is an automated

[GitHub] [incubator-echarts] 100pah commented on a change in pull request #12947: Tooltip

2020-07-21 Thread GitBox
100pah commented on a change in pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#discussion_r457857968 ## File path: src/component/tooltip/TooltipHTMLContent.ts ## @@ -259,16 +314,24 @@ class TooltipHTMLContent { // this.hide(); }

[GitHub] [incubator-echarts] quillblue commented on issue #13001: x-axis renders series multiple times

2020-07-21 Thread GitBox
quillblue commented on issue #13001: URL: https://github.com/apache/incubator-echarts/issues/13001#issuecomment-661806364 Hi, would you please be kind to build a demo reproducing/representing your issue met on [Gallery Editor](https://gallery.echartsjs.com/editor.html) so that the

[incubator-echarts] branch optimize-style updated: fix(symbol): fix image symbol not display bug

2020-07-21 Thread shenyi
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a commit to branch optimize-style in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git The following commit(s) were added to refs/heads/optimize-style by this push: new 6f5d9d7

[GitHub] [incubator-echarts] plainheart commented on issue #13000: 为tooltip 循环添加新的元素无效问题

2020-07-21 Thread GitBox
plainheart commented on issue #13000: URL: https://github.com/apache/incubator-echarts/issues/13000#issuecomment-661766541 fomatter 的回调参数里有 dataIndex 和 seriesIndex 分别标识 数据项索引 和 系列索引,可以根据这两个参数进行判别。 This is an automated

[GitHub] [incubator-echarts] cyang52 commented on issue #13000: 为tooltip 循环添加新的元素无效问题

2020-07-21 Thread GitBox
cyang52 commented on issue #13000: URL: https://github.com/apache/incubator-echarts/issues/13000#issuecomment-661765745 嗯嗯 谢谢,但是我试了一下 每一个点都打印了wwweee, 我希望还是分开的,一个点一个,按顺序被添加 This is an automated message from the Apache Git

[GitHub] [incubator-echarts] Ovilia closed issue #12957: graph元素位置的问题

2020-07-21 Thread GitBox
Ovilia closed issue #12957: URL: https://github.com/apache/incubator-echarts/issues/12957 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-echarts] plainheart edited a comment on issue #13000: 为tooltip 循环添加新的元素无效问题

2020-07-21 Thread GitBox
plainheart edited a comment on issue #13000: URL: https://github.com/apache/incubator-echarts/issues/13000#issuecomment-661762915 从代码里看,你在 for 循环体内声明的变量 a,如果想要拼接,应该在 for 循环上边声明变量 a。 ```js formatter: function (obj) { var value = obj.value; var a = ''; for(var i = 0; i<

[GitHub] [incubator-echarts] plainheart commented on issue #13000: 为tooltip 循环添加新的元素无效问题

2020-07-21 Thread GitBox
plainheart commented on issue #13000: URL: https://github.com/apache/incubator-echarts/issues/13000#issuecomment-661762915 从代码里看,你在 for 循环体内声明的变量 a,如果想要拼接,应该在 for 循环上边声明变量 a。 ```js formatter: function (obj) { var value = obj.value; var a = ''; for(var i = 0; i< 3;i++)

[GitHub] [incubator-echarts] cyang52 commented on issue #13000: 为tooltip 循环添加新的元素无效问题

2020-07-21 Thread GitBox
cyang52 commented on issue #13000: URL: https://github.com/apache/incubator-echarts/issues/13000#issuecomment-661761451 我想在tooptip 中, seriesName 后面添加上 一个entity name,这个name 来自于前面的array,需要按顺序添加进去,一个点对应一个seriesName 对应一个entity name。

[GitHub] [incubator-echarts] plainheart commented on issue #13000: 为tooltip 循环添加新的元素无效问题

2020-07-21 Thread GitBox
plainheart commented on issue #13000: URL: https://github.com/apache/incubator-echarts/issues/13000#issuecomment-661760558 抱歉不是很理解,能再具体描述下需求吗? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-echarts] cyang52 commented on issue #13000: 为tooltip 循环添加新的元素无效问题

2020-07-21 Thread GitBox
cyang52 commented on issue #13000: URL: https://github.com/apache/incubator-echarts/issues/13000#issuecomment-661759431 不好意思 我重新更新了代码 之前那个错误的 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-echarts] Ovilia commented on pull request #12859: feat: time axis label formatter

2020-07-21 Thread GitBox
Ovilia commented on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-661758950 Most of the functions above have been implemented, but not *week of year*. Leaving it for another PR.

[GitHub] [incubator-echarts] plainheart commented on issue #13000: 为tooltip 循环添加新的元素无效问题

2020-07-21 Thread GitBox
plainheart commented on issue #13000: URL: https://github.com/apache/incubator-echarts/issues/13000#issuecomment-661755443 为什么要在 for 循环体内进行 return,那样不是只会执行一次吗? This is an automated message from the Apache Git Service. To

[incubator-echarts] branch time-formatter updated (a14c8cd -> cca2853)

2020-07-21 Thread ovilia
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch time-formatter in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from a14c8cd feat(time): level formatters add 3bee422 feat(time): add half day and more

[GitHub] [incubator-echarts] plainheart commented on issue #13002: custom line displayed is inconsistent with axis

2020-07-21 Thread GitBox
plainheart commented on issue #13002: URL: https://github.com/apache/incubator-echarts/issues/13002#issuecomment-661748980 The red line is a custom series indicating the trend of bar series and it's not used to indicate the actual data of bars. If you want to keep them consistent, just

[GitHub] [incubator-echarts] echarts-bot[bot] removed a comment on issue #12867: timeline controlStyle *Icon配置base64图片导致游览器卡死

2020-07-21 Thread GitBox
echarts-bot[bot] removed a comment on issue #12867: URL: https://github.com/apache/incubator-echarts/issues/12867#issuecomment-651496574 This issue is not created using [issue template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close it.  Sorry for this, but it

[incubator-echarts] branch optimize-style updated: fix(label): support legacy style color: 'auto' for color: 'inherit' usage.

2020-07-21 Thread shenyi
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a commit to branch optimize-style in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git The following commit(s) were added to refs/heads/optimize-style by this push: new 8fea284 fix(label):

[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13003: legend not work when set dataset and series.encode

2020-07-21 Thread GitBox
echarts-bot[bot] commented on issue #13003: URL: https://github.com/apache/incubator-echarts/issues/13003#issuecomment-661728264 Hi! We've received your issue and please be patient to get responded.  The average response time is expected to be within one day for weekdays. In the

[GitHub] [incubator-echarts] owenvip opened a new issue #13003: legend not work when set dataset and series.encode

2020-07-21 Thread GitBox
owenvip opened a new issue #13003: URL: https://github.com/apache/incubator-echarts/issues/13003 ### Version 4.8.0 ### Reproduction link [https://codesandbox.io/s/quirky-carson-0dyrh?file=/index.html](https://codesandbox.io/s/quirky-carson-0dyrh?file=/index.html) ###

[GitHub] [incubator-echarts] 100pah commented on pull request #12947: Tooltip

2020-07-21 Thread GitBox
100pah commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661727624 @Wdingding reminded that: These cases should not be broken: `test/candlestick.html` where each dataItem have more than two items to be displayed. This

[GitHub] [incubator-echarts] plainheart commented on issue #12867: timeline controlStyle *Icon配置base64图片导致游览器卡死

2020-07-21 Thread GitBox
plainheart commented on issue #12867: URL: https://github.com/apache/incubator-echarts/issues/12867#issuecomment-661726378 @GiserDu 已复现,感谢反馈,后续会修复这个问题。 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-echarts] MeijunZhu commented on issue #13002: custom line displayed is inconsistent with axis

2020-07-21 Thread GitBox
MeijunZhu commented on issue #13002: URL: https://github.com/apache/incubator-echarts/issues/13002#issuecomment-661706497 all data less than 1000 but the line is higher than 1000 This is an automated message from the

[GitHub] [incubator-echarts] MeijunZhu commented on issue #13002: custom line displayed is inconsistent with axis

2020-07-21 Thread GitBox
MeijunZhu commented on issue #13002: URL: https://github.com/apache/incubator-echarts/issues/13002#issuecomment-661705449 ![image](https://user-images.githubusercontent.com/56335769/88029412-8f576f80-cb6c-11ea-895d-8554d7e32757.png)

[GitHub] [incubator-echarts] MeijunZhu opened a new issue #13002: custom line displayed is inconsistent with axis

2020-07-21 Thread GitBox
MeijunZhu opened a new issue #13002: URL: https://github.com/apache/incubator-echarts/issues/13002 ### Version 4.8.0 ### Reproduction link

[GitHub] [incubator-echarts] GiserDu commented on issue #12867: timeline controlStyle *Icon配置base64图片导致游览器卡死

2020-07-21 Thread GitBox
GiserDu commented on issue #12867: URL: https://github.com/apache/incubator-echarts/issues/12867#issuecomment-661695956 > 能否提供一个可复现的demo?出现卡死的是什么浏览器? demo已提供,麻烦看一下 This is an automated message from the Apache Git

[GitHub] [incubator-echarts] GiserDu commented on issue #12867: timeline controlStyle *Icon配置base64图片导致游览器卡死

2020-07-21 Thread GitBox
GiserDu commented on issue #12867: URL: https://github.com/apache/incubator-echarts/issues/12867#issuecomment-661695145 版本 4.1.0 遇到同样的问题,以'image://url' 或 dataURI加载自定义图片都会使页面卡死,demo如下 https://gallery.echartsjs.com/editor.html?c=xc2uz1u2Jo=2

[GitHub] [incubator-echarts] susiwen8 edited a comment on pull request #12947: Tooltip

2020-07-21 Thread GitBox
susiwen8 edited a comment on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661654745 > @susiwen8 It's beautiful! > > Is it default to have a red border? I'm not sure about the design. Perhaps @Wdingding can take a loot? No, red

[GitHub] [incubator-echarts] susiwen8 commented on pull request #12947: Tooltip

2020-07-21 Thread GitBox
susiwen8 commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661654745 > @susiwen8 It's beautiful! > > Is it default to have a red border? I'm not sure about the design. Perhaps @Wdingding can take a loot? No, red border

[incubator-echarts] branch optimize-style updated: fix(export): add back echarts.format.getTextRect

2020-07-21 Thread shenyi
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a commit to branch optimize-style in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git The following commit(s) were added to refs/heads/optimize-style by this push: new 41ba157

[GitHub] [incubator-echarts] susiwen8 commented on pull request #12947: Tooltip

2020-07-21 Thread GitBox
susiwen8 commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661652463 @100pah Sure, I'll fix those soon This is an automated message from the Apache Git Service. To