[GitHub] [incubator-echarts] easonyq opened a new pull request #13094: Fix legend color with customized itemStyle

2020-08-06 Thread GitBox


easonyq opened a new pull request #13094:
URL: https://github.com/apache/incubator-echarts/pull/13094


   
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   
   Fix the bug that when `itemStyle` with functional `color` is used, the color 
of legend will not be consist with the customized color.
   
   
   ### Fixed issues
   
   #12977 
   
   
   ## Details
   
   ### Before: What was the problem?
   
   When user customized the color of bar, the color of legend is not consist 
with it.
   
   
![image](https://user-images.githubusercontent.com/6800839/89612709-0dc54880-d8b3-11ea-8f3c-320bf1cf5aac.png)
   
   
   
   ### After: How is it fixed in this PR?
   
   
   
   
   
   The color of legend is consist with bar color customized by user
   
   
![image](https://user-images.githubusercontent.com/6800839/89612740-25043600-d8b3-11ea-9dd1-81f7e15b85e7.png)
   
   (The first color is white, so it can not be seen very clearly)
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   
   
   No
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [x] Please squash the commits into a single one when merge.
   
   ### Other information
   
   I use `const dataParams = seriesModel.getDataParams(dataIndex);` in my PR, 
and I found that `dataParams.color` is just the final result of color, no 
matter it is a function or a value, or user simply hadn't used `color` in 
`itemStyle`.
   As a result, it is not necessary anymore to retrieve or do some transforming 
calculation from LegendView, just use this value.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] plainheart edited a comment on issue #13091: Install echarts using github link

2020-08-06 Thread GitBox


plainheart edited a comment on issue #13091:
URL: 
https://github.com/apache/incubator-echarts/issues/13091#issuecomment-670329707


   The `lib` folder is generated after building.
   Installing from Github link is just to clone the repository without a 
release building, so this is different from NPM.
   But you are still able to run the release command in the root of echarts to 
generate the `lib` folder.
   ```shell
   npm run release
   ```
   Hope that helps.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] sgurin closed issue #13091: Install echarts using github link

2020-08-06 Thread GitBox


sgurin closed issue #13091:
URL: https://github.com/apache/incubator-echarts/issues/13091


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] sgurin commented on issue #13091: Install echarts using github link

2020-08-06 Thread GitBox


sgurin commented on issue #13091:
URL: 
https://github.com/apache/incubator-echarts/issues/13091#issuecomment-670330032


   Yeap, That exactly what I asked for. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] plainheart commented on issue #13091: Install echarts using github link

2020-08-06 Thread GitBox


plainheart commented on issue #13091:
URL: 
https://github.com/apache/incubator-echarts/issues/13091#issuecomment-670329707


   The `lib` folder is generated after building.
   InstallIng from Github link is just to clone the repository without a 
release building, so this is different from NPM.
   But you are still able to run the release command in the root of echarts to 
generate the `lib` folder.
   ```shell
   npm run release
   ```
   Hope that helps.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] sgurin commented on issue #13091: Install echarts using github link

2020-08-06 Thread GitBox


sgurin commented on issue #13091:
URL: 
https://github.com/apache/incubator-echarts/issues/13091#issuecomment-670319517


   Ok. Why the packages are different?
   
   There is lib folder if I install echarts `npm install echarts 
`https://prnt.sc/tvhazs but via GitHub link it is not there 
https://prnt.sc/tvhbiz



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on issue #13082: 使用散点图,多组散点下,散点未显示全

2020-08-06 Thread GitBox


pissang commented on issue #13082:
URL: 
https://github.com/apache/incubator-echarts/issues/13082#issuecomment-670310361


   这是因为图形过多导致开启了渐进渲染,设置 progressive: 0 关闭试试,可能会有一定卡顿



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch next updated: style: optimize color of brush rect

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/next by this push:
 new a69b446  style: optimize color of brush rect
a69b446 is described below

commit a69b446dfc3253ff1c83eb47719486f4b86b7411
Author: pissang 
AuthorDate: Fri Aug 7 11:07:27 2020 +0800

style: optimize color of brush rect
---
 src/component/brush/BrushModel.ts | 4 ++--
 src/component/helper/BrushController.ts   | 4 ++--
 src/component/toolbox/feature/DataZoom.ts | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/component/brush/BrushModel.ts 
b/src/component/brush/BrushModel.ts
index f30f528..8364e6f 100644
--- a/src/component/brush/BrushModel.ts
+++ b/src/component/brush/BrushModel.ts
@@ -130,8 +130,8 @@ class BrushModel extends ComponentModel {
 transformable: true,
 brushStyle: {
 borderWidth: 1,
-color: 'rgba(120,140,180,0.3)',
-borderColor: 'rgba(120,140,180,0.8)'
+color: 'rgba(210,219,238,0.3)',
+borderColor: '#D2DBEE'
 },
 throttleType: 'fixRate',
 throttleDelay: 0,
diff --git a/src/component/helper/BrushController.ts 
b/src/component/helper/BrushController.ts
index 596c37a..1b24bef 100644
--- a/src/component/helper/BrushController.ts
+++ b/src/component/helper/BrushController.ts
@@ -157,8 +157,8 @@ const CURSOR_MAP = {
 const DEFAULT_BRUSH_OPT = {
 brushStyle: {
 lineWidth: 2,
-stroke: 'rgba(0,0,0,0.3)',
-fill: 'rgba(0,0,0,0.1)'
+stroke: 'rgba(210,219,238,0.3)',
+fill: '#D2DBEE'
 },
 transformable: true,
 brushMode: 'single',
diff --git a/src/component/toolbox/feature/DataZoom.ts 
b/src/component/toolbox/feature/DataZoom.ts
index c4330ac..e36f2c3 100644
--- a/src/component/toolbox/feature/DataZoom.ts
+++ b/src/component/toolbox/feature/DataZoom.ts
@@ -311,7 +311,7 @@ function updateZoomBtnStatus(
 brushStyle: {
 // FIXME user customized?
 lineWidth: 0,
-fill: 'rgba(0,0,0,0.2)'
+fill: 'rgba(210,219,238,0.2)'
 }
 }
 : false


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] wangmeijian commented on issue #9256: echarts 4.0 树缩放 后收拢根节点会玩失踪

2020-08-06 Thread GitBox


wangmeijian commented on issue #9256:
URL: 
https://github.com/apache/incubator-echarts/issues/9256#issuecomment-670295434


   配置setOption的第二个参数设置为true即可,意思是重新绘制



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] cdydayang commented on issue #13093: 力导向图,如何通过鼠标点击后从节点随鼠标移动连出一条线到另一个节点???

2020-08-06 Thread GitBox


cdydayang commented on issue #13093:
URL: 
https://github.com/apache/incubator-echarts/issues/13093#issuecomment-670287934


   有哪位遇到的呢



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13093: 力导向图,如何通过鼠标点击后从节点随鼠标移动连出一条线到另一个节点???

2020-08-06 Thread GitBox


echarts-bot[bot] commented on issue #13093:
URL: 
https://github.com/apache/incubator-echarts/issues/13093#issuecomment-670287668


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] cdydayang opened a new issue #13093: 力导向图,如何通过鼠标点击后从节点随鼠标移动连出一条线到另一个节点???

2020-08-06 Thread GitBox


cdydayang opened a new issue #13093:
URL: https://github.com/apache/incubator-echarts/issues/13093


   ### What problem does this feature solve?
   echarts 力导向图,如何通过鼠标点击节点后从节点随鼠标移动连出一条线到另一个节点???
   
   ### What does the proposed API look like?
   make line,drawing line from node
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] plainheart commented on issue #13091: Install echarts using github link

2020-08-06 Thread GitBox


plainheart commented on issue #13091:
URL: 
https://github.com/apache/incubator-echarts/issues/13091#issuecomment-670286349


   @sgurin It can be installed as follows.
   ```shell
   npm install https://github.com/apache/incubator-echarts.git#4.8.0
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] jackferrous edited a comment on issue #13082: 使用散点图,多组散点下,散点未显示全

2020-08-06 Thread GitBox


jackferrous edited a comment on issue #13082:
URL: 
https://github.com/apache/incubator-echarts/issues/13082#issuecomment-669660737


   ```js
{symbolSize: 20,
   data:[["2020-06-16 00:02:34","-4.167E-3","2020-06-16 
00:02:34"],["2020-06-16 00:07:34","-4.167E-3","2020-06-16 
00:07:34"],["2020-06-16 00:17:34","0.01284","2020-06-16 00:17:34"],["2020-06-16 
00:27:35","-4.998E-3","2020-06-16 00:27:35"],["2020-06-16 
00:37:35","10.01","2020-06-16 00:37:35"],["2020-06-16 
00:47:34","-4.802E-3","2020-06-16 00:47:34"],["2020-06-16 
00:57:34","1.489","2020-06-16 00:57:34"],["2020-06-16 
01:07:34","18.65","2020-06-16 01:07:34"],["2020-06-16 
01:17:34","49.70","2020-06-16 01:17:34"],["2020-06-16 
01:27:35","38.07","2020-06-16 01:27:35"],["2020-06-16 
01:37:35","-2.169E-3","2020-06-16 01:37:35"],["2020-06-16 
01:47:35","9.489","2020-06-16 01:47:35"],["2020-06-16 
01:57:36","15.82","2020-06-16 01:57:36"],["2020-06-16 
02:07:36","79.55","2020-06-16 02:07:36"],["2020-06-16 
02:17:35","8.525","2020-06-16 02:17:35"],["2020-06-16 
02:27:35","-4.392E-3","2020-06-16 02:27:35"],["2020-06-16 
02:37:35","-4.078E-3","2020-06-16 02:37:35"],["2020-06-16 
02:47:35","-3.652E-3","2
 020-06-16 02:47:35"],["2020-06-16 02:57:35","-4.723E-3","2020-06-16 
02:57:35"],["2020-06-16 03:07:36","-3.538E-3","2020-06-16 
03:07:36"],["2020-06-16 03:17:37","-2.372E-3","2020-06-16 
03:17:37"],["2020-06-16 03:27:37","3.325E-3","2020-06-16 
03:27:37"],["2020-06-16 03:37:37","5.433E-3","2020-06-16 
03:37:37"],["2020-06-16 03:47:36","-2.078E-4","2020-06-16 
03:47:36"],["2020-06-16 03:57:36","-1.508E-3","2020-06-16 
03:57:36"],["2020-06-16 04:07:36","-3.001E-3","2020-06-16 
04:07:36"],["2020-06-16 04:17:36","-4.968E-3","2020-06-16 
04:17:36"],["2020-06-16 04:27:36","-3.420E-3","2020-06-16 
04:27:36"],["2020-06-16 04:37:36","-4.553E-3","2020-06-16 
04:37:36"],["2020-06-16 04:47:38","-1.013E-3","2020-06-16 
04:47:38"],["2020-06-16 04:57:38","-2.492E-3","2020-06-16 
04:57:38"],["2020-06-16 05:07:38","-4.702E-3","2020-06-16 
05:07:38"],["2020-06-16 05:17:37","-5.650E-4","2020-06-16 
05:17:37"],["2020-06-16 05:27:37","-9.134E-4","2020-06-16 
05:27:37"],["2020-06-16 05:37:37",0,"2020-06-16 05:37:37"],["
 2020-06-16 05:47:37",0,"2020-06-16 05:47:37"],["2020-06-16 
05:57:37","-7.177E-4","2020-06-16 05:57:37"],["2020-06-16 
06:07:37","3.505E-3","2020-06-16 06:07:37"],["2020-06-16 
06:17:38","0.02090","2020-06-16 06:17:38"],["2020-06-16 
06:27:39","-4.808E-3","2020-06-16 06:27:39"],["2020-06-16 
06:37:39","-1.098E-3","2020-06-16 06:37:39"],["2020-06-16 
06:47:38","9.142","2020-06-16 06:47:38"],["2020-06-16 
06:57:38","51.04","2020-06-16 06:57:38"],["2020-06-16 
07:07:38","80.00","2020-06-16 07:07:38"],["2020-06-16 
07:17:38","59.78","2020-06-16 07:17:38"],["2020-06-16 
07:27:38","16.70","2020-06-16 07:27:38"],["2020-06-16 
07:37:38","13.63","2020-06-16 07:37:38"],["2020-06-16 
07:47:39","26.19","2020-06-16 07:47:39"],["2020-06-16 
07:57:39","39.89","2020-06-16 07:57:39"],["2020-06-16 
08:07:40","80.00","2020-06-16 08:07:40"],["2020-06-16 
08:17:39","80.00","2020-06-16 08:17:39"],["2020-06-16 
08:27:39","37.33","2020-06-16 08:27:39"],["2020-06-16 
08:37:39","-1.989E-4","2020-06-16 08:37:39"],["2020-06-16
  08:47:39","-1.431E-3","2020-06-16 08:47:39"],["2020-06-16 
08:57:39","-4.993E-3","2020-06-16 08:57:39"],["2020-06-16 
09:07:39","9.546","2020-06-16 09:07:39"],["2020-06-16 
09:17:39","-1.883E-3","2020-06-16 09:17:39"],["2020-06-16 
09:27:39","0.05711","2020-06-16 09:27:39"],["2020-06-16 
09:37:39","0.04168","2020-06-16 09:37:39"],["2020-06-16 
09:47:40","4.878E-3","2020-06-16 09:47:40"],["2020-06-16 
09:57:40","-3.530E-4","2020-06-16 09:57:40"],["2020-06-16 
10:07:40","1.889E-5","2020-06-16 10:07:40"],["2020-06-16 
10:17:40","0.04921","2020-06-16 10:17:40"],["2020-06-16 
10:27:40","0.09879","2020-06-16 10:27:40"],["2020-06-16 
10:37:40","0.01478","2020-06-16 10:37:40"],["2020-06-16 
10:47:40","0.4493","2020-06-16 10:47:40"],["2020-06-16 
10:57:40","-1.046E-3","2020-06-16 10:57:40"],["2020-06-16 
11:07:40","0.01021","2020-06-16 11:07:40"],["2020-06-16 
11:17:40","5.882E-3","2020-06-16 11:17:40"],["2020-06-16 
11:27:41","10.36","2020-06-16 11:27:41"],["2020-06-16 
11:37:41","9.744","2020-06-16 11:37:
 41"],["2020-06-16 11:47:41","25.68","2020-06-16 11:47:41"],["2020-06-16 
11:57:41","24.48","2020-06-16 11:57:41"],["2020-06-16 
12:07:41","12.18","2020-06-16 12:07:41"],["2020-06-16 
12:17:41","74.50","2020-06-16 12:17:41"],["2020-06-16 
12:27:41","80.00","2020-06-16 12:27:41"],["2020-06-16 
12:37:41","80.00","2020-06-16 12:37:41"],["2020-06-16 
12:47:41","19.59","2020-06-16 12:47:41"],["2020-06-16 
12:57:41","7.628","2020-06-16 12:57:41"],["2020-06-16 
13:07:41","18.05","2020-06-16 13:07:41"],["2020-06-16 
13:17:41","21.24","2020-06-16 13:17:41"],["2020-06-16 
13:27:41","-3.767E-4","2020-06-16 13:27:41"],["2020-06-16 
13:37:41","1.489E-3","2020-06-16 13:37:41"],["2020-06-16 
13:47:42","-1.833E-5","2020-06-16 13:47:42"],["2020-06-16 

[GitHub] [incubator-echarts] jackferrous edited a comment on issue #13082: 使用散点图,多组散点下,散点未显示全

2020-08-06 Thread GitBox


jackferrous edited a comment on issue #13082:
URL: 
https://github.com/apache/incubator-echarts/issues/13082#issuecomment-669660790


   ```js
   {symbolSize: 20,
   data:[["2020-06-07 00:06:46","10.27","2020-06-07 00:06:46"],["2020-06-07 
00:16:46","10.20","2020-06-07 00:16:46"],["2020-06-07 
00:26:46","9.605","2020-06-07 00:26:46"],["2020-06-07 
00:36:46","8.718","2020-06-07 00:36:46"],["2020-06-07 
00:46:46","7.644","2020-06-07 00:46:46"],["2020-06-07 
00:56:46","7.026","2020-06-07 00:56:46"],["2020-06-07 
01:06:46","6.021","2020-06-07 01:06:46"],["2020-06-07 
01:16:46","4.511","2020-06-07 01:16:46"],["2020-06-07 
01:26:46","4.896","2020-06-07 01:26:46"],["2020-06-07 
01:36:46","5.505","2020-06-07 01:36:46"],["2020-06-07 
01:46:46","4.836","2020-06-07 01:46:46"],["2020-06-07 
01:56:46","5.619","2020-06-07 01:56:46"],["2020-06-07 
02:06:46","5.933","2020-06-07 02:06:46"],["2020-06-07 
02:16:46","6.799","2020-06-07 02:16:46"],["2020-06-07 
02:26:46","7.028","2020-06-07 02:26:46"],["2020-06-07 
02:36:46","7.638","2020-06-07 02:36:46"],["2020-06-07 
02:46:46","9.070","2020-06-07 02:46:46"],["2020-06-07 
02:56:46","10.67","2020-06-07 02:56:46"],["2020-06-07 03:0
 6:46","11.50","2020-06-07 03:06:46"],["2020-06-07 
03:16:46","11.89","2020-06-07 03:16:46"],["2020-06-07 
03:26:46","11.94","2020-06-07 03:26:46"],["2020-06-07 
03:36:46","11.66","2020-06-07 03:36:46"],["2020-06-07 
03:46:46","10.98","2020-06-07 03:46:46"],["2020-06-07 
03:56:46","10.24","2020-06-07 03:56:46"],["2020-06-07 
04:06:46","9.647","2020-06-07 04:06:46"],["2020-06-07 
04:16:46","10.00","2020-06-07 04:16:46"],["2020-06-07 
04:26:46","8.593","2020-06-07 04:26:46"],["2020-06-07 
04:36:46","7.498","2020-06-07 04:36:46"],["2020-06-07 
04:46:46","6.546","2020-06-07 04:46:46"],["2020-06-07 
04:56:46","6.178","2020-06-07 04:56:46"],["2020-06-07 
05:06:46","6.783","2020-06-07 05:06:46"],["2020-06-07 
05:16:46","6.720","2020-06-07 05:16:46"],["2020-06-07 
05:26:46","6.410","2020-06-07 05:26:46"],["2020-06-07 
05:36:46","3.877","2020-06-07 05:36:46"],["2020-06-07 
05:46:46","3.282","2020-06-07 05:46:46"],["2020-06-07 
05:56:46","1.115","2020-06-07 05:56:46"],["2020-06-07 
06:06:46","2.479","2020-06-07
  06:06:46"],["2020-06-07 06:16:46","3.454","2020-06-07 06:16:46"],["2020-06-07 
06:26:46","2.062","2020-06-07 06:26:46"],["2020-06-07 
06:36:46","2.667","2020-06-07 06:36:46"],["2020-06-07 
06:46:46","4.500","2020-06-07 06:46:46"],["2020-06-07 
06:56:46","5.409","2020-06-07 06:56:46"],["2020-06-07 
07:06:46","3.473","2020-06-07 07:06:46"],["2020-06-07 
07:16:46","1.608","2020-06-07 07:16:46"],["2020-06-07 
07:26:46","0.8650","2020-06-07 07:26:46"],["2020-06-07 
07:36:46","1.942","2020-06-07 07:36:46"],["2020-06-07 
07:46:46","1.528","2020-06-07 07:46:46"],["2020-06-07 
07:56:46","1.985","2020-06-07 07:56:46"],["2020-06-07 
08:06:46","2.576","2020-06-07 08:06:46"],["2020-06-07 
08:16:46","2.487","2020-06-07 08:16:46"],["2020-06-07 
08:26:46","2.457","2020-06-07 08:26:46"],["2020-06-07 
08:36:46","1.353","2020-06-07 08:36:46"],["2020-06-07 
08:46:46","1.070","2020-06-07 08:46:46"],["2020-06-07 
08:56:46","1.585","2020-06-07 08:56:46"],["2020-06-07 
09:06:46","2.360","2020-06-07 09:06:46"],["2020-06-07
  09:16:46","1.402","2020-06-07 09:16:46"],["2020-06-07 
09:26:46","0.8368","2020-06-07 09:26:46"],["2020-06-07 
09:36:46","2.715","2020-06-07 09:36:46"],["2020-06-07 
09:46:46","3.477","2020-06-07 09:46:46"],["2020-06-07 
09:56:46","2.888","2020-06-07 09:56:46"],["2020-06-07 
10:06:46","2.262","2020-06-07 10:06:46"],["2020-06-07 
10:16:46","2.554","2020-06-07 10:16:46"],["2020-06-07 
10:26:46","2.414","2020-06-07 10:26:46"],["2020-06-07 
10:36:46","2.210","2020-06-07 10:36:46"],["2020-06-07 
10:46:46","6.105","2020-06-07 10:46:46"],["2020-06-07 
10:56:46","2.949","2020-06-07 10:56:46"],["2020-06-07 
11:06:46","2.002","2020-06-07 11:06:46"],["2020-06-07 
11:16:46","4.433","2020-06-07 11:16:46"],["2020-06-07 
11:26:46","3.652","2020-06-07 11:26:46"],["2020-06-07 
11:36:46","5.849","2020-06-07 11:36:46"],["2020-06-07 
11:46:46","2.736","2020-06-07 11:46:46"],["2020-06-07 
11:56:46","6.167","2020-06-07 11:56:46"],["2020-06-07 
12:06:46","2.943","2020-06-07 12:06:46"],["2020-06-07 12:16:46","3.216","2020
 -06-07 12:16:46"],["2020-06-07 12:26:46","3.931","2020-06-07 
12:26:46"],["2020-06-07 12:36:46","3.859","2020-06-07 12:36:46"],["2020-06-07 
12:46:46","3.313","2020-06-07 12:46:46"],["2020-06-07 
12:56:46","3.795","2020-06-07 12:56:46"],["2020-06-07 
13:06:46","5.999","2020-06-07 13:06:46"],["2020-06-07 
13:16:46","4.490","2020-06-07 13:16:46"],["2020-06-07 
13:26:46","5.306","2020-06-07 13:26:46"],["2020-06-07 
13:36:46","3.331","2020-06-07 13:36:46"],["2020-06-07 
13:46:46","5.397","2020-06-07 13:46:46"],["2020-06-07 
13:56:46","4.150","2020-06-07 13:56:46"],["2020-06-07 
14:06:46","2.999","2020-06-07 14:06:46"],["2020-06-07 
14:16:46","2.174","2020-06-07 14:16:46"],["2020-06-07 
14:26:46","2.100","2020-06-07 14:26:46"],["2020-06-07 

[GitHub] [incubator-echarts] jackferrous commented on issue #13082: 使用散点图,多组散点下,散点未显示全

2020-08-06 Thread GitBox


jackferrous commented on issue #13082:
URL: 
https://github.com/apache/incubator-echarts/issues/13082#issuecomment-670275788


   误操作导致关闭,现重新打开



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] sgurin commented on issue #13091: Install echarts using github link

2020-08-06 Thread GitBox


sgurin commented on issue #13091:
URL: 
https://github.com/apache/incubator-echarts/issues/13091#issuecomment-670127006


   So, there is no way to install echarts via NPM by direct link to the GitHub 
repo?
   
   `npm install https://github.com/apache/incubator-echarts#4.8.0`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch next updated: fix: make boxplot transform more reasonable: add config.itemNameFormatter and remove config.layout.

2020-08-06 Thread sushuang
This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a commit to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/next by this push:
 new 87bc7fb  fix: make boxplot transform more reasonable: add 
config.itemNameFormatter and remove config.layout.
87bc7fb is described below

commit 87bc7fb730d0e091d4a64820645271cdb402f328
Author: 100pah 
AuthorDate: Fri Aug 7 02:07:28 2020 +0800

fix: make boxplot transform more reasonable: add config.itemNameFormatter 
and remove config.layout.
---
 src/chart/boxplot/boxplotTransform.ts   | 11 +++--
 src/chart/boxplot/prepareBoxplotData.ts | 30 ++-
 test/boxplot-multi.html | 43 ++---
 test/boxplot.html   |  5 +---
 4 files changed, 52 insertions(+), 37 deletions(-)

diff --git a/src/chart/boxplot/boxplotTransform.ts 
b/src/chart/boxplot/boxplotTransform.ts
index 2a8f1e0..bd92e7a 100644
--- a/src/chart/boxplot/boxplotTransform.ts
+++ b/src/chart/boxplot/boxplotTransform.ts
@@ -18,17 +18,14 @@
 */
 
 import { DataTransformOption, ExternalDataTransform } from 
'../../data/helper/transform';
-import prepareBoxplotData from './prepareBoxplotData';
+import prepareBoxplotData, { PrepareBoxplotDataOpt } from 
'./prepareBoxplotData';
 import { isArray } from 'zrender/src/core/util';
 import { throwError, makePrintable } from '../../util/log';
 
 
 export interface BoxplotTransformOption extends DataTransformOption {
 type: 'boxplot';
-config: {
-boundIQR?: number | 'none',
-layout?: 'horizontal' | 'vertical'
-}
+config: PrepareBoxplotDataOpt;
 }
 
 export const boxplotTransform: ExternalDataTransform = 
{
@@ -37,8 +34,6 @@ export const boxplotTransform: 
ExternalDataTransform = {
 
 transform: function transform(params) {
 const source = params.source;
-const config = params.config || {};
-
 const sourceData = source.data;
 if (
 !isArray(sourceData)
@@ -56,7 +51,7 @@ export const boxplotTransform: 
ExternalDataTransform = {
 
 const result = prepareBoxplotData(
 source.data as number[][],
-config
+params.config
 );
 
 return [{
diff --git a/src/chart/boxplot/prepareBoxplotData.ts 
b/src/chart/boxplot/prepareBoxplotData.ts
index 0a63a23..c7cb47c 100644
--- a/src/chart/boxplot/prepareBoxplotData.ts
+++ b/src/chart/boxplot/prepareBoxplotData.ts
@@ -18,6 +18,13 @@
 */
 
 import { quantile, asc } from '../../util/number';
+import { isFunction, isString } from 'zrender/src/core/util';
+
+export interface PrepareBoxplotDataOpt {
+boundIQR?: number | 'none';
+// Like "expriment{value}" produce: "expriment0", "expriment1", ...
+itemNameFormatter?: string | ((params: { value: number }) => string);
+}
 
 
 /**
@@ -36,18 +43,13 @@ import { quantile, asc } from '../../util/number';
  * @param opt.boundIQR=1.5 Data less than min bound is outlier.
  *  default 1.5, means Q1 - 1.5 * (Q3 - Q1).
  *  If 'none'/0 passed, min bound will not be used.
- * @param opt.layout='horizontal'
- *  Box plot layout, can be 'horizontal' or 'vertical'
  */
 export default function (
 rawData: number[][],
-opt: {
-boundIQR?: number | 'none',
-layout?: 'horizontal' | 'vertical'
-}
+opt: PrepareBoxplotDataOpt
 ): {
-boxData: number[][]
-outliers: number[][]
+boxData: (number | string)[][];
+outliers: (number | string)[][];
 } {
 opt = opt || {};
 const boxData = [];
@@ -73,13 +75,19 @@ export default function (
 ? max
 : Math.min(max, Q3 + bound);
 
-boxData.push([i, low, Q1, Q2, Q3, high]);
+const itemNameFormatter = opt.itemNameFormatter;
+const itemName = isFunction(itemNameFormatter)
+? itemNameFormatter({ value: i })
+: isString(itemNameFormatter)
+? itemNameFormatter.replace('{value}', i + '')
+: i + '';
+
+boxData.push([itemName, low, Q1, Q2, Q3, high]);
 
 for (let j = 0; j < ascList.length; j++) {
 const dataItem = ascList[j];
 if (dataItem < low || dataItem > high) {
-const outlier = [i, dataItem];
-opt.layout === 'vertical' && outlier.reverse();
+const outlier = [itemName, dataItem];
 outliers.push(outlier);
 }
 }
diff --git a/test/boxplot-multi.html b/test/boxplot-multi.html
index ef09919..ed4300d 100644
--- a/test/boxplot-multi.html
+++ b/test/boxplot-multi.html
@@ -69,9 +69,6 @@ under the License.
 splitArea: {
 show: true
 },
-axisLabel: {
-formatter: 'expr {value}'
-},
 splitLine: {
  

[GitHub] [incubator-echarts] HHHui commented on issue #13091: Install echarts using github link

2020-08-06 Thread GitBox


HHHui commented on issue #13091:
URL: 
https://github.com/apache/incubator-echarts/issues/13091#issuecomment-670017100


   maybe just use dist/echarts.min.js or use cdn 
https://cdnjs.cloudflare.com/ajax/libs/echarts/4.8.0/echarts.min.js ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] sgurin commented on issue #13091: Install echarts using github link

2020-08-06 Thread GitBox


sgurin commented on issue #13091:
URL: 
https://github.com/apache/incubator-echarts/issues/13091#issuecomment-670012332


   Unfortunately I cannot use NPM Package. Is there any way to install plugin 
thrown link? For example npm install 
https://github.com/apache/incubator-echarts#4.8.0



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] HHHui commented on issue #13091: Install echarts using github link

2020-08-06 Thread GitBox


HHHui commented on issue #13091:
URL: 
https://github.com/apache/incubator-echarts/issues/13091#issuecomment-670010481


   npm install echarts --save
   maybe you can check the 
[tutorial](https://echarts.apache.org/en/tutorial.html#Get%20Started%20with%20ECharts%20in%205%20minutes).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



svn commit: r40890 - /dev/incubator/echarts/4.9.0-rc.1/RELEASE_NOTE.txt

2020-08-06 Thread shenyi
Author: shenyi
Date: Thu Aug  6 14:42:48 2020
New Revision: 40890

Log:
add release note for 4.9.0-rc.1

Added:
dev/incubator/echarts/4.9.0-rc.1/RELEASE_NOTE.txt

Added: dev/incubator/echarts/4.9.0-rc.1/RELEASE_NOTE.txt
==
--- dev/incubator/echarts/4.9.0-rc.1/RELEASE_NOTE.txt (added)
+++ dev/incubator/echarts/4.9.0-rc.1/RELEASE_NOTE.txt Thu Aug  6 14:42:48 2020
@@ -0,0 +1,44 @@
+v4.9.0
+
++ [Feature] [graph] Support multiple edges to link nodes in graph. 
[#12590](https://github.com/apache/incubator-echarts/pull/12590) 
([wf123537200](https://github.com/wf123537200))
+
++ [Feature] [funnel] Add `orient` option in funnel. Support horizontal layout. 
[#12754](https://github.com/apache/incubator-echarts/pull/12754) 
([regrex](https://github.com/regrex))
+
++ [Enhancement] [tooltip] Add text shadow options. 
[#12664](https://github.com/apache/incubator-echarts/pull/12664) 
([Ovilia](https://github.com/Ovilia))
+
++ [Enhancement] [toolbox] Add `brushStyle` option to configuration style of 
brush rect in the dataZoom feature. 
[#12550](https://github.com/apache/incubator-echarts/pull/12550) 
([zhiyuc123](https://github.com/zhiyuc123))
+
++ [Fix] [themeRiver] Optimize data process in themeRiver. 
[#12022](https://github.com/apache/incubator-echarts/pull/12022) 
([Zaynex](https://github.com/Zaynex))
+
++ [Fix] [toolbox] Fix pie series render incorrectly after editing its data in 
the dataView feature. 
[#12561](https://github.com/apache/incubator-echarts/pull/12561) 
([plainheart](https://github.com/plainheart))
+
++ [Fix] [toolbox] Fix dataView shows NaN when using dataset. 
[#11849](https://github.com/apache/incubator-echarts/pull/11849) 
([susiwen8](https://github.com/susiwen8))
+
++ [Fix] [toolbox] Fix saveAsImage may have error in some special environments. 
[#12643](https://github.com/apache/incubator-echarts/pull/12643) 
([lzr900515](https://github.com/lzr900515))
+
++ [Fix] [lines] Fix lines disappear if setOption again without data. 
[#12850](https://github.com/apache/incubator-echarts/pull/12850) 
([plainheart](https://github.com/plainheart))
+
++ [Fix] [sunburst] [treemap] Fix label formatter in `levels` not work bug. 
[#12742](https://github.com/apache/incubator-echarts/pull/12742) 
([Ovilia](https://github.com/Ovilia))
+
++ [Fix] [bmap] Fix bmap event `moveend` is always triggered when dragging or 
zoomend. [#12558](https://github.com/apache/incubator-echarts/pull/12558) 
([plainheart](https://github.com/plainheart))
+
++ [Fix] [grid] Fix wrong gap calculation when `containLabel`is set in grid. 
[#12259](https://github.com/apache/incubator-echarts/issues/12259) 
([Ling310](https://github.com/Ling310))
+
++ [Fix] [tooltip] Fix newline in tooltip of radar and map series when using 
`ricText` render mode. 
[#12664](https://github.com/apache/incubator-echarts/pull/12664) 
([Ovilia](https://github.com/Ovilia))
+
++ [Fix] [tooltip] Update tooltip position proportionally when chart resized. 
[#12834](https://github.com/apache/incubator-echarts/pull/12834) 
([liulinboyi](https://github.com/liulinboyi))
+
++ [Fix] [tooltip] Fix tooltip dispose in `richText` render mode. 
[#12608](https://github.com/apache/incubator-echarts/pull/12608) 
([plainheart](https://github.com/plainheart))
+
++ [Fix] [tree] Fix image symbol not display on first render. 
[#12367](https://github.com/apache/incubator-echarts/pull/12367) 
([plainheart](https://github.com/plainheart))
+
++ [Fix] [geo] Fix label formatter not work bug. 
[#12762](https://github.com/apache/incubator-echarts/pull/12762) 
([plainheart](https://github.com/plainheart))
+
++ [Fix] [bar] Fix error when switching `showBackground` from `false` to 
`true`. [#13085](https://github.com/apache/incubator-echarts/pull/13085) 
([easonyq](https://github.com/easonyq))
+
++ [Fix] [markArea] Fix label is not hidden when markArea is outside the grid. 
[#12669](https://github.com/apache/incubator-echarts/pull/12669) 
([Ovilia](https://github.com/Ovilia))
+
++ [Fix] [markLine] [markPoint] Fix `symbolRotate` not work bug. 
[#12737](https://github.com/apache/incubator-echarts/pull/12737) 
[#12392](https://github.com/apache/incubator-echarts/pull/12392) 
([plainheart](https://github.com/plainheart))
+
++ [Fix] [polar] Fix bar layout on polar with nagive axis. 
[#12418](https://github.com/apache/incubator-echarts/pull/12418) 
([gracelia](https://github.com/gracelia))
+



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] susiwen8 closed issue #13083: tree图,设置节点与节点之间连线的颜色,lineStyle对所有子节点的线都设置了,无法对可以独立每条线分开设置?

2020-08-06 Thread GitBox


susiwen8 closed issue #13083:
URL: https://github.com/apache/incubator-echarts/issues/13083


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] sBhaskar20 commented on issue #8907: Sunburst with defined levels has weird behavior when drill down

2020-08-06 Thread GitBox


sBhaskar20 commented on issue #8907:
URL: 
https://github.com/apache/incubator-echarts/issues/8907#issuecomment-669962080


   Any progress on this? This is a blocker for us in terms of sunburst adoption 
in our product.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



svn commit: r40889 - in /dev/incubator/echarts: 4.9.0-rc.1/ 4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip 4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip.asc 4.9.0-rc.1/apache-echart

2020-08-06 Thread shenyi
Author: shenyi
Date: Thu Aug  6 14:26:05 2020
New Revision: 40889

Log:
prerelease 4.9.0

Added:
dev/incubator/echarts/4.9.0-rc.1/

dev/incubator/echarts/4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip   
(with props)

dev/incubator/echarts/4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip.asc

dev/incubator/echarts/4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip.sha512
Modified:
dev/incubator/echarts/KEYS

Added: 
dev/incubator/echarts/4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip
==
Binary file - no diff available.

Propchange: 
dev/incubator/echarts/4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip
--
svn:mime-type = application/octet-stream

Added: 
dev/incubator/echarts/4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip.asc
==
--- 
dev/incubator/echarts/4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip.asc
 (added)
+++ 
dev/incubator/echarts/4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip.asc
 Thu Aug  6 14:26:05 2020
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCAAdFiEElL0XgHdnIVdlKCZ1jkSoJJc4IpgFAl8sEb4ACgkQjkSoJJc4
+IpixxQ/+JyUIlUKj1gyH64F+H2qxLsD8m9YuO09N/yRkRdV/mv7spxgih4XmcFjN
+EEEysma84J3FT1caZKg12C1r2ceDIODcNHGtY3hHw/kSpUHIJ/zDpa80H8US7/BI
+fewhSeV4WFPVpISz9xijWV6Ua0zAK1fI7gMGA/c1ltw2qRITll1JrtZbO8uVpGmV
+1QB7q837BQb7nY/tTl7+I6A+wGsoqRyVYoqwJJRFSpEPv3tGhqeDpgLlNmhAvK25
+KHgZN2ybvSS/KrQScvT0BEdFZAsJQZ+rZEWfZl9PDNn95f71V8xfL96bMr94sVqJ
+OrNMDhNw2SCjVaIfdgH702ECE3TYU4LGWMWoafcWF79i5bKSiAx5v/pzuMaq34pR
+dP7UmgTO0ai1Rf8Q6iwT4GrJcq95SvTxfk+m3oOwb1Kxdpzrkm7V00w+4Zyj9hg+
+EDk6rkBtTiI8nzvysypBBRNh3CR+Pp+h56qT1wJVF9IXNjm4xfS1OvxNoofOuVN/
+mZ4RP8NMUZNYbqBjq3hkiXP213HDfH/lk1rsGZy4mKCqmL3d8XdJn7w70alYH74r
+TEgaXeGg5ThU42x7niYmdPzIerpcN48+K4TpksaGRkjP8QVzG7OJ4MloJeAl3LM8
+/5zxEv6v70lpoM6qswaBi5IROQnN1hMKWGfnVL6X8TD5QV24TZY=
+=leak
+-END PGP SIGNATURE-

Added: 
dev/incubator/echarts/4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip.sha512
==
--- 
dev/incubator/echarts/4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip.sha512
 (added)
+++ 
dev/incubator/echarts/4.9.0-rc.1/apache-echarts-4.9.0-rc.1-incubating-src.zip.sha512
 Thu Aug  6 14:26:05 2020
@@ -0,0 +1 @@
+7ee936f3a0a6a6bf9b6ddf92c36ca07ac2f1ca6db689fee1a0ac88a86caa91390c28787c110b4ae0df930717ae07318f6f9984d4a6fd8aaedc1cf89e672bc86d
  apache-echarts-4.9.0-rc.1-incubating-src.zip

Modified: dev/incubator/echarts/KEYS
==
--- dev/incubator/echarts/KEYS (original)
+++ dev/incubator/echarts/KEYS Thu Aug  6 14:26:05 2020
@@ -132,3 +132,62 @@ MhfLdHrk689ty11m+5HlrSU7O1I1wZkt/OlYsZmS
 B4WM8AJSCwl8WlZrRA==
 =wft0
 -END PGP PUBLIC KEY BLOCK-
+pub   rsa4096 2020-08-06 [SC]
+  94BD178077672157652826758E44A82497382298
+uid   [ultimate] Shen Yi (CODE SIGNING KEY\) 
+sig 38E44A82497382298 2020-08-06  Shen Yi (CODE SIGNING KEY\) 

+sub   rsa4096 2020-08-06 [E]
+sig  8E44A82497382298 2020-08-06  Shen Yi (CODE SIGNING KEY\) 

+
+-BEGIN PGP PUBLIC KEY BLOCK-
+
+mQINBF8sDHUBEADScBNW9N9I7tu/ytMLp0XSQbyDO64iRsaAic/dnM4ffcZOl1AZ
+fbKTF2jI5ABVIl6mWBx5t8RE5XluyESfnB0au3fa0N1cb9bzjAqPiiTU5l9vF4Np
+u0517j8anqPYYk9n0HCVczaBQLavwa7ulUegnMCvO+WkrapkES3PzF/QDmHEh4iC
+FnPsayrhYvirg7Gwy6gkfkSZvp2jQIt2O3PQmffW1OsxwCf0uNIf4UrXxZ9gi6hc
+O/x1jNNpyfOBJY5es8feIsx+zQu/jZRL5AnLeuqYdODD/IdcT/AsSeFnMkIuYdKl
++S5DL23Rr5W47mCkRglauIOAFXnVd6cc3I0/TB+8+B1XOE7YBcslPytVmnc00Uwf
+f09a1WF7gTufCQAizIRShHLqSXA8Gebs42g5CLEC7k4v1Yojmwun5UFDlbxERQgj
+00hyDsGYv9Mwk5EokcpB/fyInRU0Niny6kk/siui/nvol0vcqBgwTqRJjfFByX8T
+ck11j7f3mUFq4z/PsVU4pQQpGyuiKLDQm7IJPAsJC/+s7aHAuMS/j3lpitM8j26A
+3x091RsxjfBrCusxb301rzw6F2g4bxTRueoPv9Ie8OW27uykqTgdnnCSjT5LQcN7
+H3dRmfk4UMU+QJTDhIdCzHyMnSGBVmlbbHIMIaoxnqzXFpO1+iGRQs8QcwARAQAB
+tC9TaGVuIFlpIChDT0RFIFNJR05JTkcgS0VZXCkgPHNoZW55aUBhcGFjaGUub3Jn
+PokCTgQTAQgAOBYhBJS9F4B3ZyFXZSgmdY5EqCSXOCKYBQJfLAx1AhsDBQsJCAcC
+BhUKCQgLAgQWAgMBAh4BAheAAAoJEI5EqCSXOCKYVkYP/1n0eL9d5EnDunqxo0dt
+HlfxLSx4l+edORXF+q9p0s7x33AktUZxMMNEbeAAgfrtC8sXg8bMa/NWHvmWVND7
+Qj8nJYVZ/jJSVwwXImsK6EdP8401UM1X3+z7uWy4KepJZQIVd6j8dxhW4QE74mlx
+CLBm9dK5rgxTjcNIKApscBJ6pP2eZBprHNdDW3ttaIMGBfz+nA3IpvH7ADgEkffP
+zc9BjiyCuff3q4qW1PnATJFEQCbBAxU13Y8S7pDRhHHDvuo/GNMAoKm8xWb9OzTz
+u8KistljvZWD1ZBjYxAYIKDqVyyUeH/aN134QsQyra++FFHkTiyYjpn/roSQm3Ww
+eQLXtRK0f12EpDb2pchxSrN3L4wRtzGj3I/u/7z6YXa8nuK29t8CDGTss4kBjDmQ
+2uYNAxFq6EylZU6QzaqvQgv/nhSuJFGlSY3v/4Q1MxB5rn68s2jegi/HXUIbFerf
+KgeJCN8nUtBiSIzVwMo0HMrrNyR4ZdCJa4bxzHspu6Fck4572AKxB3TNFkLYC0s+
+zOQ6b6l0bMgzH4HDj6C0k0+KtikK6Q2U1YXWu1T4MBu8Gq4weGEUDOxc0B1XywA2
+BE+cbOpjHi4lK3n1//RjUR+JL90RuD+JGCB8x2d+Ttm/c19S/KjQc8CsJ9JA5x1H

[incubator-echarts] tag 4.9.0-rc.1 created (now 90243fc)

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to tag 4.9.0-rc.1
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


  at 90243fc  (commit)
No new revisions were added by this update.


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] tag 4.9.0-rc.1 created (now 450ee94)

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to tag 4.9.0-rc.1
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


  at 450ee94  (commit)
No new revisions were added by this update.


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang merged pull request #13092: Release 4.9.0

2020-08-06 Thread GitBox


pissang merged pull request #13092:
URL: https://github.com/apache/incubator-echarts/pull/13092


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] 01/01: Merge pull request #13092 from apache/release-dev

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch release
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit 90243fca100866ea802249a98df8b0899e68927e
Merge: 68e965f e5c8871
Author: Yi Shen 
AuthorDate: Thu Aug 6 21:05:16 2020 +0800

Merge pull request #13092 from apache/release-dev

Release 4.9.0

 dist/echarts-en.common.js  |  377 ++
 dist/echarts-en.common.min.js  |2 +-
 dist/echarts-en.js | 1100 +---
 dist/echarts-en.js.map |2 +-
 dist/echarts-en.min.js |2 +-
 dist/echarts-en.simple.js  |   86 +++-
 dist/echarts-en.simple.min.js  |2 +-
 dist/echarts.common.js |  377 ++
 dist/echarts.common.min.js |2 +-
 dist/echarts.js| 1100 +---
 dist/echarts.js.map|2 +-
 dist/echarts.min.js|2 +-
 dist/echarts.simple.js |   86 +++-
 dist/echarts.simple.min.js |2 +-
 dist/extension/bmap.js |  378 ++
 dist/extension/bmap.js.map |2 +-
 dist/extension/bmap.min.js |2 +-
 dist/extension/dataTool.js.map |2 +-
 extension/bmap/BMapCoordSys.js |   18 +-
 extension/bmap/BMapModel.js|4 +
 extension/bmap/BMapView.js |   32 +-
 package-lock.json  |8 +-
 package.json   |4 +-
 src/coord/axisHelper.js|6 +-
 src/echarts.js |4 +-
 25 files changed, 2412 insertions(+), 1190 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch release updated (68e965f -> 90243fc)

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch release
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


from 68e965f  Merge pull request #13088 from apache/fix/remove-es6-code
 add e5c8871  chore: release 4.9.0
 new 90243fc  Merge pull request #13092 from apache/release-dev

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 dist/echarts-en.common.js  |  377 ++
 dist/echarts-en.common.min.js  |2 +-
 dist/echarts-en.js | 1100 +---
 dist/echarts-en.js.map |2 +-
 dist/echarts-en.min.js |2 +-
 dist/echarts-en.simple.js  |   86 +++-
 dist/echarts-en.simple.min.js  |2 +-
 dist/echarts.common.js |  377 ++
 dist/echarts.common.min.js |2 +-
 dist/echarts.js| 1100 +---
 dist/echarts.js.map|2 +-
 dist/echarts.min.js|2 +-
 dist/echarts.simple.js |   86 +++-
 dist/echarts.simple.min.js |2 +-
 dist/extension/bmap.js |  378 ++
 dist/extension/bmap.js.map |2 +-
 dist/extension/bmap.min.js |2 +-
 dist/extension/dataTool.js.map |2 +-
 extension/bmap/BMapCoordSys.js |   18 +-
 extension/bmap/BMapModel.js|4 +
 extension/bmap/BMapView.js |   32 +-
 package-lock.json  |8 +-
 package.json   |4 +-
 src/coord/axisHelper.js|6 +-
 src/echarts.js |4 +-
 25 files changed, 2412 insertions(+), 1190 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13092: Release 4.9.0

2020-08-06 Thread GitBox


echarts-bot[bot] commented on pull request #13092:
URL: 
https://github.com/apache/incubator-echarts/pull/13092#issuecomment-669914257


   Congratulations! Your PR has been merged. Thanks for your contribution! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang opened a new pull request #13092: Release 4.9.0

2020-08-06 Thread GitBox


pissang opened a new pull request #13092:
URL: https://github.com/apache/incubator-echarts/pull/13092


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch release-dev created (now e5c8871)

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch release-dev
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


  at e5c8871  chore: release 4.9.0

This branch includes the following new commits:

 new e5c8871  chore: release 4.9.0

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] quillblue closed pull request #12563: fix(axisLabel): show min(max) label when interval is function and configured showMin(Max)Label #12142

2020-08-06 Thread GitBox


quillblue closed pull request #12563:
URL: https://github.com/apache/incubator-echarts/pull/12563


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] sgurin closed issue #13090: Install echarts using github link

2020-08-06 Thread GitBox


sgurin closed issue #13090:
URL: https://github.com/apache/incubator-echarts/issues/13090


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] sgurin opened a new issue #13091: Install echarts using github link

2020-08-06 Thread GitBox


sgurin opened a new issue #13091:
URL: https://github.com/apache/incubator-echarts/issues/13091


   ### Version
   4.8.0
   
   ### Steps to reproduce
   I was trying to install echarts using GitHub link 
https://github.com/apache/incubator-echarts#4.8.0 and there is lib folder 
missing.
   
   ### What is expected?
   Ok
   
   ### What is actually happening?
   ERROR Failed to compile with 49 errors
   These relative modules were not found:
   
   ./lib/chart/bar in ./node_modules/echarts/index.js
   ./lib/chart/boxplot in ./node_modules/echarts/index.js
   ./lib/chart/candlestick in ./node_modules/echarts/index.js
   ./lib/chart/custom in ./node_modules/echarts/index.js
   ./lib/chart/effectScatter in ./node_modules/echarts/index.js
   ./lib/chart/funnel in ./node_modules/echarts/index.js
   ./lib/chart/gauge in ./node_modules/echarts/index.js
   ./lib/chart/graph in ./node_modules/echarts/index.js
   
   ---
   If package was downloaded via NPM it has lib folder. Unfortunately I cannot 
use NPM. What I am doing wrong?
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13091: Install echarts using github link

2020-08-06 Thread GitBox


echarts-bot[bot] commented on issue #13091:
URL: 
https://github.com/apache/incubator-echarts/issues/13091#issuecomment-669871877


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] sgurin opened a new issue #13090: Install echarts using github link

2020-08-06 Thread GitBox


sgurin opened a new issue #13090:
URL: https://github.com/apache/incubator-echarts/issues/13090


   Hi, guys.
   
   I was trying to install echarts using GitHub link 
https://github.com/apache/incubator-echarts#4.8.0 and there is lib folder 
missing. 
   
   So, I get 
   
   ERROR  Failed to compile with 49 errors  


   These relative modules were not found:
   * ./lib/chart/bar in ./node_modules/echarts/index.js
   * ./lib/chart/boxplot in ./node_modules/echarts/index.js
   * ./lib/chart/candlestick in ./node_modules/echarts/index.js
   * ./lib/chart/custom in ./node_modules/echarts/index.js
   * ./lib/chart/effectScatter in ./node_modules/echarts/index.js
   * ./lib/chart/funnel in ./node_modules/echarts/index.js
   * ./lib/chart/gauge in ./node_modules/echarts/index.js
   * ./lib/chart/graph in ./node_modules/echarts/index.js
   
   If package was downloaded via NPM it has lib folder. Unfortunately I cannot 
use NPM. What I am doing wrong?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13090: Install echarts using github link

2020-08-06 Thread GitBox


echarts-bot[bot] commented on issue #13090:
URL: 
https://github.com/apache/incubator-echarts/issues/13090#issuecomment-669871041


   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建,所以我将关闭此 issue。
   为此带来的麻烦我深表歉意,但是请理解这是为了节约社区维护者的时间,以更高效地服务社区的开发者群体。
   如果您愿意,可以请使用 issue 模板重新创建 issue。
   
   如果你认为虽然没有使用模板,但你已经提供了复现问题的充分描述,或者你的问题无法使用模板表达,也可以重新 open 这个 issue。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] kilik52 commented on issue #10813: echarts 中的关系图,如果将link的source和target设置一致时,无法可见。

2020-08-06 Thread GitBox


kilik52 commented on issue #10813:
URL: 
https://github.com/apache/incubator-echarts/issues/10813#issuecomment-669848950


   @Ovilia 4.8.0了。这个问题还没有解决。请问是否有计划将自指向的问题解决



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pierrebonny opened a new issue #13089: Get more dimensions data from echarts instance

2020-08-06 Thread GitBox


pierrebonny opened a new issue #13089:
URL: https://github.com/apache/incubator-echarts/issues/13089


   ### What problem does this feature solve?
   It could be useful to be able to get more data about some items dimensions 
in chart. For exemple to be able to shorten x axis labels depending on chart 
width. When containLabel is set to true it is not possible to compute properly 
available space for axis labels.
   
   ### What does the proposed API look like?
   An idea is to provide in the 'rendered' or 'finished' event some more data 
about important items in the chart.
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13089: Get more dimensions data from echarts instance

2020-08-06 Thread GitBox


echarts-bot[bot] commented on issue #13089:
URL: 
https://github.com/apache/incubator-echarts/issues/13089#issuecomment-669830857


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] zl7261 commented on issue #10391: 使用dataset时,tooltip.formatter使用通配符有问题

2020-08-06 Thread GitBox


zl7261 commented on issue #10391:
URL: 
https://github.com/apache/incubator-echarts/issues/10391#issuecomment-669825256


   Same problem. wait for release new version.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13088: style: remove unexpected es6 code

2020-08-06 Thread GitBox


echarts-bot[bot] commented on pull request #13088:
URL: 
https://github.com/apache/incubator-echarts/pull/13088#issuecomment-669806144


   Congratulations! Your PR has been merged. Thanks for your contribution! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] 01/01: Merge pull request #13088 from apache/fix/remove-es6-code

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch release
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit 68e965fe840d58ebf755d19c81b0dff2ef8a39b1
Merge: 106b948 7d0d325
Author: Yi Shen 
AuthorDate: Thu Aug 6 17:01:48 2020 +0800

Merge pull request #13088 from apache/fix/remove-es6-code

style: remove unexpected es6 code

 src/component/timeline/SliderTimelineView.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang merged pull request #13088: style: remove unexpected es6 code

2020-08-06 Thread GitBox


pissang merged pull request #13088:
URL: https://github.com/apache/incubator-echarts/pull/13088


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch release updated (106b948 -> 68e965f)

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch release
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


from 106b948  Merge pull request #13087 from apache/fix/timeline-icon-style
 add 7d0d325  style: remove unexpected es6 code
 new 68e965f  Merge pull request #13088 from apache/fix/remove-es6-code

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/component/timeline/SliderTimelineView.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang opened a new pull request #13088: style: remove unexpected es6 code

2020-08-06 Thread GitBox


pissang opened a new pull request #13088:
URL: https://github.com/apache/incubator-echarts/pull/13088


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch fix/remove-es6-code updated: style: remove unexpected es6 code

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch fix/remove-es6-code
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/fix/remove-es6-code by this 
push:
 new 7d0d325  style: remove unexpected es6 code
7d0d325 is described below

commit 7d0d325c52e1718f50ac7773599b5be50594e1cd
Author: pissang 
AuthorDate: Thu Aug 6 16:58:41 2020 +0800

style: remove unexpected es6 code
---
 src/component/timeline/SliderTimelineView.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/component/timeline/SliderTimelineView.js 
b/src/component/timeline/SliderTimelineView.js
index 216d376..a9e4b6b 100644
--- a/src/component/timeline/SliderTimelineView.js
+++ b/src/component/timeline/SliderTimelineView.js
@@ -618,8 +618,8 @@ function getViewRect(model, api) {
 }
 
 function makeIcon(timelineModel, objPath, rect, opts) {
-const style = opts.style;
-const icon = graphic.createIcon(
+var style = opts.style;
+var icon = graphic.createIcon(
 timelineModel.get(objPath),
 opts || {},
 new BoundingRect(rect[0], rect[1], rect[2], rect[3])


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch fix/remove-es6-code created (now 106b948)

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch fix/remove-es6-code
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


  at 106b948  Merge pull request #13087 from apache/fix/timeline-icon-style

No new revisions were added by this update.


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] liucaidong commented on issue #12221: Cannot read property 'traverse' of undefined when drawing custom chart

2020-08-06 Thread GitBox


liucaidong commented on issue #12221:
URL: 
https://github.com/apache/incubator-echarts/issues/12221#issuecomment-669803544


   has this problem been resolved?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch fix/remove-es6-code created (now 2e1429c)

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch fix/remove-es6-code
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


  at 2e1429c  style: remove unexpected es6 code.

This branch includes the following new commits:

 new 2e1429c  style: remove unexpected es6 code.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] 01/01: style: remove unexpected es6 code.

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch fix/remove-es6-code
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit 2e1429ca861e276323c792214e1f315dfcda3840
Author: pissang 
AuthorDate: Thu Aug 6 16:53:32 2020 +0800

style: remove unexpected es6 code.
---
 dist/echarts-en.common.js|  371 ++---
 dist/echarts-en.common.min.js|2 +-
 dist/echarts-en.js   | 1094 +++---
 dist/echarts-en.js.map   |2 +-
 dist/echarts-en.min.js   |2 +-
 dist/echarts-en.simple.js|   80 +-
 dist/echarts-en.simple.min.js|2 +-
 dist/extension/bmap.js   |  378 +
 dist/extension/bmap.js.map   |2 +-
 dist/extension/bmap.min.js   |2 +-
 dist/extension/dataTool.js   |   20 -
 src/component/timeline/SliderTimelineView.js |4 +-
 12 files changed, 1192 insertions(+), 767 deletions(-)

diff --git a/dist/echarts-en.common.js b/dist/echarts-en.common.js
index 900be34..5716540 100644
--- a/dist/echarts-en.common.js
+++ b/dist/echarts-en.common.js
@@ -26152,7 +26152,7 @@ var proto = Scheduler.prototype;
  * @param {Object} payload
  */
 proto.restoreData = function (ecModel, payload) {
-// TODO: Only restroe needed series and components, but not all components.
+// TODO: Only restore needed series and components, but not all components.
 // Currently `restoreData` of all of the series and component will be 
called.
 // But some independent components like `title`, `legend`, `graphic`, 
`toolbox`,
 // `tooltip`, `axisPointer`, etc, do not need series refresh when 
`setOption`,
@@ -30975,7 +30975,7 @@ listProto.mapDimension = function (coordDim, idx) {
  * Initialize from data
  * @param {Array.} data source or data or data provider.
  * @param {Array.} [nameLIst] The name of a datum is used on data diff 
and
- *defualt label/tooltip.
+ *default label/tooltip.
  *A name can be specified in encode.itemName,
  *or dataItem.name (only for series option data),
  *or provided in nameList from outside.
@@ -35567,8 +35567,8 @@ function rotateTextRect(textRect, rotate) {
 var boundingBox = textRect.plain();
 var beforeWidth = boundingBox.width;
 var beforeHeight = boundingBox.height;
-var afterWidth = beforeWidth * Math.cos(rotateRadians) + beforeHeight * 
Math.sin(rotateRadians);
-var afterHeight = beforeWidth * Math.sin(rotateRadians) + beforeHeight * 
Math.cos(rotateRadians);
+var afterWidth = beforeWidth * Math.abs(Math.cos(rotateRadians)) + 
Math.abs(beforeHeight * Math.sin(rotateRadians));
+var afterHeight = beforeWidth * Math.abs(Math.sin(rotateRadians)) + 
Math.abs(beforeHeight * Math.cos(rotateRadians));
 var rotatedRect = new BoundingRect(boundingBox.x, boundingBox.y, 
afterWidth, afterHeight);
 
 return rotatedRect;
@@ -37669,7 +37669,7 @@ symbolProto._updateCommon = function (data, idx, 
symbolSize, seriesScope) {
 }
 else {
 symbolPath.setStyle({
-opacity: null,
+opacity: 1,
 shadowBlur: null,
 shadowOffsetX: null,
 shadowOffsetY: null,
@@ -39854,7 +39854,7 @@ var dataSample = function (seriesType) {
 var valueAxis = coordSys.getOtherAxis(baseAxis);
 var extent = baseAxis.getExtent();
 // Coordinste system has been resized
-var size = extent[1] - extent[0];
+var size = Math.abs(extent[1] - extent[0]);
 var rate = Math.round(data.count() / size);
 if (rate > 1) {
 var sampler;
@@ -40310,7 +40310,7 @@ var defaultOption = {
 name: '',
 // 'start' | 'middle' | 'end'
 nameLocation: 'end',
-// By degree. By defualt auto rotate by nameLocation.
+// By degree. By default auto rotate by nameLocation.
 nameRotate: null,
 nameTruncate: {
 maxWidth: null,
@@ -43553,20 +43553,25 @@ extendChartView({
 var bgEls = [];
 var oldBgEls = this._backgroundEls || [];
 
+var createBackground = function (dataIndex) {
+var bgLayout = getLayout[coord.type](data, dataIndex);
+var bgEl = createBackgroundEl(coord, isHorizontalOrRadial, 
bgLayout);
+bgEl.useStyle(backgroundModel.getBarItemStyle());
+// Only cartesian2d support borderRadius.
+if (coord.type === 'cartesian2d') {
+bgEl.setShape('r', barBorderRadius);
+}
+bgEls[dataIndex] = bgEl;
+return bgEl;
+};
+
 data.diff(oldData)
 .add(function (dataIndex) {
 var itemModel = data.getItemModel(dataIndex);
 var layout = getLayout[coord.type](data, 

[GitHub] [incubator-echarts] plainheart closed issue #13050: 配置项手册无内容

2020-08-06 Thread GitBox


plainheart closed issue #13050:
URL: https://github.com/apache/incubator-echarts/issues/13050


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] plainheart closed issue #13061: 配置项手册无内容

2020-08-06 Thread GitBox


plainheart closed issue #13061:
URL: https://github.com/apache/incubator-echarts/issues/13061


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang merged pull request #13087: fix(timeline): fix icon style not work bug brought in #13015

2020-08-06 Thread GitBox


pissang merged pull request #13087:
URL: https://github.com/apache/incubator-echarts/pull/13087


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] 01/01: Merge pull request #13087 from apache/fix/timeline-icon-style

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch release
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit 106b94875eac1137f69ba933fc0885b9c8ffa962
Merge: 59f9861 5b8839b
Author: Yi Shen 
AuthorDate: Thu Aug 6 16:35:23 2020 +0800

Merge pull request #13087 from apache/fix/timeline-icon-style

fix(timeline): fix icon style not work bug brought in #13015

 src/component/timeline/SliderTimelineView.js | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13087: fix(timeline): fix icon style not work bug brought in #13015

2020-08-06 Thread GitBox


echarts-bot[bot] commented on pull request #13087:
URL: 
https://github.com/apache/incubator-echarts/pull/13087#issuecomment-669793266


   Congratulations! Your PR has been merged. Thanks for your contribution! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch release updated (59f9861 -> 106b948)

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch release
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


from 59f9861  Merge pull request #13085 from easonyq/fix-13009
 add 5b8839b  fix(timeline): fix icon style not work bug brought in #13015
 new 106b948  Merge pull request #13087 from apache/fix/timeline-icon-style

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/component/timeline/SliderTimelineView.js | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] meggiepeng closed issue #13031: toolbox optionToContent 自定义 dataView,点刷新,optionToContent回调中拿到的series数据遗失

2020-08-06 Thread GitBox


meggiepeng closed issue #13031:
URL: https://github.com/apache/incubator-echarts/issues/13031


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] meggiepeng commented on issue #13031: toolbox optionToContent 自定义 dataView,点刷新,optionToContent回调中拿到的series数据遗失

2020-08-06 Thread GitBox


meggiepeng commented on issue #13031:
URL: 
https://github.com/apache/incubator-echarts/issues/13031#issuecomment-669792019


   谢谢,问题已解决。(如果没有设定contentToOption方法时也能容错就更好了)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] vincentzxt commented on issue #13061: 配置项手册无内容

2020-08-06 Thread GitBox


vincentzxt commented on issue #13061:
URL: 
https://github.com/apache/incubator-echarts/issues/13061#issuecomment-669789087


   可以正常访问了
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   在 2020-08-06 12:49:34,"Zhongxiang.Wang"  写道:
   
   @vincentzxt@wahoro 问题应该已经被解决,请再试试看验证下是否仍有问题。
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub, or unsubscribe.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts-doc] branch master updated: unify contributors name with github id in changelog.

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts-doc.git


The following commit(s) were added to refs/heads/master by this push:
 new 343c470  unify contributors name with github id in changelog.
343c470 is described below

commit 343c47086ed541bdab5014778c6d7d2ae09ebb40
Author: pissang 
AuthorDate: Thu Aug 6 16:20:09 2020 +0800

unify contributors name with github id in changelog.
---
 en/changelog.md | 138 
 zh/changelog.md | 136 +++
 2 files changed, 137 insertions(+), 137 deletions(-)

diff --git a/en/changelog.md b/en/changelog.md
index 7211d8f..42f4466 100644
--- a/en/changelog.md
+++ b/en/changelog.md
@@ -1,7 +1,7 @@
 ## v4.9.0
 2020-08-06
 
-+ [Feature] [graph] Support multiple edges to link nodes in graph. 
[#12590](https://github.com/apache/incubator-echarts/pull/12590) ([Zak 
Wu](https://github.com/wf123537200))
++ [Feature] [graph] Support multiple edges to link nodes in graph. 
[#12590](https://github.com/apache/incubator-echarts/pull/12590) 
([wf123537200](https://github.com/wf123537200))
 
 + [Feature] [funnel] Add `orient` option in funnel. Support horizontal layout. 
[#12754](https://github.com/apache/incubator-echarts/pull/12754) 
([regrex](https://github.com/regrex))
 
@@ -11,17 +11,17 @@
 
 + [Fix] [themeRiver] Optimize data process in themeRiver. 
[#12022](https://github.com/apache/incubator-echarts/pull/12022) 
([Zaynex](https://github.com/Zaynex))
 
-+ [Fix] [toolbox] Fix pie series render incorrectly after editing its data in 
the dataView feature. 
[#12561](https://github.com/apache/incubator-echarts/pull/12561) ([Zhongxiang 
Wang](https://github.com/plainheart))
++ [Fix] [toolbox] Fix pie series render incorrectly after editing its data in 
the dataView feature. 
[#12561](https://github.com/apache/incubator-echarts/pull/12561) 
([plainheart](https://github.com/plainheart))
 
-+ [Fix] [toolbox] Fix dataView shows NaN when using dataset. 
[#11849](https://github.com/apache/incubator-echarts/pull/11849) ([Su 
Siwen](https://github.com/susiwen8))
++ [Fix] [toolbox] Fix dataView shows NaN when using dataset. 
[#11849](https://github.com/apache/incubator-echarts/pull/11849) 
([susiwen8](https://github.com/susiwen8))
 
 + [Fix] [toolbox] Fix saveAsImage may have error in some special environments. 
[#12643](https://github.com/apache/incubator-echarts/pull/12643) 
([lzr900515](https://github.com/lzr900515))
 
-+ [Fix] [lines] Fix lines disappear if setOption again without data. 
[#12850](https://github.com/apache/incubator-echarts/pull/12850) ([Zhongxiang 
Wang](https://github.com/plainheart))
++ [Fix] [lines] Fix lines disappear if setOption again without data. 
[#12850](https://github.com/apache/incubator-echarts/pull/12850) 
([plainheart](https://github.com/plainheart))
 
 + [Fix] [sunburst] [treemap] Fix label formatter in `levels` not work bug. 
[#12742](https://github.com/apache/incubator-echarts/pull/12742) 
([Ovilia](https://github.com/Ovilia))
 
-+ [Fix] [bmap] Fix bmap event `moveend` is always triggered when dragging or 
zoomend. [#12558](https://github.com/apache/incubator-echarts/pull/12558) 
([Zhongxiang Wang](https://github.com/plainheart))
++ [Fix] [bmap] Fix bmap event `moveend` is always triggered when dragging or 
zoomend. [#12558](https://github.com/apache/incubator-echarts/pull/12558) 
([plainheart](https://github.com/plainheart))
 
 + [Fix] [grid] Fix wrong gap calculation when `containLabel`is set in grid. 
[#12259](https://github.com/apache/incubator-echarts/issues/12259) 
([Ling310](https://github.com/Ling310))
 
@@ -29,17 +29,17 @@
 
 + [Fix] [tooltip] Update tooltip position proportionally when chart resized. 
[#12834](https://github.com/apache/incubator-echarts/pull/12834) 
([liulinboyi](https://github.com/liulinboyi))
 
-+ [Fix] [tooltip] Fix tooltip dispose in `richText` render mode. 
[#12608](https://github.com/apache/incubator-echarts/pull/12608) ([Zhongxiang 
Wang](https://github.com/plainheart))
++ [Fix] [tooltip] Fix tooltip dispose in `richText` render mode. 
[#12608](https://github.com/apache/incubator-echarts/pull/12608) 
([plainheart](https://github.com/plainheart))
 
-+ [Fix] [tree] Fix image symbol not display on first render. 
[#12367](https://github.com/apache/incubator-echarts/pull/12367) ([Zhongxiang 
Wang](https://github.com/plainheart))
++ [Fix] [tree] Fix image symbol not display on first render. 
[#12367](https://github.com/apache/incubator-echarts/pull/12367) 
([plainheart](https://github.com/plainheart))
 
-+ [Fix] [geo] Fix label formatter not work bug. 
[#12762](https://github.com/apache/incubator-echarts/pull/12762) ([Zhongxiang 
Wang](https://github.com/plainheart))
++ [Fix] [geo] Fix label formatter not work bug. 
[#12762](https://github.com/apache/incubator-echarts/pull/12762) 

[GitHub] [incubator-echarts] pissang opened a new pull request #13087: fix(timeline): fix icon style not work bug brought in #13015

2020-08-06 Thread GitBox


pissang opened a new pull request #13087:
URL: https://github.com/apache/incubator-echarts/pull/13087


   
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Fix timeline icon style not work bug brought in #13015



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] 01/01: fix(timeline): fix icon style not work bug brought in #13015

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch fix/timeline-icon-style
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit 5b8839bb6fe54abb9e95b9beed100566b2c5fc6e
Author: pissang 
AuthorDate: Thu Aug 6 16:11:20 2020 +0800

fix(timeline): fix icon style not work bug brought in #13015
---
 src/component/timeline/SliderTimelineView.js | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/component/timeline/SliderTimelineView.js 
b/src/component/timeline/SliderTimelineView.js
index 71594d0..216d376 100644
--- a/src/component/timeline/SliderTimelineView.js
+++ b/src/component/timeline/SliderTimelineView.js
@@ -618,11 +618,17 @@ function getViewRect(model, api) {
 }
 
 function makeIcon(timelineModel, objPath, rect, opts) {
-return graphic.createIcon(
+const style = opts.style;
+const icon = graphic.createIcon(
 timelineModel.get(objPath),
 opts || {},
 new BoundingRect(rect[0], rect[1], rect[2], rect[3])
 );
+// TODO createIcon won't use style in opt.
+if (style) {
+icon.setStyle(style);
+}
+return icon;
 }
 
 /**


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch fix/timeline-icon-style created (now 5b8839b)

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch fix/timeline-icon-style
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


  at 5b8839b  fix(timeline): fix icon style not work bug brought in #13015

This branch includes the following new commits:

 new 5b8839b  fix(timeline): fix icon style not work bug brought in #13015

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch release updated: remove unnecessary var declaration

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch release
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/release by this push:
 new c16913c  remove unnecessary var declaration
 new 59f9861  Merge pull request #13085 from easonyq/fix-13009
c16913c is described below

commit c16913c48282033bbf49b8e377f0898d4133513d
Author: Eason Wang 
AuthorDate: Thu Aug 6 14:54:27 2020 +0800

remove unnecessary var declaration
---
 src/chart/bar/BarView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/chart/bar/BarView.js b/src/chart/bar/BarView.js
index 63aae9b..fe45122 100644
--- a/src/chart/bar/BarView.js
+++ b/src/chart/bar/BarView.js
@@ -192,7 +192,7 @@ export default echarts.extendChartView({
 bgEl = createBackground(oldIndex);
 }
 else {
-var bgEl = oldBgEls[oldIndex];
+bgEl = oldBgEls[oldIndex];
 bgEl.useStyle(backgroundModel.getBarItemStyle());
 // Only cartesian2d support borderRadius.
 if (coord.type === 'cartesian2d') {


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang merged pull request #13085: fix(bar): showBackground bug when update with no previous background elements

2020-08-06 Thread GitBox


pissang merged pull request #13085:
URL: https://github.com/apache/incubator-echarts/pull/13085


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13085: fix(bar): showBackground bug when update with no previous background elements

2020-08-06 Thread GitBox


echarts-bot[bot] commented on pull request #13085:
URL: 
https://github.com/apache/incubator-echarts/pull/13085#issuecomment-669768461


   Congratulations! Your PR has been merged. Thanks for your contribution! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] easonyq opened a new pull request #13086: fix: make `contentToOption` totally optional

2020-08-06 Thread GitBox


easonyq opened a new pull request #13086:
URL: https://github.com/apache/incubator-echarts/pull/13086


   
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   
   
   Fix #13031 
   
   ### Fixed issues
   
   #13031 has described such a situation that user has provided 
`optionToContent` function while has not provided the corresponding 
`contentToOption` function.
   If we think echarts should also work well in this situation, we need to make 
`contentToOption` function totally optional. (In other words, if user hasn't 
provide it, bugs like missing series data or a list of `undefined` should not 
happen.)
   
   
   ## Details
   
   ### Before: What was the problem?
   
   If user provide `optionToContent` function but has not provided 
`contentToOption` function, press 'refresh' will lose data and make a list of 
`undefined` displayed.
   
   
   
   ### After: How is it fixed in this PR?
   
   Even user has not provided `contentToOption` function, by pressing 'refresh' 
button also works well.
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   
   
   No
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [x] Please squash the commits into a single one when merge.
   
   ### Other information
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts-doc] branch master updated: add changelog of 4.9.0

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts-doc.git


The following commit(s) were added to refs/heads/master by this push:
 new f37e7bd  add changelog of 4.9.0
f37e7bd is described below

commit f37e7bd9e394450e9678dd658e8f7a7e61003419
Author: pissang 
AuthorDate: Thu Aug 6 15:28:52 2020 +0800

add changelog of 4.9.0
---
 en/changelog.md | 49 -
 zh/changelog.md | 46 ++
 2 files changed, 94 insertions(+), 1 deletion(-)

diff --git a/en/changelog.md b/en/changelog.md
index 25585a7..7211d8f 100644
--- a/en/changelog.md
+++ b/en/changelog.md
@@ -1,3 +1,50 @@
+## v4.9.0
+2020-08-06
+
++ [Feature] [graph] Support multiple edges to link nodes in graph. 
[#12590](https://github.com/apache/incubator-echarts/pull/12590) ([Zak 
Wu](https://github.com/wf123537200))
+
++ [Feature] [funnel] Add `orient` option in funnel. Support horizontal layout. 
[#12754](https://github.com/apache/incubator-echarts/pull/12754) 
([regrex](https://github.com/regrex))
+
++ [Enhancement] [tooltip] Add text shadow options. 
[#12664](https://github.com/apache/incubator-echarts/pull/12664) 
([Ovilia](https://github.com/Ovilia))
+
++ [Enhancement] [toolbox] Add `brushStyle` option to configuration style of 
brush rect in the dataZoom feature. 
[#12550](https://github.com/apache/incubator-echarts/pull/12550) 
([zhiyuc123](https://github.com/zhiyuc123))
+
++ [Fix] [themeRiver] Optimize data process in themeRiver. 
[#12022](https://github.com/apache/incubator-echarts/pull/12022) 
([Zaynex](https://github.com/Zaynex))
+
++ [Fix] [toolbox] Fix pie series render incorrectly after editing its data in 
the dataView feature. 
[#12561](https://github.com/apache/incubator-echarts/pull/12561) ([Zhongxiang 
Wang](https://github.com/plainheart))
+
++ [Fix] [toolbox] Fix dataView shows NaN when using dataset. 
[#11849](https://github.com/apache/incubator-echarts/pull/11849) ([Su 
Siwen](https://github.com/susiwen8))
+
++ [Fix] [toolbox] Fix saveAsImage may have error in some special environments. 
[#12643](https://github.com/apache/incubator-echarts/pull/12643) 
([lzr900515](https://github.com/lzr900515))
+
++ [Fix] [lines] Fix lines disappear if setOption again without data. 
[#12850](https://github.com/apache/incubator-echarts/pull/12850) ([Zhongxiang 
Wang](https://github.com/plainheart))
+
++ [Fix] [sunburst] [treemap] Fix label formatter in `levels` not work bug. 
[#12742](https://github.com/apache/incubator-echarts/pull/12742) 
([Ovilia](https://github.com/Ovilia))
+
++ [Fix] [bmap] Fix bmap event `moveend` is always triggered when dragging or 
zoomend. [#12558](https://github.com/apache/incubator-echarts/pull/12558) 
([Zhongxiang Wang](https://github.com/plainheart))
+
++ [Fix] [grid] Fix wrong gap calculation when `containLabel`is set in grid. 
[#12259](https://github.com/apache/incubator-echarts/issues/12259) 
([Ling310](https://github.com/Ling310))
+
++ [Fix] [tooltip] Fix newline in tooltip of radar and map series when using 
`ricText` render mode. 
[#12664](https://github.com/apache/incubator-echarts/pull/12664) 
([Ovilia](https://github.com/Ovilia))
+
++ [Fix] [tooltip] Update tooltip position proportionally when chart resized. 
[#12834](https://github.com/apache/incubator-echarts/pull/12834) 
([liulinboyi](https://github.com/liulinboyi))
+
++ [Fix] [tooltip] Fix tooltip dispose in `richText` render mode. 
[#12608](https://github.com/apache/incubator-echarts/pull/12608) ([Zhongxiang 
Wang](https://github.com/plainheart))
+
++ [Fix] [tree] Fix image symbol not display on first render. 
[#12367](https://github.com/apache/incubator-echarts/pull/12367) ([Zhongxiang 
Wang](https://github.com/plainheart))
+
++ [Fix] [geo] Fix label formatter not work bug. 
[#12762](https://github.com/apache/incubator-echarts/pull/12762) ([Zhongxiang 
Wang](https://github.com/plainheart))
+
++ [Fix] [bar] Fix error when switching `showBackground` from `false` to 
`true`. [#13085](https://github.com/apache/incubator-echarts/pull/13085) 
([easonyq](https://github.com/easonyq))
+
++ [Fix] [markArea] Fix label is not hidden when markArea is outside the grid. 
[#12669](https://github.com/apache/incubator-echarts/pull/12669) 
([Ovilia](https://github.com/Ovilia))
+
++ [Fix] [markLine] [markPoint] Fix `symbolRotate` not work bug. 
[#12737](https://github.com/apache/incubator-echarts/pull/12737) 
[#12392](https://github.com/apache/incubator-echarts/pull/12392) ([Zhongxiang 
Wang](https://github.com/plainheart))
+
++ [Fix] [polar] Fix bar layout on polar with nagive axis. 
[#12418](https://github.com/apache/incubator-echarts/pull/12418) 
([gracelia](https://github.com/gracelia))
+
+
+
 ## v4.8.0
 2020-05-25
 
@@ -5,7 +52,7 @@
 
 + [Feature] Add more parameters in the loading effect. 

[GitHub] [incubator-echarts] easonyq commented on issue #13031: toolbox optionToContent 自定义 dataView,点刷新,optionToContent回调中拿到的series数据遗失

2020-08-06 Thread GitBox


easonyq commented on issue #13031:
URL: 
https://github.com/apache/incubator-echarts/issues/13031#issuecomment-669756495


   @plainheart 
   如果认为是使用者使用错误(没有设定 `contentToOption` 方法),那么可以关闭这个 issue。
   如果认为即便在使用者没有设定该方法时仍然应当容错,我可以提交一个 PR 进行这个修改。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] easonyq edited a comment on issue #13031: toolbox optionToContent 自定义 dataView,点刷新,optionToContent回调中拿到的series数据遗失

2020-08-06 Thread GitBox


easonyq edited a comment on issue #13031:
URL: 
https://github.com/apache/incubator-echarts/issues/13031#issuecomment-669756495


   @plainheart 
   如果认为是使用者使用错误(没有设定 `contentToOption` 方法)导致了该问题,那么可以关闭这个 issue。
   如果认为即便在使用者没有设定该方法时仍然应当容错,我可以提交一个 PR 进行这个修改。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] easonyq commented on issue #13031: toolbox optionToContent 自定义 dataView,点刷新,optionToContent回调中拿到的series数据遗失

2020-08-06 Thread GitBox


easonyq commented on issue #13031:
URL: 
https://github.com/apache/incubator-echarts/issues/13031#issuecomment-669755948


   的确如 @plainheart 所说,实际上 `optionToContent` 和 `contentToOption` 
是必须配对使用的,而在你的例子中你只使用了 `optionToContent` 而没有使用 
`contentToOption`,使得点击“刷新”时获取不到最新的 dataView 转化而成的 option,因此丢失了一条数据。再往后的一列 
undefined 也是相同原因所致。
   
   
![image](https://user-images.githubusercontent.com/6800839/89503108-ab0f7680-d7f8-11ea-883d-42dc9e33c6a9.png)
   
   
   ## 修改方法
   
   添加 `contentToOption` 方法。鉴于你给的例子是一个纯输出的 HTML Table (只读),因此实际上直接 `return 
options` 即可,如下:
   
   (另外我发现,只要你添加了 `contentToOption` 方法,即使不写 `return` 也能工作,但没有这个方法就不行)
   
   ```diff
   option = {
   title: {
   text: '未来一周气温变化',
   subtext: '纯属虚构'
   },
   tooltip: {
   trigger: 'axis'
   },
   legend: {
   data: ['最高气温', '最低气温']
   },
   toolbox: {
   show: true,
   feature: {
   dataZoom: {
   yAxisIndex: 'none'
   },
   dataView: {
   readOnly: false,
   optionToContent: function(opt) {
   var axisData = opt.xAxis[0].data;
   var series = opt.series;
   var table = '' +
   '时间' +
   '' + series[0].name + '' +
   '' + series[1].name + '' +
   '';
   for (var i = 0, l = axisData.length; i < l; i++) {
   table += '' +
   '' + axisData[i] + '' +
   '' + series[0].data[i] + '' +
   '' + series[1].data[i] + '' +
   '';
   }
   table += '';
   return table;
   },
   +   contentToOption: function(container, options) {
   +   return options;
   +   }
   
   },
   magicType: {
   type: ['line', 'bar']
   },
   restore: {},
   saveAsImage: {}
   }
   },
   xAxis: {
   type: 'category',
   boundaryGap: false,
   data: ['周一', '周二', '周三', '周四', '周五', '周六', '周日']
   },
   yAxis: {
   type: 'value',
   axisLabel: {
   formatter: '{value} °C'
   }
   },
   series: [{
   name: '最高气温',
   type: 'line',
   data: [11, 11, 15, 13, 12, 13, 10],
   markPoint: {
   data: [{
   type: 'max',
   name: '最大值'
   },
   {
   type: 'min',
   name: '最小值'
   }
   ]
   },
   markLine: {
   data: [{
   type: 'average',
   name: '平均值'
   }]
   }
   },
   {
   name: '最低气温',
   type: 'line',
   data: [1, -2, 2, 5, 3, 2, 0],
   markPoint: {
   data: [{
   name: '周最低',
   value: -2,
   xAxis: 1,
   yAxis: -1.5
   }]
   },
   markLine: {
   data: [{
   type: 'average',
   name: '平均值'
   },
   [{
   symbol: 'none',
   x: '90%',
   yAxis: 'max'
   }, {
   symbol: 'circle',
   label: {
   position: 'start',
   formatter: '最大值'
   },
   type: 'max',
   name: '最高点'
   }]
   ]
   }
   }
   ]
   }
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] plainheart commented on pull request #13085: fix(bar): showBackground bug when update with no previous background elements

2020-08-06 Thread GitBox


plainheart commented on pull request #13085:
URL: 
https://github.com/apache/incubator-echarts/pull/13085#issuecomment-669746323


   Thank you! You're flying to solve this.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] easonyq edited a comment on pull request #13085: fix(bar): showBackground bug when update with no previous background elements

2020-08-06 Thread GitBox


easonyq edited a comment on pull request #13085:
URL: 
https://github.com/apache/incubator-echarts/pull/13085#issuecomment-669745637


   Mainly same as #13084, but fix a small mistake about duplicate var 
declaration issue (line 195) which is raised by reviewers **AFTER** PR closed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] easonyq commented on pull request #13085: fix(bar): showBackground bug when update with no previous background elements

2020-08-06 Thread GitBox


easonyq commented on pull request #13085:
URL: 
https://github.com/apache/incubator-echarts/pull/13085#issuecomment-669745637


   Mainly same as #13084, but also fix a small mistakes about duplicate var 
declaration issue which is raised by reviewers **AFTER** PR closed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] easonyq commented on a change in pull request #13084: fix(bar): showBackground bug when update with no previous background elements

2020-08-06 Thread GitBox


easonyq commented on a change in pull request #13084:
URL: 
https://github.com/apache/incubator-echarts/pull/13084#discussion_r466186634



##
File path: src/chart/bar/BarView.js
##
@@ -182,13 +187,19 @@ export default echarts.extendChartView({
 var layout = getLayout[coord.type](data, newIndex, itemModel);
 
 if (drawBackground) {
-var bgEl = oldBgEls[oldIndex];
-bgEl.useStyle(backgroundModel.getBarItemStyle());
-// Only cartesian2d support borderRadius.
-if (coord.type === 'cartesian2d') {
-bgEl.setShape('r', barBorderRadius);
+var bgEl;
+if (oldBgEls.length === 0) {
+bgEl = createBackground(oldIndex);
+}
+else {
+var bgEl = oldBgEls[oldIndex];

Review comment:
   Since this PR has already been merged and closed, I cannot append 
commits on it. I've created a new one #13085 to apply this change. Sorry for 
this mistake.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on a change in pull request #13084: fix(bar): showBackground bug when update with no previous background elements

2020-08-06 Thread GitBox


pissang commented on a change in pull request #13084:
URL: 
https://github.com/apache/incubator-echarts/pull/13084#discussion_r466185300



##
File path: src/chart/bar/BarView.js
##
@@ -182,13 +187,19 @@ export default echarts.extendChartView({
 var layout = getLayout[coord.type](data, newIndex, itemModel);
 
 if (drawBackground) {
-var bgEl = oldBgEls[oldIndex];
-bgEl.useStyle(backgroundModel.getBarItemStyle());
-// Only cartesian2d support borderRadius.
-if (coord.type === 'cartesian2d') {
-bgEl.setShape('r', barBorderRadius);
+var bgEl;
+if (oldBgEls.length === 0) {
+bgEl = createBackground(oldIndex);
+}
+else {
+var bgEl = oldBgEls[oldIndex];

Review comment:
   U, missed that in the review. Thanks for bringing this up





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] easonyq opened a new pull request #13085: Fix 13009

2020-08-06 Thread GitBox


easonyq opened a new pull request #13085:
URL: https://github.com/apache/incubator-echarts/pull/13085


   
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   
   Fix 13009
   
   **Remove unnecessary var declaration, according to #13084 **
   
   ### Fixed issues
   
   Switch 'options -> series -> showBackground' from `false` to `true` will no 
longer throw exceptions. (something like calling `useStyle` from undefined, 
more detailed described in #13009 )
   
   
   ## Details
   
   ### Before: What was the problem?
   
   Switch 'options -> series -> showBackground' from `false` to `true` will 
throw exceptions.
   
   
   
   ### After: How is it fixed in this PR?
   
   
   
   
   
   Switch 'options -> series -> showBackground' from `false` to `true` works 
well.
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   
   
   No
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [x] Please squash the commits into a single one when merge.
   
   ### Other information
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on a change in pull request #13084: fix(bar): showBackground bug when update with no previous background elements

2020-08-06 Thread GitBox


pissang commented on a change in pull request #13084:
URL: 
https://github.com/apache/incubator-echarts/pull/13084#discussion_r466185300



##
File path: src/chart/bar/BarView.js
##
@@ -182,13 +187,19 @@ export default echarts.extendChartView({
 var layout = getLayout[coord.type](data, newIndex, itemModel);
 
 if (drawBackground) {
-var bgEl = oldBgEls[oldIndex];
-bgEl.useStyle(backgroundModel.getBarItemStyle());
-// Only cartesian2d support borderRadius.
-if (coord.type === 'cartesian2d') {
-bgEl.setShape('r', barBorderRadius);
+var bgEl;
+if (oldBgEls.length === 0) {
+bgEl = createBackground(oldIndex);
+}
+else {
+var bgEl = oldBgEls[oldIndex];

Review comment:
   U, missed that in the review.

##
File path: src/chart/bar/BarView.js
##
@@ -182,13 +187,19 @@ export default echarts.extendChartView({
 var layout = getLayout[coord.type](data, newIndex, itemModel);
 
 if (drawBackground) {
-var bgEl = oldBgEls[oldIndex];
-bgEl.useStyle(backgroundModel.getBarItemStyle());
-// Only cartesian2d support borderRadius.
-if (coord.type === 'cartesian2d') {
-bgEl.setShape('r', barBorderRadius);
+var bgEl;
+if (oldBgEls.length === 0) {
+bgEl = createBackground(oldIndex);
+}
+else {
+var bgEl = oldBgEls[oldIndex];

Review comment:
   U, missed that in the review.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] plainheart commented on a change in pull request #13084: fix(bar): showBackground bug when update with no previous background elements

2020-08-06 Thread GitBox


plainheart commented on a change in pull request #13084:
URL: 
https://github.com/apache/incubator-echarts/pull/13084#discussion_r466182308



##
File path: src/chart/bar/BarView.js
##
@@ -182,13 +187,19 @@ export default echarts.extendChartView({
 var layout = getLayout[coord.type](data, newIndex, itemModel);
 
 if (drawBackground) {
-var bgEl = oldBgEls[oldIndex];
-bgEl.useStyle(backgroundModel.getBarItemStyle());
-// Only cartesian2d support borderRadius.
-if (coord.type === 'cartesian2d') {
-bgEl.setShape('r', barBorderRadius);
+var bgEl;
+if (oldBgEls.length === 0) {
+bgEl = createBackground(oldIndex);
+}
+else {
+var bgEl = oldBgEls[oldIndex];

Review comment:
   ```suggestion
   bgEl = oldBgEls[oldIndex];
   ```
   The `var` should be removed, otherwise, it may lead to an error after 
confusion and compression.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13084: fix(bar): showBackground bug when update with no previous background elements

2020-08-06 Thread GitBox


echarts-bot[bot] commented on pull request #13084:
URL: 
https://github.com/apache/incubator-echarts/pull/13084#issuecomment-669733293


   Congratulations! Your PR has been merged. Thanks for your contribution! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch release updated (2cbf459 -> 7c7a206)

2020-08-06 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch release
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


from 2cbf459  Merge pull request #13080 from apache/fix/line-symbol-rotation
 new fd7bb7a  fix 13009
 new 1da2b2d  change arrow function to normal function
 new 7c7a206  Merge pull request #13084 from easonyq/master

The 5974 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/chart/bar/BarView.js | 39 +--
 1 file changed, 25 insertions(+), 14 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang merged pull request #13084: fix(bar): showBackground bug when update with no previous background elements

2020-08-06 Thread GitBox


pissang merged pull request #13084:
URL: https://github.com/apache/incubator-echarts/pull/13084


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org