[GitHub] [incubator-echarts] FuryDragon closed issue #13138: how to add a text like title to every chart bottom in a multiple funnel chart?怎麼樣在多漏斗圖表的每個圖下方加一段文字?

2020-08-18 Thread GitBox


FuryDragon closed issue #13138:
URL: https://github.com/apache/incubator-echarts/issues/13138


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch master updated: doc: update readme

2020-08-18 Thread ovilia
This is an automated email from the ASF dual-hosted git repository.

ovilia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/master by this push:
 new eb396f2  doc: update readme
eb396f2 is described below

commit eb396f27137af1d74b42b1b28752f204a34dbecf
Author: Wenli Zhang 
AuthorDate: Wed Aug 19 13:28:59 2020 +0800

doc: update readme
---
 README.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 7e772b7..e369f6b 100644
--- a/README.md
+++ b/README.md
@@ -1,10 +1,10 @@
-# ECharts
+# Apache ECharts (incubating)
 
 https://echarts.apache.org/";>
 
 
 
-ECharts is a free, powerful charting and visualization library offering an 
easy way of adding intuitive, interactive, and highly customizable charts to 
your commercial products. It is written in pure JavaScript and based on https://github.com/ecomfe/zrender";>zrender, which is a whole new 
lightweight canvas library.
+Apache ECharts (incubating) is a free, powerful charting and visualization 
library offering an easy way of adding intuitive, interactive, and highly 
customizable charts to your commercial products. It is written in pure 
JavaScript and based on https://github.com/ecomfe/zrender";>zrender, which is a whole new 
lightweight canvas library.
 
 Now ECharts is an incubator project of Apache Software Foundation.
 Please check its incubator status 
[here](http://incubator.apache.org/projects/echarts.html)
@@ -13,7 +13,7 @@ Please check its incubator status 
[here](http://incubator.apache.org/projects/ec
 
 [![Build 
Status](https://travis-ci.org/apache/incubator-echarts.svg?branch=master)](https://travis-ci.org/apache/incubator-echarts)
 
[![](https://img.shields.io/npm/dw/echarts.svg?label=npm%20downloads&style=flat)](https://www.npmjs.com/package/echarts)
 [![Last npm 
release](https://img.shields.io/npm/v/echarts)](https://www.npmjs.com/package/echarts)
 
-## Get ECharts
+## Get Apache ECharts (incubating)
 
 You may choose one of the following methods:
 


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia merged pull request #13149: doc: update readme

2020-08-18 Thread GitBox


Ovilia merged pull request #13149:
URL: https://github.com/apache/incubator-echarts/pull/13149


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13149: doc: update readme

2020-08-18 Thread GitBox


echarts-bot[bot] commented on pull request #13149:
URL: 
https://github.com/apache/incubator-echarts/pull/13149#issuecomment-675860511


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch fix-readme created (now e59dd8d)

2020-08-18 Thread ovilia
This is an automated email from the ASF dual-hosted git repository.

ovilia pushed a change to branch fix-readme
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


  at e59dd8d  doc: update readme

No new revisions were added by this update.


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia opened a new pull request #13149: doc: update readme

2020-08-18 Thread GitBox


Ovilia opened a new pull request #13149:
URL: https://github.com/apache/incubator-echarts/pull/13149


   Update readme.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13148: Stack in bar chart, some serie's label will be hidden when each label set into top positon

2020-08-18 Thread GitBox


echarts-bot[bot] commented on issue #13148:
URL: 
https://github.com/apache/incubator-echarts/issues/13148#issuecomment-675824354


   Hi! We've received your issue and please be patient to get responded. 🎉
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 🍵



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] jay0815 opened a new issue #13148: Stack in bar chart, some serie's label will be hidden when each label set into top positon

2020-08-18 Thread GitBox


jay0815 opened a new issue #13148:
URL: https://github.com/apache/incubator-echarts/issues/13148


   ### Version
   4.8.0
   
   ### Reproduction link
   [https://jsfiddle.net/ge6937tu/5/](https://jsfiddle.net/ge6937tu/5/)
   
   ### Steps to reproduce
   Look at the chart. 
   first and second items' label should be rendering. 
   member A and member B.
   But only member C's label dispaly
   
   ### What is expected?
   label in series all can be display
   
   ### What is actually happening?
   only last item's label can be display
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] lh8725473 commented on issue #10828: 地图下钻后调用.clear()方法依旧不能清除上一层地图中的部分series的一些效果|the echarts.clear() no longer has any effect when Not zero that lines series. trailLength

2020-08-18 Thread GitBox


lh8725473 commented on issue #10828:
URL: 
https://github.com/apache/incubator-echarts/issues/10828#issuecomment-675823571


   我也遇到了同样的问题,请问如何解决的。现在只能dispose() 重新初始化,这样性能肯定比较差



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts-doc] plainheart commented on pull request #128: fix: search result width

2020-08-18 Thread GitBox


plainheart commented on pull request #128:
URL: 
https://github.com/apache/incubator-echarts-doc/pull/128#issuecomment-675810662


   If it's necessary to let the popover follow the width of search content, it 
may not be better to use the CSS3 feature `width: max-content` here. Using 
`width: auto!important; min-width: 300px;` is just enough.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] plainheart edited a comment on issue #13114: 内部的id生成机制似乎有问题

2020-08-18 Thread GitBox


plainheart edited a comment on issue #13114:
URL: 
https://github.com/apache/incubator-echarts/issues/13114#issuecomment-675802271


   恐怕还是转义问题,使用 `JSON.stringify` 序列化之后的字符串中包含的 `\u` 空字符如 
[这里](https://stackoverflow.com/questions/48668314/javascript-json-parse-with-u)
 所说,应当被转义一次。
   ```js
   JSON.parse('{"id": "\\u"}'); // OK
   
   JSON.parse('{"id": "\u"}'); // ERROR
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] plainheart commented on issue #13114: 内部的id生成机制似乎有问题

2020-08-18 Thread GitBox


plainheart commented on issue #13114:
URL: 
https://github.com/apache/incubator-echarts/issues/13114#issuecomment-675802271


   恐怕还是转义问题,使用 `JSON.stringify` 序列化之后的字符串中包含的 `\u` 空字符如 
[这里](https://stackoverflow.com/questions/48668314/javascript-json-parse-with-u)
 所说,应当被转义一次。
   ```js
   JSON.parse('{"id": "\\u"}'); // OK
   
   JSON.parse('{ "id": "\u" }'); // ERROR
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] peach5460 commented on issue #13114: 内部的id生成机制似乎有问题

2020-08-18 Thread GitBox


peach5460 commented on issue #13114:
URL: 
https://github.com/apache/incubator-echarts/issues/13114#issuecomment-675791188


   > 后端传回是什么?这是否是后端对 json 的处理有些问题?
   
   最初的这个shape-line是前端js自动生成的,生成的时候我只设置了线段的两个端点的坐标值,id由echart自动生成。
   后来我后端获取了这个line的值,对两个端点进行了修改后回传,发现前端就报错了。
   一开始我以为是后端获取的时候字符集转换有问题。
   但是后来我在前端打印json后发现,前端对echart的option属性进行JSON.stringify后就已经有了这些uncode值了。
   
   我知道\u是一个合法的json字符,但是显然JSON.stringify没有对其提供支持。
   我搜了一些资料,有人说不支持是有理由的。我也不知道这个说法对不对。而且我似乎也没找到js上有别的json序列化库可用。
   我是一个后端人员,对前端的这些梗不是太熟悉,但是显然,echarts和JSON.stringify之间有一个匹配问题。
   我不知道这两个第三方库到底孰对孰错,但是我希望在官方层面来解决这个问题,而不是我手动给我new出来的每一个shape都赋值一个guid。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13147: Allow style control for "de-emphasized" nodes (or their mask)

2020-08-18 Thread GitBox


echarts-bot[bot] commented on issue #13147:
URL: 
https://github.com/apache/incubator-echarts/issues/13147#issuecomment-675743046


   Hi! We've received your issue and please be patient to get responded. 🎉
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 🍵



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] hoshmn opened a new issue #13147: Allow style control for "de-emphasized" nodes (or their mask)

2020-08-18 Thread GitBox


hoshmn opened a new issue #13147:
URL: https://github.com/apache/incubator-echarts/issues/13147


   ### What problem does this feature solve?
   I would like to use focusNodeAdjacency, but the "non-focused" nodes are too 
transparent. I can currently specify itemStyles for 'emphasis' nodes; it would 
be great if I could also specify itemStyles for 'deemphasis' (downplay?) nodes 
(or the mask that goes over them).
   
   ### What does the proposed API look like?
   ```javascript
   series: [{
 name: 's1',
 ...
 itemStyle: {
   emphasis: { ... } // exists
   downplay: { // proposed
 maskOpacity: 0.4 // could either allow specifying the opacity of the 
mask over the non-focused nodes
 color: 'rgba(0, 0, 0, 0.4)' // or setting the node color/styles 
directly (though this would be less helpful on its own, as node colors may vary 
across the series)
   }
 }
   }]
   ```
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] namannehra opened a new issue #13146: Item missing in scatter chart

2020-08-18 Thread GitBox


namannehra opened a new issue #13146:
URL: https://github.com/apache/incubator-echarts/issues/13146


   ### Version
   4.8.0
   
   ### Reproduction link
   [https://jsfiddle.net/f0ampunx/](https://jsfiddle.net/f0ampunx/)
   
   ### Steps to reproduce
   Look at the chart. 2 items should be rendering. 1 red and 1 blue. Red item 
is not rendering.
   
   ### What is expected?
   2 items render. 1 red and 1 blue.
   
   ### What is actually happening?
   Red item is not rendering.
   
   ---
   Removing `type: 'log'` fixes the issue. Removing `max: 'dataMax'` also fixes 
the issue.
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts-doc] branch next updated: (1) `npm run localsite` to update example rapidly in dev. (2) add error hint. (3) tweak text in doc.

2020-08-18 Thread sushuang
This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a commit to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts-doc.git


The following commit(s) were added to refs/heads/next by this push:
 new eea4d0d  (1) `npm run localsite` to update example rapidly in dev. (2) 
add error hint. (3) tweak text in doc.
eea4d0d is described below

commit eea4d0d50c5d590534fafa9e3873d3e2e9f6f370
Author: 100pah 
AuthorDate: Tue Aug 18 23:03:03 2020 +0800

(1) `npm run localsite` to update example rapidly in dev. (2) add error 
hint. (3) tweak text in doc.
---
 en/tutorial/media-query.md |  2 +-
 package.json   |  1 +
 tool/md2json.js| 14 +-
 3 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/en/tutorial/media-query.md b/en/tutorial/media-query.md
index f126031..34d88ab 100644
--- a/en/tutorial/media-query.md
+++ b/en/tutorial/media-query.md
@@ -133,7 +133,7 @@ A `query` is in the following format:
 }
 ```
 
-Currently there are three supported attributes:`width`, `height`, 
`aspectRatio` (length-to-width ratio), each of which can add `min` or `max` as 
prefix. E.g., `minWidth: 200` stands for when width is greater than or equal to 
200px. When two attributes are written together, it means *and* in Bool logic. 
For example, `{minWidth: 200, maxHeight: 300}` stands for when width is greater 
than or equal to 200px and height is smaller than or equal to 300px.
+Currently there are three supported attributes:`width`, `height`, 
`aspectRatio` (height / width), each of which can add `min` or `max` as prefix. 
E.g., `minWidth: 200` stands for when width is greater than or equal to 200px. 
When two attributes are written together, it means *and* in Bool logic. For 
example, `{minWidth: 200, maxHeight: 300}` stands for when width is greater 
than or equal to 200px and height is smaller than or equal to 300px.
 
 
 **option: **
diff --git a/package.json b/package.json
index 91af066..89be2dc 100644
--- a/package.json
+++ b/package.json
@@ -9,6 +9,7 @@
   "scripts": {
 "build": "node build.js --env asf",
 "watch": "node build.js --env dev --watch",
+"localsite": "node build.js --env localsite",
 "build:site": "npx webpack --config build/webpack.config.js --mode 
production",
 "watch:site": "npx webpack --config build/webpack.config.js --mode 
development --devtool sourcemap --watch",
 "server": "node server.js",
diff --git a/tool/md2json.js b/tool/md2json.js
index bd8b2fc..bff7203 100644
--- a/tool/md2json.js
+++ b/tool/md2json.js
@@ -3,6 +3,7 @@ const marked = require('marked');
 const etpl = require('etpl');
 const glob = require('glob');
 const htmlparser2 = require('htmlparser2');
+const chalk = require('chalk');
 
 function convert(opts, cb) {
 const mdPath = opts.path;
@@ -42,7 +43,18 @@ function convert(opts, cb) {
 Object.prototype[key] = tplEnv[key];
 });
 
-var mdStr = etplEngine.getRenderer(entry)({});
+var mdStr;
+var compileErr;
+try {
+mdStr = etplEngine.getRenderer(entry)({});
+}
+catch (err) {
+compileErr = err;
+}
+if (compileErr) {
+console.error(chalk.red('There is something illegal in doc md!'));
+throw err;
+}
 
 // Restore the global variables.
 Object.keys(tplEnv).forEach(function (key) {


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] dr-itz commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh

2020-08-18 Thread GitBox


dr-itz commented on pull request #13100:
URL: 
https://github.com/apache/incubator-echarts/pull/13100#issuecomment-675470177


   > I only just realized that there is a `_lastDataByCoordSys` already, so 
this might be simpler than this.
   
   changed it to use that. It's simpler and works as expected. I also tested 
the non-axis trigger and couldn't find any problem. I'm not familiar enough 
with this to see why `_lastDataByCoordSys` was cleared in `render()`, so I'm 
not sure about that one. I think `_tryShow()` and  `manuallyHideTip()` should 
clear it when necessary.
   
I'll rebase for `next` later 😉 
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts-doc] random-yang opened a new pull request #128: fix: search result width

2020-08-18 Thread GitBox


random-yang opened a new pull request #128:
URL: https://github.com/apache/incubator-echarts-doc/pull/128


   ### before:
   
   
   ### after:
   
   
   The current search result‘s width minimum is 300px (same as before), and the 
maximum is the maximum width of the current result.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] susiwen8 commented on issue #13122: 饼图的提示性文字lable 文字显示不全

2020-08-18 Thread GitBox


susiwen8 commented on issue #13122:
URL: 
https://github.com/apache/incubator-echarts/issues/13122#issuecomment-675416451


   5.0 fix this issue, please try it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] dr-itz commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh

2020-08-18 Thread GitBox


dr-itz commented on pull request #13100:
URL: 
https://github.com/apache/incubator-echarts/pull/13100#issuecomment-675390990


   I only just realized that there is a `_lastDataByCoordSys` already, so this 
might be simpler than this.
   
   Btw 😍 the move to TypeScript in `next`
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] congling0251 opened a new issue #13145: yAxis name position is middle overlap by axis label

2020-08-18 Thread GitBox


congling0251 opened a new issue #13145:
URL: https://github.com/apache/incubator-echarts/issues/13145


   ### What problem does this feature solve?
   when yAxis name position is middle, the position can't position from the 
yAxis label, so it will overlap.
   
   ### What does the proposed API look like?
   add option for gap from axis label
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] 100pah commented on issue #13114: 内部的id生成机制似乎有问题

2020-08-18 Thread GitBox


100pah commented on issue #13114:
URL: 
https://github.com/apache/incubator-echarts/issues/13114#issuecomment-675330090


\u 是个合法的 json 字符,
   `'\0' === '\u'`
   
   > 这些转义字符会导致后端处理完json后回传的时候 var op = JSON.parse(option);解析错误...
   
   后端传回是什么?这是否是后端对 json 的处理有些问题?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] susiwen8 commented on pull request #13141: Fix #13130: make labelLine z option configurable

2020-08-18 Thread GitBox


susiwen8 commented on pull request #13141:
URL: 
https://github.com/apache/incubator-echarts/pull/13141#issuecomment-675319627


   > @pissang How can we assure `labelLine` is absolutely at top of canvas? 
Cause we provide `z` and `zlevel` to user
   
   I have tried `Infinity`, seem works. In order to make it more flexible, 
could we add two more options? `z: number` and `alwaysOntop: boolean`? @pissang 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] yech1990 commented on issue #13144: Customize like order of Sankey diagram

2020-08-18 Thread GitBox


yech1990 commented on issue #13144:
URL: 
https://github.com/apache/incubator-echarts/issues/13144#issuecomment-675318726


   
https://github.com/apache/incubator-echarts/issues/4880#issuecomment-675304446



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13144: Customize like order of Sankey diagram

2020-08-18 Thread GitBox


echarts-bot[bot] commented on issue #13144:
URL: 
https://github.com/apache/incubator-echarts/issues/13144#issuecomment-675318578


   Hi! We've received your issue and please be patient to get responded. 🎉
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 🍵



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] yech1990 opened a new issue #13144: Customize like order of Sankey diagram

2020-08-18 Thread GitBox


yech1990 opened a new issue #13144:
URL: https://github.com/apache/incubator-echarts/issues/13144


   ### What problem does this feature solve?
   Draw the links in a customized order.
   
   ### What does the proposed API look like?
   
   ```javascript
   option = {
   series: {
   type: 'sankey',
   layout: 'none',
   focusNodeAdjacency: 'allEdges',
   data: [{
   name: 'a'
   }, {
   name: 'b1'
   }, {
   name: 'b2'
   }],
   links: [{
   source: 'a',
   target: 'b2',
   value: 5
   }, {
   source: 'a',
   target: 'b1',
   value: 3
   }]
   }
   };
   ```
   Instead of readering the sankey plot automatically, I would like to 
customize the order of the links.

   ```
   a - b1
   a
   a-- b2
   ```
   
   ```
   a----b1
   ax
   a----b2
   ```
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] susiwen8 commented on pull request #13141: Fix #13130: make labelLine z option configurable

2020-08-18 Thread GitBox


susiwen8 commented on pull request #13141:
URL: 
https://github.com/apache/incubator-echarts/pull/13141#issuecomment-675316954


   @pissang How can we assure `labelLine` is absolutely at top of canvas? Cause 
we provide `z` and `zlevel` to user 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] yech1990 commented on issue #4880: 桑基图显示排序问题

2020-08-18 Thread GitBox


yech1990 commented on issue #4880:
URL: 
https://github.com/apache/incubator-echarts/issues/4880#issuecomment-675304446


   @deqingli  能否同样设置 link 的排序?即按照输入顺序来绘制link。
   
   调整link的顺序后,render的结果不变,
   看起来是以下这几行的导致的?
   
https://github.com/apache/incubator-echarts/blob/08bd44ae83efdf45be95f2b0bde8f1ae50c0034d/src/chart/sankey/sankeyLayout.js#L480-L486



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] yech1990 edited a comment on issue #4880: 桑基图显示排序问题

2020-08-18 Thread GitBox


yech1990 edited a comment on issue #4880:
URL: 
https://github.com/apache/incubator-echarts/issues/4880#issuecomment-675304446


   @deqingli  能否同样设置 link 的排序?即按照输入顺序来绘制link。
   
   目前调整link的顺序后,render的结果不变,
   看起来是以下这几行的导致的?
   
https://github.com/apache/incubator-echarts/blob/08bd44ae83efdf45be95f2b0bde8f1ae50c0034d/src/chart/sankey/sankeyLayout.js#L480-L486



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] plainheart edited a comment on issue #13143: 导出图片 backgroundColor只有为颜色时才能正常导出

2020-08-18 Thread GitBox


plainheart edited a comment on issue #13143:
URL: 
https://github.com/apache/incubator-echarts/issues/13143#issuecomment-675296458


   没有复现。https://codepen.io/plainheart/pen/YzqWvZw
   提示:如果是图片,应当在其加载完成后再去导出。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch next updated: feature: enable media query and timeline declared without `baseOption` in echarts option.

2020-08-18 Thread sushuang
This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a commit to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/next by this push:
 new 2deacbd  feature: enable media query and timeline declared without 
`baseOption` in echarts option.
2deacbd is described below

commit 2deacbd5203701ef836a15e99d8c059df7a4782b
Author: 100pah 
AuthorDate: Tue Aug 18 15:03:16 2020 +0800

feature: enable media query and timeline declared without `baseOption` in 
echarts option.
---
 package.json|   1 +
 src/model/OptionManager.ts  | 130 +--
 src/util/types.ts   |   8 +-
 test/media-pie.html | 292 
 test/ut/spec/model/timelineMediaOptions.test.js | 430 
 test/ut/spec/model/timelineOptions.test.js  | 178 --
 6 files changed, 674 insertions(+), 365 deletions(-)

diff --git a/package.json b/package.json
index 186f1f0..fdfc853 100644
--- a/package.json
+++ b/package.json
@@ -28,6 +28,7 @@
 "test:visual": "node test/runTest/server.js",
 "test:visual:report": "node test/runTest/genReport.js",
 "test": "node build/build.js --prepublish && jest --config 
test/ut/jest.config.js",
+"test:single": "jest --config test/ut/jest.config.js --coverage=false -t",
 "mktest": "node test/build/mktest.js",
 "mktest:help": "node test/build/mktest.js -h",
 "lint": "./node_modules/.bin/eslint src/**/*.ts extension-src/**/*.ts",
diff --git a/src/model/OptionManager.ts b/src/model/OptionManager.ts
index b92d5b4..850a29f 100644
--- a/src/model/OptionManager.ts
+++ b/src/model/OptionManager.ts
@@ -235,34 +235,105 @@ class OptionManager {
 
 }
 
+/**
+ * [RAW_OPTION_PATTERNS]
+ * (Note: "series: []" represents all other props in `ECUnitOption`)
+ *
+ * (1) No prop "baseOption" declared:
+ * Root option is used as "baseOption" (except prop "options" and "media").
+ * ```js
+ * option = {
+ * series: [],
+ * timeline: {},
+ * options: [],
+ * };
+ * option = {
+ * series: [],
+ * media: {},
+ * };
+ * option = {
+ * series: [],
+ * timeline: {},
+ * options: [],
+ * media: {},
+ * }
+ * ```
+ *
+ * (2) Prop "baseOption" declared:
+ * If "baseOption" declared, `ECUnitOption` props can only be declared
+ * inside "baseOption" except prop "timeline" (compat ec2).
+ * ```js
+ * option = {
+ * baseOption: {
+ * timeline: {},
+ * series: [],
+ * },
+ * options: []
+ * };
+ * option = {
+ * baseOption: {
+ * series: [],
+ * },
+ * media: []
+ * };
+ * option = {
+ * baseOption: {
+ * timeline: {},
+ * series: [],
+ * },
+ * options: []
+ * media: []
+ * };
+ * option = {
+ * // ec3 compat ec2: allow (only) `timeline` declared
+ * // outside baseOption. Keep this setting for compat.
+ * timeline: {},
+ * baseOption: {
+ * series: [],
+ * },
+ * options: [],
+ * media: []
+ * };
+ * ```
+ */
 function parseRawOption(
+// `rawOption` May be modified
 rawOption: ECOption,
 optionPreprocessorFuncs: OptionPreprocessor[],
 isNew: boolean
 ): ParsedRawOption {
-let timelineOptions: ECUnitOption[] = [];
 const mediaList: MediaUnit[] = [];
 let mediaDefault: MediaUnit;
 let baseOption: ECUnitOption;
 
-// Compatible with ec2.
-const timelineOpt = rawOption.timeline;
+const declaredBaseOption = rawOption.baseOption;
+// Compatible with ec2, [RAW_OPTION_PATTERNS] above.
+const timelineOnRoot = rawOption.timeline;
+const timelineOptionsOnRoot = rawOption.options;
+const mediaOnRoot = rawOption.media;
+const hasMedia = !!rawOption.media;
+const hasTimeline = !!(
+timelineOptionsOnRoot || timelineOnRoot || (declaredBaseOption && 
declaredBaseOption.timeline)
+);
 
-if (rawOption.baseOption) {
-baseOption = rawOption.baseOption;
+if (declaredBaseOption) {
+baseOption = declaredBaseOption;
+// For merge option.
+if (!baseOption.timeline) {
+baseOption.timeline = timelineOnRoot;
+}
 }
-
-// For timeline
-if (timelineOpt || rawOption.options) {
-baseOption = baseOption || {} as ECUnitOption;
-timelineOptions = (rawOption.options || []).slice();
+// For convenience, enable to use the root option as the `baseOption`:
+// `{ ...normalOptionProps, media: [{ ... }, { ... }] }`
+else {
+if (hasTimeline || hasMedia) {
+rawOption.options = rawOption.media = null;
+}
+baseOption = rawOption;
 }
 
-// For media query
-if (rawOption.media) {
-baseOption = baseOption || {} as ECUnitOption;
-const media = rawOption.media;
-each(media, function (singleMedia) {
+if (hasMedia) {
+ 

[incubator-echarts] branch next updated: feature: enable media query and timeline declared without `baseOption` in echarts option.

2020-08-18 Thread sushuang
This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a commit to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/next by this push:
 new 2deacbd  feature: enable media query and timeline declared without 
`baseOption` in echarts option.
2deacbd is described below

commit 2deacbd5203701ef836a15e99d8c059df7a4782b
Author: 100pah 
AuthorDate: Tue Aug 18 15:03:16 2020 +0800

feature: enable media query and timeline declared without `baseOption` in 
echarts option.
---
 package.json|   1 +
 src/model/OptionManager.ts  | 130 +--
 src/util/types.ts   |   8 +-
 test/media-pie.html | 292 
 test/ut/spec/model/timelineMediaOptions.test.js | 430 
 test/ut/spec/model/timelineOptions.test.js  | 178 --
 6 files changed, 674 insertions(+), 365 deletions(-)

diff --git a/package.json b/package.json
index 186f1f0..fdfc853 100644
--- a/package.json
+++ b/package.json
@@ -28,6 +28,7 @@
 "test:visual": "node test/runTest/server.js",
 "test:visual:report": "node test/runTest/genReport.js",
 "test": "node build/build.js --prepublish && jest --config 
test/ut/jest.config.js",
+"test:single": "jest --config test/ut/jest.config.js --coverage=false -t",
 "mktest": "node test/build/mktest.js",
 "mktest:help": "node test/build/mktest.js -h",
 "lint": "./node_modules/.bin/eslint src/**/*.ts extension-src/**/*.ts",
diff --git a/src/model/OptionManager.ts b/src/model/OptionManager.ts
index b92d5b4..850a29f 100644
--- a/src/model/OptionManager.ts
+++ b/src/model/OptionManager.ts
@@ -235,34 +235,105 @@ class OptionManager {
 
 }
 
+/**
+ * [RAW_OPTION_PATTERNS]
+ * (Note: "series: []" represents all other props in `ECUnitOption`)
+ *
+ * (1) No prop "baseOption" declared:
+ * Root option is used as "baseOption" (except prop "options" and "media").
+ * ```js
+ * option = {
+ * series: [],
+ * timeline: {},
+ * options: [],
+ * };
+ * option = {
+ * series: [],
+ * media: {},
+ * };
+ * option = {
+ * series: [],
+ * timeline: {},
+ * options: [],
+ * media: {},
+ * }
+ * ```
+ *
+ * (2) Prop "baseOption" declared:
+ * If "baseOption" declared, `ECUnitOption` props can only be declared
+ * inside "baseOption" except prop "timeline" (compat ec2).
+ * ```js
+ * option = {
+ * baseOption: {
+ * timeline: {},
+ * series: [],
+ * },
+ * options: []
+ * };
+ * option = {
+ * baseOption: {
+ * series: [],
+ * },
+ * media: []
+ * };
+ * option = {
+ * baseOption: {
+ * timeline: {},
+ * series: [],
+ * },
+ * options: []
+ * media: []
+ * };
+ * option = {
+ * // ec3 compat ec2: allow (only) `timeline` declared
+ * // outside baseOption. Keep this setting for compat.
+ * timeline: {},
+ * baseOption: {
+ * series: [],
+ * },
+ * options: [],
+ * media: []
+ * };
+ * ```
+ */
 function parseRawOption(
+// `rawOption` May be modified
 rawOption: ECOption,
 optionPreprocessorFuncs: OptionPreprocessor[],
 isNew: boolean
 ): ParsedRawOption {
-let timelineOptions: ECUnitOption[] = [];
 const mediaList: MediaUnit[] = [];
 let mediaDefault: MediaUnit;
 let baseOption: ECUnitOption;
 
-// Compatible with ec2.
-const timelineOpt = rawOption.timeline;
+const declaredBaseOption = rawOption.baseOption;
+// Compatible with ec2, [RAW_OPTION_PATTERNS] above.
+const timelineOnRoot = rawOption.timeline;
+const timelineOptionsOnRoot = rawOption.options;
+const mediaOnRoot = rawOption.media;
+const hasMedia = !!rawOption.media;
+const hasTimeline = !!(
+timelineOptionsOnRoot || timelineOnRoot || (declaredBaseOption && 
declaredBaseOption.timeline)
+);
 
-if (rawOption.baseOption) {
-baseOption = rawOption.baseOption;
+if (declaredBaseOption) {
+baseOption = declaredBaseOption;
+// For merge option.
+if (!baseOption.timeline) {
+baseOption.timeline = timelineOnRoot;
+}
 }
-
-// For timeline
-if (timelineOpt || rawOption.options) {
-baseOption = baseOption || {} as ECUnitOption;
-timelineOptions = (rawOption.options || []).slice();
+// For convenience, enable to use the root option as the `baseOption`:
+// `{ ...normalOptionProps, media: [{ ... }, { ... }] }`
+else {
+if (hasTimeline || hasMedia) {
+rawOption.options = rawOption.media = null;
+}
+baseOption = rawOption;
 }
 
-// For media query
-if (rawOption.media) {
-baseOption = baseOption || {} as ECUnitOption;
-const media = rawOption.media;
-each(media, function (singleMedia) {
+if (hasMedia) {
+ 

[GitHub] [incubator-echarts] plainheart commented on issue #13143: 导出图片 backgroundColor只有为颜色时才能正常导出

2020-08-18 Thread GitBox


plainheart commented on issue #13143:
URL: 
https://github.com/apache/incubator-echarts/issues/13143#issuecomment-675296458


   没有复现。https://codepen.io/plainheart/pen/YzqWvZw



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org