[GitHub] [incubator-echarts] TemptationParadise removed a comment on issue #13259: dynamic multiple titles auto fit in a multiple funnel chart?在一个多图漏斗图中,如何让多个title自适应展示?

2020-09-21 Thread GitBox


TemptationParadise removed a comment on issue #13259:
URL: 
https://github.com/apache/incubator-echarts/issues/13259#issuecomment-695989010


   > Try
   > 
[title.textAlign](https://echarts.apache.org/en/option.html#title.textAlign): 
center
   
   
   not work



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] kcc666 opened a new issue #13324: 折线图数据差值较大时的渲染BUG

2020-09-21 Thread GitBox


kcc666 opened a new issue #13324:
URL: https://github.com/apache/incubator-echarts/issues/13324


   
![echartsBug](https://user-images.githubusercontent.com/50289274/93846046-805c7d00-fcd5-11ea-9d74-32b2c4508973.png)
   折线图的**数据差值过大时**,或
   数据值**接近零**的线条会被渲染成**一条竖线**.,dataZoom放大或缩小一下就恢复正常显示.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] closed issue #13324: 折线图数据差值较大时的渲染BUG

2020-09-21 Thread GitBox


echarts-bot[bot] closed issue #13324:
URL: https://github.com/apache/incubator-echarts/issues/13324


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13324: 折线图数据差值较大时的渲染BUG

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13324:
URL: 
https://github.com/apache/incubator-echarts/issues/13324#issuecomment-696512063


   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建,所以我将关闭此 issue。
   为此带来的麻烦我深表歉意,但是请理解这是为了节约社区维护者的时间,以更高效地服务社区的开发者群体。
   如果您愿意,可以请使用 issue 模板重新创建 issue。
   
   如果你认为虽然没有使用模板,但你已经提供了复现问题的充分描述,或者你的问题无法使用模板表达,也可以重新 open 这个 issue。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13321: when i use xAxis.type equal value the layout is broken

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13321:
URL: 
https://github.com/apache/incubator-echarts/issues/13321#issuecomment-696187674


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] plainheart commented on issue #13290: Update echarts on cdnjs.com

2020-09-21 Thread GitBox


plainheart commented on issue #13290:
URL: 
https://github.com/apache/incubator-echarts/issues/13290#issuecomment-695856446







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] woliwa1 commented on issue #13263: feat: Decals support

2020-09-21 Thread GitBox


woliwa1 commented on issue #13263:
URL: 
https://github.com/apache/incubator-echarts/issues/13263#issuecomment-695992887







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch next updated: expose helper.getECData for gl.

2020-09-21 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/next by this push:
 new 3162fe3  expose helper.getECData for gl.
3162fe3 is described below

commit 3162fe304a84a65ea93b0b3d9e22e86888a3646b
Author: pissang 
AuthorDate: Tue Sep 22 11:57:30 2020 +0800

expose helper.getECData for gl.
---
 src/helper.ts | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/helper.ts b/src/helper.ts
index 92622b4..a0332d8 100644
--- a/src/helper.ts
+++ b/src/helper.ts
@@ -17,6 +17,10 @@
 * under the License.
 */
 
+/**
+ * This module exposes helper functions for developing extensions.
+ */
+
 import * as zrUtil from 'zrender/src/core/util';
 import createListFromArray from './chart/helper/createListFromArray';
 // import createGraphFromNodeEdge from 
'./chart/helper/createGraphFromNodeEdge';
@@ -31,6 +35,7 @@ import {
 } from './data/helper/dataStackHelper';
 import SeriesModel from './model/Series';
 import { AxisBaseModel } from './coord/AxisBaseModel';
+import { getECData } from './util/ecData';
 
 /**
  * Create a muti dimension List structure from seriesModel.
@@ -105,4 +110,6 @@ export function createScale(dataExtent: number[], option: 
object | AxisBaseModel
  */
 export function mixinAxisModelCommonMethods(Model: Model) {
 zrUtil.mixin(Model, AxisModelCommonMixin);
-}
\ No newline at end of file
+}
+
+export {getECData};
\ No newline at end of file


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] SnailSword closed pull request #13312: feat(sample): support largest-triangle-three-buckets algo

2020-09-21 Thread GitBox


SnailSword closed pull request #13312:
URL: https://github.com/apache/incubator-echarts/pull/13312


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on a change in pull request #13210: Feat: multiple value axis alignment

2020-09-21 Thread GitBox


pissang commented on a change in pull request #13210:
URL: 
https://github.com/apache/incubator-echarts/pull/13210#discussion_r492453250



##
File path: src/component/axis/AxisBuilder.ts
##
@@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 
'axisName', AxisElementsBu
 const textStyleModel = axisModel.getModel('nameTextStyle');
 const gap = axisModel.get('nameGap') || 0;
 
-const extent = axisModel.axis.getExtent();
+const extent = axisModel.axis.getGridExtent();
 const gapSignal = extent[0] > extent[1] ? -1 : 1;

Review comment:
   I thought the main reason two axes don't align is that they don't have 
the same split numbers. They should be aligned if  the split numbers are same.

##
File path: src/component/axis/AxisBuilder.ts
##
@@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 
'axisName', AxisElementsBu
 const textStyleModel = axisModel.getModel('nameTextStyle');
 const gap = axisModel.get('nameGap') || 0;
 
-const extent = axisModel.axis.getExtent();
+const extent = axisModel.axis.getGridExtent();
 const gapSignal = extent[0] > extent[1] ? -1 : 1;

Review comment:
   I thought the main reason two axes don't align is that they don't 
have the same split numbers. They should be aligned if  the split numbers are 
same.
   
   I see, axis extent is different from grid extent only when `min`, `max` is 
fixed?

##
File path: src/component/axis/AxisBuilder.ts
##
@@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 
'axisName', AxisElementsBu
 const textStyleModel = axisModel.getModel('nameTextStyle');
 const gap = axisModel.get('nameGap') || 0;
 
-const extent = axisModel.axis.getExtent();
+const extent = axisModel.axis.getGridExtent();
 const gapSignal = extent[0] > extent[1] ? -1 : 1;

Review comment:
   I thought the main reason two axes don't align is that they don't 
have the same split numbers. They should be aligned if  the split numbers are 
same.
   
   I see, so axis extent is different from grid extent only when `min`, `max` 
is fixed?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13323: areaStyle区域填充无法使用渐变色

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13323:
URL: 
https://github.com/apache/incubator-echarts/issues/13323#issuecomment-696476809


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] xss751309229 commented on issue #13323: areaStyle区域填充无法使用渐变色

2020-09-21 Thread GitBox


xss751309229 commented on issue #13323:
URL: 
https://github.com/apache/incubator-echarts/issues/13323#issuecomment-696489686


   --原始邮件--
   发件人: 
   "apache/incubator-echarts"   
 


[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-21 Thread GitBox


echarts-bot[bot] commented on pull request #13314:
URL: 
https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695880093


   Congratulations! Your PR has been merged. Thanks for your contribution! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang edited a comment on pull request #13315: german translation added

2020-09-21 Thread GitBox


pissang edited a comment on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695933159







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] zhoujiachang commented on issue #3564: [讨论] 关于 Legend 等组件的鼠标事件

2020-09-21 Thread GitBox


zhoujiachang commented on issue #3564:
URL: 
https://github.com/apache/incubator-echarts/issues/3564#issuecomment-696469171


   0202年了还不支持吗- -



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] YvesR commented on pull request #13315: german translation added

2020-09-21 Thread GitBox


YvesR commented on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695932099







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] TemptationParadise commented on issue #13259: dynamic multiple titles auto fit in a multiple funnel chart?在一个多图漏斗图中,如何让多个title自适应展示?

2020-09-21 Thread GitBox


TemptationParadise commented on issue #13259:
URL: 
https://github.com/apache/incubator-echarts/issues/13259#issuecomment-695989010







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13316:
URL: 
https://github.com/apache/incubator-echarts/issues/13316#issuecomment-695950100


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] leeoniya commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-21 Thread GitBox


leeoniya commented on pull request #13314:
URL: 
https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695785582







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] purplepeng commented on issue #13276: 多个series,xAxis轴type为category,在交叉的区间内,点的个数不同会出现线来回折的情况

2020-09-21 Thread GitBox


purplepeng commented on issue #13276:
URL: 
https://github.com/apache/incubator-echarts/issues/13276#issuecomment-695977202


   日期是已排序的@100pah



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] YvesR edited a comment on pull request #13310: german translation

2020-09-21 Thread GitBox


YvesR edited a comment on pull request #13310:
URL: 
https://github.com/apache/incubator-echarts/pull/13310#issuecomment-695923948


   > Because it's not approved by someone who has write access for this 
project, also, could you change base branch to `next`?
   
   Lots of conflicts on these branch. Should I better close this PR and rebase 
to `next` before?
   
   **Edit** Why is `dist` folder even committed?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] plainheart edited a comment on issue #13290: Update echarts on cdnjs.com

2020-09-21 Thread GitBox


plainheart edited a comment on issue #13290:
URL: 
https://github.com/apache/incubator-echarts/issues/13290#issuecomment-695856446


   @piotrzarzycki21 Sorry for the late reply. I've opened an issue (see 
cdnjs/packages#442) to request an update of 4.9.0 several days ago, a member 
said that both 4.9.0 and 4.9.0-rc.1 were from the same commit in git, so they 
picked up the initial 4.9.0-rc.1 version. That is, you can use the version of 
4.9.0-rc.1 in cdnjs, which is the same as 4.9.0.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] YvesR closed pull request #13310: german translation

2020-09-21 Thread GitBox


YvesR closed pull request #13310:
URL: https://github.com/apache/incubator-echarts/pull/13310


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] leeoniya edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-21 Thread GitBox


leeoniya edited a comment on pull request #13314:
URL: 
https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695785582







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] msbasanth commented on issue #13279: Allow chart action controls for modifying data visualization in the rendered charts

2020-09-21 Thread GitBox


msbasanth commented on issue #13279:
URL: 
https://github.com/apache/incubator-echarts/issues/13279#issuecomment-695876523


   @100pah 
   
   Agree that ECharts is rendered using Canvas or SVG. 
   As you said we could move this data filtering controls outside chart 
rendering area and and modify the chart by responding to the events. But it 
clearly gives better usability when we have controls inside the chart.
   
   The options available:
   1. Using SVG itself for creating controls for modifying data.
   
![image](https://user-images.githubusercontent.com/1813/93728762-fc27ce00-fbde-11ea-8299-d6c3c0c8b411.png)
   http://jsfiddle.net/qd9js9oj/
   Here they used SVG rect for creating a button.
   
   1. Using HTML Elements as overlay when need to take input from user.
   
![image](https://user-images.githubusercontent.com/1813/93728965-01394d00-fbe0-11ea-8494-79532b846b9d.png)
   https://jsfiddle.net/BlackLabel/cf0h8tp5/
   Here used HTML Input on double click and allow user input through that. 
   With this user don't have to go out of chart for doing a filtering logic.
   
   It would be great if echarts allow data modifications controls similar way.
   
   
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] SnailSword commented on pull request #13312: feat(sample): support largest-triangle-three-buckets algo

2020-09-21 Thread GitBox


SnailSword commented on pull request #13312:
URL: 
https://github.com/apache/incubator-echarts/pull/13312#issuecomment-695882203


   > Thanks a lot for the work! Do you mind changing the pull request target to 
the next branch
   
   @pissang  OK, I will open a new pr.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-21 Thread GitBox


pissang commented on pull request #13314:
URL: 
https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695777118







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] paradox010 commented on issue #13277: 自定义图形的纹理

2020-09-21 Thread GitBox


paradox010 commented on issue #13277:
URL: 
https://github.com/apache/incubator-echarts/issues/13277#issuecomment-695797178







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on pull request #13315: german translation added

2020-09-21 Thread GitBox


pissang commented on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695933159







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] plainheart commented on issue #13323: areaStyle区域填充无法使用渐变色

2020-09-21 Thread GitBox


plainheart commented on issue #13323:
URL: 
https://github.com/apache/incubator-echarts/issues/13323#issuecomment-696487448


   根据提供的例子没能复现问题,你在使用的是什么浏览器?
   
   
![image](https://user-images.githubusercontent.com/26999792/93841094-1b009000-fcc5-11ea-9fe5-df12f67f3c1d.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] closed issue #13319: js

2020-09-21 Thread GitBox


echarts-bot[bot] closed issue #13319:
URL: https://github.com/apache/incubator-echarts/issues/13319


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] jgsrty closed issue #9109: 柱状图可否定制一组数据不同颜色(根据正负值)

2020-09-21 Thread GitBox


jgsrty closed issue #9109:
URL: https://github.com/apache/incubator-echarts/issues/9109


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on issue #13006: 饼图label使用换行\n,同时定义了lineHeight时会导致两个label重叠

2020-09-21 Thread GitBox


pissang commented on issue #13006:
URL: 
https://github.com/apache/incubator-echarts/issues/13006#issuecomment-695928360


   5.0 will be released soon. In the next month if everything goes well.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] piotrzarzycki21 commented on issue #13290: Update echarts on cdnjs.com

2020-09-21 Thread GitBox


piotrzarzycki21 commented on issue #13290:
URL: 
https://github.com/apache/incubator-echarts/issues/13290#issuecomment-695773783







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13318: Security

2020-09-21 Thread GitBox


echarts-bot[bot] commented on pull request #13318:
URL: 
https://github.com/apache/incubator-echarts/pull/13318#issuecomment-696033221


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the 
coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki 
about [How to make a pull 
request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] YvesR commented on pull request #13310: german translation

2020-09-21 Thread GitBox


YvesR commented on pull request #13310:
URL: 
https://github.com/apache/incubator-echarts/pull/13310#issuecomment-695920438







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang merged pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-21 Thread GitBox


pissang merged pull request #13314:
URL: https://github.com/apache/incubator-echarts/pull/13314


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13210: Feat: multiple value axis alignment

2020-09-21 Thread GitBox


susiwen8 commented on a change in pull request #13210:
URL: 
https://github.com/apache/incubator-echarts/pull/13210#discussion_r492436816



##
File path: src/component/axis/AxisBuilder.ts
##
@@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 
'axisName', AxisElementsBu
 const textStyleModel = axisModel.getModel('nameTextStyle');
 const gap = axisModel.get('nameGap') || 0;
 
-const extent = axisModel.axis.getExtent();
+const extent = axisModel.axis.getGridExtent();
 const gapSignal = extent[0] > extent[1] ? -1 : 1;

Review comment:
   Sorry for this late reply
   The reason why `splitline` of two axis cannot align in most case, it's 
because axis will fill the 
`grid`[code](https://github.com/apache/incubator-echarts/blob/next/src/coord/cartesian/Grid.ts#L166).
  `axis` will be split evenly by using `grid extent`. What I trying to do is 
calculate the `proportion` of axis in this grid, each axis has same standard 
which is `unionExtent`.   

##
File path: src/component/axis/AxisBuilder.ts
##
@@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 
'axisName', AxisElementsBu
 const textStyleModel = axisModel.getModel('nameTextStyle');
 const gap = axisModel.get('nameGap') || 0;
 
-const extent = axisModel.axis.getExtent();
+const extent = axisModel.axis.getGridExtent();
 const gapSignal = extent[0] > extent[1] ? -1 : 1;

Review comment:
   @pissang So, if user specified `min` or `max`, `axis extent` will be 
different from `grid extent`.

##
File path: src/component/axis/AxisBuilder.ts
##
@@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 
'axisName', AxisElementsBu
 const textStyleModel = axisModel.getModel('nameTextStyle');
 const gap = axisModel.get('nameGap') || 0;
 
-const extent = axisModel.axis.getExtent();
+const extent = axisModel.axis.getGridExtent();
 const gapSignal = extent[0] > extent[1] ? -1 : 1;

Review comment:
   Sorry for this late reply
   The reason why `splitline` of two axis cannot align in most case, it's 
because axis will fill the `grid`[see 
here](https://github.com/apache/incubator-echarts/blob/next/src/coord/cartesian/Grid.ts#L166).
  `axis` will be split evenly by using `grid extent`. What I trying to do is 
calculate the `proportion` of axis in this grid, each axis has same standard 
which is `unionExtent`.   

##
File path: src/component/axis/AxisBuilder.ts
##
@@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 
'axisName', AxisElementsBu
 const textStyleModel = axisModel.getModel('nameTextStyle');
 const gap = axisModel.get('nameGap') || 0;
 
-const extent = axisModel.axis.getExtent();
+const extent = axisModel.axis.getGridExtent();
 const gapSignal = extent[0] > extent[1] ? -1 : 1;

Review comment:
   @pissang That's correct, because without `min` `max`, axis will fill the 
`grid`, the proportion will be `100%`, with `min` or `max`, it will be less 
than `100%`(in most case, some case can still have `100%`, `max % interval === 
0` ).





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] susiwen8 commented on pull request #13310: german translation

2020-09-21 Thread GitBox


susiwen8 commented on pull request #13310:
URL: 
https://github.com/apache/incubator-echarts/pull/13310#issuecomment-695922530







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on issue #13263: feat: Decals support

2020-09-21 Thread GitBox


pissang commented on issue #13263:
URL: 
https://github.com/apache/incubator-echarts/issues/13263#issuecomment-696013779


   @woliwa1 Next month if everything goes well



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] closed issue #13320: when i use xAxis.type equal value the layout is broken

2020-09-21 Thread GitBox


echarts-bot[bot] closed issue #13320:
URL: https://github.com/apache/incubator-echarts/issues/13320


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13322: Series (bar) - type: 'time' - entriy width doesnt follow the maxInterval and gets corrected if there is any adjacent value.

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13322:
URL: 
https://github.com/apache/incubator-echarts/issues/13322#issuecomment-696257377


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13320: when i use xAxis.type equal value the layout is broken

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13320:
URL: 
https://github.com/apache/incubator-echarts/issues/13320#issuecomment-696183884


   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建,所以我将关闭此 issue。
   为此带来的麻烦我深表歉意,但是请理解这是为了节约社区维护者的时间,以更高效地服务社区的开发者群体。
   如果您愿意,可以请使用 issue 模板重新创建 issue。
   
   如果你认为虽然没有使用模板,但你已经提供了复现问题的充分描述,或者你的问题无法使用模板表达,也可以重新 open 这个 issue。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-21 Thread GitBox


pissang edited a comment on pull request #13314:
URL: 
https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695777118







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13315: german translation added

2020-09-21 Thread GitBox


echarts-bot[bot] commented on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695931507







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang merged pull request #13315: german translation added

2020-09-21 Thread GitBox


pissang merged pull request #13315:
URL: https://github.com/apache/incubator-echarts/pull/13315


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13317: feat(sample): support largest-triangle-three-buckets algo

2020-09-21 Thread GitBox


echarts-bot[bot] commented on pull request #13317:
URL: 
https://github.com/apache/incubator-echarts/pull/13317#issuecomment-696019927


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the 
coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki 
about [How to make a pull 
request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a 
committer of this project.
   
   Document changes are required in this PR. Please also make a PR to 
[apache/incubator-echarts-doc](https://github.com/apache/incubator-echarts-doc) 
for document changes. When the doc PR is merged, the maintainers will remove 
the `PR: awaiting doc` label.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang edited a comment on issue #13006: 饼图label使用换行\n,同时定义了lineHeight时会导致两个label重叠

2020-09-21 Thread GitBox


pissang edited a comment on issue #13006:
URL: 
https://github.com/apache/incubator-echarts/issues/13006#issuecomment-695928360


   5.0 will be released soon. In the next month if everything goes well.
   
   > @pissang BTW, any workaround before 5.0?
   
   Sorry but I can't think of a good solution.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13319: js

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13319:
URL: 
https://github.com/apache/incubator-echarts/issues/13319#issuecomment-696168727


   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建,所以我将关闭此 issue。
   为此带来的麻烦我深表歉意,但是请理解这是为了节约社区维护者的时间,以更高效地服务社区的开发者群体。
   如果您愿意,可以请使用 issue 模板重新创建 issue。
   
   如果你认为虽然没有使用模板,但你已经提供了复现问题的充分描述,或者你的问题无法使用模板表达,也可以重新 open 这个 issue。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] xss751309229 opened a new issue #13323: areaStyle区域填充无法使用渐变色

2020-09-21 Thread GitBox


xss751309229 opened a new issue #13323:
URL: https://github.com/apache/incubator-echarts/issues/13323


   ### Version
   4.9.0
   
   ### Reproduction link
   
[https://echarts.apache.org/examples/zh/editor.html?c=area-simple](https://echarts.apache.org/examples/zh/editor.html?c=area-simple)
   
   ### Steps to reproduce
   var base =  new Date(1968, 9, 3);
   var oneDay = 24 * 3600 * 1000;
   var date = [];
   
   var data = [Math.random() * 300];
   
   for (var i = 1; i < 2; i  ) {
   var now = new Date(base  = oneDay);
   date.push([now.getFullYear(), now.getMonth()   1, 
now.getDate()].join('/'));
   data.push(Math.round((Math.random() - 0.5) * 20   data[i - 1]));
   }
   
   option = {
   tooltip: {
   trigger: 'axis',
   position: function (pt) {
   return [pt[0], '10%'];
   }
   },
   title: {
   left: 'center',
   text: '大数据量面积图',
   },
   toolbox: {
   feature: {
   dataZoom: {
   yAxisIndex: 'none'
   },
   restore: {},
   saveAsImage: {}
   }
   },
   xAxis: {
   type: 'category',
   boundaryGap: false,
   data: date
   },
   yAxis: {
   type: 'value',
   boundaryGap: [0, '100%']
   },
   dataZoom: [{
   type: 'inside',
   start: 0,
   end: 10
   }, {
   start: 0,
   end: 10,
   handleIcon: 
'M10.7,11.9v-1.3H9.3v1.3c-4.9,0.3-8.8,4.4-8.8,9.4c0,5,3.9,9.1,8.8,9.4v1.3h1.3v-1.3c4.9-0.3,8.8-4.4,8.8-9.4C19.5,16.3,15.6,12.2,10.7,11.9z
 M13.3,24.4H6.7V23h6.6V24.4z M13.3,19.6H6.7v-1.4h6.6V19.6z',
   handleSize: '80%',
   handleStyle: {
   color: '#fff',
   shadowBlur: 3,
   shadowColor: 'rgba(0, 0, 0, 0.6)',
   shadowOffsetX: 2,
   shadowOffsetY: 2
   }
   }],
   series: [
   {
   name: '模拟数据',
   type: 'line',
   smooth: true,
   symbol: 'none',
   sampling: 'average',
   itemStyle: {
   color: 'rgb(255, 70, 131)'
   },
   areaStyle: {
   color: new echarts.graphic.LinearGradient(0, 0, 0, 1, [{
   offset: 0,
   color: 'rgb(255, 158, 68)'
   }, {
   offset: 1,
   color: 'rgb(255, 70, 131)'
   }])
   },
   data: data
   }
   ]
   };
   
   ### What is expected?
   区域填充渐变色
   
   ### What is actually happening?
   区域未填充渐变色
   
   ---
   实例中就有这个问题,只能填充纯色,如果设置渐变色后,就不显示填充颜色。
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13323: areaStyle区域填充无法使用渐变色

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13323:
URL: 
https://github.com/apache/incubator-echarts/issues/13323#issuecomment-696476809


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13210: Feat: multiple value axis alignment

2020-09-21 Thread GitBox


susiwen8 commented on a change in pull request #13210:
URL: 
https://github.com/apache/incubator-echarts/pull/13210#discussion_r492436816



##
File path: src/component/axis/AxisBuilder.ts
##
@@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 
'axisName', AxisElementsBu
 const textStyleModel = axisModel.getModel('nameTextStyle');
 const gap = axisModel.get('nameGap') || 0;
 
-const extent = axisModel.axis.getExtent();
+const extent = axisModel.axis.getGridExtent();
 const gapSignal = extent[0] > extent[1] ? -1 : 1;

Review comment:
   Sorry for this late reply
   The reason why `splitline` of two axis cannot align in most case, it's 
because axis will fill the `grid`[see 
here](https://github.com/apache/incubator-echarts/blob/next/src/coord/cartesian/Grid.ts#L166).
  `axis` will be split evenly by using `grid extent`. What I trying to do is 
calculate the `proportion` of axis in this grid, each axis has same standard 
which is `unionExtent`.   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13210: Feat: multiple value axis alignment

2020-09-21 Thread GitBox


susiwen8 commented on a change in pull request #13210:
URL: 
https://github.com/apache/incubator-echarts/pull/13210#discussion_r492437140



##
File path: src/component/axis/AxisBuilder.ts
##
@@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 
'axisName', AxisElementsBu
 const textStyleModel = axisModel.getModel('nameTextStyle');
 const gap = axisModel.get('nameGap') || 0;
 
-const extent = axisModel.axis.getExtent();
+const extent = axisModel.axis.getGridExtent();
 const gapSignal = extent[0] > extent[1] ? -1 : 1;

Review comment:
   @pissang So, if user specified `min` or `max`, `axis extent` will be 
different from `grid extent`.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13210: Feat: multiple value axis alignment

2020-09-21 Thread GitBox


susiwen8 commented on a change in pull request #13210:
URL: 
https://github.com/apache/incubator-echarts/pull/13210#discussion_r492436816



##
File path: src/component/axis/AxisBuilder.ts
##
@@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 
'axisName', AxisElementsBu
 const textStyleModel = axisModel.getModel('nameTextStyle');
 const gap = axisModel.get('nameGap') || 0;
 
-const extent = axisModel.axis.getExtent();
+const extent = axisModel.axis.getGridExtent();
 const gapSignal = extent[0] > extent[1] ? -1 : 1;

Review comment:
   Sorry for this late reply
   The reason why `splitline` of two axis cannot align in most case, it's 
because axis will fill the 
`grid`[code](https://github.com/apache/incubator-echarts/blob/next/src/coord/cartesian/Grid.ts#L166).
  `axis` will be split evenly by using `grid extent`. What I trying to do is 
calculate the `proportion` of axis in this grid, each axis has same standard 
which is `unionExtent`.   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] zhoujiachang commented on issue #3564: [讨论] 关于 Legend 等组件的鼠标事件

2020-09-21 Thread GitBox


zhoujiachang commented on issue #3564:
URL: 
https://github.com/apache/incubator-echarts/issues/3564#issuecomment-696469171


   0202年了还不支持吗- -



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] ngmgit opened a new issue #13322: Series (bar) - type: 'time' - entriy width doesnt follow the maxInterval and gets corrected if there is any adjacent value.

2020-09-21 Thread GitBox


ngmgit opened a new issue #13322:
URL: https://github.com/apache/incubator-echarts/issues/13322


   ### Version
   4.9.0
   
   ### Reproduction link
   
[https://codesandbox.io/s/gifted-bhaskara-eoesy?file=/src/transform.js](https://codesandbox.io/s/gifted-bhaskara-eoesy?file=/src/transform.js)
   
   ### Steps to reproduce
   * setup a time series bar chart
   * Set maxInterval to 1 hr bucket i.e 60 * 60 * 1000
   * Set min and max values to the end and start of the day for the given 
bucket.
   
   Even though this looks like what should be done to get a graph for a day 
divided into hour buckets and set the values to fill up the graph. Note that 
its not necessary that all the values for the series are set.
   
   ### What is expected?
   To show the bar with width taking up only the maxInterval and the graph 
x-axis should start with 00 value and end with 00 values with 1 hr buckets. 
   
   This should also work even when the entries are not adjacent.
   
   ### What is actually happening?
   Shows the buckets starting and ending wrong and the zoom in always becomes 
glitchy. The entries are taking up 2 hr interval width. This happens when the 
values are not adjacent.
   
   ---
   As per the attached minimal reproduction link. The values in the MOCK_DATA 
has value which doenst have any adjacent value while the one in 
ADJANCE_BUCKET_MOCK_DATA has entries for 15:00 and 16:00 which are adjacent.
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13322: Series (bar) - type: 'time' - entriy width doesnt follow the maxInterval and gets corrected if there is any adjacent value.

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13322:
URL: 
https://github.com/apache/incubator-echarts/issues/13322#issuecomment-696257377


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13321: when i use xAxis.type equal value the layout is broken

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13321:
URL: 
https://github.com/apache/incubator-echarts/issues/13321#issuecomment-696187674


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Remy-J opened a new issue #13321: when i use xAxis.type equal value the layout is broken

2020-09-21 Thread GitBox


Remy-J opened a new issue #13321:
URL: https://github.com/apache/incubator-echarts/issues/13321


   ### Version
   4.6.0
   
   ### Reproduction link
   
[https://gallery.echartsjs.com/editor.html?c=xs9BT4SnHR=1](https://gallery.echartsjs.com/editor.html?c=xs9BT4SnHR=1)
   
   ### Steps to reproduce
   use this conf: 
   `option = {
   legend: {},
   tooltip: {},
   dataset: {
   source: [
   ['val', 'id'],
   [0, 1234],
   [4, 12345],
   
   ]
   },
   xAxis: {type: 'value'},
   yAxis: {},
   series: [
   {type: 'bar'},
   
   ]
   };`
   
   
   ### What is expected?
   the graph is expected to be consistent
   
   ### What is actually happening?
   the layout is broken.
   the columns come out of the graph and their size is not good
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Remy-J opened a new issue #13320: when i use xAxis.type equal value the layout is broken

2020-09-21 Thread GitBox


Remy-J opened a new issue #13320:
URL: https://github.com/apache/incubator-echarts/issues/13320


   **Version**
   4.6.0
   
   **Reproduction link**
   https://gallery.echartsjs.com/editor.html?c=xs9BT4SnHR=1
   
   **Steps to reproduce**
   use this conf :
   
   `option = {
   legend: {},
   tooltip: {},
   dataset: {
   source: [
   ['val', 'id'],
   [0, 1234],
   [4, 12345],
   
   ]
   },
   xAxis: {type: 'value'},
   yAxis: {},
   series: [
   {type: 'bar'},
   
   ]
   };
   `
   
   What is expected?
   the graph is expected to be consistent
   
   What is actually happening?
   the layout is broken.
   the columns come out of the graph and their size is not good
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] closed issue #13320: when i use xAxis.type equal value the layout is broken

2020-09-21 Thread GitBox


echarts-bot[bot] closed issue #13320:
URL: https://github.com/apache/incubator-echarts/issues/13320


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13320: when i use xAxis.type equal value the layout is broken

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13320:
URL: 
https://github.com/apache/incubator-echarts/issues/13320#issuecomment-696183884


   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建,所以我将关闭此 issue。
   为此带来的麻烦我深表歉意,但是请理解这是为了节约社区维护者的时间,以更高效地服务社区的开发者群体。
   如果您愿意,可以请使用 issue 模板重新创建 issue。
   
   如果你认为虽然没有使用模板,但你已经提供了复现问题的充分描述,或者你的问题无法使用模板表达,也可以重新 open 这个 issue。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Arman-rs opened a new issue #13319: js

2020-09-21 Thread GitBox


Arman-rs opened a new issue #13319:
URL: https://github.com/apache/incubator-echarts/issues/13319


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] closed issue #13319: js

2020-09-21 Thread GitBox


echarts-bot[bot] closed issue #13319:
URL: https://github.com/apache/incubator-echarts/issues/13319


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13319: js

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13319:
URL: 
https://github.com/apache/incubator-echarts/issues/13319#issuecomment-696168727


   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建,所以我将关闭此 issue。
   为此带来的麻烦我深表歉意,但是请理解这是为了节约社区维护者的时间,以更高效地服务社区的开发者群体。
   如果您愿意,可以请使用 issue 模板重新创建 issue。
   
   如果你认为虽然没有使用模板,但你已经提供了复现问题的充分描述,或者你的问题无法使用模板表达,也可以重新 open 这个 issue。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch next updated: fix(createScale): make Model#getNeedCrossZero optional in createScale.

2020-09-21 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/next by this push:
 new e60e410  fix(createScale): make Model#getNeedCrossZero optional in 
createScale.
e60e410 is described below

commit e60e41087ce294047477009434479b6d0189e058
Author: pissang 
AuthorDate: Mon Sep 21 18:40:55 2020 +0800

fix(createScale): make Model#getNeedCrossZero optional in createScale.
---
 src/coord/scaleRawExtentInfo.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/coord/scaleRawExtentInfo.ts b/src/coord/scaleRawExtentInfo.ts
index 9f90b1a..9a71f4a 100644
--- a/src/coord/scaleRawExtentInfo.ts
+++ b/src/coord/scaleRawExtentInfo.ts
@@ -96,7 +96,7 @@ export class ScaleRawExtentInfo {
 this._dataMax = dataExtent[1];
 
 const isOrdinal = this._isOrdinal = scale.type === 'ordinal';
-this._needCrossZero = model.getNeedCrossZero();
+this._needCrossZero = model.getNeedCrossZero && 
model.getNeedCrossZero();
 
 const modelMinRaw = this._modelMinRaw = model.get('min', true);
 if (isFunction(modelMinRaw)) {


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] nelsonbbarriento23 opened a new pull request #13318: Security

2020-09-21 Thread GitBox


nelsonbbarriento23 opened a new pull request #13318:
URL: https://github.com/apache/incubator-echarts/pull/13318


   
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   
   
   
   
   ### Fixed issues
   
   
   
   
   ## Details
   
   ### Before: What was the problem?
   
   
   
   
   
   
   
   ### After: How is it fixed in this PR?
   
   
   
   
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13318: Security

2020-09-21 Thread GitBox


echarts-bot[bot] commented on pull request #13318:
URL: 
https://github.com/apache/incubator-echarts/pull/13318#issuecomment-696033221


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the 
coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki 
about [How to make a pull 
request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13317: feat(sample): support largest-triangle-three-buckets algo

2020-09-21 Thread GitBox


echarts-bot[bot] commented on pull request #13317:
URL: 
https://github.com/apache/incubator-echarts/pull/13317#issuecomment-696019927


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the 
coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki 
about [How to make a pull 
request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a 
committer of this project.
   
   Document changes are required in this PR. Please also make a PR to 
[apache/incubator-echarts-doc](https://github.com/apache/incubator-echarts-doc) 
for document changes. When the doc PR is merged, the maintainers will remove 
the `PR: awaiting doc` label.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] SnailSword opened a new pull request #13317: feat(sample): support largest-triangle-three-buckets algo

2020-09-21 Thread GitBox


SnailSword opened a new pull request #13317:
URL: https://github.com/apache/incubator-echarts/pull/13317


   
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   
   
   Support largest-triangle-three-buckets sampling algorithm.
   
   ### Fixed issues
   
   
   
   #9403 
   
   ## Usage
   
   ### Are there any API changes?
   
   - [x] The API has been changed.
   
   
   
   sampling: 'lttb'
   
   ### Related test cases or examples to use the new APIs
   
   ```
   {
 type: 'line',
 sampling: 'lttb',
 data: data
   }
   ```
   
   See **test/line-large.html** line 101.
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   
   In master branch it works, see #13312.
   But in next branch, because of #12997 , samplers doesn't run in some cases. 
   And when it run, there is a point highlight bug, I think it's better to fix 
those bugs in other pr.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] woliwa1 commented on issue #13263: feat: Decals support

2020-09-21 Thread GitBox


woliwa1 commented on issue #13263:
URL: 
https://github.com/apache/incubator-echarts/issues/13263#issuecomment-696015329


   Really looking forward to



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on issue #13263: feat: Decals support

2020-09-21 Thread GitBox


pissang commented on issue #13263:
URL: 
https://github.com/apache/incubator-echarts/issues/13263#issuecomment-696013779


   @woliwa1 Next month if everything goes well



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] woliwa1 commented on issue #13263: feat: Decals support

2020-09-21 Thread GitBox


woliwa1 commented on issue #13263:
URL: 
https://github.com/apache/incubator-echarts/issues/13263#issuecomment-695992887


   May I ask, when will version 5.0 be released



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] TemptationParadise removed a comment on issue #13259: dynamic multiple titles auto fit in a multiple funnel chart?在一个多图漏斗图中,如何让多个title自适应展示?

2020-09-21 Thread GitBox


TemptationParadise removed a comment on issue #13259:
URL: 
https://github.com/apache/incubator-echarts/issues/13259#issuecomment-695989010


   > Try
   > 
[title.textAlign](https://echarts.apache.org/en/option.html#title.textAlign): 
center
   
   
   not work



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] TemptationParadise commented on issue #13259: dynamic multiple titles auto fit in a multiple funnel chart?在一个多图漏斗图中,如何让多个title自适应展示?

2020-09-21 Thread GitBox


TemptationParadise commented on issue #13259:
URL: 
https://github.com/apache/incubator-echarts/issues/13259#issuecomment-695989010


   > Try
   > 
[title.textAlign](https://echarts.apache.org/en/option.html#title.textAlign): 
center
   
   
   not work



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] TemptationParadise commented on issue #13259: dynamic multiple titles auto fit in a multiple funnel chart?在一个多图漏斗图中,如何让多个title自适应展示?

2020-09-21 Thread GitBox


TemptationParadise commented on issue #13259:
URL: 
https://github.com/apache/incubator-echarts/issues/13259#issuecomment-695989399


   
![image](https://user-images.githubusercontent.com/21994378/93748919-99a8ef00-fc2b-11ea-987a-79ea0260eab9.png)
   
   
   > Try
   > 
[title.textAlign](https://echarts.apache.org/en/option.html#title.textAlign): 
center
   
   not work



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] purplepeng commented on issue #13276: 多个series,xAxis轴type为category,在交叉的区间内,点的个数不同会出现线来回折的情况

2020-09-21 Thread GitBox


purplepeng commented on issue #13276:
URL: 
https://github.com/apache/incubator-echarts/issues/13276#issuecomment-695977202


   日期是已排序的@100pah



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] piotrzarzycki21 commented on issue #13290: Update echarts on cdnjs.com

2020-09-21 Thread GitBox


piotrzarzycki21 commented on issue #13290:
URL: 
https://github.com/apache/incubator-echarts/issues/13290#issuecomment-695968014


   @plainheart Thanks! I will use jsdelivr link to update ECharst in our app 
and get back to you if that's resolve our issue. :) 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] itwhat126 commented on issue #5511: treemap 怎么禁止缩放,还有点击时候会移动位置

2020-09-21 Thread GitBox


itwhat126 commented on issue #5511:
URL: 
https://github.com/apache/incubator-echarts/issues/5511#issuecomment-695958678


   设置了并没有效果



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] jgsrty closed issue #9109: 柱状图可否定制一组数据不同颜色(根据正负值)

2020-09-21 Thread GitBox


jgsrty closed issue #9109:
URL: https://github.com/apache/incubator-echarts/issues/9109


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] ys4503 opened a new issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis

2020-09-21 Thread GitBox


ys4503 opened a new issue #13316:
URL: https://github.com/apache/incubator-echarts/issues/13316


   ### Version
   4.9.0
   
   ### Reproduction link
   [https://jsfiddle.net/zg7mw5nf/](https://jsfiddle.net/zg7mw5nf/)
   
   ### Steps to reproduce
   The line is not connected to points outside the zoom-in region when using 
dataZoom in a Line chart with xaxis type value. Try zooming between 6 and 9 in 
above JSFiddle Link
   
   ### What is expected?
   The line should be connected to points outside the zoom-in region. 
   
   ### What is actually happening?
   The line is only connected to points inside the zoom-in region.
   
   ---
   There should be scatterline type chart.
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis

2020-09-21 Thread GitBox


echarts-bot[bot] commented on issue #13316:
URL: 
https://github.com/apache/incubator-echarts/issues/13316#issuecomment-695950100


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on pull request #13315: german translation added

2020-09-21 Thread GitBox


pissang commented on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695937119


   Looks good, thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang merged pull request #13315: german translation added

2020-09-21 Thread GitBox


pissang merged pull request #13315:
URL: https://github.com/apache/incubator-echarts/pull/13315


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch next updated (6c7802e -> 76688aa)

2020-09-21 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


from 6c7802e  export necessary method for usage in gl.
 new be2e127  german translation added
 new 41780c2  added DE ts file
 new 76688aa  Merge pull request #13315 from 
TQsoft-GmbH/next-german-translation

The 6623 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 i18n/langDE-obj.js | 172 +
 i18n/langDE.js | 167 +++
 src/i18n/langDE.ts | 142 +++
 3 files changed, 481 insertions(+)
 create mode 100644 i18n/langDE-obj.js
 create mode 100644 i18n/langDE.js
 create mode 100644 src/i18n/langDE.ts


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13315: german translation added

2020-09-21 Thread GitBox


echarts-bot[bot] commented on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695937187


   Congratulations! Your PR has been merged. Thanks for your contribution! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] YvesR commented on pull request #13315: german translation added

2020-09-21 Thread GitBox


YvesR commented on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695934997


   > Hi, @YvesR Thanks for the contribution.
   > 
   > The language source files are in the 
https://github.com/apache/incubator-echarts/tree/next/src/i18n
   > 
   > https://github.com/apache/incubator-echarts/blob/next/src/i18n/langEN.ts 
is an example template.
   
   Thanks for info, translation the wrong file. Ok, did add a new german ts 
file and commited.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang edited a comment on pull request #13315: german translation added

2020-09-21 Thread GitBox


pissang edited a comment on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695933159


   Hi, @YvesR Thanks for the contribution. 
   
   The language source files are in the 
https://github.com/apache/incubator-echarts/tree/next/src/i18n
   
   https://github.com/apache/incubator-echarts/blob/next/src/i18n/langEN.ts is 
an example template.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang edited a comment on pull request #13315: german translation added

2020-09-21 Thread GitBox


pissang edited a comment on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695933159


   Hi, @YvesR Thanks for the contribution. The language source files is in the 
https://github.com/apache/incubator-echarts/tree/next/src/i18n
   
   https://github.com/apache/incubator-echarts/blob/next/src/i18n/langEN.ts is 
an example template.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on pull request #13315: german translation added

2020-09-21 Thread GitBox


pissang commented on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695933159


   Hi, @YvesR Thanks for the contribution. The language source file is in the 
https://github.com/apache/incubator-echarts/tree/next/src/i18n
   
   https://github.com/apache/incubator-echarts/blob/next/src/i18n/langEN.ts is 
an example template.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] YvesR commented on pull request #13315: german translation added

2020-09-21 Thread GitBox


YvesR commented on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695932099


   @susiwen8 Added in new format. Please review.
   
   > I didn't dig into the changed i18n settings, just translated, so if you 
have to register `DE` as language in a config file, please advice.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13315: german translation added

2020-09-21 Thread GitBox


echarts-bot[bot] commented on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695931507


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the 
coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki 
about [How to make a pull 
request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] YvesR opened a new pull request #13315: german translation added

2020-09-21 Thread GitBox


YvesR opened a new pull request #13315:
URL: https://github.com/apache/incubator-echarts/pull/13315


   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   Added german translation
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on issue #13006: 饼图label使用换行\n,同时定义了lineHeight时会导致两个label重叠

2020-09-21 Thread GitBox


pissang commented on issue #13006:
URL: 
https://github.com/apache/incubator-echarts/issues/13006#issuecomment-695928360


   5.0 will be released soon. In the next month if everything goes well.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang edited a comment on issue #13006: 饼图label使用换行\n,同时定义了lineHeight时会导致两个label重叠

2020-09-21 Thread GitBox


pissang edited a comment on issue #13006:
URL: 
https://github.com/apache/incubator-echarts/issues/13006#issuecomment-695928360


   5.0 will be released soon. In the next month if everything goes well.
   
   > @pissang BTW, any workaround before 5.0?
   
   Sorry but I can't think of a good solution.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch next updated: export necessary method for usage in gl.

2020-09-21 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/next by this push:
 new 6c7802e  export necessary method for usage in gl.
6c7802e is described below

commit 6c7802e7914555f010861528a3fb89d6d8bbc488
Author: pissang 
AuthorDate: Mon Sep 21 14:31:19 2020 +0800

export necessary method for usage in gl.
---
 src/component/marker/MarkerView.ts | 2 +-
 src/coord/calendar/Calendar.ts | 3 +--
 src/coord/geo/geoJSONLoader.ts | 2 +-
 src/export.ts  | 3 ++-
 src/util/layout.ts | 2 +-
 src/util/model.ts  | 9 +
 6 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/src/component/marker/MarkerView.ts 
b/src/component/marker/MarkerView.ts
index 64202a8..56b8a04 100644
--- a/src/component/marker/MarkerView.ts
+++ b/src/component/marker/MarkerView.ts
@@ -24,7 +24,7 @@ import GlobalModel from '../../model/Global';
 import ExtensionAPI from '../../ExtensionAPI';
 import { makeInner } from '../../util/model';
 import SeriesModel from '../../model/Series';
-import { Group } from 'zrender/src/export';
+import Group from 'zrender/src/graphic/Group';
 import { enterBlur } from '../../util/states';
 
 const inner = makeInner<{
diff --git a/src/coord/calendar/Calendar.ts b/src/coord/calendar/Calendar.ts
index 646ab7b..ad3d4a1 100644
--- a/src/coord/calendar/Calendar.ts
+++ b/src/coord/calendar/Calendar.ts
@@ -20,7 +20,7 @@
 import * as zrUtil from 'zrender/src/core/util';
 import * as layout from '../../util/layout';
 import * as numberUtil from '../../util/number';
-import { BoundingRect } from 'zrender/src/export';
+import BoundingRect, {RectLike} from 'zrender/src/core/BoundingRect';
 import CalendarModel from './CalendarModel';
 import GlobalModel from '../../model/Global';
 import ExtensionAPI from '../../ExtensionAPI';
@@ -35,7 +35,6 @@ import { ParsedModelFinder } from '../../util/model';
 import { CoordinateSystem, CoordinateSystemMaster } from '../CoordinateSystem';
 import SeriesModel from '../../model/Series';
 import CoordinateSystemManager from '../../CoordinateSystem';
-import { RectLike } from 'zrender/src/core/BoundingRect';
 
 // (24*60*60*1000)
 const PROXIMATE_ONE_DAY = 8640;
diff --git a/src/coord/geo/geoJSONLoader.ts b/src/coord/geo/geoJSONLoader.ts
index 3fa11fe..93e5c9e 100644
--- a/src/coord/geo/geoJSONLoader.ts
+++ b/src/coord/geo/geoJSONLoader.ts
@@ -27,7 +27,7 @@ import fixTextCoord from './fix/textCoord';
 import fixGeoCoord from './fix/geoCoord';
 import fixDiaoyuIsland from './fix/diaoyuIsland';
 import { GeoJSONMapRecord } from './mapDataStorage';
-import { BoundingRect } from 'zrender/src/export';
+import BoundingRect from 'zrender/src/core/BoundingRect';
 import Region from './Region';
 
 type MapRecordInner = {
diff --git a/src/export.ts b/src/export.ts
index 1020eb0..0ce9971 100644
--- a/src/export.ts
+++ b/src/export.ts
@@ -34,6 +34,8 @@ import {throttle} from './util/throttle';
 import * as ecHelper from './helper';
 import parseGeoJSON from './coord/geo/parseGeoJson';
 
+// Only for GL
+export {brushSingle as innerDrawElementOnCanvas} from 
'zrender/src/canvas/graphic';
 
 export {zrender};
 export {default as List} from './data/List';
@@ -49,7 +51,6 @@ export {default as env} from 'zrender/src/core/env';
 export {parseGeoJSON};
 export const parseGeoJson = parseGeoJSON;
 
-
 export const number = {};
 zrUtil.each(
 [
diff --git a/src/util/layout.ts b/src/util/layout.ts
index 31e0fac..f13fd5c 100644
--- a/src/util/layout.ts
+++ b/src/util/layout.ts
@@ -24,7 +24,7 @@ import BoundingRect from 'zrender/src/core/BoundingRect';
 import {parsePercent} from './number';
 import * as formatUtil from './format';
 import { BoxLayoutOptionMixin, ComponentLayoutMode } from './types';
-import { Group } from 'zrender/src/export';
+import Group from 'zrender/src/graphic/Group';
 import Element from 'zrender/src/Element';
 import { Dictionary } from 'zrender/src/core/types';
 
diff --git a/src/util/model.ts b/src/util/model.ts
index c09a154..edbc337 100644
--- a/src/util/model.ts
+++ b/src/util/model.ts
@@ -862,24 +862,25 @@ export const MULTIPLE_REFERRING: QueryReferringOpt = { 
useDefault: false, enable
 
 export type QueryReferringOpt = {
 // Whether to use the first componet as the default if none of 
index/id/name are specified.
-useDefault: boolean;
+useDefault?: boolean;
 // Whether to enable `'all'` on index option.
-enableAll: boolean;
+enableAll?: boolean;
 // Whether to enable `'none'`/`false` on index option.
-enableNone: boolean;
+enableNone?: boolean;
 };
 
 export function queryReferringComponents(
 ecModel: GlobalModel,
 mainType: ComponentMainType,
 userOption: QueryReferringUserOption,
-opt: QueryReferringOpt
+opt?: QueryReferringOpt
 ): {
 // Always be array 

[GitHub] [incubator-echarts] YvesR closed pull request #13310: german translation

2020-09-21 Thread GitBox


YvesR closed pull request #13310:
URL: https://github.com/apache/incubator-echarts/pull/13310


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] susiwen8 commented on pull request #13310: german translation

2020-09-21 Thread GitBox


susiwen8 commented on pull request #13310:
URL: 
https://github.com/apache/incubator-echarts/pull/13310#issuecomment-695924820


   Yes, you can close this one and make a new PR for `next`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] YvesR commented on pull request #13310: german translation

2020-09-21 Thread GitBox


YvesR commented on pull request #13310:
URL: 
https://github.com/apache/incubator-echarts/pull/13310#issuecomment-695923948


   > Because it's not approved by someone who has write access for this 
project, also, could you change base branch to `next`?
   
   Lots of conflicts on these branch. Should I better close this PR and rebase 
to `next` before?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] YvesR edited a comment on pull request #13310: german translation

2020-09-21 Thread GitBox


YvesR edited a comment on pull request #13310:
URL: 
https://github.com/apache/incubator-echarts/pull/13310#issuecomment-695923948


   > Because it's not approved by someone who has write access for this 
project, also, could you change base branch to `next`?
   
   Lots of conflicts on these branch. Should I better close this PR and rebase 
to `next` before?
   
   **Edit** Why is `dist` folder even committed?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



  1   2   >