[GitHub] [echarts] echarts-bot[bot] commented on pull request #14552: test(line): add test case for line remove animation.
echarts-bot[bot] commented on pull request #14552: URL: https://github.com/apache/echarts/pull/14552#issuecomment-809930687 Congratulations! Your PR has been merged. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch master updated (d80deef -> 6e8515a)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git. from d80deef Merge pull request #13638 from areo/fix-10228 add d010376 test(line): add test case for line remove animation. add 6e8515a Merge pull request #14552 from apache/add-test-for-line-extraneous No new revisions were added by this update. Summary of changes: test/line-extraneous.html | 274 + test/lines-extraneous.html | 146 --- test/runTest/actions/__meta__.json | 1 + test/runTest/actions/line-extraneous.json | 1 + test/runTest/actions/lines-extraneous.json | 1 - 5 files changed, 276 insertions(+), 147 deletions(-) create mode 100644 test/line-extraneous.html delete mode 100644 test/lines-extraneous.html create mode 100644 test/runTest/actions/line-extraneous.json delete mode 100644 test/runTest/actions/lines-extraneous.json - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #14552: test(line): add test case for line remove animation.
pissang merged pull request #14552: URL: https://github.com/apache/echarts/pull/14552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch add-test-for-line-extraneous updated: test(line): add test case for line remove animation.
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch add-test-for-line-extraneous
in repository https://gitbox.apache.org/repos/asf/echarts.git
The following commit(s) were added to refs/heads/add-test-for-line-extraneous
by this push:
new d010376 test(line): add test case for line remove animation.
d010376 is described below
commit d010376539659f359d983bf6ae7d01fddac0ea77
Author: pissang
AuthorDate: Tue Mar 30 13:44:08 2021 +0800
test(line): add test case for line remove animation.
---
test/line-extraneous.html | 274 +
test/lines-extraneous.html | 146 ---
test/runTest/actions/__meta__.json | 1 +
test/runTest/actions/line-extraneous.json | 1 +
test/runTest/actions/lines-extraneous.json | 1 -
5 files changed, 276 insertions(+), 147 deletions(-)
diff --git a/test/line-extraneous.html b/test/line-extraneous.html
new file mode 100644
index 000..884c19d
--- /dev/null
+++ b/test/line-extraneous.html
@@ -0,0 +1,274 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+.test-title {
+background: #146402;
+color: #fff;
+}
+
+
+
+
+
+
+
+
+/**
+ * Related issues:
+ * - https://github.com/apache/incubator-echarts/issues/10228
+ * - https://github.com/apache/incubator-echarts/issues/11633
+ * - https://github.com/apache/incubator-echarts/issues/12164
+ * - https://github.com/apache/incubator-echarts/issues/12433
+ */
+require([
+'echarts'
+], function (echarts) {
+var chart;
+var myChart;
+
+const datasetSource1 = [['2019-04-14', 17], ['2019-04-16', 13],
['2019-04-17', 5]];
+const datasetSource2 = [['2019-04-13', 0], ['2019-04-18', 23]];
+
+
+const option1 = {
+dataset: [
+{
+source: datasetSource1,
+sourceHeader: false
+}
+],
+dataZoom: [
+{ show: true }
+],
+xAxis: {
+type: 'time',
+min: '2019-04-15',
+max: '2019-04-18',
+},
+yAxis: [
+{
+scale: true,
+type: 'value'
+}
+],
+series: [
+{
+type: 'line',
+showSymbol: false,
+animation: false,
+}
+]
+};
+
+const option2 = {
+dataset: [
+{
+source: datasetSource2,
+sourceHeader: false
+}
+],
+dataZoom: [
+{
+show: true,
+start: 0,
+end: 100,
+}
+],
+xAxis: {
+type: 'time',
+min: '2019-04-12',
+max: '2019-04-19',
+},
+yAxis: [
+{
+scale: true,
+type: 'value'
+}
+],
+series: [
+{
+type: 'line',
+showSymbol: false,
+}
+]
+};
+
+chart = myChart = testHelper.create(echarts, 'main0', {
+title: [
+'Lines series should not show extraneous points when
updating options',
+'Only **one** segment (e.g.: **two** data points) should
be displayed after pressing the button'
+],
+option: option1,
+button: {
+text: 'Click to trigger extraneous lines bug',
+onClick: () => {
+myChart.setOption(option2, true);
+}
+}
+});
+});
+
+
+
+
+
+
+var chart;
+var myChart;
+
+const datasetSource1 = [['2019-04-14', 17], ['2019-04-16', 13],
['2019-04-17', 5]];
+const datasetSource2 = [['2019-04-13', 0], ['2019-04-18', 23]];
+
+require([
+'echarts'
+
[GitHub] [echarts] echarts-bot[bot] commented on issue #13923: resize的取消动画效果了吗？
echarts-bot[bot] commented on issue #13923: URL: https://github.com/apache/echarts/issues/13923#issuecomment-809931155 This issue is labeled with `priority: high`, which means it's a frequently asked problem and we will fix it ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch add-test-for-line-extraneous created (now d80deef)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch add-test-for-line-extraneous in repository https://gitbox.apache.org/repos/asf/echarts.git. at d80deef Merge pull request #13638 from areo/fix-10228 No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang opened a new pull request #14552: test(line): add test case for line remove animation.
pissang opened a new pull request #14552: URL: https://github.com/apache/echarts/pull/14552 ## Brief Information This pull request is in the type of: - [ ] bug fixing - [ ] new feature - x] others ### What does this PR do? Added test cases for https://github.com/apache/echarts/pull/13638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14552: test(line): add test case for line remove animation.
echarts-bot[bot] commented on pull request #14552: URL: https://github.com/apache/echarts/pull/14552#issuecomment-809929299 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request). The pull request is marked to be `PR: author is committer` because you are a committer of this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang closed issue #12433: When used dataZoom - adding data dynamically leaves lines.
pissang closed issue #12433: URL: https://github.com/apache/echarts/issues/12433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang closed issue #12164: Erroneous Behavior when displaying a line chart with multiple data pushes before updating chart data while zoomed in
pissang closed issue #12164: URL: https://github.com/apache/echarts/issues/12164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang closed issue #11633: when updating the series data on zooming the line chart, the line will be wrong
pissang closed issue #11633: URL: https://github.com/apache/echarts/issues/11633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang closed issue #10228: wrong line display after setOption()
pissang closed issue #10228: URL: https://github.com/apache/echarts/issues/10228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on pull request #13638: fix(lines): discard extraneous data-points during lines animation
pissang edited a comment on pull request #13638: URL: https://github.com/apache/echarts/pull/13638#issuecomment-809924203 Thanks so much! Have to admit I'm very surprised this issue that bothers us for a long time can be fixed by simply removing this branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #13638: fix(lines): discard extraneous data-points during lines animation
pissang commented on pull request #13638: URL: https://github.com/apache/echarts/pull/13638#issuecomment-809924203 Have to admit I'm very surprised this issue that bothers us for a long time can be fixed by simply removing this branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch master updated (a39c4a1 -> d80deef)
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git.
from a39c4a1 Merge pull request #14375 from apache/fix/markLine-symbol
new 1e86a5c test(lines): add extraneous lines test case
new 41551fa fix: discard removed line data points
new d80deef Merge pull request #13638 from areo/fix-10228
The 7385 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/chart/line/lineAnimationDiff.ts| 27 +---
test/lines-extraneous.html | 146 +
.../{line-animation.json => lines-extraneous.json} | 2 +-
3 files changed, 149 insertions(+), 26 deletions(-)
create mode 100644 test/lines-extraneous.html
copy test/runTest/actions/{line-animation.json => lines-extraneous.json} (58%)
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #13638: fix(lines): discard extraneous data-points during lines animation
echarts-bot[bot] commented on pull request #13638: URL: https://github.com/apache/echarts/pull/13638#issuecomment-809922755 Congratulations! Your PR has been merged. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #13638: fix(lines): discard extraneous data-points during lines animation
pissang merged pull request #13638: URL: https://github.com/apache/echarts/pull/13638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] mythFrist opened a new issue #14551: effectScatter datazoom filterModle none 数据溢出grid?
mythFrist opened a new issue #14551:
URL: https://github.com/apache/echarts/issues/14551
option = {
xAxis: {
scale: true
},
yAxis: {
scale: true
},
grid: {
show: true,
height: "60%",
top: 200,
borderColor: 'red'
},
dataZoom: [{
type: 'inside',
filterMode: 'none',
}, {
filterMode: 'none',
type: 'slider',
showDataShadow: false,
handleIcon:
'path://M10.7,11.9v-1.3H9.3v1.3c-4.9,0.3-8.8,4.4-8.8,9.4c0,5,3.9,9.1,8.8,9.4v1.3h1.3v-1.3c4.9-0.3,8.8-4.4,8.8-9.4C19.5,16.3,15.6,12.2,10.7,11.9z
M13.3,24.4H6.7V23h6.6V24.4z M13.3,19.6H6.7v-1.4h6.6V19.6z',
handleSize: '80%'
}, {
filterMode: 'none',
type: 'inside',
orient: 'vertical'
}, {
filterMode: 'none',
type: 'slider',
orient: 'vertical',
showDataShadow: false,
handleIcon:
'path://M10.7,11.9v-1.3H9.3v1.3c-4.9,0.3-8.8,4.4-8.8,9.4c0,5,3.9,9.1,8.8,9.4v1.3h1.3v-1.3c4.9-0.3,8.8-4.4,8.8-9.4C19.5,16.3,15.6,12.2,10.7,11.9z
M13.3,24.4H6.7V23h6.6V24.4z M13.3,19.6H6.7v-1.4h6.6V19.6z',
handleSize: '80%'
}],
series: [{
type: 'effectScatter',
symbolSize: 20,
data: [
[172.7, 105.2],
[153.4, 42]
]
}, {
type: 'scatter',
data: [[161.2, 51.6], [167.5, 59.0], [159.5, 49.2], [157.0, 63.0],
[155.8, 53.6],
[170.0, 59.0], [159.1, 47.6], [166.0, 69.8], [176.2, 66.8],
[160.2, 75.2], [170.2, 59.1],
[172.7, 70.5], [165.1, 60.9], [170.2, 63.6]
],
}]
};
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14551: effectScatter datazoom filterModle none 数据溢出grid?
echarts-bot[bot] commented on issue #14551: URL: https://github.com/apache/echarts/issues/14551#issuecomment-809922032 This issue is not created using [issue template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close it. Sorry for this, but it helps save our maintainers' time so that more developers get helped. Feel free to create another issue using the issue template. If you think you have already made your point clear without the template, or your problem cannot be covered by it, you may re-open this issue again. 这个 issue 未使用 [issue 模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。 为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。 如果您愿意，请使用 issue 模板重新创建 issue。 如果您认为虽然没有使用模板，但您已经提供了复现问题的充分描述，或者您的问题无法使用模板表达，也可以重新 open 这个 issue。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] closed issue #14551: effectScatter datazoom filterModle none 数据溢出grid?
echarts-bot[bot] closed issue #14551: URL: https://github.com/apache/echarts/issues/14551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #14542: fix(label): fix labels are not on the top bug.
pissang commented on a change in pull request #14542:
URL: https://github.com/apache/echarts/pull/14542#discussion_r603765920
##
File path: src/core/echarts.ts
##
@@ -2157,34 +2157,44 @@ class ECharts extends Eventful {
if (model.preventAutoZ) {
return;
}
-const z = model.get('z');
-const zlevel = model.get('zlevel');
// Set z and zlevel
-view.group.traverse(function (el: Displayable) {
-if (!el.isGroup) {
-z != null && (el.z = z);
-zlevel != null && (el.zlevel = zlevel);
-
-// TODO if textContent is on group.
-const label = el.getTextContent();
-const labelLine = el.getTextGuideLine();
-if (label) {
-label.z = el.z;
-label.zlevel = el.zlevel;
-// lift z2 of text content
-// TODO if el.emphasis.z2 is spcefied, what about
textContent.
-label.z2 = el.z2 + 2;
-}
-if (labelLine) {
-const showAbove = el.textGuideLineConfig &&
el.textGuideLineConfig.showAbove;
-labelLine.z = el.z;
-labelLine.zlevel = el.zlevel;
-labelLine.z2 = el.z2 + (showAbove ? 1 : -1);
-}
-}
-});
+_updateZ(view.group, model.get('z'), model.get('zlevel'));
};
+function _updateZ(el: Element, z: number, zlevel: number) {
+// Group may also have textContent
+const label = el.getTextContent();
+const labelLine = el.getTextGuideLine();
+const isGroup = el.isGroup;
+
+// always set z and zlevel if label/labelLine exists
+if (label || labelLine) {
+if (label) {
+label.z = z + 1;
+label.zlevel = zlevel;
+// lift z2 of text content
+// TODO if el.emphasis.z2 is spcefied, what about
textContent.
+isGroup || (label.z2 = (el as Displayable).z2 + 2);
+}
+if (labelLine) {
+const showAbove = el.textGuideLineConfig &&
el.textGuideLineConfig.showAbove;
+labelLine.z = z;
+labelLine.zlevel = zlevel;
+isGroup || (labelLine.z2 = (el as Displayable).z2 +
(showAbove ? 1 : -1));
+}
+}
+
+if (isGroup) {
+// set z & zlevel of children elements of Group
+el.traverse((childEl: Element) => _updateZ(childEl, z,
zlevel));
Review comment:
Perhaps we can return max z2 of all elements in the group and update z2
of label and labelLine based on this max z2 value.
For example:
```ts
if (isGroup) {
const children = el.childrenRef();
let maxZ2 = -Infinity;
for (let i = 0; i < children.length; i++); {
maxZ2 =_updateZ(childEl, z, zlevel, maxZ2);
}
if (isFinite(maxZ2)) {
label.z2 = maxZ2 + 2;
labelLine.
}
}
else {
return Math.max(el.z2, maxZ2);
}
```
Also this code may cause each group node to be traversed too many times
because for each group node it will call `traverse` and visits all its
descendants when it's visited. We need to loop the childrenRef() we want to do
it recursively.
##
File path: src/core/echarts.ts
##
@@ -2157,34 +2157,44 @@ class ECharts extends Eventful {
if (model.preventAutoZ) {
return;
}
-const z = model.get('z');
-const zlevel = model.get('zlevel');
// Set z and zlevel
-view.group.traverse(function (el: Displayable) {
-if (!el.isGroup) {
-z != null && (el.z = z);
-zlevel != null && (el.zlevel = zlevel);
-
-// TODO if textContent is on group.
-const label = el.getTextContent();
-const labelLine = el.getTextGuideLine();
-if (label) {
-label.z = el.z;
-label.zlevel = el.zlevel;
-// lift z2 of text content
-// TODO if el.emphasis.z2 is spcefied, what about
textContent.
-label.z2 = el.z2 + 2;
-}
-if (labelLine) {
-const showAbove = el.textGuideLineConfig &&
el.textGuideLineConfig.showAbove;
-labelLine.z = el.z;
-labelLine.zlevel = el.zlevel;
-labelLine.z2 = el.z2 + (showAbove ? 1 :
[GitHub] [echarts] pissang commented on a change in pull request #14243: fix(visualMap): use itemSymbol as default symbol type and fix #5719
pissang commented on a change in pull request #14243:
URL: https://github.com/apache/echarts/pull/14243#discussion_r603756637
##
File path: src/component/visualMap/VisualMapModel.ts
##
@@ -511,7 +516,7 @@ class VisualMapModel extends Com
// Filter square and none.
visuals.symbol = mapVisual(visuals.symbol, function (symbol) {
-return (symbol === 'none' || symbol === 'square') ?
'roundRect' : symbol;
+return (symbol === 'none' || symbol === 'square') ?
defaultSymbol : symbol;
Review comment:
@100pah Do you still remember why the `'square'` symbol needs to be
filtered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14375: fix(markLine): fix a bug that markLine `symbolOffset` doesn't work and some other issues.
echarts-bot[bot] commented on pull request #14375: URL: https://github.com/apache/echarts/pull/14375#issuecomment-809878808 Congratulations! Your PR has been merged. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart merged pull request #14375: fix(markLine): fix a bug that markLine `symbolOffset` doesn't work and some other issues.
plainheart merged pull request #14375: URL: https://github.com/apache/echarts/pull/14375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart closed issue #12495: symbolOffset as callback function
plainheart closed issue #12495: URL: https://github.com/apache/echarts/issues/12495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart closed issue #14106: Echart5.0.1 markLine symbolOffset不生效
plainheart closed issue #14106: URL: https://github.com/apache/echarts/issues/14106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch master updated (28f01ef -> a39c4a1)
This is an automated email from the ASF dual-hosted git repository. wangzx pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git. from 28f01ef Merge pull request #14357 from apache/fix-legacy-code add 01e2da5 1) fix: markLine `symbolOffset` doesn't work bug - Resolves #9325 - Resolves #14106 - Resolves #4771 2) feat: `markLine.symbolRotate` can be an array to specify symbol rotation at the two endpoints. - Related #12736, #12392 3) feat: add `markLine.symbolKeepAspect` and fix `symbolKeepAspect` doesn't work bug. 4) feat: `symbolOffset` can be a callback function, close #12495. add 93b157c fix(markLine): remove unexpected dev code. add 1c1632d fix(lint): tweak code format. add d5b3f71 fix(symbol): fix `symbolOffset` bug in `effectSymbol`. add a328e65 fix(markLine): `0` should be considered as a valid value, so use `retrieve2` instead of `||`. add 1fb3d89 test(markLine): add test cases for markLine symbolRotate & symbolOffset. new a39c4a1 Merge pull request #14375 from apache/fix/markLine-symbol The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/chart/helper/EffectSymbol.ts | 10 +--- src/chart/helper/Line.ts | 33 ++--- src/chart/helper/Symbol.ts| 17 ++--- src/chart/helper/SymbolDraw.ts| 5 src/component/marker/MarkLineModel.ts | 7 +- src/component/marker/MarkLineView.ts | 24 +++--- src/data/List.ts | 1 + src/util/types.ts | 4 +-- src/visual/commonVisualTypes.ts | 8 -- src/visual/symbol.ts | 23 +++--- test/markLine-symbolRotate.html | 8 -- test/symbol3.html | 46 ++- 12 files changed, 143 insertions(+), 43 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] 01/01: Merge pull request #14375 from apache/fix/markLine-symbol
This is an automated email from the ASF dual-hosted git repository. wangzx pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git commit a39c4a18103897157bf34332efbc8ca605f0ffeb Merge: 28f01ef 1fb3d89 Author: Zhongxiang.Wang AuthorDate: Tue Mar 30 11:30:51 2021 +0800 Merge pull request #14375 from apache/fix/markLine-symbol fix(markLine): fix a bug that markLine `symbolOffset` doesn't work and some other issues. src/chart/helper/EffectSymbol.ts | 10 +--- src/chart/helper/Line.ts | 33 ++--- src/chart/helper/Symbol.ts| 17 ++--- src/chart/helper/SymbolDraw.ts| 5 src/component/marker/MarkLineModel.ts | 7 +- src/component/marker/MarkLineView.ts | 24 +++--- src/data/List.ts | 1 + src/util/types.ts | 4 +-- src/visual/commonVisualTypes.ts | 8 -- src/visual/symbol.ts | 23 +++--- test/markLine-symbolRotate.html | 8 -- test/symbol3.html | 46 ++- 12 files changed, 143 insertions(+), 43 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart closed issue #9325: symbolOffset not working in markLine data
plainheart closed issue #9325: URL: https://github.com/apache/echarts/issues/9325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch master updated (f3471f0 -> 28f01ef)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git. from f3471f0 Merge pull request #14254 from Nick22nd/fix-14092 add c3a4982 fix: remove legacy usage of transform add 28f01ef Merge pull request #14357 from apache/fix-legacy-code No new revisions were added by this update. Summary of changes: src/chart/helper/EffectSymbol.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #14357: fix: remove legacy usage of transform
pissang merged pull request #14357: URL: https://github.com/apache/echarts/pull/14357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14357: fix: remove legacy usage of transform
echarts-bot[bot] commented on pull request #14357: URL: https://github.com/apache/echarts/pull/14357#issuecomment-809877342 Congratulations! Your PR has been merged. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #14550: 关于effectScatter经纬度不准确的问题
plainheart commented on issue #14550: URL: https://github.com/apache/echarts/issues/14550#issuecomment-809877044 可以提供个示例代码，方便我们定位问题。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] zhoufanglu commented on issue #14550: 关于effectScatter经纬度不准确的问题
zhoufanglu commented on issue #14550:
URL: https://github.com/apache/echarts/issues/14550#issuecomment-809876681
> 注意坐标系，阿里云这个应该是高德坐标系，在百度地图上显示需要转换下。
```js
//将腾讯/高德地图经纬度转换为百度地图经纬度
qqMapTransBMap(lng, lat) {
let x_pi = 3.14159265358979324 * 3000.0 / 180.0;
let x = lng;
let y = lat;
let z = Math.sqrt(x * x + y * y) + 0.2 * Math.sin(y * x_pi);
let theta = Math.atan2(y, x) + 0.03 * Math.cos(x * x_pi);
let lngs = z * Math.cos(theta) + 0.0065;
let lats = z * Math.sin(theta) + 0.006;
return {
lng: lngs,
lat: lats
}
}
```
转换过了 没有效果， 地图的点往上偏移了点
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] zhoufanglu removed a comment on issue #14550: 关于effectScatter经纬度不准确的问题
zhoufanglu removed a comment on issue #14550:
URL: https://github.com/apache/echarts/issues/14550#issuecomment-809876437
> 注意坐标系，阿里云这个应该是高德坐标系，在百度地图上显示需要转换下。
转换过了 没有效果
```
//将腾讯/高德地图经纬度转换为百度地图经纬度
qqMapTransBMap(lng, lat) {
let x_pi = 3.14159265358979324 * 3000.0 / 180.0;
let x = lng;
let y = lat;
let z = Math.sqrt(x * x + y * y) + 0.2 * Math.sin(y * x_pi);
let theta = Math.atan2(y, x) + 0.03 * Math.cos(x * x_pi);
let lngs = z * Math.cos(theta) + 0.0065;
let lats = z * Math.sin(theta) + 0.006;
return {
lng: lngs,
lat: lats
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] zhoufanglu commented on issue #14550: 关于effectScatter经纬度不准确的问题
zhoufanglu commented on issue #14550:
URL: https://github.com/apache/echarts/issues/14550#issuecomment-809876437
> 注意坐标系，阿里云这个应该是高德坐标系，在百度地图上显示需要转换下。
转换过了 没有效果
```
//将腾讯/高德地图经纬度转换为百度地图经纬度
qqMapTransBMap(lng, lat) {
let x_pi = 3.14159265358979324 * 3000.0 / 180.0;
let x = lng;
let y = lat;
let z = Math.sqrt(x * x + y * y) + 0.2 * Math.sin(y * x_pi);
let theta = Math.atan2(y, x) + 0.03 * Math.cos(x * x_pi);
let lngs = z * Math.cos(theta) + 0.0065;
let lats = z * Math.sin(theta) + 0.006;
return {
lng: lngs,
lat: lats
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #14550: 关于effectScatter经纬度不准确的问题
plainheart commented on issue #14550: URL: https://github.com/apache/echarts/issues/14550#issuecomment-809876014 注意坐标系，阿里云这个应该是高德坐标系，在百度地图上显示需要转换下。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #13902: fix(Calendar): fix day label drifting. close #11508
pissang commented on pull request #13902: URL: https://github.com/apache/echarts/pull/13902#issuecomment-809870121 Sorry for the late review. Is it better to use the smaller dimension like: ```ts margin = numberUtil.parsePercent(margin, Math.min(cellSize[1], cellSize[0]); ``` Since `cellSize[1]` may also be too large when calendar layout is vertical -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] zhoufanglu commented on issue #14550: 关于effectScatter经纬度不准确的问题
zhoufanglu commented on issue #14550: URL: https://github.com/apache/echarts/issues/14550#issuecomment-809869683 https://datav.aliyun.com/tools/atlas/#=30.332329214580188=106.72278672066881=3.5 地图是用这个生成的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14550: 关于effectScatter经纬度不准确的问题
echarts-bot[bot] commented on issue #14550: URL: https://github.com/apache/echarts/issues/14550#issuecomment-809869133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] zhoufanglu opened a new issue #14550: 关于effectScatter经纬度不准确的问题
zhoufanglu opened a new issue #14550: URL: https://github.com/apache/echarts/issues/14550 ### Version 4.9.0 ### Steps to reproduce 我画了个浦东新区的地图，然后我想在上面标记了effectScatter,点，发现经纬度位置与实际的位置不符合 ### What is expected? effectScatter经纬度与实际地图符合 ### What is actually happening? effectScatter经纬度与实际地图不符合 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] fezhangyao commented on issue #14519: In the highlight action, if the type of "seriesName" is set to array, only one series will be highlighted
fezhangyao commented on issue #14519:
URL: https://github.com/apache/echarts/issues/14519#issuecomment-809868155
> > Right now, you can't, We will look into it
>
> I do it in other ways now, set emphasis: {focus: 'self'}, set the
highlight style to transparent, highlight unselected series to achieve the
effect
demo: https://codesandbox.io/s/awesome-sun-ey7f9?file=/src/index.js
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] fezhangyao commented on issue #14519: In the highlight action, if the type of "seriesName" is set to array, only one series will be highlighted
fezhangyao commented on issue #14519:
URL: https://github.com/apache/echarts/issues/14519#issuecomment-809867729
> Right now, you can't, We will look into it
I do it in other ways now, set emphasis: {focus: 'self'}, set the highlight
style to transparent, highlight unselected series to achieve the effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] fezhangyao removed a comment on issue #14519: In the highlight action, if the type of "seriesName" is set to array, only one series will be highlighted
fezhangyao removed a comment on issue #14519: URL: https://github.com/apache/echarts/issues/14519#issuecomment-809862701 > Right now, you can't, We will look into it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] fezhangyao closed issue #14519: In the highlight action, if the type of "seriesName" is set to array, only one series will be highlighted
fezhangyao closed issue #14519: URL: https://github.com/apache/echarts/issues/14519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] fezhangyao commented on issue #14519: In the highlight action, if the type of "seriesName" is set to array, only one series will be highlighted
fezhangyao commented on issue #14519: URL: https://github.com/apache/echarts/issues/14519#issuecomment-809862701 > Right now, you can't, We will look into it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] tamersalama commented on issue #8992: How to remove the round and the arrow on a markLine ?
tamersalama commented on issue #8992: URL: https://github.com/apache/echarts/issues/8992#issuecomment-809731509 `symbol:['none', 'none']` setting is on the markLine - not the data within the markLine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] susiwen8 commented on issue #14519: In the highlight action, if the type of "seriesName" is set to array, only one series will be highlighted
susiwen8 commented on issue #14519: URL: https://github.com/apache/echarts/issues/14519#issuecomment-809445300 Right now, you can't, We will look into it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] nguyencuongabcxyz commented on issue #11240: [feature] Add clip option for scatter, line, bar, lines, custom chart
nguyencuongabcxyz commented on issue #11240: URL: https://github.com/apache/echarts/issues/11240#issuecomment-809273538 > For example, if I wish to keep my grid area clean and do not want anything to overflow from it, or if there is axis tick label on the left side and I don't want the circle to overflow from the grid to touch the axis label. >  > In this case, neither of the situations when the circle is on the top of the axis label or under it creates a satisfying result. > > This is just one example. What I wish to say is that it is important (to provide the ability) to keep the series inside the grid area to avoid unexpected results. Hi Olivia, Is there anything new with this. I think it is really cool to provide flexibility for users. In my case, I am in the need of hiding the part of scatters outside the grid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] xjhjzxh commented on issue #14537: Can dataZoom slider only use left or right handler? dataZoom可以仅使用一侧的滑动手柄, 另一侧保持固定吗?
xjhjzxh commented on issue #14537: URL: https://github.com/apache/echarts/issues/14537#issuecomment-809178830 > Like this? > https://echarts.apache.org/examples/zh/editor.html?c=grid-multiple emm.I want only left handler can be drag, right handler always at the end of slider or hidden.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14549: 桑基图中emphasis配置项并不起作用
echarts-bot[bot] commented on issue #14549: URL: https://github.com/apache/echarts/issues/14549#issuecomment-809173035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] lijia150 opened a new issue #14549: 桑基图中emphasis配置项并不起作用
lijia150 opened a new issue #14549: URL: https://github.com/apache/echarts/issues/14549 ### Version 5.0.2 ### Steps to reproduce 最新版本中echarts-sankey.emphasis.focus值备选中只有'none'、'self'、'series'、'ancestor'、'descendant'，但示例中设为“adjacency”时可高亮当前上下各一级，但是官方文档中并无此值; 而填入'series'、'ancestor'、'descendant'这三个值并未起作用; ### What is expected? series：高亮当前系列 ancestor：高亮所有祖先节点 descendant：高亮所有子节点 ### What is actually happening? series：并未高亮 ancestor：只高亮当前节点 descendant：只高亮当前节点 --- 另外桑基图是否不支持legend图例？谢谢！ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 14glwu commented on issue #13645: Limit connected action in echarts.connect
14glwu commented on issue #13645:
URL: https://github.com/apache/echarts/issues/13645#issuecomment-809144829
> ### What problem does this feature solve?
> In some cases, only part of the action wants to be connected. Like the
case in #13630
>
> ### What does the proposed API look like?
> The second parameter is a list of fired events.
>
> ```ts
> echarts.connect([chart1, chart2], ['dataZoom', 'visualMap']);
> ```
I read source code, find this method to avoid be connected, you can try it.
```javascript
chartInstance.dispatchAction({
type: 'legendUnSelect',
escapeConnect: true,
batch: [
{
name: key,
selected: legendsSelected,
},
],
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 14glwu edited a comment on issue #13828: 页面内多图表实例联动场景下，如何关闭个别属性联动，例如关闭tooltip联动，其他行为联动保持正常
14glwu edited a comment on issue #13828:
URL: https://github.com/apache/echarts/issues/13828#issuecomment-809141838
> > > 讲一下我最后的解决办法，仅供参考，非必要不建议改源码
> > > 图表联动，本质是某一图表触发action时，遍历当前group内的图表，dispatch对应的action,
> > > 解决的思路为，在遍历group,触发action前，判断`eventType`是否需要联动，不需要则不触发action
> > > 解决方法：
> > >
> > > * 图表配置`options`内增加要排除的联动属性 `disabledConnectEventTypes`, `string []`
> > > * 在这个方法内，判断如果是不需要联动的属性，不触发action
> > >
> > > ```js
> > > each(eventActionMap, function (actionType, eventType) {
> > > chart._messageCenter.on(eventType, function (event) {
> > > var options = chart._model.option;
> > > // 过滤不需要联动的actionType
> > > var disabledConnectEventTypes = _.get(chart,
'_model.option.customConf.disabledConnectEventTypes', []);
> > > if (disabledConnectEventTypes.includes(eventType)) return
> > > // 原有逻辑
> > > });
> > > });
> > > ```
> >
> >
> > 你这个是修改源码了么
>
> 是的，不建议改源码，我们是项目里有多处需要改的，就一并改了
我看了下echarts源码找到了一种新的解决办法，就是使用batch方式，这样可以使用到escapeConnect属性
``` javascript
chartInstance.dispatchAction({
type: 'legendUnSelect',
escapeConnect: true,
batch: [
{
name: key,
selected: legendsSelected,
},
],
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 14glwu edited a comment on issue #13828: 页面内多图表实例联动场景下，如何关闭个别属性联动，例如关闭tooltip联动，其他行为联动保持正常
14glwu edited a comment on issue #13828:
URL: https://github.com/apache/echarts/issues/13828#issuecomment-809141838
> > > 讲一下我最后的解决办法，仅供参考，非必要不建议改源码
> > > 图表联动，本质是某一图表触发action时，遍历当前group内的图表，dispatch对应的action,
> > > 解决的思路为，在遍历group,触发action前，判断`eventType`是否需要联动，不需要则不触发action
> > > 解决方法：
> > >
> > > * 图表配置`options`内增加要排除的联动属性 `disabledConnectEventTypes`, `string []`
> > > * 在这个方法内，判断如果是不需要联动的属性，不触发action
> > >
> > > ```js
> > > each(eventActionMap, function (actionType, eventType) {
> > > chart._messageCenter.on(eventType, function (event) {
> > > var options = chart._model.option;
> > > // 过滤不需要联动的actionType
> > > var disabledConnectEventTypes = _.get(chart,
'_model.option.customConf.disabledConnectEventTypes', []);
> > > if (disabledConnectEventTypes.includes(eventType)) return
> > > // 原有逻辑
> > > });
> > > });
> > > ```
> >
> >
> > 你这个是修改源码了么
>
> 是的，不建议改源码，我们是项目里有多处需要改的，就一并改了
我看了下echarts源码找到了一种新的解决办法，就是使用batch方式，这样可以使用到escapeConnect属性
```
chartInstance.dispatchAction({
type: 'legendUnSelect',
escapeConnect: true,
batch: [
{
name: key,
selected: legendsSelected,
},
],
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 14glwu commented on issue #13828: 页面内多图表实例联动场景下，如何关闭个别属性联动，例如关闭tooltip联动，其他行为联动保持正常
14glwu commented on issue #13828:
URL: https://github.com/apache/echarts/issues/13828#issuecomment-809141838
> > > 讲一下我最后的解决办法，仅供参考，非必要不建议改源码
> > > 图表联动，本质是某一图表触发action时，遍历当前group内的图表，dispatch对应的action,
> > > 解决的思路为，在遍历group,触发action前，判断`eventType`是否需要联动，不需要则不触发action
> > > 解决方法：
> > >
> > > * 图表配置`options`内增加要排除的联动属性 `disabledConnectEventTypes`, `string []`
> > > * 在这个方法内，判断如果是不需要联动的属性，不触发action
> > >
> > > ```js
> > > each(eventActionMap, function (actionType, eventType) {
> > > chart._messageCenter.on(eventType, function (event) {
> > > var options = chart._model.option;
> > > // 过滤不需要联动的actionType
> > > var disabledConnectEventTypes = _.get(chart,
'_model.option.customConf.disabledConnectEventTypes', []);
> > > if (disabledConnectEventTypes.includes(eventType)) return
> > > // 原有逻辑
> > > });
> > > });
> > > ```
> >
> >
> > 你这个是修改源码了么
>
> 是的，不建议改源码，我们是项目里有多处需要改的，就一并改了
我看了下echarts源码找到了一种新的解决办法，就是使用batch方式，这样可以使用到escapeConnect属性
`chartInstance.dispatchAction({
type: 'legendUnSelect',
escapeConnect: true,
batch: [
{
name: key,
selected: legendsSelected,
},
],
});`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] tok-gogogo opened a new issue #14548: animation is ineffective when using echarts on node-canvas
tok-gogogo opened a new issue #14548:
URL: https://github.com/apache/echarts/issues/14548
### Version
5.0.2
### Steps to reproduce
like this:
const { createCanvas } = require("canvas");
const echarts = require('echarts');
const canvas = createCanvas(300, 300);
echarts.setCanvasCreator(() => canvas);
const chart = echarts.init(canvas, 'dark');
var option = {
animationDuration:5000,
animation:true,
xAxis: {
type: 'category',
data: ['Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat', 'Sun']
},
yAxis: {
type: 'value'
},
series: [{
data: [150, 230, 224, 218, 135, 147, 260],
type: 'line'
}]
};
chart.setOption(option);
console.log(canvas.toDataURL());
### What is expected?
animation is effective
### What is actually happening?
The image i get is at the end of the animation, not in the animation
---
i tried antv, and the animation is effctive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14548: animation is ineffective when using echarts on node-canvas
echarts-bot[bot] commented on issue #14548: URL: https://github.com/apache/echarts/issues/14548#issuecomment-809116020 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical question. If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html). Have a nice day! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sandm1227 commented on issue #14536: android8 【itemStyle-color-image】 is Script error
sandm1227 commented on issue #14536: URL: https://github.com/apache/echarts/issues/14536#issuecomment-809100618 > 请提供更多信息帮助我们排查问题   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sandm1227 removed a comment on issue #14536: android8 【itemStyle-color-image】 is Script error
sandm1227 removed a comment on issue #14536: URL: https://github.com/apache/echarts/issues/14536#issuecomment-809099518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sandm1227 commented on issue #14536: android8 【itemStyle-color-image】 is Script error
sandm1227 commented on issue #14536: URL: https://github.com/apache/echarts/issues/14536#issuecomment-809099893  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sandm1227 commented on issue #14536: android8 【itemStyle-color-image】 is Script error
sandm1227 commented on issue #14536: URL: https://github.com/apache/echarts/issues/14536#issuecomment-809099518  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] zhaoxuhui1122 commented on issue #13828: 页面内多图表实例联动场景下，如何关闭个别属性联动，例如关闭tooltip联动，其他行为联动保持正常
zhaoxuhui1122 commented on issue #13828:
URL: https://github.com/apache/echarts/issues/13828#issuecomment-809099433
> > 讲一下我最后的解决办法，仅供参考，非必要不建议改源码
> > 图表联动，本质是某一图表触发action时，遍历当前group内的图表，dispatch对应的action,
> > 解决的思路为，在遍历group,触发action前，判断`eventType`是否需要联动，不需要则不触发action
> > 解决方法：
> >
> > * 图表配置`options`内增加要排除的联动属性 `disabledConnectEventTypes`, `string []`
> > * 在这个方法内，判断如果是不需要联动的属性，不触发action
> >
> > ```js
> > each(eventActionMap, function (actionType, eventType) {
> > chart._messageCenter.on(eventType, function (event) {
> > var options = chart._model.option;
> > // 过滤不需要联动的actionType
> > var disabledConnectEventTypes = _.get(chart,
'_model.option.customConf.disabledConnectEventTypes', []);
> > if (disabledConnectEventTypes.includes(eventType)) return
> > // 原有逻辑
> > });
> > });
> > ```
>
> 你这个是修改源码了么
是的，不建议改源码，我们是项目里有多处需要改的，就一并改了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
