[GitHub] [echarts] plainheart edited a comment on issue #14690: LegendOption is missing a definition for property "icon"
plainheart edited a comment on issue #14690: URL: https://github.com/apache/echarts/issues/14690#issuecomment-821755160 Hi, #14263 fixed it in [5.1.0](https://github.com/apache/echarts/releases/tag/5.1.0). Seems to be another issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #14690: LegendOption is missing a definition for property "icon"
plainheart commented on issue #14690: URL: https://github.com/apache/echarts/issues/14690#issuecomment-821755160 Hi, #14263 fixed it in [5.1.0](https://github.com/apache/echarts/releases/tag/5.1.0). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14692: Merge 5.1.0 release to master
echarts-bot[bot] commented on pull request #14692: URL: https://github.com/apache/echarts/pull/14692#issuecomment-821739599 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request). The pull request is marked to be `PR: author is committer` because you are a committer of this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang opened a new pull request #14692: Merge 5.1.0 release to master
pissang opened a new pull request #14692: URL: https://github.com/apache/echarts/pull/14692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14691: Echarts Dataset examples require TransformComponent
echarts-bot[bot] commented on issue #14691: URL: https://github.com/apache/echarts/issues/14691#issuecomment-821731075 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical question. If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html). Have a nice day! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] kennymalac opened a new issue #14691: Echarts Dataset examples require TransformComponent
kennymalac opened a new issue #14691: URL: https://github.com/apache/echarts/issues/14691 ### Version 5.0.2 ### Steps to reproduce Copy example code with minimal ES bundle, you will get an error saying transform 'sort' not available. https://echarts.apache.org/examples/en/editor.html?c=data-transform-sort-bar ### What is expected? Example for all dataset examples that use transform should import and use TransformComponent from echarts/components ### What is actually happening? It does not include it in the examples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14690: LegendOption is missing a definition for property "icon"
echarts-bot[bot] commented on issue #14690: URL: https://github.com/apache/echarts/issues/14690#issuecomment-821727142 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical question. If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html). Have a nice day! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Bilge opened a new issue #14690: LegendOption is missing a definition for property "icon"
Bilge opened a new issue #14690:
URL: https://github.com/apache/echarts/issues/14690
### Version
5.1.0
### Steps to reproduce
```js
chart.setOption(
{
legend: {
icon: 'circle',
},
}
);
```
### What is expected?
No error.
### What is actually happening?
TS2322: Type '{ icon: string; }' is not assignable to type
'Arrayable | undefined'.
Object literal may only specify known properties, and 'icon' does not
exist in type 'Arrayable'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] tmscer commented on issue #14689: Using sampling with connectNulls connects
tmscer commented on issue #14689: URL: https://github.com/apache/echarts/issues/14689#issuecomment-821461042 ## Images ### When zoomed out  ### When zoomed in  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14689: Using sampling with connectNulls connects
echarts-bot[bot] commented on issue #14689: URL: https://github.com/apache/echarts/issues/14689#issuecomment-821456610 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical question. If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html). Have a nice day! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] tmscer opened a new issue #14689: Using sampling with connectNulls connects
tmscer opened a new issue #14689: URL: https://github.com/apache/echarts/issues/14689 ### Version 5.1.0 ### Reproduction link [https://codepen.io/tmscer/pen/wvgxKNR](https://codepen.io/tmscer/pen/wvgxKNR) ### Steps to reproduce Use a series line with `connectNulls: false` and `sampling: 'lttb'` (may be reproducible with other sampling methods) and have a null value in your data. ### What is expected? I'd expect null values to never be connected with regular values. ### What is actually happening? When zoomed out, regular values are connected with null values. When zoomed in, the line between regular values and nulls disappears and behaves as expected. --- I suspect this may be caused by the sampling algorithm since when no sampling is used, null values are never connected with regular ones. I'm not sure what version of Echarts is used in the codepen, however, the bug is reproducible in 5.1.0. To see the bug, zoom in the flat line. At the end of it, there is a null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] GO3LIN commented on pull request #13227: Fix #13195 - Update way of parsing date
GO3LIN commented on pull request #13227: URL: https://github.com/apache/echarts/pull/13227#issuecomment-821148787 We really need this fix in our app please can you fix the conflict / merge it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] yufeng04 opened a new pull request #14688: feat(gauge): Add data index and series index for indexing the data
yufeng04 opened a new pull request #14688: URL: https://github.com/apache/echarts/pull/14688 ## Brief Information This pull request is in the type of: - [ ] bug fixing - [x] new feature - [ ] others ### What does this PR do? Clicking on the progress in the gauge chart you can get an event ### Fixed issues #14655 ## Details ### Before: What was the problem? ### After: How is it fixed in this PR? Add data index and series index for indexing the data by element in gauge Useful in tooltip ## Usage ### Are there any API changes? - [ ] The API has been changed. ### Related test cases or examples to use the new APIs NA. ## Others ### Merging options - [ ] Please squash the commits into a single one when merge. ### Other information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14688: feat(gauge): Add data index and series index for indexing the data
echarts-bot[bot] commented on pull request #14688: URL: https://github.com/apache/echarts/pull/14688#issuecomment-821120757 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request). The pull request is marked to be `PR: author is committer` because you are a committer of this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
svn commit: r47121 - in /release/echarts/5.1.0: ./ RELEASE_NOTE.txt apache-echarts-5.1.0-src.zip apache-echarts-5.1.0-src.zip.asc apache-echarts-5.1.0-src.zip.sha512
Author: sushuang Date: Fri Apr 16 11:45:08 2021 New Revision: 47121 Log: release Added: release/echarts/5.1.0/ release/echarts/5.1.0/RELEASE_NOTE.txt release/echarts/5.1.0/apache-echarts-5.1.0-src.zip (with props) release/echarts/5.1.0/apache-echarts-5.1.0-src.zip.asc release/echarts/5.1.0/apache-echarts-5.1.0-src.zip.sha512 Added: release/echarts/5.1.0/RELEASE_NOTE.txt == --- release/echarts/5.1.0/RELEASE_NOTE.txt (added) +++ release/echarts/5.1.0/RELEASE_NOTE.txt Fri Apr 16 11:45:08 2021 @@ -0,0 +1,27 @@ +## v5.1.0 + ++ !![Feature] [geo] [map] geo component and map series support SVG format source. [#14571](https://github.com/apache/echarts/issues/14571) ([100pah](https://github.com/100pah)) ++ ![Feature] [legend] Default legend design is more intuitive. [#14497](https://github.com/apache/echarts/issues/14497) ([Ovilia](https://github.com/Ovilia)) ++ [Feature] [i18n] Add czech translation [#14468](https://github.com/apache/echarts/issues/14468) ([JiriBalcar](https://github.com/JiriBalcar)) ++ [Feature] [animation] Add animaiton configuration in resize [#14553](https://github.com/apache/echarts/issues/14553) ([pissang](https://github.com/pissang)) ++ [Feature] [effectScatter] Add clip for effectScatter [#14574](https://github.com/apache/echarts/issues/14574) ([susiwen8](https://github.com/susiwen8)) ++ [Fix] [debug] Optimize error log when components or series are missing [#14568](https://github.com/apache/echarts/issues/14568) ([pissang](https://github.com/pissang)) ++ [Fix] [tooltip] Improve the performance of tooltip. [#14246](https://github.com/apache/echarts/issues/14246) ([plainheart](https://github.com/plainheart)) ++ [Fix] [label] Fix labels may have wrong `z` and not in the front. [#14542](https://github.com/apache/echarts/issues/14542) ([plainheart](https://github.com/plainheart)) [#14417](https://github.com/apache/echarts/issues/14417) ([susiwen8](https://github.com/susiwen8)) ++ [Fix] [pattern] Fix `CanvasPatttern#setTransform` may not exists error. [#738](https://github.com/ecomfe/zrender/issues/738) ([pissang](https://github.com/pissang)) ++ [Fix] [tooltip] Fix formatter wrong when using time axis [#14471](https://github.com/apache/echarts/issues/14471) ([Ovilia](https://github.com/Ovilia)) ++ [Fix] [symbol] Make `symbolOffset` work on all the components using symbols. [#14375](https://github.com/apache/echarts/issues/14375) ([plainheart](https://github.com/plainheart)) ++ [Fix] [markArea] Fix markArea background color disappeared bug. Close [#13647](https://github.com/apache/echarts/issues/13647) [#14343](https://github.com/apache/echarts/issues/14343) ([Nick22nd](https://github.com/Nick22nd)) ++ [Fix] [markLine] Fix string type data may not work in markLine. Close [#14300](https://github.com/apache/echarts/issues/14300) [#14314](https://github.com/apache/echarts/issues/14314) ([Ovilia](https://github.com/Ovilia)) ++ [Fix] [select] Fix null access bug when checking selected status. Close [#14293](https://github.com/apache/echarts/issues/14293) [#14413](https://github.com/apache/echarts/issues/14413) ([leosxie](https://github.com/leosxie)) ++ [Fix] [dataZoom]fix dataZoom setting no effect [#14388](https://github.com/apache/echarts/issues/14388) ([wf123537200](https://github.com/wf123537200)) ++ [Fix] [animation] Fix animation between NaN value may have problem. [#730](https://github.com/ecomfe/zrender/issues/730) ([Nick22nd](https://github.com/Nick22nd)) ++ [Fix] [visualMap] Use itemSymbol as default symbol type. Close [#5719](https://github.com/apache/echarts/issues/5719) [#14243](https://github.com/apache/echarts/issues/14243) ([Ovilia](https://github.com/Ovilia)) ++ [Fix] [loading] Fix text of loading is not in the front and covered by others. [#14191](https://github.com/apache/echarts/issues/14191) ([yufeng04](https://github.com/yufeng04)) ++ [Fix] [custom] Fix series label on custom series not working properly. Close [#14092](https://github.com/apache/echarts/issues/14092) [#14254](https://github.com/apache/echarts/issues/14254) ([Nick22nd](https://github.com/Nick22nd)) ++ [Fix] [map] Fix map labels won't update its position when `labelLayout` is used. [#14578](https://github.com/apache/echarts/issues/14578) ([pissang](https://github.com/pissang)) ++ [Fix] [calendar] Fix day label drifting. Close [#11508](https://github.com/apache/echarts/issues/11508) [#13902](https://github.com/apache/echarts/issues/13902) ([Nick22nd](https://github.com/Nick22nd)) ++ [Fix] [lines] Fix line animation may have extra points and being messed up. [#13638](https://github.com/apache/echarts/issues/13638) ([vially](https://github.com/vially)) ++ [Fix] [type] Exporting more necessary types for generating declarations in the extensions [#14289](https://github.com/apache/echarts/issues/14289) ([pissang](https://github.com/pissang)) ++ [Fix] [type] Add
[echarts] 01/01: feat(gauge): Add data index and series index for indexing the data by element
This is an automated email from the ASF dual-hosted git repository.
yufeng04 pushed a commit to branch feat-14655
in repository https://gitbox.apache.org/repos/asf/echarts.git
commit 48d81370b03e7b34f9b87c1fe20fdd064ac2d287
Author: yufeng04 <740135...@qq.com>
AuthorDate: Fri Apr 16 19:39:24 2021 +0800
feat(gauge): Add data index and series index for indexing the data by
element
---
src/chart/gauge/GaugeView.ts | 7 +++
src/data/List.ts | 30 +-
src/util/innerStore.ts | 25 +
3 files changed, 37 insertions(+), 25 deletions(-)
diff --git a/src/chart/gauge/GaugeView.ts b/src/chart/gauge/GaugeView.ts
index b005b53..0ef34b8 100644
--- a/src/chart/gauge/GaugeView.ts
+++ b/src/chart/gauge/GaugeView.ts
@@ -32,6 +32,7 @@ import Sausage from '../../util/shape/sausage';
import {createSymbol} from '../../util/symbol';
import ZRImage from 'zrender/src/graphic/Image';
import {extend} from 'zrender/src/core/util';
+import {setCommonECData} from '../../util/innerStore';
type ECSymbol = ReturnType;
@@ -439,6 +440,9 @@ class GaugeView extends ChartView {
}
}, seriesModel);
group.add(progress);
+// Add data index and series index for indexing the
data by element
+// Useful in tooltip
+setCommonECData(seriesModel.seriesIndex,
data.dataType, idx, progress);
progressList[idx] = progress;
}
})
@@ -471,6 +475,9 @@ class GaugeView extends ChartView {
}
}, seriesModel);
group.add(progress);
+// Add data index and series index for indexing the
data by element
+// Useful in tooltip
+setCommonECData(seriesModel.seriesIndex,
data.dataType, newIdx, progress);
progressList[newIdx] = progress;
}
})
diff --git a/src/data/List.ts b/src/data/List.ts
index 2e0f131..32fd061 100644
--- a/src/data/List.ts
+++ b/src/data/List.ts
@@ -39,7 +39,7 @@ import {
DecalObject
} from '../util/types';
import {isDataItemOption, convertOptionIdName} from '../util/model';
-import { getECData } from '../util/innerStore';
+import {getECData, setCommonECData} from '../util/innerStore';
import type Graph from './Graph';
import type Tree from './Tree';
import type { VisualMeta } from '../component/visualMap/VisualMapModel';
@@ -180,7 +180,6 @@ let normalizeDimensions: (dimensions: ItrParamDims) =>
Array;
let validateDimensions: (list: List, dims: DimensionName[]) => void;
let cloneListForMapAndSample: (original: List, excludeDimensions:
DimensionName[]) => List;
let getInitialExtent: () => [number, number];
-let setItemDataAndSeriesIndex: (this: Element, child: Element) => void;
let transferProperties: (target: List, source: List) => void;
@@ -1905,21 +1904,10 @@ class List<
* Set graphic element relative to data. It can be set as null
*/
setItemGraphicEl(idx: number, el: Element): void {
-const hostModel = this.hostModel;
-
-if (el) {
-const ecData = getECData(el);
-// Add data index and series index for indexing the data by element
-// Useful in tooltip
-ecData.dataIndex = idx;
-ecData.dataType = this.dataType;
-ecData.seriesIndex = hostModel && (hostModel as any).seriesIndex;
-
-// TODO: not store dataIndex on children.
-if (el.type === 'group') {
-el.traverse(setItemDataAndSeriesIndex, el);
-}
-}
+const seriesIndex = this.hostModel && (this.hostModel as
any).seriesIndex;
+// Add data index and series index for indexing the data by element
+// Useful in tooltip
+setCommonECData(seriesIndex, this.dataType, idx, el);
this._graphicEls[idx] = el;
}
@@ -2213,14 +2201,6 @@ class List<
return [Infinity, -Infinity];
};
-setItemDataAndSeriesIndex = function (this: Element, child: Element):
void {
-const childECData = getECData(child);
-const thisECData = getECData(this);
-childECData.seriesIndex = thisECData.seriesIndex;
-childECData.dataIndex = thisECData.dataIndex;
-childECData.dataType = thisECData.dataType;
-};
-
transferProperties = function (target: List, source: List): void {
zrUtil.each(
TRANSFERABLE_PROPERTIES.concat(source.__wrappedMethods || []),
diff --git a/src/util/innerStore.ts b/src/util/innerStore.ts
index 9fa4355..0fc15a6 100644
--- a/src/util/innerStore.ts
+++ b/src/util/innerStore.ts
@@ -51,4 +51,29 @@ export interface ECData {
option:
[echarts] branch feat-14655 created (now 48d8137)
This is an automated email from the ASF dual-hosted git repository. yufeng04 pushed a change to branch feat-14655 in repository https://gitbox.apache.org/repos/asf/echarts.git. at 48d8137 feat(gauge): Add data index and series index for indexing the data by element This branch includes the following new commits: new 48d8137 feat(gauge): Add data index and series index for indexing the data by element The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch feat-14655 created (now ddf639b)
This is an automated email from the ASF dual-hosted git repository. yufeng04 pushed a change to branch feat-14655 in repository https://gitbox.apache.org/repos/asf/echarts.git. at ddf639b feat(gauge): Add data index and series index for indexing the data by element This branch includes the following new commits: new ddf639b feat(gauge): Add data index and series index for indexing the data by element The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] maneetgoyal edited a comment on issue #10130: dynamic chart memory leak
maneetgoyal edited a comment on issue #10130: URL: https://github.com/apache/echarts/issues/10130#issuecomment-821044822 We also experimented a bit with a line chart whose data changed dynamically every few seconds or so. Recorded the heap for 60-70 minutes. Heap size grew a bit initially but later decreased down too, so memory leaks (if any) didn't seem to be very worrisome. The same test with Vega library weren't encouraging, however. --- cc @SumitNegi7 @saikat-samanta -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] maneetgoyal commented on issue #10130: dynamic chart memory leak
maneetgoyal commented on issue #10130: URL: https://github.com/apache/echarts/issues/10130#issuecomment-821044822 We also experimented a bit with a line chart whose data changed dynamically every few seconds or so. Recorded the heap for 60-70 minutes. Heap size grew a bit initially but later decreased down too, so memory leaks (if any) didn't seem to be very worrisome. The same test with Vega library weren't encouraging, however. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] elenaS-vertikal-ai commented on issue #11865: Add an event to tell when an axis pointer has changed on a line chart
elenaS-vertikal-ai commented on issue #11865: URL: https://github.com/apache/echarts/issues/11865#issuecomment-821032542 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] alphabetabc closed issue #14673: visualMap can not be disabled
alphabetabc closed issue #14673: URL: https://github.com/apache/echarts/issues/14673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] alphabetabc commented on issue #14673: visualMap can not be disabled
alphabetabc commented on issue #14673: URL: https://github.com/apache/echarts/issues/14673#issuecomment-821025481 @pissang 感谢大佬，我已经明白 - 中文回复 -- 后来者请自行看下面的文档 https://echarts.apache.org/zh/api.html#echartsInstance.setOption -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] h4de5 commented on issue #10130: dynamic chart memory leak
h4de5 commented on issue #10130: URL: https://github.com/apache/echarts/issues/10130#issuecomment-821003153 we do see a similar issue running echarts 5.0.2 in angular -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Seanne-AI commented on issue #11865: Add an event to tell when an axis pointer has changed on a line chart
Seanne-AI commented on issue #11865: URL: https://github.com/apache/echarts/issues/11865#issuecomment-821000947 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
Ovilia commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-820983128 @villebro Cool! @pissang @100pah would give you some further discussion on this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14687: legend图例监听之后设置柱状图堆叠的总数...当不是最后一个series时...label显示的数据会发生闪烁
echarts-bot[bot] commented on issue #14687: URL: https://github.com/apache/echarts/issues/14687#issuecomment-820980491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] zcsoniubi opened a new issue #14687: legend图例监听之后设置柱状图堆叠的总数...当不是最后一个series时...label显示的数据会发生闪烁
zcsoniubi opened a new issue #14687: URL: https://github.com/apache/echarts/issues/14687 ### Version 5.0.2 ### Reproduction link [https://codepen.io/zengcheng/pen/mdRKQVM](https://codepen.io/zengcheng/pen/mdRKQVM) ### Steps to reproduce legend图例监听之后设置柱状图堆叠的总数...当不是最后一个series时...label显示的数据会发生闪烁 ### What is expected? 希望切换不会出现闪烁的问题 ### What is actually happening? legend图例监听之后设置柱状图堆叠的总数...当不是最后一个series上的label时...label显示的数据会发生闪烁 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] elenaS-vertikal-ai removed a comment on issue #11865: Add an event to tell when an axis pointer has changed on a line chart
elenaS-vertikal-ai removed a comment on issue #11865: URL: https://github.com/apache/echarts/issues/11865#issuecomment-815619417 Is it possible add an event on the axisPointer in a line plot when clicked and retrieve the data point? It would be a really useful event ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] villebro commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
villebro commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-820957191 > Another consideration is, should `"The others"` slice have a special color (gray?) or use the color palette by default? > Tooltip and legend should also be taken care of. I think it could default to grey or some other "downgraded" color, of course with the option to define a custom one. Regarding tooltip/legend, we can experiment with different options and see what looks best (we can potentially ask our design team to come up with a few suggestions if you'd like). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sandm1227 edited a comment on issue #14686: ios12.4 也无法使用image填充【itemStyle-color-image】
sandm1227 edited a comment on issue #14686: URL: https://github.com/apache/echarts/issues/14686#issuecomment-820954186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sandm1227 edited a comment on issue #14686: ios12.4 也无法使用image填充【itemStyle-color-image】
sandm1227 edited a comment on issue #14686: URL: https://github.com/apache/echarts/issues/14686#issuecomment-820954186 代码 #14536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia edited a comment on issue #14684: Please add support for slice visibility threshold in Pie Chart
Ovilia edited a comment on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-820954309 Another consideration is, should `"The others"` slice have a special color (gray?) or use the color palette by default? Tooltip and legend should also be taken care of. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sandm1227 edited a comment on issue #14686: ios12.4 也无法使用image填充【itemStyle-color-image】
sandm1227 edited a comment on issue #14686: URL: https://github.com/apache/echarts/issues/14686#issuecomment-820954186 #14536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
Ovilia commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-820954309 Another consideration is, should `"The others"` slice have a special color (gray?) or use the color palette by default? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sandm1227 commented on issue #14686: ios12.4 也无法使用image填充【itemStyle-color-image】
sandm1227 commented on issue #14686: URL: https://github.com/apache/echarts/issues/14686#issuecomment-820954186 [https://github.com/apache/echarts/issues/14536](url) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sandm1227 commented on issue #14686: ios12.4 也无法使用image填充【itemStyle-color-image】
sandm1227 commented on issue #14686: URL: https://github.com/apache/echarts/issues/14686#issuecomment-820954071 代码地址 [](https://github.com/apache/echarts/issues/14536) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sandm1227 removed a comment on issue #14686: ios12.4 也无法使用image填充【itemStyle-color-image】
sandm1227 removed a comment on issue #14686: URL: https://github.com/apache/echarts/issues/14686#issuecomment-820954071 代码地址 [](https://github.com/apache/echarts/issues/14536) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14686: ios12.4 也无法使用image填充【itemStyle-color-image】
echarts-bot[bot] commented on issue #14686: URL: https://github.com/apache/echarts/issues/14686#issuecomment-820953644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sandm1227 opened a new issue #14686: ios12.4 也无法使用image填充【itemStyle-color-image】
sandm1227 opened a new issue #14686: URL: https://github.com/apache/echarts/issues/14686 ### Version 5.0.2 ### Steps to reproduce 参考代码 [https://github.com/apache/echarts/issues/14536](url) ### What is expected? ios12.4手机上可以image填充 ### What is actually happening? ios12.4手机上image无法填充，console无报错显示 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] villebro commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
villebro commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-820951680 > @villebro I think there may also be cases where slices should be merged if the slice amount reachs a threshold. For example, if data values could be `8%, 7%, 7.2%, 7.1%, 6.4%, ...` or `53%, 4%, 3.2%, ` and the developer may not have a clue to how these values distribute, it may not be a good idea to set a value threshold in this case. In stead, a slice amount threshold is more helpful. For example, we can show the largest 5 slices and merge the others. I think maybe both the policy should be provided. Your PR may not implement them both, but should give the consideration of API design for such future features. Excellent point @Ovilia , and now that you mention it, actually something I've run into. > Or, would it be helpful if we provide a `mergePolicy` callback to let developers decide how slices should be merged? Yes, this is an even better design, as it will make it easy to customize. I'll start working on a callback based approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sandm1227 commented on issue #14536: android8 【itemStyle-color-image】 is Script error
sandm1227 commented on issue #14536: URL: https://github.com/apache/echarts/issues/14536#issuecomment-820950370 ios12.4 也无法使用image填充，console无报错显示 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang closed issue #14651: line chart animation for dynamic data isn't smooth if max value for axes is defined
pissang closed issue #14651: URL: https://github.com/apache/echarts/issues/14651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
Ovilia commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-820949382 Or, would it be helpful if we provide a `mergePolicy` callback to let developers decide how slices should be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
Ovilia commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-820947382 @villebro I think there may also be cases where slices should be merged if the slice amount reachs a threshold. For example, if data values could be `8%, 7%, 7.2%, 7.1%, 6.4%, ...` or `53%, 4%, 3.2%, ` and the developer may not have a clue to how these values distribute, it may not be a good idea to set a value threshold in this case. In stead, a slice amount threshold is more helpful. For example, we can show the largest 5 slices and merge the others. I think maybe both the policy should be provided. Your PR may not implement them both, but should give the consideration of API design for such future features. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] symlons commented on issue #14651: line chart animation for dynamic data isn't smooth if max value for axes is defined
symlons commented on issue #14651: URL: https://github.com/apache/echarts/issues/14651#issuecomment-820944301 Ok, Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] junlincc commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
junlincc commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-820941937 @Ovilia if the request is aligned with your product strategy, we(Apache Superset) are happy to contribute this feature :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] villebro commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
villebro commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-820939155 It could be nice to have to options: - `labelThreshold`: minimum threshold that determines which labels and label lines should be drawn. Similar to the `labelThreshold` property on NVD3 Pie Chart: https://nvd3.org/examples/pie.html - `sliceThreshold`: minimum threshold that determines which slices should be drawn as separate slices and which should be grouped into an "Other" category. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
